mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-26 09:57:56 +00:00
2bff2f84e3
* Runtime API versioning Related to issue #11577 Add support for multiple versions of a Runtime API. The purpose is to have one main version of the API, which is considered stable and multiple unstable (aka staging) ones. How it works =========== Some methods of the API trait can be tagged with `#[api_version(N)]` attribute where N is version number bigger than the main one. Let's call them **staging methods** for brevity. The implementor of the API decides which version to implement. Example (from https://github.com/paritytech/substrate/issues/11577#issuecomment-1145347025): ``` decl_runtime_apis! { #{api_version(10)] trait Test { fn something() -> Vec<u8>; #[api_version(11)] fn new_cool_function() -> u32; } } ``` ``` impl_runtime_apis! { #[api_version(11)] impl Test for Runtime { fn something() -> Vec<u8> { vec![1, 2, 3] } fn new_cool_function() -> u32 { 10 } } } ``` Version safety checks (currently not implemented) ================================================= By default in the API trait all staging methods has got default implementation calling `unimplemented!()`. This is a problem because if the developer wants to implement version 11 in the example above and forgets to add `fn new_cool_function()` in `impl_runtime_apis!` the runtime will crash when the function is executed. Ideally a compilation error should be generated in such cases. TODOs ===== Things not working well at the moment: [ ] Version safety check [ ] Integration tests of `primitives/api` are messed up a bit. More specifically `primitives/api/test/tests/decl_and_impl.rs` [ ] Integration test covering the new functionality. [ ] Some duplicated code * Update primitives/api/proc-macro/src/impl_runtime_apis.rs Code review feedback and formatting Co-authored-by: asynchronous rob <rphmeier@gmail.com> * Code review feedback Applying suggestions from @bkchr * fmt * Apply suggestions from code review Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Code review feedback * dummy trait -> versioned trait * Implement only versioned traits (not compiling) * Remove native API calls (still not compiling) * fmt * Fix compilation * Comments * Remove unused code * Remove native runtime tests * Remove unused code * Fix UI tests * Code review feedback * Code review feedback * attribute_names -> common * Rework `append_api_version` * Code review feedback * Apply suggestions from code review Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Code review feedback * Code review feedback * Code review feedback * Use type alias for the default trait - doesn't compile * Fixes * Better error for `method_api_ver < trait_api_version` * fmt * Rework how we call runtime functions * Update UI tests * Fix warnings * Fix doctests * Apply suggestions from code review Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Fix formatting and small compilation errors * Update primitives/api/proc-macro/src/impl_runtime_apis.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: asynchronous rob <rphmeier@gmail.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <info@kchr.de>
231 lines
5.8 KiB
Rust
231 lines
5.8 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) 2019-2022 Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use sp_api::{
|
|
decl_runtime_apis, impl_runtime_apis, mock_impl_runtime_apis, ApiError, ApiExt, RuntimeApiInfo,
|
|
};
|
|
use sp_runtime::{
|
|
generic::BlockId,
|
|
traits::{Block as BlockT, GetNodeBlockType},
|
|
};
|
|
use substrate_test_runtime_client::runtime::Block;
|
|
|
|
/// The declaration of the `Runtime` type and the implementation of the `GetNodeBlockType`
|
|
/// trait are done by the `construct_runtime!` macro in a real runtime.
|
|
pub struct Runtime {}
|
|
impl GetNodeBlockType for Runtime {
|
|
type NodeBlock = Block;
|
|
}
|
|
|
|
decl_runtime_apis! {
|
|
pub trait Api {
|
|
fn test(data: u64);
|
|
fn something_with_block(block: Block) -> Block;
|
|
fn function_with_two_args(data: u64, block: Block);
|
|
fn same_name();
|
|
fn wild_card(_: u32);
|
|
}
|
|
|
|
#[api_version(2)]
|
|
pub trait ApiWithCustomVersion {
|
|
fn same_name();
|
|
#[changed_in(2)]
|
|
fn same_name() -> String;
|
|
}
|
|
|
|
#[api_version(2)]
|
|
pub trait ApiWithMultipleVersions {
|
|
fn stable_one(data: u64);
|
|
#[api_version(3)]
|
|
fn new_one();
|
|
#[api_version(4)]
|
|
fn glory_one();
|
|
}
|
|
}
|
|
|
|
impl_runtime_apis! {
|
|
impl self::Api<Block> for Runtime {
|
|
fn test(_: u64) {
|
|
unimplemented!()
|
|
}
|
|
|
|
fn something_with_block(_: Block) -> Block {
|
|
unimplemented!()
|
|
}
|
|
|
|
fn function_with_two_args(_: u64, _: Block) {
|
|
unimplemented!()
|
|
}
|
|
|
|
fn same_name() {}
|
|
|
|
fn wild_card(_: u32) {}
|
|
}
|
|
|
|
impl self::ApiWithCustomVersion<Block> for Runtime {
|
|
fn same_name() {}
|
|
}
|
|
|
|
#[api_version(3)]
|
|
impl self::ApiWithMultipleVersions<Block> for Runtime {
|
|
fn stable_one(_: u64) {}
|
|
|
|
fn new_one() {}
|
|
}
|
|
|
|
impl sp_api::Core<Block> for Runtime {
|
|
fn version() -> sp_version::RuntimeVersion {
|
|
unimplemented!()
|
|
}
|
|
fn execute_block(_: Block) {
|
|
unimplemented!()
|
|
}
|
|
fn initialize_block(_: &<Block as BlockT>::Header) {
|
|
unimplemented!()
|
|
}
|
|
}
|
|
}
|
|
|
|
struct MockApi {
|
|
block: Option<Block>,
|
|
}
|
|
|
|
mock_impl_runtime_apis! {
|
|
impl Api<Block> for MockApi {
|
|
fn test(_: u64) {
|
|
unimplemented!()
|
|
}
|
|
|
|
fn something_with_block(&self, _: Block) -> Block {
|
|
self.block.clone().unwrap()
|
|
}
|
|
|
|
fn function_with_two_args(_: u64, _: Block) {
|
|
unimplemented!()
|
|
}
|
|
|
|
#[advanced]
|
|
fn same_name(_: &BlockId<Block>) -> Result<(), ApiError> {
|
|
Ok(().into())
|
|
}
|
|
|
|
#[advanced]
|
|
fn wild_card(at: &BlockId<Block>, _: u32) -> Result<(), ApiError> {
|
|
if let BlockId::Number(1337) = at {
|
|
// yeah
|
|
Ok(().into())
|
|
} else {
|
|
Err((Box::from("Test error") as Box<dyn std::error::Error + Send + Sync>).into())
|
|
}
|
|
}
|
|
}
|
|
|
|
impl ApiWithCustomVersion<Block> for MockApi {
|
|
fn same_name() {}
|
|
}
|
|
}
|
|
|
|
type TestClient = substrate_test_runtime_client::client::Client<
|
|
substrate_test_runtime_client::Backend,
|
|
substrate_test_runtime_client::ExecutorDispatch,
|
|
Block,
|
|
RuntimeApi,
|
|
>;
|
|
|
|
#[test]
|
|
fn test_client_side_function_signature() {
|
|
let _test: fn(
|
|
&RuntimeApiImpl<Block, TestClient>,
|
|
&BlockId<Block>,
|
|
u64,
|
|
) -> Result<(), ApiError> = RuntimeApiImpl::<Block, TestClient>::test;
|
|
let _something_with_block: fn(
|
|
&RuntimeApiImpl<Block, TestClient>,
|
|
&BlockId<Block>,
|
|
Block,
|
|
) -> Result<Block, ApiError> = RuntimeApiImpl::<Block, TestClient>::something_with_block;
|
|
|
|
#[allow(deprecated)]
|
|
let _same_name_before_version_2: fn(
|
|
&RuntimeApiImpl<Block, TestClient>,
|
|
&BlockId<Block>,
|
|
) -> Result<String, ApiError> = RuntimeApiImpl::<Block, TestClient>::same_name_before_version_2;
|
|
}
|
|
|
|
#[test]
|
|
fn check_runtime_api_info() {
|
|
assert_eq!(&<dyn Api::<Block>>::ID, &runtime_decl_for_Api::ID);
|
|
assert_eq!(<dyn Api::<Block>>::VERSION, runtime_decl_for_Api::VERSION);
|
|
assert_eq!(<dyn Api::<Block>>::VERSION, 1);
|
|
|
|
assert_eq!(
|
|
<dyn ApiWithCustomVersion::<Block>>::VERSION,
|
|
runtime_decl_for_ApiWithCustomVersion::VERSION,
|
|
);
|
|
assert_eq!(
|
|
&<dyn ApiWithCustomVersion::<Block>>::ID,
|
|
&runtime_decl_for_ApiWithCustomVersion::ID,
|
|
);
|
|
assert_eq!(<dyn ApiWithCustomVersion::<Block>>::VERSION, 2);
|
|
|
|
// The stable version of the API
|
|
assert_eq!(<dyn ApiWithMultipleVersions::<Block>>::VERSION, 2);
|
|
}
|
|
|
|
fn check_runtime_api_versions_contains<T: RuntimeApiInfo + ?Sized>() {
|
|
assert!(RUNTIME_API_VERSIONS.iter().any(|v| v == &(T::ID, T::VERSION)));
|
|
}
|
|
|
|
#[test]
|
|
fn check_runtime_api_versions() {
|
|
check_runtime_api_versions_contains::<dyn Api<Block>>();
|
|
check_runtime_api_versions_contains::<dyn ApiWithCustomVersion<Block>>();
|
|
assert!(RUNTIME_API_VERSIONS
|
|
.iter()
|
|
.any(|v| v == &(<dyn ApiWithMultipleVersions<Block>>::ID, 3)));
|
|
check_runtime_api_versions_contains::<dyn sp_api::Core<Block>>();
|
|
}
|
|
|
|
#[test]
|
|
fn mock_runtime_api_has_api() {
|
|
let mock = MockApi { block: None };
|
|
|
|
assert!(mock.has_api::<dyn ApiWithCustomVersion<Block>>(&BlockId::Number(0)).unwrap());
|
|
assert!(mock.has_api::<dyn Api<Block>>(&BlockId::Number(0)).unwrap());
|
|
}
|
|
|
|
#[test]
|
|
#[should_panic(expected = "Calling deprecated methods is not supported by mocked runtime api.")]
|
|
fn mock_runtime_api_panics_on_calling_old_version() {
|
|
let mock = MockApi { block: None };
|
|
|
|
#[allow(deprecated)]
|
|
let _ = mock.same_name_before_version_2(&BlockId::Number(0));
|
|
}
|
|
|
|
#[test]
|
|
fn mock_runtime_api_works_with_advanced() {
|
|
let mock = MockApi { block: None };
|
|
|
|
Api::<Block>::same_name(&mock, &BlockId::Number(0)).unwrap();
|
|
mock.wild_card(&BlockId::Number(1337), 1).unwrap();
|
|
assert_eq!(
|
|
"Test error".to_string(),
|
|
mock.wild_card(&BlockId::Number(1336), 1).unwrap_err().to_string(),
|
|
);
|
|
}
|