mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-07-04 13:57:23 +00:00

Files

T

Branislav Kontur 3d9439f646 [pallet-xcm] Adjust benchmarks (teleport_assets/reserve_transfer_assets) not relying on ED (#3464 )

## Problem
During the bumping of the `polkadot-fellows` repository to
`polkadot-sdk@1.6.0`, I encountered a situation where the benchmarks
`teleport_assets` and `reserve_transfer_assets` in AssetHubKusama
started to fail. This issue arose due to a decreased ED balance for
AssetHubs introduced
[here](https://github.com/polkadot-fellows/runtimes/pull/158/files#diff-80668ff8e793b64f36a9a3ec512df5cbca4ad448c157a5d81abda1b15f35f1daR213),
and also because of a [missing CI
pipeline](https://github.com/polkadot-fellows/runtimes/issues/197) to
check the benchmarks, which went unnoticed.

These benchmarks expect the `caller` to have enough:
1. balance to transfer (BTT)
2. balance for paying delivery (BFPD).
 
So the initial balance was calculated as `ED * 100`, which seems
reasonable:
```
const ED_MULTIPLIER: u32 = 100;
let balance = existential_deposit.saturating_mul(ED_MULTIPLIER.into());`
```
The problem arises when the price for delivery is 100 times higher than
the existential deposit. In other words, when `ED * 100` does not cover
`BTT` + `BFPD`.

I check AHR/AHW/AHK/AHP and this problem has only AssetHubKusama
```
ED: 3333333
calculated price to parent delivery:  1031666634  (from xcm logs from the benchmark)
---

3333333 * 100 - BTT(3333333) - BFPD(1031666634) = −701666667
```
which results in the error;
```
2024-02-23 09:19:42 Unable to charge fee with error Module(ModuleError { index: 31, error: [17, 0, 0, 0], message: Some("FeesNotMet") })
Error: Input("Benchmark pallet_xcm::reserve_transfer_assets failed: FeesNotMet")
     
```

## Solution

The benchmarks `teleport_assets` and `reserve_transfer_assets` were
fixed by removing `ED * 100` and replacing it with `DeliveryHelper`
logic, which calculates the (almost real) price for delivery and sets it
along with the existential deposit as the initial balance for the
account used in the benchmark.


## TODO

- [ ] patch for 1.6 -
https://github.com/paritytech/polkadot-sdk/pull/3466
- [ ] patch for 1.7 -
https://github.com/paritytech/polkadot-sdk/pull/3465
- [ ] patch for 1.8 - TODO: PR

---------

Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>

2024-02-26 08:12:28 +00:00

chain-specs

Update coretime-westend bootnodes (#3380 )

2024-02-19 10:11:17 +00:00

common

remove bound on accountID in AssetFeeAsExistentialDepositMultiplier (#3303 )

2024-02-20 23:34:09 +00:00

integration-tests/emulated

[FRAME] Test for sane genesis default (#3412 )

2024-02-22 00:35:01 +00:00

pallets

Sync Cargo.toml and crates.io versions (#3034 )

2024-01-26 18:14:03 +00:00

runtimes

[pallet-xcm] Adjust benchmarks (teleport_assets/reserve_transfer_assets) not relying on ED (#3464 )

2024-02-26 08:12:28 +00:00

README.md

Minor update to Readme - Statemint section (#2078 )

2023-01-11 15:25:23 +00:00

README.md

Parachains

This directory is the home of Parity-developed parachain runtimes. This directory is runtime focused, and does not include builds of parachain nodes.

The general internal structure is:

chain-specs: Chain specs for the runtimes contained in its sibling dir runtimes.
common: Common configurations, impls, etc. used by several parachain runtimes.
integration-tests: Integration tests to test parachain interactions via XCM.
pallets: FRAME pallets that are specific to parachains.
runtimes: The entry point for parachain runtimes.

System Parachains

The runtimes directory includes many, but is not limited to, system parachains. Likewise, not all system parachains are in this repo.

Releases

The project maintainers generally try to release a set of parachain runtimes for each Polkadot Relay Chain runtime release.