Files
pezkuwi-subxt/substrate/frame/child-bounties/src/tests.rs
T
Gavin Wood 3dd8f83a3a Insufficient asset quota and deposits (#10382)
* Allow asset accounts to exist by deposit

* Place limit on consumers (and therefore freebie asset accounts)

* Maximum number of assets

* Fixes

* Fixes

* Formatting

* Docs

* Formatting

* Destroyed assets are properly tidied

* Update frame/assets/src/types.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Docs

* Docs

* Formatting

* Docs

* Docs

* Fixes

* Fixes

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
2021-12-09 13:22:54 +01:00

1221 lines
40 KiB
Rust

// This file is part of Substrate.
// Copyright (C) 2021 Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: Apache-2.0
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//! Child-bounties pallet tests.
#![cfg(test)]
use super::*;
use crate as pallet_child_bounties;
use std::cell::RefCell;
use frame_support::{
assert_noop, assert_ok, pallet_prelude::GenesisBuild, parameter_types, traits::OnInitialize,
weights::Weight, PalletId,
};
use sp_core::H256;
use sp_runtime::{
testing::Header,
traits::{BadOrigin, BlakeTwo256, IdentityLookup},
Perbill, Permill,
};
use super::Event as ChildBountiesEvent;
type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>;
type Block = frame_system::mocking::MockBlock<Test>;
type BountiesError = pallet_bounties::Error<Test>;
frame_support::construct_runtime!(
pub enum Test where
Block = Block,
NodeBlock = Block,
UncheckedExtrinsic = UncheckedExtrinsic,
{
System: frame_system::{Pallet, Call, Config, Storage, Event<T>},
Balances: pallet_balances::{Pallet, Call, Storage, Config<T>, Event<T>},
Bounties: pallet_bounties::{Pallet, Call, Storage, Event<T>},
Treasury: pallet_treasury::{Pallet, Call, Storage, Config, Event<T>},
ChildBounties: pallet_child_bounties::{Pallet, Call, Storage, Event<T>},
}
);
parameter_types! {
pub const BlockHashCount: u64 = 250;
pub const MaximumBlockWeight: Weight = 1024;
pub const MaximumBlockLength: u32 = 2 * 1024;
pub const AvailableBlockRatio: Perbill = Perbill::one();
}
impl frame_system::Config for Test {
type BaseCallFilter = frame_support::traits::Everything;
type BlockWeights = ();
type BlockLength = ();
type DbWeight = ();
type Origin = Origin;
type Index = u64;
type BlockNumber = u64;
type Call = Call;
type Hash = H256;
type Hashing = BlakeTwo256;
type AccountId = u128;
type Lookup = IdentityLookup<Self::AccountId>;
type Header = Header;
type Event = Event;
type BlockHashCount = BlockHashCount;
type Version = ();
type PalletInfo = PalletInfo;
type AccountData = pallet_balances::AccountData<u64>;
type OnNewAccount = ();
type OnKilledAccount = ();
type SystemWeightInfo = ();
type SS58Prefix = ();
type OnSetCode = ();
type MaxConsumers = frame_support::traits::ConstU32<16>;
}
parameter_types! {
pub const ExistentialDeposit: u64 = 1;
}
impl pallet_balances::Config for Test {
type MaxLocks = ();
type MaxReserves = ();
type ReserveIdentifier = [u8; 8];
type Balance = u64;
type Event = Event;
type DustRemoval = ();
type ExistentialDeposit = ExistentialDeposit;
type AccountStore = System;
type WeightInfo = ();
}
thread_local! {
static TEN_TO_FOURTEEN: RefCell<Vec<u128>> = RefCell::new(vec![10,11,12,13,14]);
}
parameter_types! {
pub const ProposalBond: Permill = Permill::from_percent(5);
pub const ProposalBondMinimum: u64 = 1;
pub const SpendPeriod: u64 = 2;
pub const Burn: Permill = Permill::from_percent(50);
pub const DataDepositPerByte: u64 = 1;
pub const TreasuryPalletId: PalletId = PalletId(*b"py/trsry");
pub const MaxApprovals: u32 = 100;
}
impl pallet_treasury::Config for Test {
type PalletId = TreasuryPalletId;
type Currency = pallet_balances::Pallet<Test>;
type ApproveOrigin = frame_system::EnsureRoot<u128>;
type RejectOrigin = frame_system::EnsureRoot<u128>;
type Event = Event;
type OnSlash = ();
type ProposalBond = ProposalBond;
type ProposalBondMinimum = ProposalBondMinimum;
type SpendPeriod = SpendPeriod;
type Burn = Burn;
type BurnDestination = ();
type WeightInfo = ();
type SpendFunds = Bounties;
type MaxApprovals = MaxApprovals;
}
parameter_types! {
pub const BountyDepositBase: u64 = 80;
pub const BountyDepositPayoutDelay: u64 = 3;
pub const BountyUpdatePeriod: u32 = 10;
pub const BountyCuratorDeposit: Permill = Permill::from_percent(50);
pub const BountyValueMinimum: u64 = 5;
pub const MaximumReasonLength: u32 = 300;
}
impl pallet_bounties::Config for Test {
type Event = Event;
type BountyDepositBase = BountyDepositBase;
type BountyDepositPayoutDelay = BountyDepositPayoutDelay;
type BountyUpdatePeriod = BountyUpdatePeriod;
type BountyCuratorDeposit = BountyCuratorDeposit;
type BountyValueMinimum = BountyValueMinimum;
type DataDepositPerByte = DataDepositPerByte;
type MaximumReasonLength = MaximumReasonLength;
type WeightInfo = ();
type ChildBountyManager = ChildBounties;
}
parameter_types! {
pub const MaxActiveChildBountyCount: u32 = 2;
pub const ChildBountyValueMinimum: u64 = 1;
pub const ChildBountyCuratorDepositBase: Permill = Permill::from_percent(10);
}
impl pallet_child_bounties::Config for Test {
type Event = Event;
type MaxActiveChildBountyCount = MaxActiveChildBountyCount;
type ChildBountyValueMinimum = ChildBountyValueMinimum;
type ChildBountyCuratorDepositBase = ChildBountyCuratorDepositBase;
type WeightInfo = ();
}
pub fn new_test_ext() -> sp_io::TestExternalities {
let mut t = frame_system::GenesisConfig::default().build_storage::<Test>().unwrap();
pallet_balances::GenesisConfig::<Test> {
// Total issuance will be 200 with treasury account initialized at ED.
balances: vec![(0, 100), (1, 98), (2, 1)],
}
.assimilate_storage(&mut t)
.unwrap();
GenesisBuild::<Test>::assimilate_storage(&pallet_treasury::GenesisConfig, &mut t).unwrap();
t.into()
}
fn last_event() -> ChildBountiesEvent<Test> {
System::events()
.into_iter()
.map(|r| r.event)
.filter_map(|e| if let Event::ChildBounties(inner) = e { Some(inner) } else { None })
.last()
.unwrap()
}
#[test]
fn genesis_config_works() {
new_test_ext().execute_with(|| {
assert_eq!(Treasury::pot(), 0);
assert_eq!(Treasury::proposal_count(), 0);
});
}
#[test]
fn minting_works() {
new_test_ext().execute_with(|| {
// Check that accumulate works when we have Some value in Dummy already.
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Treasury::pot(), 100);
});
}
#[test]
fn add_child_bounty() {
new_test_ext().execute_with(|| {
// TestProcedure.
// 1, Create bounty & move to active state with enough bounty fund & master-curator.
// 2, Master-curator adds child-bounty child-bounty-1, test for error like RequireCurator
// ,InsufficientProposersBalance, InsufficientBountyBalance with invalid arguments.
// 3, Master-curator adds child-bounty child-bounty-1, moves to "Approved" state &
// test for the event Added.
// 4, Test for DB state of `Bounties` & `ChildBounties`.
// 5, Observe fund transaction moment between Bounty, Child-bounty,
// Curator, child-bounty curator & beneficiary.
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 4));
Balances::make_free_balance_be(&4, 10);
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
assert_eq!(Balances::free_balance(&4), 8);
assert_eq!(Balances::reserved_balance(&4), 2);
// Add child-bounty.
// Acc-4 is the master curator.
// Call from invalid origin & check for error "RequireCurator".
assert_noop!(
ChildBounties::add_child_bounty(Origin::signed(0), 0, 10, b"12345-p1".to_vec()),
BountiesError::RequireCurator,
);
// Update the master curator balance.
Balances::make_free_balance_be(&4, 101);
// Master curator fee is reserved on parent bounty account.
assert_eq!(Balances::free_balance(Bounties::bounty_account_id(0)), 50);
assert_eq!(Balances::reserved_balance(Bounties::bounty_account_id(0)), 0);
assert_noop!(
ChildBounties::add_child_bounty(Origin::signed(4), 0, 50, b"12345-p1".to_vec()),
pallet_balances::Error::<Test>::KeepAlive,
);
assert_noop!(
ChildBounties::add_child_bounty(Origin::signed(4), 0, 100, b"12345-p1".to_vec()),
Error::<Test>::InsufficientBountyBalance,
);
// Add child-bounty with valid value, which can be funded by parent bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
// Check for the event child-bounty added.
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
assert_eq!(Balances::free_balance(4), 101);
assert_eq!(Balances::reserved_balance(4), 2);
// DB check.
// Check the child-bounty status.
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 0,
curator_deposit: 0,
status: ChildBountyStatus::Added,
}
);
// Check the child-bounty count.
assert_eq!(ChildBounties::parent_child_bounties(0), 1);
// Check the child-bounty description status.
assert_eq!(ChildBounties::child_bounty_descriptions(0).unwrap(), b"12345-p1".to_vec(),);
});
}
#[test]
fn child_bounty_assign_curator() {
new_test_ext().execute_with(|| {
// TestProcedure
// 1, Create bounty & move to active state with enough bounty fund & master-curator.
// 2, Master-curator adds child-bounty child-bounty-1, moves to "Active" state.
// 3, Test for DB state of `ChildBounties`.
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
Balances::make_free_balance_be(&4, 101);
Balances::make_free_balance_be(&8, 101);
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 4));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Bounty account status before adding child-bounty.
assert_eq!(Balances::free_balance(Bounties::bounty_account_id(0)), 50);
assert_eq!(Balances::reserved_balance(Bounties::bounty_account_id(0)), 0);
// Check the balance of master curator.
// Curator deposit is reserved for master curator on parent bounty.
assert_eq!(Balances::free_balance(4), 99);
assert_eq!(Balances::reserved_balance(4), 2);
// Add child-bounty.
// Acc-4 is the master curator & make sure enough deposit.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
// Bounty account status after adding child-bounty.
assert_eq!(Balances::free_balance(Bounties::bounty_account_id(0)), 40);
assert_eq!(Balances::reserved_balance(Bounties::bounty_account_id(0)), 0);
// Child-bounty account status.
assert_eq!(Balances::free_balance(ChildBounties::child_bounty_account_id(0)), 10);
assert_eq!(Balances::reserved_balance(ChildBounties::child_bounty_account_id(0)), 0);
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 8, 2));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::CuratorProposed { curator: 8 },
}
);
// Check the balance of master curator.
assert_eq!(Balances::free_balance(4), 99);
assert_eq!(Balances::reserved_balance(4), 2);
assert_noop!(
ChildBounties::accept_curator(Origin::signed(3), 0, 0),
BountiesError::RequireCurator,
);
assert_ok!(ChildBounties::accept_curator(Origin::signed(8), 0, 0));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::Active { curator: 8 },
}
);
// Deposit for child-bounty curator is reserved.
assert_eq!(Balances::free_balance(8), 100);
assert_eq!(Balances::reserved_balance(8), 1);
// Bounty account status at exit.
assert_eq!(Balances::free_balance(Bounties::bounty_account_id(0)), 40);
assert_eq!(Balances::reserved_balance(Bounties::bounty_account_id(0)), 0);
// Child-bounty account status at exit.
assert_eq!(Balances::free_balance(ChildBounties::child_bounty_account_id(0)), 10);
assert_eq!(Balances::reserved_balance(ChildBounties::child_bounty_account_id(0)), 0);
// Treasury account status at exit.
assert_eq!(Balances::free_balance(Treasury::account_id()), 26);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
});
}
#[test]
fn award_claim_child_bounty() {
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
// Propose and accept curator for child-bounty.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 8, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(8), 0, 0));
// Award child-bounty.
// Test for non child-bounty curator.
assert_noop!(
ChildBounties::award_child_bounty(Origin::signed(3), 0, 0, 7),
BountiesError::RequireCurator,
);
assert_ok!(ChildBounties::award_child_bounty(Origin::signed(8), 0, 0, 7));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::PendingPayout {
curator: 8,
beneficiary: 7,
unlock_at: 5
},
}
);
// Claim child-bounty.
// Test for Premature condition.
assert_noop!(
ChildBounties::claim_child_bounty(Origin::signed(7), 0, 0),
BountiesError::Premature
);
System::set_block_number(9);
assert_ok!(ChildBounties::claim_child_bounty(Origin::signed(7), 0, 0));
// Ensure child-bounty curator is paid with curator fee & deposit refund.
assert_eq!(Balances::free_balance(8), 103);
assert_eq!(Balances::reserved_balance(8), 0);
// Ensure executor is paid with beneficiary amount.
assert_eq!(Balances::free_balance(7), 8);
assert_eq!(Balances::reserved_balance(7), 0);
// Child-bounty account status.
assert_eq!(Balances::free_balance(ChildBounties::child_bounty_account_id(0)), 0);
assert_eq!(Balances::reserved_balance(ChildBounties::child_bounty_account_id(0)), 0);
// Check the child-bounty count.
assert_eq!(ChildBounties::parent_child_bounties(0), 0);
});
}
#[test]
fn close_child_bounty_added() {
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
System::set_block_number(4);
// Close child-bounty.
// Wrong origin.
assert_noop!(ChildBounties::close_child_bounty(Origin::signed(7), 0, 0), BadOrigin);
assert_noop!(ChildBounties::close_child_bounty(Origin::signed(8), 0, 0), BadOrigin);
// Correct origin - parent curator.
assert_ok!(ChildBounties::close_child_bounty(Origin::signed(4), 0, 0));
// Check the child-bounty count.
assert_eq!(ChildBounties::parent_child_bounties(0), 0);
// Parent-bounty account status.
assert_eq!(Balances::free_balance(Bounties::bounty_account_id(0)), 50);
assert_eq!(Balances::reserved_balance(Bounties::bounty_account_id(0)), 0);
// Child-bounty account status.
assert_eq!(Balances::free_balance(ChildBounties::child_bounty_account_id(0)), 0);
assert_eq!(Balances::reserved_balance(ChildBounties::child_bounty_account_id(0)), 0);
});
}
#[test]
fn close_child_bounty_active() {
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
// Propose and accept curator for child-bounty.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 8, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(8), 0, 0));
// Close child-bounty in active state.
assert_ok!(ChildBounties::close_child_bounty(Origin::signed(4), 0, 0));
// Check the child-bounty count.
assert_eq!(ChildBounties::parent_child_bounties(0), 0);
// Ensure child-bounty curator balance is unreserved.
assert_eq!(Balances::free_balance(8), 101);
assert_eq!(Balances::reserved_balance(8), 0);
// Parent-bounty account status.
assert_eq!(Balances::free_balance(Bounties::bounty_account_id(0)), 50);
assert_eq!(Balances::reserved_balance(Bounties::bounty_account_id(0)), 0);
// Child-bounty account status.
assert_eq!(Balances::free_balance(ChildBounties::child_bounty_account_id(0)), 0);
assert_eq!(Balances::reserved_balance(ChildBounties::child_bounty_account_id(0)), 0);
});
}
#[test]
fn close_child_bounty_pending() {
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
// Propose and accept curator for child-bounty.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 8, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(8), 0, 0));
assert_ok!(ChildBounties::award_child_bounty(Origin::signed(8), 0, 0, 7));
// Close child-bounty in pending_payout state.
assert_noop!(
ChildBounties::close_child_bounty(Origin::signed(4), 0, 0),
BountiesError::PendingPayout
);
// Check the child-bounty count.
assert_eq!(ChildBounties::parent_child_bounties(0), 1);
// Ensure no changes in child-bounty curator balance.
assert_eq!(Balances::free_balance(8), 100);
assert_eq!(Balances::reserved_balance(8), 1);
// Child-bounty account status.
assert_eq!(Balances::free_balance(ChildBounties::child_bounty_account_id(0)), 10);
assert_eq!(Balances::reserved_balance(ChildBounties::child_bounty_account_id(0)), 0);
});
}
#[test]
fn child_bounty_added_unassign_curator() {
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
// Unassign curator in added state.
assert_noop!(
ChildBounties::unassign_curator(Origin::signed(4), 0, 0),
BountiesError::UnexpectedStatus
);
});
}
#[test]
fn child_bounty_curator_proposed_unassign_curator() {
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
// Propose curator for child-bounty.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 8, 2));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::CuratorProposed { curator: 8 },
}
);
// Random account cannot unassign the curator when in proposed state.
assert_noop!(ChildBounties::unassign_curator(Origin::signed(99), 0, 0), BadOrigin);
// Unassign curator.
assert_ok!(ChildBounties::unassign_curator(Origin::signed(4), 0, 0));
// Verify updated child-bounty status.
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::Added,
}
);
});
}
#[test]
fn child_bounty_active_unassign_curator() {
// Covers all scenarios with all origin types.
// Step 1: Setup bounty, child bounty.
// Step 2: Assign, accept curator for child bounty. Unassign from reject origin. Should slash.
// Step 3: Assign, accept another curator for child bounty. Unassign from parent-bounty curator.
// Should slash. Step 4: Assign, accept another curator for child bounty. Unassign from
// child-bounty curator. Should NOT slash. Step 5: Assign, accept another curator for child
// bounty. Unassign from random account. Should slash.
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&6, 101); // Child-bounty curator 1.
Balances::make_free_balance_be(&7, 101); // Child-bounty curator 2.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator 3.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Create Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
System::set_block_number(3);
<Treasury as OnInitialize<u64>>::on_initialize(3);
// Propose and accept curator for child-bounty.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 8, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(8), 0, 0));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::Active { curator: 8 },
}
);
System::set_block_number(4);
<Treasury as OnInitialize<u64>>::on_initialize(4);
// Unassign curator - from reject origin.
assert_ok!(ChildBounties::unassign_curator(Origin::root(), 0, 0));
// Verify updated child-bounty status.
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::Added,
}
);
// Ensure child-bounty curator was slashed.
assert_eq!(Balances::free_balance(8), 100);
assert_eq!(Balances::reserved_balance(8), 0); // slashed
// Propose and accept curator for child-bounty again.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 7, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(7), 0, 0));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::Active { curator: 7 },
}
);
System::set_block_number(5);
<Treasury as OnInitialize<u64>>::on_initialize(5);
// Unassign curator again - from master curator.
assert_ok!(ChildBounties::unassign_curator(Origin::signed(4), 0, 0));
// Verify updated child-bounty status.
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::Added,
}
);
// Ensure child-bounty curator was slashed.
assert_eq!(Balances::free_balance(7), 100);
assert_eq!(Balances::reserved_balance(7), 0); // slashed
// Propose and accept curator for child-bounty again.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 6, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(6), 0, 0));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::Active { curator: 6 },
}
);
System::set_block_number(6);
<Treasury as OnInitialize<u64>>::on_initialize(6);
// Unassign curator again - from child-bounty curator.
assert_ok!(ChildBounties::unassign_curator(Origin::signed(6), 0, 0));
// Verify updated child-bounty status.
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::Added,
}
);
// Ensure child-bounty curator was **not** slashed.
assert_eq!(Balances::free_balance(6), 101); // not slashed
assert_eq!(Balances::reserved_balance(6), 0);
// Propose and accept curator for child-bounty one last time.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 6, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(6), 0, 0));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::Active { curator: 6 },
}
);
System::set_block_number(7);
<Treasury as OnInitialize<u64>>::on_initialize(7);
// Unassign curator again - from non curator; non reject origin; some random guy.
// Bounty update period is not yet complete.
assert_noop!(
ChildBounties::unassign_curator(Origin::signed(3), 0, 0),
BountiesError::Premature
);
System::set_block_number(20);
<Treasury as OnInitialize<u64>>::on_initialize(20);
// Unassign child curator from random account after inactivity.
assert_ok!(ChildBounties::unassign_curator(Origin::signed(3), 0, 0));
// Verify updated child-bounty status.
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::Added,
}
);
// Ensure child-bounty curator was slashed.
assert_eq!(Balances::free_balance(6), 100); // slashed
assert_eq!(Balances::reserved_balance(6), 0);
});
}
#[test]
fn parent_bounty_inactive_unassign_curator_child_bounty() {
// Unassign curator when parent bounty in not in active state.
// This can happen when the curator of parent bounty has been unassigned.
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator 1.
Balances::make_free_balance_be(&5, 101); // Parent-bounty curator 2.
Balances::make_free_balance_be(&6, 101); // Child-bounty curator 1.
Balances::make_free_balance_be(&7, 101); // Child-bounty curator 2.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator 3.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Create Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
System::set_block_number(3);
<Treasury as OnInitialize<u64>>::on_initialize(3);
// Propose and accept curator for child-bounty.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 8, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(8), 0, 0));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::Active { curator: 8 },
}
);
System::set_block_number(4);
<Treasury as OnInitialize<u64>>::on_initialize(4);
// Unassign parent bounty curator.
assert_ok!(Bounties::unassign_curator(Origin::root(), 0));
System::set_block_number(5);
<Treasury as OnInitialize<u64>>::on_initialize(5);
// Try unassign child-bounty curator - from non curator; non reject
// origin; some random guy. Bounty update period is not yet complete.
assert_noop!(
ChildBounties::unassign_curator(Origin::signed(3), 0, 0),
Error::<Test>::ParentBountyNotActive
);
// Unassign curator - from reject origin.
assert_ok!(ChildBounties::unassign_curator(Origin::root(), 0, 0));
// Verify updated child-bounty status.
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::Added,
}
);
// Ensure child-bounty curator was slashed.
assert_eq!(Balances::free_balance(8), 100);
assert_eq!(Balances::reserved_balance(8), 0); // slashed
System::set_block_number(6);
<Treasury as OnInitialize<u64>>::on_initialize(6);
// Propose and accept curator for parent-bounty again.
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 5, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(5), 0));
System::set_block_number(7);
<Treasury as OnInitialize<u64>>::on_initialize(7);
// Propose and accept curator for child-bounty again.
assert_ok!(ChildBounties::propose_curator(Origin::signed(5), 0, 0, 7, 2));
assert_ok!(ChildBounties::accept_curator(Origin::signed(7), 0, 0));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::Active { curator: 7 },
}
);
System::set_block_number(8);
<Treasury as OnInitialize<u64>>::on_initialize(8);
assert_noop!(
ChildBounties::unassign_curator(Origin::signed(3), 0, 0),
BountiesError::Premature
);
// Unassign parent bounty curator again.
assert_ok!(Bounties::unassign_curator(Origin::signed(5), 0));
System::set_block_number(9);
<Treasury as OnInitialize<u64>>::on_initialize(9);
// Unassign curator again - from master curator.
assert_ok!(ChildBounties::unassign_curator(Origin::signed(7), 0, 0));
// Verify updated child-bounty status.
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 0,
status: ChildBountyStatus::Added,
}
);
// Ensure child-bounty curator was not slashed.
assert_eq!(Balances::free_balance(7), 101);
assert_eq!(Balances::reserved_balance(7), 0); // slashed
});
}
#[test]
fn close_parent_with_child_bounty() {
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
// Try add child-bounty.
// Should fail, parent bounty not active yet.
assert_noop!(
ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()),
Error::<Test>::ParentBountyNotActive
);
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
System::set_block_number(4);
<Treasury as OnInitialize<u64>>::on_initialize(4);
// Try close parent-bounty.
// Child bounty active, can't close parent.
assert_noop!(
Bounties::close_bounty(Origin::root(), 0),
BountiesError::HasActiveChildBounty
);
System::set_block_number(2);
// Close child-bounty.
assert_ok!(ChildBounties::close_child_bounty(Origin::root(), 0, 0));
// Check the child-bounty count.
assert_eq!(ChildBounties::parent_child_bounties(0), 0);
// Try close parent-bounty again.
// Should pass this time.
assert_ok!(Bounties::close_bounty(Origin::root(), 0));
});
}
#[test]
fn children_curator_fee_calculation_test() {
// Tests the calculation of subtracting child-bounty curator fee
// from parent bounty fee when claiming bounties.
new_test_ext().execute_with(|| {
// Make the parent bounty.
System::set_block_number(1);
Balances::make_free_balance_be(&Treasury::account_id(), 101);
assert_eq!(Balances::free_balance(Treasury::account_id()), 101);
assert_eq!(Balances::reserved_balance(Treasury::account_id()), 0);
// Bounty curator initial balance.
Balances::make_free_balance_be(&4, 101); // Parent-bounty curator.
Balances::make_free_balance_be(&8, 101); // Child-bounty curator.
assert_ok!(Bounties::propose_bounty(Origin::signed(0), 50, b"12345".to_vec()));
assert_ok!(Bounties::approve_bounty(Origin::root(), 0));
System::set_block_number(2);
<Treasury as OnInitialize<u64>>::on_initialize(2);
assert_ok!(Bounties::propose_curator(Origin::root(), 0, 4, 6));
assert_ok!(Bounties::accept_curator(Origin::signed(4), 0));
// Child-bounty.
assert_ok!(ChildBounties::add_child_bounty(Origin::signed(4), 0, 10, b"12345-p1".to_vec()));
assert_eq!(last_event(), ChildBountiesEvent::Added { index: 0, child_index: 0 });
System::set_block_number(4);
<Treasury as OnInitialize<u64>>::on_initialize(4);
// Propose curator for child-bounty.
assert_ok!(ChildBounties::propose_curator(Origin::signed(4), 0, 0, 8, 2));
// Check curator fee added to the sum.
assert_eq!(ChildBounties::children_curator_fees(0), 2);
// Accept curator for child-bounty.
assert_ok!(ChildBounties::accept_curator(Origin::signed(8), 0, 0));
// Award child-bounty.
assert_ok!(ChildBounties::award_child_bounty(Origin::signed(8), 0, 0, 7));
assert_eq!(
ChildBounties::child_bounties(0, 0).unwrap(),
ChildBounty {
parent_bounty: 0,
value: 10,
fee: 2,
curator_deposit: 1,
status: ChildBountyStatus::PendingPayout {
curator: 8,
beneficiary: 7,
unlock_at: 7
},
}
);
System::set_block_number(9);
// Claim child-bounty.
assert_ok!(ChildBounties::claim_child_bounty(Origin::signed(7), 0, 0));
// Check the child-bounty count.
assert_eq!(ChildBounties::parent_child_bounties(0), 0);
// Award the parent bounty.
assert_ok!(Bounties::award_bounty(Origin::signed(4), 0, 9));
System::set_block_number(15);
// Claim the parent bounty.
assert_ok!(Bounties::claim_bounty(Origin::signed(9), 0));
// Ensure parent-bounty curator received correctly reduced fee.
assert_eq!(Balances::free_balance(4), 105); // 101 + 6 - 2
assert_eq!(Balances::reserved_balance(4), 0);
// Verify parent-bounty beneficiary balance.
assert_eq!(Balances::free_balance(9), 34);
assert_eq!(Balances::reserved_balance(9), 0);
});
}