mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-07-11 12:55:46 +00:00

Files

T

Branislav Kontur e3c97e4860 [xcm] Use Weight::MAX for reserve_asset_deposited, receive_teleported_asset benchmarks (#1726 )

# Description

## Summary

Previously, the `pallet_xcm::do_reserve_transfer_assets` and
`pallet_xcm::do_teleport_assets` functions relied on weight estimation
for remote chain execution, which was based on guesswork derived from
the local chain. This approach led to complications for runtimes that
did not provide or support specific [XCM
configurations](https://github.com/paritytech/polkadot-sdk/blob/7cbe0c76ef8fd2aabf9f07de0156941ce3ed44b0/polkadot/xcm/xcm-executor/src/config.rs#L43-L47)
for `IsReserve` or `IsTeleporter`. Consequently, such runtimes had to
resort to implementing hard-coded weights for XCM instructions like
`reserve_asset_deposited` or `receive_teleported_asset` to support
extrinsics such as `pallet_xcm::reserve_transfer_assets` and
`pallet_xcm::teleport_assets`, which depended on remote weight
estimation.

The issue of remote weight estimation was addressed and resolved by
[Pull Request
#1645](https://github.com/paritytech/polkadot-sdk/pull/1645), which
removed the need for remote weight estimation.

## Solution

As a continuation of this improvement, the current PR proposes further
cleanup by removing unnecessary hard-coded values and rectifying
benchmark results with `Weight::MAX` that previously used
`T::BlockWeights::get().max_block` as an override for unsupported XCM
instructions like `ReserveAssetDeposited` and `ReceiveTeleportedAsset`.


## Questions

- [x] Can we remove now also `Hardcoded till the XCM pallet is fixed`
for `deposit_asset`? E.g. for AssetHubKusama
[here](https://github.com/paritytech/polkadot-sdk/blob/7cbe0c76ef8fd2aabf9f07de0156941ce3ed44b0/cumulus/parachains/runtimes/assets/asset-hub-kusama/src/weights/xcm/mod.rs#L129-L134)
- [x] Are comments like
[this](https://github.com/paritytech/polkadot-sdk/blob/7cbe0c76ef8fd2aabf9f07de0156941ce3ed44b0/polkadot/runtime/kusama/src/weights/xcm/mod.rs#L94)
`// Kusama doesn't support ReserveAssetDeposited, so this benchmark has
a default weight` still relevant? Shouldnt be removed/changed?


## TODO

- [x] `bench bot` regenerate xcm weights for all runtimes
- [x] remove hard-coded stuff from system parachain weight files
- [ ] when merged, open `polkadot-fellow/runtimes` PR

## References

Fixes #1132
Closes #1132
Old polkadot repo [PR](https://github.com/paritytech/polkadot/pull/7546)

---------

Co-authored-by: command-bot <>

2023-10-10 13:26:22 +02:00

chain-specs

Add Helikon boot nodes for Bridge Hub Polkadot and Bridge Hub Westend. (#2927 )

2023-08-15 22:30:53 +00:00

common

Remove kusama and polkadot runtime crates (#1731 )

2023-09-29 09:54:11 +02:00

integration-tests

[xcm] Use Weight::MAX for reserve_asset_deposited, receive_teleported_asset benchmarks (#1726 )

2023-10-10 13:26:22 +02:00

pallets

The Ambassador Program (#1308 )

2023-09-20 21:55:56 +02:00

runtimes

[xcm] Use Weight::MAX for reserve_asset_deposited, receive_teleported_asset benchmarks (#1726 )

2023-10-10 13:26:22 +02:00

README.md

Minor update to Readme - Statemint section (#2078 )

2023-01-11 15:25:23 +00:00

README.md

Parachains

This directory is the home of Parity-developed parachain runtimes. This directory is runtime focused, and does not include builds of parachain nodes.

The general internal structure is:

chain-specs: Chain specs for the runtimes contained in its sibling dir runtimes.
common: Common configurations, impls, etc. used by several parachain runtimes.
integration-tests: Integration tests to test parachain interactions via XCM.
pallets: FRAME pallets that are specific to parachains.
runtimes: The entry point for parachain runtimes.

System Parachains

The runtimes directory includes many, but is not limited to, system parachains. Likewise, not all system parachains are in this repo.

Releases

The project maintainers generally try to release a set of parachain runtimes for each Polkadot Relay Chain runtime release.