mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-18 02:31:03 +00:00
8428f678fe
# Note for reviewer
Most changes are just syntax changes necessary for the new version.
Most important files should be the ones under the `xcm` folder.
# Description
Added XCMv4.
## Removed `Multi` prefix
The following types have been renamed:
- MultiLocation -> Location
- MultiAsset -> Asset
- MultiAssets -> Assets
- InteriorMultiLocation -> InteriorLocation
- MultiAssetFilter -> AssetFilter
- VersionedMultiAsset -> VersionedAsset
- WildMultiAsset -> WildAsset
- VersionedMultiLocation -> VersionedLocation
In order to fix a name conflict, the `Assets` in `xcm-executor` were
renamed to `HoldingAssets`, as they represent assets in holding.
## Removed `Abstract` asset id
It was not being used anywhere and this simplifies the code.
Now assets are just constructed as follows:
```rust
let asset: Asset = (AssetId(Location::new(1, Here)), 100u128).into();
```
No need for specifying `Concrete` anymore.
## Outcome is now a named fields struct
Instead of
```rust
pub enum Outcome {
Complete(Weight),
Incomplete(Weight, Error),
Error(Error),
}
```
we now have
```rust
pub enum Outcome {
Complete { used: Weight },
Incomplete { used: Weight, error: Error },
Error { error: Error },
}
```
## Added Reanchorable trait
Now both locations and assets implement this trait, making it easier to
reanchor both.
## New syntax for building locations and junctions
Now junctions are built using the following methods:
```rust
let location = Location {
parents: 1,
interior: [Parachain(1000), PalletInstance(50), GeneralIndex(1984)].into()
};
```
or
```rust
let location = Location::new(1, [Parachain(1000), PalletInstance(50), GeneralIndex(1984)]);
```
And they are matched like so:
```rust
match location.unpack() {
(1, [Parachain(id)]) => ...
(0, Here) => ...,
(1, [_]) => ...,
}
```
This syntax is mandatory in v4, and has been also implemented for v2 and
v3 for easier migration.
This was needed to make all sizes smaller.
# TODO
- [x] Scaffold v4
- [x] Port github.com/paritytech/polkadot/pull/7236
- [x] Remove `Multi` prefix
- [x] Remove `Abstract` asset id
---------
Co-authored-by: command-bot <>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
319 lines
10 KiB
Rust
319 lines
10 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Adapters to work with [`frame_support::traits::fungibles`] through XCM.
|
|
|
|
use frame_support::traits::{Contains, Get};
|
|
use sp_runtime::traits::MaybeEquivalence;
|
|
use sp_std::{marker::PhantomData, prelude::*, result};
|
|
use xcm::latest::prelude::*;
|
|
use xcm_executor::traits::{Error as MatchError, MatchesFungibles, MatchesNonFungibles};
|
|
|
|
/// Converter struct implementing `AssetIdConversion` converting a numeric asset ID (must be
|
|
/// `TryFrom/TryInto<u128>`) into a `GeneralIndex` junction, prefixed by some `Location` value.
|
|
/// The `Location` value will typically be a `PalletInstance` junction.
|
|
pub struct AsPrefixedGeneralIndex<Prefix, AssetId, ConvertAssetId, L = Location>(
|
|
PhantomData<(Prefix, AssetId, ConvertAssetId, L)>,
|
|
);
|
|
impl<
|
|
Prefix: Get<L>,
|
|
AssetId: Clone,
|
|
ConvertAssetId: MaybeEquivalence<u128, AssetId>,
|
|
L: TryInto<Location> + TryFrom<Location> + Clone,
|
|
> MaybeEquivalence<L, AssetId> for AsPrefixedGeneralIndex<Prefix, AssetId, ConvertAssetId, L>
|
|
{
|
|
fn convert(id: &L) -> Option<AssetId> {
|
|
let prefix = Prefix::get();
|
|
let latest_prefix: Location = prefix.try_into().ok()?;
|
|
let latest_id: Location = (*id).clone().try_into().ok()?;
|
|
if latest_prefix.parent_count() != latest_id.parent_count() ||
|
|
latest_prefix
|
|
.interior()
|
|
.iter()
|
|
.enumerate()
|
|
.any(|(index, junction)| latest_id.interior().at(index) != Some(junction))
|
|
{
|
|
return None
|
|
}
|
|
match latest_id.interior().at(latest_prefix.interior().len()) {
|
|
Some(Junction::GeneralIndex(id)) => ConvertAssetId::convert(&id),
|
|
_ => None,
|
|
}
|
|
}
|
|
fn convert_back(what: &AssetId) -> Option<L> {
|
|
let location = Prefix::get();
|
|
let mut latest_location: Location = location.try_into().ok()?;
|
|
let id = ConvertAssetId::convert_back(what)?;
|
|
latest_location.push_interior(Junction::GeneralIndex(id)).ok()?;
|
|
latest_location.try_into().ok()
|
|
}
|
|
}
|
|
|
|
pub struct ConvertedConcreteId<AssetId, Balance, ConvertAssetId, ConvertOther>(
|
|
PhantomData<(AssetId, Balance, ConvertAssetId, ConvertOther)>,
|
|
);
|
|
impl<
|
|
AssetId: Clone,
|
|
Balance: Clone,
|
|
ConvertAssetId: MaybeEquivalence<Location, AssetId>,
|
|
ConvertBalance: MaybeEquivalence<u128, Balance>,
|
|
> MatchesFungibles<AssetId, Balance>
|
|
for ConvertedConcreteId<AssetId, Balance, ConvertAssetId, ConvertBalance>
|
|
{
|
|
fn matches_fungibles(a: &Asset) -> result::Result<(AssetId, Balance), MatchError> {
|
|
let (amount, id) = match (&a.fun, &a.id) {
|
|
(Fungible(ref amount), AssetId(ref id)) => (amount, id),
|
|
_ => return Err(MatchError::AssetNotHandled),
|
|
};
|
|
let what = ConvertAssetId::convert(id).ok_or(MatchError::AssetIdConversionFailed)?;
|
|
let amount =
|
|
ConvertBalance::convert(amount).ok_or(MatchError::AmountToBalanceConversionFailed)?;
|
|
Ok((what, amount))
|
|
}
|
|
}
|
|
impl<
|
|
ClassId: Clone,
|
|
InstanceId: Clone,
|
|
ConvertClassId: MaybeEquivalence<Location, ClassId>,
|
|
ConvertInstanceId: MaybeEquivalence<AssetInstance, InstanceId>,
|
|
> MatchesNonFungibles<ClassId, InstanceId>
|
|
for ConvertedConcreteId<ClassId, InstanceId, ConvertClassId, ConvertInstanceId>
|
|
{
|
|
fn matches_nonfungibles(a: &Asset) -> result::Result<(ClassId, InstanceId), MatchError> {
|
|
let (instance, class) = match (&a.fun, &a.id) {
|
|
(NonFungible(ref instance), AssetId(ref class)) => (instance, class),
|
|
_ => return Err(MatchError::AssetNotHandled),
|
|
};
|
|
let what = ConvertClassId::convert(class).ok_or(MatchError::AssetIdConversionFailed)?;
|
|
let instance =
|
|
ConvertInstanceId::convert(instance).ok_or(MatchError::InstanceConversionFailed)?;
|
|
Ok((what, instance))
|
|
}
|
|
}
|
|
|
|
#[deprecated = "Use `ConvertedConcreteId` instead"]
|
|
pub type ConvertedConcreteAssetId<A, B, C, O> = ConvertedConcreteId<A, B, C, O>;
|
|
|
|
pub struct V4V3LocationConverter;
|
|
impl MaybeEquivalence<xcm::v4::Location, xcm::v3::Location> for V4V3LocationConverter {
|
|
fn convert(old: &xcm::v4::Location) -> Option<xcm::v3::Location> {
|
|
(*old).clone().try_into().ok()
|
|
}
|
|
|
|
fn convert_back(new: &xcm::v3::Location) -> Option<xcm::v4::Location> {
|
|
(*new).try_into().ok()
|
|
}
|
|
}
|
|
|
|
pub struct MatchedConvertedConcreteId<AssetId, Balance, MatchAssetId, ConvertAssetId, ConvertOther>(
|
|
PhantomData<(AssetId, Balance, MatchAssetId, ConvertAssetId, ConvertOther)>,
|
|
);
|
|
impl<
|
|
AssetId: Clone,
|
|
Balance: Clone,
|
|
MatchAssetId: Contains<Location>,
|
|
ConvertAssetId: MaybeEquivalence<Location, AssetId>,
|
|
ConvertBalance: MaybeEquivalence<u128, Balance>,
|
|
> MatchesFungibles<AssetId, Balance>
|
|
for MatchedConvertedConcreteId<AssetId, Balance, MatchAssetId, ConvertAssetId, ConvertBalance>
|
|
{
|
|
fn matches_fungibles(a: &Asset) -> result::Result<(AssetId, Balance), MatchError> {
|
|
let (amount, id) = match (&a.fun, &a.id) {
|
|
(Fungible(ref amount), AssetId(ref id)) if MatchAssetId::contains(id) => (amount, id),
|
|
_ => return Err(MatchError::AssetNotHandled),
|
|
};
|
|
let what = ConvertAssetId::convert(id).ok_or(MatchError::AssetIdConversionFailed)?;
|
|
let amount =
|
|
ConvertBalance::convert(amount).ok_or(MatchError::AmountToBalanceConversionFailed)?;
|
|
Ok((what, amount))
|
|
}
|
|
}
|
|
impl<
|
|
ClassId: Clone,
|
|
InstanceId: Clone,
|
|
MatchClassId: Contains<Location>,
|
|
ConvertClassId: MaybeEquivalence<Location, ClassId>,
|
|
ConvertInstanceId: MaybeEquivalence<AssetInstance, InstanceId>,
|
|
> MatchesNonFungibles<ClassId, InstanceId>
|
|
for MatchedConvertedConcreteId<ClassId, InstanceId, MatchClassId, ConvertClassId, ConvertInstanceId>
|
|
{
|
|
fn matches_nonfungibles(a: &Asset) -> result::Result<(ClassId, InstanceId), MatchError> {
|
|
let (instance, class) = match (&a.fun, &a.id) {
|
|
(NonFungible(ref instance), AssetId(ref class)) if MatchClassId::contains(class) =>
|
|
(instance, class),
|
|
_ => return Err(MatchError::AssetNotHandled),
|
|
};
|
|
let what = ConvertClassId::convert(class).ok_or(MatchError::AssetIdConversionFailed)?;
|
|
let instance =
|
|
ConvertInstanceId::convert(instance).ok_or(MatchError::InstanceConversionFailed)?;
|
|
Ok((what, instance))
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
use xcm_executor::traits::JustTry;
|
|
|
|
struct OnlyParentZero;
|
|
impl Contains<Location> for OnlyParentZero {
|
|
fn contains(a: &Location) -> bool {
|
|
match a {
|
|
Location { parents: 0, .. } => true,
|
|
_ => false,
|
|
}
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn matched_converted_concrete_id_for_fungibles_works() {
|
|
type AssetIdForTrustBackedAssets = u32;
|
|
type Balance = u128;
|
|
frame_support::parameter_types! {
|
|
pub TrustBackedAssetsPalletLocation: Location = PalletInstance(50).into();
|
|
}
|
|
|
|
// ConvertedConcreteId cfg
|
|
type Converter = MatchedConvertedConcreteId<
|
|
AssetIdForTrustBackedAssets,
|
|
Balance,
|
|
OnlyParentZero,
|
|
AsPrefixedGeneralIndex<
|
|
TrustBackedAssetsPalletLocation,
|
|
AssetIdForTrustBackedAssets,
|
|
JustTry,
|
|
>,
|
|
JustTry,
|
|
>;
|
|
assert_eq!(
|
|
TrustBackedAssetsPalletLocation::get(),
|
|
Location { parents: 0, interior: [PalletInstance(50)].into() }
|
|
);
|
|
|
|
// err - does not match
|
|
assert_eq!(
|
|
Converter::matches_fungibles(&Asset {
|
|
id: AssetId(Location::new(1, [PalletInstance(50), GeneralIndex(1)])),
|
|
fun: Fungible(12345),
|
|
}),
|
|
Err(MatchError::AssetNotHandled)
|
|
);
|
|
|
|
// err - matches, but convert fails
|
|
assert_eq!(
|
|
Converter::matches_fungibles(&Asset {
|
|
id: AssetId(Location::new(
|
|
0,
|
|
[PalletInstance(50), GeneralKey { length: 1, data: [1; 32] }]
|
|
)),
|
|
fun: Fungible(12345),
|
|
}),
|
|
Err(MatchError::AssetIdConversionFailed)
|
|
);
|
|
|
|
// err - matches, but NonFungible
|
|
assert_eq!(
|
|
Converter::matches_fungibles(&Asset {
|
|
id: AssetId(Location::new(0, [PalletInstance(50), GeneralIndex(1)])),
|
|
fun: NonFungible(Index(54321)),
|
|
}),
|
|
Err(MatchError::AssetNotHandled)
|
|
);
|
|
|
|
// ok
|
|
assert_eq!(
|
|
Converter::matches_fungibles(&Asset {
|
|
id: AssetId(Location::new(0, [PalletInstance(50), GeneralIndex(1)])),
|
|
fun: Fungible(12345),
|
|
}),
|
|
Ok((1, 12345))
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn matched_converted_concrete_id_for_nonfungibles_works() {
|
|
type ClassId = u32;
|
|
type ClassInstanceId = u64;
|
|
frame_support::parameter_types! {
|
|
pub TrustBackedAssetsPalletLocation: Location = PalletInstance(50).into();
|
|
}
|
|
|
|
// ConvertedConcreteId cfg
|
|
struct ClassInstanceIdConverter;
|
|
impl MaybeEquivalence<AssetInstance, ClassInstanceId> for ClassInstanceIdConverter {
|
|
fn convert(value: &AssetInstance) -> Option<ClassInstanceId> {
|
|
(*value).try_into().ok()
|
|
}
|
|
|
|
fn convert_back(value: &ClassInstanceId) -> Option<AssetInstance> {
|
|
Some(AssetInstance::from(*value))
|
|
}
|
|
}
|
|
|
|
type Converter = MatchedConvertedConcreteId<
|
|
ClassId,
|
|
ClassInstanceId,
|
|
OnlyParentZero,
|
|
AsPrefixedGeneralIndex<TrustBackedAssetsPalletLocation, ClassId, JustTry>,
|
|
ClassInstanceIdConverter,
|
|
>;
|
|
assert_eq!(
|
|
TrustBackedAssetsPalletLocation::get(),
|
|
Location { parents: 0, interior: [PalletInstance(50)].into() }
|
|
);
|
|
|
|
// err - does not match
|
|
assert_eq!(
|
|
Converter::matches_nonfungibles(&Asset {
|
|
id: AssetId(Location::new(1, [PalletInstance(50), GeneralIndex(1)])),
|
|
fun: NonFungible(Index(54321)),
|
|
}),
|
|
Err(MatchError::AssetNotHandled)
|
|
);
|
|
|
|
// err - matches, but convert fails
|
|
assert_eq!(
|
|
Converter::matches_nonfungibles(&Asset {
|
|
id: AssetId(Location::new(
|
|
0,
|
|
[PalletInstance(50), GeneralKey { length: 1, data: [1; 32] }]
|
|
)),
|
|
fun: NonFungible(Index(54321)),
|
|
}),
|
|
Err(MatchError::AssetIdConversionFailed)
|
|
);
|
|
|
|
// err - matches, but Fungible vs NonFungible
|
|
assert_eq!(
|
|
Converter::matches_nonfungibles(&Asset {
|
|
id: AssetId(Location::new(0, [PalletInstance(50), GeneralIndex(1)])),
|
|
fun: Fungible(12345),
|
|
}),
|
|
Err(MatchError::AssetNotHandled)
|
|
);
|
|
|
|
// ok
|
|
assert_eq!(
|
|
Converter::matches_nonfungibles(&Asset {
|
|
id: AssetId(Location::new(0, [PalletInstance(50), GeneralIndex(1)])),
|
|
fun: NonFungible(Index(54321)),
|
|
}),
|
|
Ok((1, 54321))
|
|
);
|
|
}
|
|
}
|