mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-17 04:15:42 +00:00
002d9260f9
**Update:** Pushed additional changes based on the review comments. **This pull request fixes various spelling mistakes in this repository.** Most of the changes are contained in the first **3** commits: - `Fix spelling mistakes in comments and docs` - `Fix spelling mistakes in test names` - `Fix spelling mistakes in error messages, panic messages, logs and tracing` Other source code spelling mistakes are separated into individual commits for easier reviewing: - `Fix the spelling of 'authority'` - `Fix the spelling of 'REASONABLE_HEADERS_IN_JUSTIFICATION_ANCESTRY'` - `Fix the spelling of 'prev_enqueud_messages'` - `Fix the spelling of 'endpoint'` - `Fix the spelling of 'children'` - `Fix the spelling of 'PenpalSiblingSovereignAccount'` - `Fix the spelling of 'PenpalSudoAccount'` - `Fix the spelling of 'insufficient'` - `Fix the spelling of 'PalletXcmExtrinsicsBenchmark'` - `Fix the spelling of 'subtracted'` - `Fix the spelling of 'CandidatePendingAvailability'` - `Fix the spelling of 'exclusive'` - `Fix the spelling of 'until'` - `Fix the spelling of 'discriminator'` - `Fix the spelling of 'nonexistent'` - `Fix the spelling of 'subsystem'` - `Fix the spelling of 'indices'` - `Fix the spelling of 'committed'` - `Fix the spelling of 'topology'` - `Fix the spelling of 'response'` - `Fix the spelling of 'beneficiary'` - `Fix the spelling of 'formatted'` - `Fix the spelling of 'UNKNOWN_PROOF_REQUEST'` - `Fix the spelling of 'succeeded'` - `Fix the spelling of 'reopened'` - `Fix the spelling of 'proposer'` - `Fix the spelling of 'InstantiationNonce'` - `Fix the spelling of 'depositor'` - `Fix the spelling of 'expiration'` - `Fix the spelling of 'phantom'` - `Fix the spelling of 'AggregatedKeyValue'` - `Fix the spelling of 'randomness'` - `Fix the spelling of 'defendant'` - `Fix the spelling of 'AquaticMammal'` - `Fix the spelling of 'transactions'` - `Fix the spelling of 'PassingTracingSubscriber'` - `Fix the spelling of 'TxSignaturePayload'` - `Fix the spelling of 'versioning'` - `Fix the spelling of 'descendant'` - `Fix the spelling of 'overridden'` - `Fix the spelling of 'network'` Let me know if this structure is adequate. **Note:** The usage of the words `Merkle`, `Merkelize`, `Merklization`, `Merkelization`, `Merkleization`, is somewhat inconsistent but I left it as it is. ~~**Note:** In some places the term `Receival` is used to refer to message reception, IMO `Reception` is the correct word here, but I left it as it is.~~ ~~**Note:** In some places the term `Overlayed` is used instead of the more acceptable version `Overlaid` but I also left it as it is.~~ ~~**Note:** In some places the term `Applyable` is used instead of the correct version `Applicable` but I also left it as it is.~~ **Note:** Some usage of British vs American english e.g. `judgement` vs `judgment`, `initialise` vs `initialize`, `optimise` vs `optimize` etc. are both present in different places, but I suppose that's understandable given the number of contributors. ~~**Note:** There is a spelling mistake in `.github/CODEOWNERS` but it triggers errors in CI when I make changes to it, so I left it as it is.~~
196 lines
5.9 KiB
Rust
196 lines
5.9 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
//! Tests regarding the reentrancy functionality.
|
|
|
|
use super::*;
|
|
use frame_support::traits::tokens::{
|
|
Fortitude::Force,
|
|
Precision::BestEffort,
|
|
Preservation::{Expendable, Protect},
|
|
};
|
|
use fungible::Balanced;
|
|
|
|
#[test]
|
|
fn transfer_dust_removal_tst1_should_work() {
|
|
ExtBuilder::default()
|
|
.existential_deposit(100)
|
|
.dust_trap(1)
|
|
.build_and_execute_with(|| {
|
|
// Verification of reentrancy in dust removal
|
|
assert_ok!(Balances::force_set_balance(RawOrigin::Root.into(), 1, 1000));
|
|
assert_ok!(Balances::force_set_balance(RawOrigin::Root.into(), 2, 500));
|
|
|
|
// In this transaction, account 2 free balance
|
|
// drops below existential balance
|
|
// and dust balance is removed from account 2
|
|
assert_ok!(Balances::transfer_allow_death(RawOrigin::Signed(2).into(), 3, 450));
|
|
|
|
// As expected dust balance is removed.
|
|
assert_eq!(Balances::free_balance(&2), 0);
|
|
|
|
// As expected beneficiary account 3
|
|
// received the transferred fund.
|
|
assert_eq!(Balances::free_balance(&3), 450);
|
|
|
|
// Dust balance is deposited to account 1
|
|
// during the process of dust removal.
|
|
assert_eq!(Balances::free_balance(&1), 1050);
|
|
|
|
// Verify the events
|
|
assert_eq!(System::events().len(), 12);
|
|
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::Transfer {
|
|
from: 2,
|
|
to: 3,
|
|
amount: 450,
|
|
}));
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::DustLost {
|
|
account: 2,
|
|
amount: 50,
|
|
}));
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::Deposit {
|
|
who: 1,
|
|
amount: 50,
|
|
}));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn transfer_dust_removal_tst2_should_work() {
|
|
ExtBuilder::default()
|
|
.existential_deposit(100)
|
|
.dust_trap(1)
|
|
.build_and_execute_with(|| {
|
|
// Verification of reentrancy in dust removal
|
|
assert_ok!(Balances::force_set_balance(RawOrigin::Root.into(), 1, 1000));
|
|
assert_ok!(Balances::force_set_balance(RawOrigin::Root.into(), 2, 500));
|
|
|
|
// In this transaction, account 2 free balance
|
|
// drops below existential balance
|
|
// and dust balance is removed from account 2
|
|
assert_ok!(Balances::transfer_allow_death(RawOrigin::Signed(2).into(), 1, 450));
|
|
|
|
// As expected dust balance is removed.
|
|
assert_eq!(Balances::free_balance(&2), 0);
|
|
|
|
// Dust balance is deposited to account 1
|
|
// during the process of dust removal.
|
|
assert_eq!(Balances::free_balance(&1), 1500);
|
|
|
|
// Verify the events
|
|
assert_eq!(System::events().len(), 10);
|
|
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::Transfer {
|
|
from: 2,
|
|
to: 1,
|
|
amount: 450,
|
|
}));
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::DustLost {
|
|
account: 2,
|
|
amount: 50,
|
|
}));
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::Deposit {
|
|
who: 1,
|
|
amount: 50,
|
|
}));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn repatriating_reserved_balance_dust_removal_should_work() {
|
|
ExtBuilder::default()
|
|
.existential_deposit(100)
|
|
.dust_trap(1)
|
|
.build_and_execute_with(|| {
|
|
// Verification of reentrancy in dust removal
|
|
assert_ok!(Balances::force_set_balance(RawOrigin::Root.into(), 1, 1000));
|
|
assert_ok!(Balances::force_set_balance(RawOrigin::Root.into(), 2, 500));
|
|
|
|
// Reserve a value on account 2,
|
|
// Such that free balance is lower than
|
|
// Existential deposit.
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), 1, 450));
|
|
|
|
// Since free balance of account 2 is lower than
|
|
// existential deposit, dust amount is
|
|
// removed from the account 2
|
|
assert_eq!(Balances::reserved_balance(2), 0);
|
|
assert_eq!(Balances::free_balance(2), 0);
|
|
|
|
// account 1 is credited with reserved amount
|
|
// together with dust balance during dust
|
|
// removal.
|
|
assert_eq!(Balances::reserved_balance(1), 0);
|
|
assert_eq!(Balances::free_balance(1), 1500);
|
|
|
|
// Verify the events
|
|
assert_eq!(System::events().len(), 10);
|
|
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::Transfer {
|
|
from: 2,
|
|
to: 1,
|
|
amount: 450,
|
|
}));
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::DustLost {
|
|
account: 2,
|
|
amount: 50,
|
|
}));
|
|
System::assert_has_event(RuntimeEvent::Balances(crate::Event::Deposit {
|
|
who: 1,
|
|
amount: 50,
|
|
}));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn emit_events_with_no_existential_deposit_suicide_with_dust() {
|
|
ExtBuilder::default().existential_deposit(2).build_and_execute_with(|| {
|
|
assert_ok!(Balances::force_set_balance(RawOrigin::Root.into(), 1, 100));
|
|
|
|
assert_eq!(
|
|
events(),
|
|
[
|
|
RuntimeEvent::System(system::Event::NewAccount { account: 1 }),
|
|
RuntimeEvent::Balances(crate::Event::Endowed { account: 1, free_balance: 100 }),
|
|
RuntimeEvent::Balances(crate::Event::BalanceSet { who: 1, free: 100 }),
|
|
]
|
|
);
|
|
|
|
let res = Balances::withdraw(&1, 98, BestEffort, Protect, Force);
|
|
assert_eq!(res.unwrap().peek(), 98);
|
|
|
|
// no events
|
|
assert_eq!(
|
|
events(),
|
|
[RuntimeEvent::Balances(crate::Event::Withdraw { who: 1, amount: 98 })]
|
|
);
|
|
|
|
let res = Balances::withdraw(&1, 1, BestEffort, Expendable, Force);
|
|
assert_eq!(res.unwrap().peek(), 1);
|
|
|
|
assert_eq!(
|
|
events(),
|
|
[
|
|
RuntimeEvent::System(system::Event::KilledAccount { account: 1 }),
|
|
RuntimeEvent::Balances(crate::Event::DustLost { account: 1, amount: 1 }),
|
|
RuntimeEvent::Balances(crate::Event::Withdraw { who: 1, amount: 1 })
|
|
]
|
|
);
|
|
});
|
|
}
|