mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-24 06:41:06 +00:00
a98010a889
* make pool roles optional * undo lock file changes? * add migration * add the ability for pools to chill themselves * boilerplate of tests * somewhat stable, but I think I found another bug as well * Fix it all * Add more more sophisticated test + capture one more bug. * Update frame/staking/src/lib.rs * reduce the diff a little bit * add some test for the slashing bug * cleanup * fix lock file? * Fix * fmt * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/mock.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix build * fix some fishy tests.. * add one last integrity check for MinCreateBond * remove bad assertion -- needs to be dealt with later * nits * fix tests and add benchmarks for chill * remove stuff * fix benchmarks * cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs * remove defensive * first working version * bring back all tests * ALL new tests work now * cleanup * make sure benchmarks and all work * cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs * round of self-review, make arithmetic safe * fix warn * add migration code * Fix doc * add precision notes * make arithmetic fallible * fix node runtime * a lot of precision tests and notes and stuff * document MaxPOintsToBalance better * :round of self-review * fmt * fix some comments * new logic, some broken tests * Check if after unbonding remaining balance is more or equal to MinJoinBond and is not zero * incorporate nikos' work * make it work again * merge * Fix all tests * fix all tests * some updates * Add tests * remove erroneoysly placed comment * Try to make lint pass * Try to make lint pass * revamp the tests for unbond * fix docs * Fix proportional slashing logic * Update frame/nomination-pools/src/tests.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/tests.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * track poinst in migration * fix * fmt * fix migration * remove event read * Apply suggestions from code review * Update frame/nomination-pools/src/lib.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * remove log * Update frame/staking/src/lib.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Update frame/nomination-pools/src/lib.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Update frame/nomination-pools/src/lib.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * update * fmt * fmt * add one last test * fmrt * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/tests.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: wirednkod <wirednkod@gmail.com>
379 lines
10 KiB
Rust
379 lines
10 KiB
Rust
use super::*;
|
|
use crate::{self as pools};
|
|
use frame_support::{assert_ok, parameter_types, PalletId};
|
|
use frame_system::RawOrigin;
|
|
use sp_runtime::FixedU128;
|
|
|
|
pub type AccountId = u128;
|
|
pub type Balance = u128;
|
|
pub type RewardCounter = FixedU128;
|
|
// This sneaky little hack allows us to write code exactly as we would do in the pallet in the tests
|
|
// as well, e.g. `StorageItem::<T>::get()`.
|
|
pub type T = Runtime;
|
|
|
|
// Ext builder creates a pool with id 1.
|
|
pub fn default_bonded_account() -> AccountId {
|
|
Pools::create_bonded_account(1)
|
|
}
|
|
|
|
// Ext builder creates a pool with id 1.
|
|
pub fn default_reward_account() -> AccountId {
|
|
Pools::create_reward_account(1)
|
|
}
|
|
|
|
parameter_types! {
|
|
pub static MinJoinBondConfig: Balance = 2;
|
|
pub static CurrentEra: EraIndex = 0;
|
|
pub static BondingDuration: EraIndex = 3;
|
|
pub storage BondedBalanceMap: BTreeMap<AccountId, Balance> = Default::default();
|
|
pub storage UnbondingBalanceMap: BTreeMap<AccountId, Balance> = Default::default();
|
|
#[derive(Clone, PartialEq)]
|
|
pub static MaxUnbonding: u32 = 8;
|
|
pub static StakingMinBond: Balance = 10;
|
|
pub storage Nominations: Option<Vec<AccountId>> = None;
|
|
}
|
|
|
|
pub struct StakingMock;
|
|
impl StakingMock {
|
|
pub(crate) fn set_bonded_balance(who: AccountId, bonded: Balance) {
|
|
let mut x = BondedBalanceMap::get();
|
|
x.insert(who, bonded);
|
|
BondedBalanceMap::set(&x)
|
|
}
|
|
}
|
|
|
|
impl sp_staking::StakingInterface for StakingMock {
|
|
type Balance = Balance;
|
|
type AccountId = AccountId;
|
|
|
|
fn minimum_bond() -> Self::Balance {
|
|
StakingMinBond::get()
|
|
}
|
|
|
|
fn current_era() -> EraIndex {
|
|
CurrentEra::get()
|
|
}
|
|
|
|
fn bonding_duration() -> EraIndex {
|
|
BondingDuration::get()
|
|
}
|
|
|
|
fn active_stake(who: &Self::AccountId) -> Option<Self::Balance> {
|
|
BondedBalanceMap::get().get(who).map(|v| *v)
|
|
}
|
|
|
|
fn total_stake(who: &Self::AccountId) -> Option<Self::Balance> {
|
|
match (
|
|
UnbondingBalanceMap::get().get(who).map(|v| *v),
|
|
BondedBalanceMap::get().get(who).map(|v| *v),
|
|
) {
|
|
(None, None) => None,
|
|
(Some(v), None) | (None, Some(v)) => Some(v),
|
|
(Some(a), Some(b)) => Some(a + b),
|
|
}
|
|
}
|
|
|
|
fn bond_extra(who: Self::AccountId, extra: Self::Balance) -> DispatchResult {
|
|
let mut x = BondedBalanceMap::get();
|
|
x.get_mut(&who).map(|v| *v += extra);
|
|
BondedBalanceMap::set(&x);
|
|
Ok(())
|
|
}
|
|
|
|
fn unbond(who: Self::AccountId, amount: Self::Balance) -> DispatchResult {
|
|
let mut x = BondedBalanceMap::get();
|
|
*x.get_mut(&who).unwrap() = x.get_mut(&who).unwrap().saturating_sub(amount);
|
|
BondedBalanceMap::set(&x);
|
|
let mut y = UnbondingBalanceMap::get();
|
|
*y.entry(who).or_insert(Self::Balance::zero()) += amount;
|
|
UnbondingBalanceMap::set(&y);
|
|
Ok(())
|
|
}
|
|
|
|
fn chill(_: Self::AccountId) -> sp_runtime::DispatchResult {
|
|
Ok(())
|
|
}
|
|
|
|
fn withdraw_unbonded(who: Self::AccountId, _: u32) -> Result<bool, DispatchError> {
|
|
// Simulates removing unlocking chunks and only having the bonded balance locked
|
|
let mut x = UnbondingBalanceMap::get();
|
|
x.remove(&who);
|
|
UnbondingBalanceMap::set(&x);
|
|
|
|
Ok(UnbondingBalanceMap::get().is_empty() && BondedBalanceMap::get().is_empty())
|
|
}
|
|
|
|
fn bond(
|
|
stash: Self::AccountId,
|
|
_: Self::AccountId,
|
|
value: Self::Balance,
|
|
_: Self::AccountId,
|
|
) -> DispatchResult {
|
|
StakingMock::set_bonded_balance(stash, value);
|
|
Ok(())
|
|
}
|
|
|
|
fn nominate(_: Self::AccountId, nominations: Vec<Self::AccountId>) -> DispatchResult {
|
|
Nominations::set(&Some(nominations));
|
|
Ok(())
|
|
}
|
|
|
|
#[cfg(feature = "runtime-benchmarks")]
|
|
fn nominations(_: Self::AccountId) -> Option<Vec<Self::AccountId>> {
|
|
Nominations::get()
|
|
}
|
|
}
|
|
|
|
impl frame_system::Config for Runtime {
|
|
type SS58Prefix = ();
|
|
type BaseCallFilter = frame_support::traits::Everything;
|
|
type Origin = Origin;
|
|
type Index = u64;
|
|
type BlockNumber = u64;
|
|
type Call = Call;
|
|
type Hash = sp_core::H256;
|
|
type Hashing = sp_runtime::traits::BlakeTwo256;
|
|
type AccountId = AccountId;
|
|
type Lookup = sp_runtime::traits::IdentityLookup<Self::AccountId>;
|
|
type Header = sp_runtime::testing::Header;
|
|
type Event = Event;
|
|
type BlockHashCount = ();
|
|
type DbWeight = ();
|
|
type BlockLength = ();
|
|
type BlockWeights = ();
|
|
type Version = ();
|
|
type PalletInfo = PalletInfo;
|
|
type AccountData = pallet_balances::AccountData<Balance>;
|
|
type OnNewAccount = ();
|
|
type OnKilledAccount = ();
|
|
type SystemWeightInfo = ();
|
|
type OnSetCode = ();
|
|
type MaxConsumers = frame_support::traits::ConstU32<16>;
|
|
}
|
|
|
|
parameter_types! {
|
|
pub static ExistentialDeposit: Balance = 5;
|
|
}
|
|
|
|
impl pallet_balances::Config for Runtime {
|
|
type MaxLocks = frame_support::traits::ConstU32<1024>;
|
|
type MaxReserves = ();
|
|
type ReserveIdentifier = [u8; 8];
|
|
type Balance = Balance;
|
|
type Event = Event;
|
|
type DustRemoval = ();
|
|
type ExistentialDeposit = ExistentialDeposit;
|
|
type AccountStore = System;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
pub struct BalanceToU256;
|
|
impl Convert<Balance, U256> for BalanceToU256 {
|
|
fn convert(n: Balance) -> U256 {
|
|
n.into()
|
|
}
|
|
}
|
|
|
|
pub struct U256ToBalance;
|
|
impl Convert<U256, Balance> for U256ToBalance {
|
|
fn convert(n: U256) -> Balance {
|
|
n.try_into().unwrap()
|
|
}
|
|
}
|
|
|
|
parameter_types! {
|
|
pub static PostUnbondingPoolsWindow: u32 = 2;
|
|
pub static MaxMetadataLen: u32 = 2;
|
|
pub static CheckLevel: u8 = 255;
|
|
pub const PoolsPalletId: PalletId = PalletId(*b"py/nopls");
|
|
}
|
|
impl pools::Config for Runtime {
|
|
type Event = Event;
|
|
type WeightInfo = ();
|
|
type Currency = Balances;
|
|
type CurrencyBalance = Balance;
|
|
type RewardCounter = RewardCounter;
|
|
type BalanceToU256 = BalanceToU256;
|
|
type U256ToBalance = U256ToBalance;
|
|
type StakingInterface = StakingMock;
|
|
type PostUnbondingPoolsWindow = PostUnbondingPoolsWindow;
|
|
type PalletId = PoolsPalletId;
|
|
type MaxMetadataLen = MaxMetadataLen;
|
|
type MaxUnbonding = MaxUnbonding;
|
|
type MaxPointsToBalance = frame_support::traits::ConstU8<10>;
|
|
}
|
|
|
|
type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Runtime>;
|
|
type Block = frame_system::mocking::MockBlock<Runtime>;
|
|
frame_support::construct_runtime!(
|
|
pub enum Runtime where
|
|
Block = Block,
|
|
NodeBlock = Block,
|
|
UncheckedExtrinsic = UncheckedExtrinsic,
|
|
{
|
|
System: frame_system::{Pallet, Call, Storage, Event<T>, Config},
|
|
Balances: pallet_balances::{Pallet, Call, Storage, Config<T>, Event<T>},
|
|
Pools: pools::{Pallet, Call, Storage, Event<T>},
|
|
}
|
|
);
|
|
|
|
pub struct ExtBuilder {
|
|
members: Vec<(AccountId, Balance)>,
|
|
max_members: Option<u32>,
|
|
max_members_per_pool: Option<u32>,
|
|
}
|
|
|
|
impl Default for ExtBuilder {
|
|
fn default() -> Self {
|
|
Self { members: Default::default(), max_members: Some(4), max_members_per_pool: Some(3) }
|
|
}
|
|
}
|
|
|
|
impl ExtBuilder {
|
|
// Add members to pool 0.
|
|
pub(crate) fn add_members(mut self, members: Vec<(AccountId, Balance)>) -> Self {
|
|
self.members = members;
|
|
self
|
|
}
|
|
|
|
pub(crate) fn ed(self, ed: Balance) -> Self {
|
|
ExistentialDeposit::set(ed);
|
|
self
|
|
}
|
|
|
|
pub(crate) fn min_bond(self, min: Balance) -> Self {
|
|
StakingMinBond::set(min);
|
|
self
|
|
}
|
|
|
|
pub(crate) fn min_join_bond(self, min: Balance) -> Self {
|
|
MinJoinBondConfig::set(min);
|
|
self
|
|
}
|
|
|
|
pub(crate) fn with_check(self, level: u8) -> Self {
|
|
CheckLevel::set(level);
|
|
self
|
|
}
|
|
|
|
pub(crate) fn max_members(mut self, max: Option<u32>) -> Self {
|
|
self.max_members = max;
|
|
self
|
|
}
|
|
|
|
pub(crate) fn max_members_per_pool(mut self, max: Option<u32>) -> Self {
|
|
self.max_members_per_pool = max;
|
|
self
|
|
}
|
|
|
|
pub(crate) fn build(self) -> sp_io::TestExternalities {
|
|
sp_tracing::try_init_simple();
|
|
let mut storage =
|
|
frame_system::GenesisConfig::default().build_storage::<Runtime>().unwrap();
|
|
|
|
let _ = crate::GenesisConfig::<Runtime> {
|
|
min_join_bond: MinJoinBondConfig::get(),
|
|
min_create_bond: 2,
|
|
max_pools: Some(2),
|
|
max_members_per_pool: self.max_members_per_pool,
|
|
max_members: self.max_members,
|
|
}
|
|
.assimilate_storage(&mut storage);
|
|
|
|
let mut ext = sp_io::TestExternalities::from(storage);
|
|
|
|
ext.execute_with(|| {
|
|
// for events to be deposited.
|
|
frame_system::Pallet::<Runtime>::set_block_number(1);
|
|
|
|
// make a pool
|
|
let amount_to_bond = Pools::depositor_min_bond();
|
|
Balances::make_free_balance_be(&10, amount_to_bond * 5);
|
|
assert_ok!(Pools::create(RawOrigin::Signed(10).into(), amount_to_bond, 900, 901, 902));
|
|
|
|
let last_pool = LastPoolId::<Runtime>::get();
|
|
for (account_id, bonded) in self.members {
|
|
Balances::make_free_balance_be(&account_id, bonded * 2);
|
|
assert_ok!(Pools::join(RawOrigin::Signed(account_id).into(), bonded, last_pool));
|
|
}
|
|
});
|
|
|
|
ext
|
|
}
|
|
|
|
pub fn build_and_execute(self, test: impl FnOnce() -> ()) {
|
|
self.build().execute_with(|| {
|
|
test();
|
|
Pools::sanity_checks(CheckLevel::get()).unwrap();
|
|
})
|
|
}
|
|
}
|
|
|
|
pub(crate) fn unsafe_set_state(pool_id: PoolId, state: PoolState) {
|
|
BondedPools::<Runtime>::try_mutate(pool_id, |maybe_bonded_pool| {
|
|
maybe_bonded_pool.as_mut().ok_or(()).map(|bonded_pool| {
|
|
bonded_pool.state = state;
|
|
})
|
|
})
|
|
.unwrap()
|
|
}
|
|
|
|
parameter_types! {
|
|
storage PoolsEvents: u32 = 0;
|
|
storage BalancesEvents: u32 = 0;
|
|
}
|
|
|
|
/// All events of this pallet.
|
|
pub(crate) fn pool_events_since_last_call() -> Vec<super::Event<Runtime>> {
|
|
let events = System::events()
|
|
.into_iter()
|
|
.map(|r| r.event)
|
|
.filter_map(|e| if let Event::Pools(inner) = e { Some(inner) } else { None })
|
|
.collect::<Vec<_>>();
|
|
let already_seen = PoolsEvents::get();
|
|
PoolsEvents::set(&(events.len() as u32));
|
|
events.into_iter().skip(already_seen as usize).collect()
|
|
}
|
|
|
|
/// All events of the `Balances` pallet.
|
|
pub(crate) fn balances_events_since_last_call() -> Vec<pallet_balances::Event<Runtime>> {
|
|
let events = System::events()
|
|
.into_iter()
|
|
.map(|r| r.event)
|
|
.filter_map(|e| if let Event::Balances(inner) = e { Some(inner) } else { None })
|
|
.collect::<Vec<_>>();
|
|
let already_seen = BalancesEvents::get();
|
|
BalancesEvents::set(&(events.len() as u32));
|
|
events.into_iter().skip(already_seen as usize).collect()
|
|
}
|
|
|
|
/// Same as `fully_unbond`, in permissioned setting.
|
|
pub fn fully_unbond_permissioned(member: AccountId) -> DispatchResult {
|
|
let points = PoolMembers::<Runtime>::get(&member)
|
|
.map(|d| d.active_points())
|
|
.unwrap_or_default();
|
|
Pools::unbond(Origin::signed(member), member, points)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
#[test]
|
|
fn u256_to_balance_convert_works() {
|
|
assert_eq!(U256ToBalance::convert(0u32.into()), Zero::zero());
|
|
assert_eq!(U256ToBalance::convert(Balance::max_value().into()), Balance::max_value())
|
|
}
|
|
|
|
#[test]
|
|
#[should_panic]
|
|
fn u256_to_balance_convert_panics_correctly() {
|
|
U256ToBalance::convert(U256::from(Balance::max_value()).saturating_add(1u32.into()));
|
|
}
|
|
|
|
#[test]
|
|
fn balance_to_u256_convert_works() {
|
|
assert_eq!(BalanceToU256::convert(0u32.into()), U256::zero());
|
|
assert_eq!(BalanceToU256::convert(Balance::max_value()), Balance::max_value().into())
|
|
}
|
|
}
|