mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-31 11:01:01 +00:00
3d9439f646
## Problem During the bumping of the `polkadot-fellows` repository to `polkadot-sdk@1.6.0`, I encountered a situation where the benchmarks `teleport_assets` and `reserve_transfer_assets` in AssetHubKusama started to fail. This issue arose due to a decreased ED balance for AssetHubs introduced [here](https://github.com/polkadot-fellows/runtimes/pull/158/files#diff-80668ff8e793b64f36a9a3ec512df5cbca4ad448c157a5d81abda1b15f35f1daR213), and also because of a [missing CI pipeline](https://github.com/polkadot-fellows/runtimes/issues/197) to check the benchmarks, which went unnoticed. These benchmarks expect the `caller` to have enough: 1. balance to transfer (BTT) 2. balance for paying delivery (BFPD). So the initial balance was calculated as `ED * 100`, which seems reasonable: ``` const ED_MULTIPLIER: u32 = 100; let balance = existential_deposit.saturating_mul(ED_MULTIPLIER.into());` ``` The problem arises when the price for delivery is 100 times higher than the existential deposit. In other words, when `ED * 100` does not cover `BTT` + `BFPD`. I check AHR/AHW/AHK/AHP and this problem has only AssetHubKusama ``` ED: 3333333 calculated price to parent delivery: 1031666634 (from xcm logs from the benchmark) --- 3333333 * 100 - BTT(3333333) - BFPD(1031666634) = −701666667 ``` which results in the error; ``` 2024-02-23 09:19:42 Unable to charge fee with error Module(ModuleError { index: 31, error: [17, 0, 0, 0], message: Some("FeesNotMet") }) Error: Input("Benchmark pallet_xcm::reserve_transfer_assets failed: FeesNotMet") ``` ## Solution The benchmarks `teleport_assets` and `reserve_transfer_assets` were fixed by removing `ED * 100` and replacing it with `DeliveryHelper` logic, which calculates the (almost real) price for delivery and sets it along with the existential deposit as the initial balance for the account used in the benchmark. ## TODO - [ ] patch for 1.6 - https://github.com/paritytech/polkadot-sdk/pull/3466 - [ ] patch for 1.7 - https://github.com/paritytech/polkadot-sdk/pull/3465 - [ ] patch for 1.8 - TODO: PR --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
115 lines
4.0 KiB
Rust
115 lines
4.0 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Pallet that serves no other purpose than benchmarking raw messages [`Xcm`].
|
|
|
|
#![cfg_attr(not(feature = "std"), no_std)]
|
|
|
|
use codec::Encode;
|
|
use frame_benchmarking::{account, BenchmarkError};
|
|
use sp_std::prelude::*;
|
|
use xcm::latest::prelude::*;
|
|
use xcm_builder::EnsureDelivery;
|
|
use xcm_executor::{traits::ConvertLocation, Config as XcmConfig};
|
|
|
|
pub mod fungible;
|
|
pub mod generic;
|
|
|
|
#[cfg(test)]
|
|
mod mock;
|
|
|
|
/// A base trait for all individual pallets
|
|
pub trait Config: frame_system::Config {
|
|
/// The XCM configurations.
|
|
///
|
|
/// These might affect the execution of XCM messages, such as defining how the
|
|
/// `TransactAsset` is implemented.
|
|
type XcmConfig: XcmConfig;
|
|
|
|
/// A converter between a location to a sovereign account.
|
|
type AccountIdConverter: ConvertLocation<Self::AccountId>;
|
|
|
|
/// Helper that ensures successful delivery for XCM instructions which need `SendXcm`.
|
|
type DeliveryHelper: EnsureDelivery;
|
|
|
|
/// Does any necessary setup to create a valid destination for XCM messages.
|
|
/// Returns that destination's location to be used in benchmarks.
|
|
fn valid_destination() -> Result<Location, BenchmarkError>;
|
|
|
|
/// Worst case scenario for a holding account in this runtime.
|
|
fn worst_case_holding(depositable_count: u32) -> Assets;
|
|
}
|
|
|
|
const SEED: u32 = 0;
|
|
|
|
/// The XCM executor to use for doing stuff.
|
|
pub type ExecutorOf<T> = xcm_executor::XcmExecutor<<T as Config>::XcmConfig>;
|
|
/// The overarching call type.
|
|
pub type OverArchingCallOf<T> = <T as frame_system::Config>::RuntimeCall;
|
|
/// The asset transactor of our executor
|
|
pub type AssetTransactorOf<T> = <<T as Config>::XcmConfig as XcmConfig>::AssetTransactor;
|
|
/// The call type of executor's config. Should eventually resolve to the same overarching call type.
|
|
pub type XcmCallOf<T> = <<T as Config>::XcmConfig as XcmConfig>::RuntimeCall;
|
|
|
|
pub fn mock_worst_case_holding(depositable_count: u32, max_assets: u32) -> Assets {
|
|
let fungibles_amount: u128 = 100;
|
|
let holding_fungibles = max_assets / 2 - depositable_count;
|
|
let holding_non_fungibles = holding_fungibles;
|
|
(0..holding_fungibles)
|
|
.map(|i| {
|
|
Asset {
|
|
id: AssetId(GeneralIndex(i as u128).into()),
|
|
fun: Fungible(fungibles_amount * i as u128),
|
|
}
|
|
.into()
|
|
})
|
|
.chain(core::iter::once(Asset { id: AssetId(Here.into()), fun: Fungible(u128::MAX) }))
|
|
.chain((0..holding_non_fungibles).map(|i| Asset {
|
|
id: AssetId(GeneralIndex(i as u128).into()),
|
|
fun: NonFungible(asset_instance_from(i)),
|
|
}))
|
|
.collect::<Vec<_>>()
|
|
.into()
|
|
}
|
|
|
|
pub fn asset_instance_from(x: u32) -> AssetInstance {
|
|
let bytes = x.encode();
|
|
let mut instance = [0u8; 4];
|
|
instance.copy_from_slice(&bytes);
|
|
AssetInstance::Array4(instance)
|
|
}
|
|
|
|
pub fn new_executor<T: Config>(origin: Location) -> ExecutorOf<T> {
|
|
ExecutorOf::<T>::new(origin, [0; 32])
|
|
}
|
|
|
|
/// Build a location from an account id.
|
|
fn account_id_junction<T: frame_system::Config>(index: u32) -> Junction {
|
|
let account: T::AccountId = account("account", index, SEED);
|
|
let mut encoded = account.encode();
|
|
encoded.resize(32, 0u8);
|
|
let mut id = [0u8; 32];
|
|
id.copy_from_slice(&encoded);
|
|
Junction::AccountId32 { network: None, id }
|
|
}
|
|
|
|
pub fn account_and_location<T: Config>(index: u32) -> (T::AccountId, Location) {
|
|
let location: Location = account_id_junction::<T>(index).into();
|
|
let account = T::AccountIdConverter::convert_location(&location).unwrap();
|
|
|
|
(account, location)
|
|
}
|