mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-08 18:18:02 +00:00
e16ef0861f
This is a rather big change in jsonrpsee, the major things in this bump are: - Server backpressure (the subscription impls are modified to deal with that) - Allow custom error types / return types (remove jsonrpsee::core::Error and jsonrpee::core::CallError) - Bug fixes (graceful shutdown in particular not used by substrate anyway) - Less dependencies for the clients in particular - Return type requires Clone in method call responses - Moved to tokio channels - Async subscription API (not used in this PR) Major changes in this PR: - The subscriptions are now bounded and if subscription can't keep up with the server it is dropped - CLI: add parameter to configure the jsonrpc server bounded message buffer (default is 64) - Add our own subscription helper to deal with the unbounded streams in substrate The most important things in this PR to review is the added helpers functions in `substrate/client/rpc/src/utils.rs` and the rest is pretty much chore. Regarding the "bounded buffer limit" it may cause the server to handle the JSON-RPC calls slower than before. The message size limit is bounded by "--rpc-response-size" thus "by default 10MB * 64 = 640MB" but the subscription message size is not covered by this limit and could be capped as well. Hopefully the last release prior to 1.0, sorry in advance for a big PR Previous attempt: https://github.com/paritytech/substrate/pull/13992 Resolves https://github.com/paritytech/polkadot-sdk/issues/748, resolves https://github.com/paritytech/polkadot-sdk/issues/627
114 lines
3.2 KiB
Rust
114 lines
3.2 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
//! Substrate JSON-RPC interface v2.
|
|
//!
|
|
//! Specification [document](https://paritytech.github.io/json-rpc-interface-spec/).
|
|
|
|
#![warn(missing_docs)]
|
|
#![deny(unused_crate_dependencies)]
|
|
|
|
use serde::{Deserialize, Serialize};
|
|
use sp_core::hexdisplay::{AsBytesRef, HexDisplay};
|
|
|
|
mod common;
|
|
|
|
pub mod archive;
|
|
pub mod chain_head;
|
|
pub mod chain_spec;
|
|
pub mod transaction;
|
|
|
|
/// Task executor that is being used by RPC subscriptions.
|
|
pub type SubscriptionTaskExecutor = std::sync::Arc<dyn sp_core::traits::SpawnNamed>;
|
|
|
|
/// The result of an RPC method.
|
|
#[derive(Clone, Debug, Deserialize, Serialize, PartialEq)]
|
|
#[serde(untagged)]
|
|
pub enum MethodResult {
|
|
/// Method generated a result.
|
|
Ok(MethodResultOk),
|
|
/// Method encountered an error.
|
|
Err(MethodResultErr),
|
|
}
|
|
|
|
impl MethodResult {
|
|
/// Constructs a successful result.
|
|
pub fn ok(result: impl Into<String>) -> MethodResult {
|
|
MethodResult::Ok(MethodResultOk { success: true, result: result.into() })
|
|
}
|
|
|
|
/// Constructs an error result.
|
|
pub fn err(error: impl Into<String>) -> MethodResult {
|
|
MethodResult::Err(MethodResultErr { success: false, error: error.into() })
|
|
}
|
|
}
|
|
|
|
/// The successful result of an RPC method.
|
|
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
|
#[serde(rename_all = "camelCase")]
|
|
pub struct MethodResultOk {
|
|
/// Method was successful.
|
|
success: bool,
|
|
/// The result of the method.
|
|
pub result: String,
|
|
}
|
|
|
|
/// The error result of an RPC method.
|
|
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
|
#[serde(rename_all = "camelCase")]
|
|
pub struct MethodResultErr {
|
|
/// Method encountered an error.
|
|
success: bool,
|
|
/// The error of the method.
|
|
pub error: String,
|
|
}
|
|
|
|
/// Util function to encode a value as a hex string
|
|
pub fn hex_string<Data: AsBytesRef>(data: &Data) -> String {
|
|
format!("0x{:?}", HexDisplay::from(data))
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn method_result_ok() {
|
|
let ok = MethodResult::ok("hello");
|
|
|
|
let ser = serde_json::to_string(&ok).unwrap();
|
|
let exp = r#"{"success":true,"result":"hello"}"#;
|
|
assert_eq!(ser, exp);
|
|
|
|
let ok_dec: MethodResult = serde_json::from_str(exp).unwrap();
|
|
assert_eq!(ok_dec, ok);
|
|
}
|
|
|
|
#[test]
|
|
fn method_result_error() {
|
|
let ok = MethodResult::err("hello");
|
|
|
|
let ser = serde_json::to_string(&ok).unwrap();
|
|
let exp = r#"{"success":false,"error":"hello"}"#;
|
|
assert_eq!(ser, exp);
|
|
|
|
let ok_dec: MethodResult = serde_json::from_str(exp).unwrap();
|
|
assert_eq!(ok_dec, ok);
|
|
}
|
|
}
|