mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-28 19:07:57 +00:00
62d551a063
* client/network/req-resp: Add unit test for request id collision * client/network/req-resp: Prevent request id collision `RequestId` is a monotonically increasing integer, starting at `1`. A `RequestId` is unique for a single `RequestResponse` behaviour, but not across multiple `RequestResponse` behaviours. Thus when handling `RequestId` in the context of multiple `RequestResponse` behaviours, one needs to couple the protocol name with the `RequestId` to get a unique request identifier. This commit ensures that pending requests (`pending_requests`) and pending responses (`pending_response_arrival_time`) are tracked both by their protocol name and `RequestId`. * client/network/req-resp: Remove unused import * client/network/req-resp: Introduce ProtocolRequestId struct * client/network/req-resp: Update test doc comment Treat `RequestId` as an opaque type. * client/network/req-resp: Improve expect proof
1156 lines
36 KiB
Rust
1156 lines
36 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) 2019-2021 Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
//! Collection of request-response protocols.
|
|
//!
|
|
//! The [`RequestResponse`] struct defined in this module provides support for zero or more
|
|
//! so-called "request-response" protocols.
|
|
//!
|
|
//! A request-response protocol works in the following way:
|
|
//!
|
|
//! - For every emitted request, a new substream is open and the protocol is negotiated. If the
|
|
//! remote supports the protocol, the size of the request is sent as a LEB128 number, followed
|
|
//! with the request itself. The remote then sends the size of the response as a LEB128 number,
|
|
//! followed with the response.
|
|
//!
|
|
//! - Requests have a certain time limit before they time out. This time includes the time it
|
|
//! takes to send/receive the request and response.
|
|
//!
|
|
//! - If provided, a ["requests processing"](ProtocolConfig::inbound_queue) channel
|
|
//! is used to handle incoming requests.
|
|
//!
|
|
|
|
use futures::{channel::{mpsc, oneshot}, prelude::*};
|
|
use libp2p::{
|
|
core::{
|
|
connection::{ConnectionId, ListenerId},
|
|
ConnectedPoint, Multiaddr, PeerId,
|
|
},
|
|
request_response::{
|
|
RequestResponse, RequestResponseCodec, RequestResponseConfig, RequestResponseEvent,
|
|
RequestResponseMessage, ResponseChannel, ProtocolSupport
|
|
},
|
|
swarm::{
|
|
protocols_handler::multi::MultiHandler, NetworkBehaviour, NetworkBehaviourAction,
|
|
PollParameters, ProtocolsHandler,
|
|
},
|
|
};
|
|
use std::{
|
|
borrow::Cow, collections::{hash_map::Entry, HashMap}, convert::TryFrom as _, io, iter,
|
|
pin::Pin, task::{Context, Poll}, time::Duration,
|
|
};
|
|
use wasm_timer::Instant;
|
|
|
|
pub use libp2p::request_response::{InboundFailure, OutboundFailure, RequestId};
|
|
|
|
/// Configuration for a single request-response protocol.
|
|
#[derive(Debug, Clone)]
|
|
pub struct ProtocolConfig {
|
|
/// Name of the protocol on the wire. Should be something like `/foo/bar`.
|
|
pub name: Cow<'static, str>,
|
|
|
|
/// Maximum allowed size, in bytes, of a request.
|
|
///
|
|
/// Any request larger than this value will be declined as a way to avoid allocating too
|
|
/// much memory for it.
|
|
pub max_request_size: u64,
|
|
|
|
/// Maximum allowed size, in bytes, of a response.
|
|
///
|
|
/// Any response larger than this value will be declined as a way to avoid allocating too
|
|
/// much memory for it.
|
|
pub max_response_size: u64,
|
|
|
|
/// Duration after which emitted requests are considered timed out.
|
|
///
|
|
/// If you expect the response to come back quickly, you should set this to a smaller duration.
|
|
pub request_timeout: Duration,
|
|
|
|
/// Channel on which the networking service will send incoming requests.
|
|
///
|
|
/// Every time a peer sends a request to the local node using this protocol, the networking
|
|
/// service will push an element on this channel. The receiving side of this channel then has
|
|
/// to pull this element, process the request, and send back the response to send back to the
|
|
/// peer.
|
|
///
|
|
/// The size of the channel has to be carefully chosen. If the channel is full, the networking
|
|
/// service will discard the incoming request send back an error to the peer. Consequently,
|
|
/// the channel being full is an indicator that the node is overloaded.
|
|
///
|
|
/// You can typically set the size of the channel to `T / d`, where `T` is the
|
|
/// `request_timeout` and `d` is the expected average duration of CPU and I/O it takes to
|
|
/// build a response.
|
|
///
|
|
/// Can be `None` if the local node does not support answering incoming requests.
|
|
/// If this is `None`, then the local node will not advertise support for this protocol towards
|
|
/// other peers. If this is `Some` but the channel is closed, then the local node will
|
|
/// advertise support for this protocol, but any incoming request will lead to an error being
|
|
/// sent back.
|
|
pub inbound_queue: Option<mpsc::Sender<IncomingRequest>>,
|
|
}
|
|
|
|
/// A single request received by a peer on a request-response protocol.
|
|
#[derive(Debug)]
|
|
pub struct IncomingRequest {
|
|
/// Who sent the request.
|
|
pub peer: PeerId,
|
|
|
|
/// Request sent by the remote. Will always be smaller than
|
|
/// [`ProtocolConfig::max_request_size`].
|
|
pub payload: Vec<u8>,
|
|
|
|
/// Channel to send back the response to.
|
|
pub pending_response: oneshot::Sender<Vec<u8>>,
|
|
}
|
|
|
|
/// Event generated by the [`RequestResponsesBehaviour`].
|
|
#[derive(Debug)]
|
|
pub enum Event {
|
|
/// A remote sent a request and either we have successfully answered it or an error happened.
|
|
///
|
|
/// This event is generated for statistics purposes.
|
|
InboundRequest {
|
|
/// Peer which has emitted the request.
|
|
peer: PeerId,
|
|
/// Name of the protocol in question.
|
|
protocol: Cow<'static, str>,
|
|
/// Whether handling the request was successful or unsuccessful.
|
|
///
|
|
/// When successful contains the time elapsed between when we received the request and when
|
|
/// we sent back the response. When unsuccessful contains the failure reason.
|
|
result: Result<Duration, ResponseFailure>,
|
|
},
|
|
|
|
/// A request initiated using [`RequestResponsesBehaviour::send_request`] has succeeded or
|
|
/// failed.
|
|
///
|
|
/// This event is generated for statistics purposes.
|
|
RequestFinished {
|
|
/// Peer that we send a request to.
|
|
peer: PeerId,
|
|
/// Name of the protocol in question.
|
|
protocol: Cow<'static, str>,
|
|
/// Duration the request took.
|
|
duration: Duration,
|
|
/// Result of the request.
|
|
result: Result<(), RequestFailure>
|
|
},
|
|
}
|
|
|
|
/// Combination of a protocol name and a request id.
|
|
///
|
|
/// Uniquely identifies an inbound or outbound request among all handled protocols. Note however
|
|
/// that uniqueness is only guaranteed between two inbound and likewise between two outbound
|
|
/// requests. There is no uniqueness guarantee in a set of both inbound and outbound
|
|
/// [`ProtocolRequestId`]s.
|
|
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
|
|
struct ProtocolRequestId {
|
|
protocol: Cow<'static, str>,
|
|
request_id: RequestId,
|
|
}
|
|
|
|
impl From<(Cow<'static, str>, RequestId)> for ProtocolRequestId {
|
|
fn from((protocol, request_id): (Cow<'static, str>, RequestId)) -> Self {
|
|
Self { protocol, request_id }
|
|
}
|
|
}
|
|
|
|
/// Implementation of `NetworkBehaviour` that provides support for request-response protocols.
|
|
pub struct RequestResponsesBehaviour {
|
|
/// The multiple sub-protocols, by name.
|
|
/// Contains the underlying libp2p `RequestResponse` behaviour, plus an optional
|
|
/// "response builder" used to build responses for incoming requests.
|
|
protocols: HashMap<
|
|
Cow<'static, str>,
|
|
(RequestResponse<GenericCodec>, Option<mpsc::Sender<IncomingRequest>>)
|
|
>,
|
|
|
|
/// Pending requests, passed down to a [`RequestResponse`] behaviour, awaiting a reply.
|
|
pending_requests: HashMap<
|
|
ProtocolRequestId,
|
|
(Instant, oneshot::Sender<Result<Vec<u8>, RequestFailure>>),
|
|
>,
|
|
|
|
/// Whenever an incoming request arrives, a `Future` is added to this list and will yield the
|
|
/// start time and the response to send back to the remote.
|
|
pending_responses: stream::FuturesUnordered<
|
|
Pin<Box<dyn Future<Output = Option<RequestProcessingOutcome>> + Send>>
|
|
>,
|
|
|
|
/// Whenever an incoming request arrives, the arrival [`Instant`] is recorded here.
|
|
pending_responses_arrival_time: HashMap<ProtocolRequestId, Instant>,
|
|
}
|
|
|
|
/// Generated by the response builder and waiting to be processed.
|
|
struct RequestProcessingOutcome {
|
|
request_id: RequestId,
|
|
protocol: Cow<'static, str>,
|
|
inner_channel: ResponseChannel<Result<Vec<u8>, ()>>,
|
|
response: Vec<u8>,
|
|
}
|
|
|
|
impl RequestResponsesBehaviour {
|
|
/// Creates a new behaviour. Must be passed a list of supported protocols. Returns an error if
|
|
/// the same protocol is passed twice.
|
|
pub fn new(list: impl Iterator<Item = ProtocolConfig>) -> Result<Self, RegisterError> {
|
|
let mut protocols = HashMap::new();
|
|
for protocol in list {
|
|
let mut cfg = RequestResponseConfig::default();
|
|
cfg.set_connection_keep_alive(Duration::from_secs(10));
|
|
cfg.set_request_timeout(protocol.request_timeout);
|
|
|
|
let protocol_support = if protocol.inbound_queue.is_some() {
|
|
ProtocolSupport::Full
|
|
} else {
|
|
ProtocolSupport::Outbound
|
|
};
|
|
|
|
let rq_rp = RequestResponse::new(GenericCodec {
|
|
max_request_size: protocol.max_request_size,
|
|
max_response_size: protocol.max_response_size,
|
|
}, iter::once((protocol.name.as_bytes().to_vec(), protocol_support)), cfg);
|
|
|
|
match protocols.entry(protocol.name) {
|
|
Entry::Vacant(e) => e.insert((rq_rp, protocol.inbound_queue)),
|
|
Entry::Occupied(e) =>
|
|
return Err(RegisterError::DuplicateProtocol(e.key().clone())),
|
|
};
|
|
}
|
|
|
|
Ok(Self {
|
|
protocols,
|
|
pending_requests: Default::default(),
|
|
pending_responses: Default::default(),
|
|
pending_responses_arrival_time: Default::default(),
|
|
})
|
|
}
|
|
|
|
/// Initiates sending a request.
|
|
///
|
|
/// An error is returned if we are not connected to the target peer or if the protocol doesn't
|
|
/// match one that has been registered.
|
|
pub fn send_request(
|
|
&mut self,
|
|
target: &PeerId,
|
|
protocol_name: &str,
|
|
request: Vec<u8>,
|
|
pending_response: oneshot::Sender<Result<Vec<u8>, RequestFailure>>,
|
|
) {
|
|
if let Some((protocol, _)) = self.protocols.get_mut(protocol_name) {
|
|
if protocol.is_connected(target) {
|
|
let request_id = protocol.send_request(target, request);
|
|
self.pending_requests.insert(
|
|
(protocol_name.to_string().into(), request_id).into(),
|
|
(Instant::now(), pending_response),
|
|
);
|
|
} else {
|
|
if pending_response.send(Err(RequestFailure::NotConnected)).is_err() {
|
|
log::debug!(
|
|
target: "sub-libp2p",
|
|
"Not connected to peer {:?}. At the same time local \
|
|
node is no longer interested in the result.",
|
|
target,
|
|
);
|
|
};
|
|
}
|
|
} else {
|
|
if pending_response.send(Err(RequestFailure::UnknownProtocol)).is_err() {
|
|
log::debug!(
|
|
target: "sub-libp2p",
|
|
"Unknown protocol {:?}. At the same time local \
|
|
node is no longer interested in the result.",
|
|
protocol_name,
|
|
);
|
|
};
|
|
}
|
|
}
|
|
}
|
|
|
|
impl NetworkBehaviour for RequestResponsesBehaviour {
|
|
type ProtocolsHandler = MultiHandler<
|
|
String,
|
|
<RequestResponse<GenericCodec> as NetworkBehaviour>::ProtocolsHandler,
|
|
>;
|
|
type OutEvent = Event;
|
|
|
|
fn new_handler(&mut self) -> Self::ProtocolsHandler {
|
|
let iter = self.protocols.iter_mut()
|
|
.map(|(p, (r, _))| (p.to_string(), NetworkBehaviour::new_handler(r)));
|
|
|
|
MultiHandler::try_from_iter(iter)
|
|
.expect("Protocols are in a HashMap and there can be at most one handler per \
|
|
protocol name, which is the only possible error; qed")
|
|
}
|
|
|
|
fn addresses_of_peer(&mut self, _: &PeerId) -> Vec<Multiaddr> {
|
|
Vec::new()
|
|
}
|
|
|
|
fn inject_connection_established(
|
|
&mut self,
|
|
peer_id: &PeerId,
|
|
conn: &ConnectionId,
|
|
endpoint: &ConnectedPoint,
|
|
) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_connection_established(p, peer_id, conn, endpoint)
|
|
}
|
|
}
|
|
|
|
fn inject_connected(&mut self, peer_id: &PeerId) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_connected(p, peer_id)
|
|
}
|
|
}
|
|
|
|
fn inject_connection_closed(&mut self, peer_id: &PeerId, conn: &ConnectionId, endpoint: &ConnectedPoint) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_connection_closed(p, peer_id, conn, endpoint)
|
|
}
|
|
}
|
|
|
|
fn inject_disconnected(&mut self, peer_id: &PeerId) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_disconnected(p, peer_id)
|
|
}
|
|
}
|
|
|
|
fn inject_addr_reach_failure(
|
|
&mut self,
|
|
peer_id: Option<&PeerId>,
|
|
addr: &Multiaddr,
|
|
error: &dyn std::error::Error
|
|
) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_addr_reach_failure(p, peer_id, addr, error)
|
|
}
|
|
}
|
|
|
|
fn inject_event(
|
|
&mut self,
|
|
peer_id: PeerId,
|
|
connection: ConnectionId,
|
|
(p_name, event): <Self::ProtocolsHandler as ProtocolsHandler>::OutEvent,
|
|
) {
|
|
if let Some((proto, _)) = self.protocols.get_mut(&*p_name) {
|
|
return proto.inject_event(peer_id, connection, event)
|
|
}
|
|
|
|
log::warn!(target: "sub-libp2p",
|
|
"inject_node_event: no request-response instance registered for protocol {:?}",
|
|
p_name)
|
|
}
|
|
|
|
fn inject_new_external_addr(&mut self, addr: &Multiaddr) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_new_external_addr(p, addr)
|
|
}
|
|
}
|
|
|
|
fn inject_expired_listen_addr(&mut self, addr: &Multiaddr) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_expired_listen_addr(p, addr)
|
|
}
|
|
}
|
|
|
|
fn inject_dial_failure(&mut self, peer_id: &PeerId) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_dial_failure(p, peer_id)
|
|
}
|
|
}
|
|
|
|
fn inject_new_listen_addr(&mut self, addr: &Multiaddr) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_new_listen_addr(p, addr)
|
|
}
|
|
}
|
|
|
|
fn inject_listener_error(&mut self, id: ListenerId, err: &(dyn std::error::Error + 'static)) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_listener_error(p, id, err)
|
|
}
|
|
}
|
|
|
|
fn inject_listener_closed(&mut self, id: ListenerId, reason: Result<(), &io::Error>) {
|
|
for (p, _) in self.protocols.values_mut() {
|
|
NetworkBehaviour::inject_listener_closed(p, id, reason)
|
|
}
|
|
}
|
|
|
|
fn poll(
|
|
&mut self,
|
|
cx: &mut Context,
|
|
params: &mut impl PollParameters,
|
|
) -> Poll<
|
|
NetworkBehaviourAction<
|
|
<Self::ProtocolsHandler as ProtocolsHandler>::InEvent,
|
|
Self::OutEvent,
|
|
>,
|
|
> {
|
|
'poll_all: loop {
|
|
// Poll to see if any response is ready to be sent back.
|
|
while let Poll::Ready(Some(outcome)) = self.pending_responses.poll_next_unpin(cx) {
|
|
let RequestProcessingOutcome {
|
|
request_id,
|
|
protocol: protocol_name,
|
|
inner_channel,
|
|
response
|
|
} = match outcome {
|
|
Some(outcome) => outcome,
|
|
// The response builder was too busy and thus the request was dropped. This is
|
|
// later on reported as a `InboundFailure::Omission`.
|
|
None => continue,
|
|
};
|
|
|
|
if let Some((protocol, _)) = self.protocols.get_mut(&*protocol_name) {
|
|
if let Err(_) = protocol.send_response(inner_channel, Ok(response)) {
|
|
// Note: Failure is handled further below when receiving `InboundFailure`
|
|
// event from `RequestResponse` behaviour.
|
|
log::debug!(
|
|
target: "sub-libp2p",
|
|
"Failed to send response for {:?} on protocol {:?} due to a \
|
|
timeout or due to the connection to the peer being closed. \
|
|
Dropping response",
|
|
request_id, protocol_name,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
// Poll request-responses protocols.
|
|
for (protocol, (behaviour, resp_builder)) in &mut self.protocols {
|
|
while let Poll::Ready(ev) = behaviour.poll(cx, params) {
|
|
let ev = match ev {
|
|
// Main events we are interested in.
|
|
NetworkBehaviourAction::GenerateEvent(ev) => ev,
|
|
|
|
// Other events generated by the underlying behaviour are transparently
|
|
// passed through.
|
|
NetworkBehaviourAction::DialAddress { address } => {
|
|
log::error!("The request-response isn't supposed to start dialing peers");
|
|
return Poll::Ready(NetworkBehaviourAction::DialAddress { address })
|
|
}
|
|
NetworkBehaviourAction::DialPeer { peer_id, condition } => {
|
|
log::error!("The request-response isn't supposed to start dialing peers");
|
|
return Poll::Ready(NetworkBehaviourAction::DialPeer {
|
|
peer_id,
|
|
condition,
|
|
})
|
|
}
|
|
NetworkBehaviourAction::NotifyHandler {
|
|
peer_id,
|
|
handler,
|
|
event,
|
|
} => {
|
|
return Poll::Ready(NetworkBehaviourAction::NotifyHandler {
|
|
peer_id,
|
|
handler,
|
|
event: ((*protocol).to_string(), event),
|
|
})
|
|
}
|
|
NetworkBehaviourAction::ReportObservedAddr { address, score } => {
|
|
return Poll::Ready(NetworkBehaviourAction::ReportObservedAddr {
|
|
address, score,
|
|
})
|
|
}
|
|
};
|
|
|
|
match ev {
|
|
// Received a request from a remote.
|
|
RequestResponseEvent::Message {
|
|
peer,
|
|
message: RequestResponseMessage::Request { request_id, request, channel, .. },
|
|
} => {
|
|
self.pending_responses_arrival_time.insert(
|
|
(protocol.clone(), request_id.clone()).into(),
|
|
Instant::now(),
|
|
);
|
|
|
|
let (tx, rx) = oneshot::channel();
|
|
|
|
// Submit the request to the "response builder" passed by the user at
|
|
// initialization.
|
|
if let Some(resp_builder) = resp_builder {
|
|
// If the response builder is too busy, silently drop `tx`. This
|
|
// will be reported by the corresponding `RequestResponse` through
|
|
// an `InboundFailure::Omission` event.
|
|
let _ = resp_builder.try_send(IncomingRequest {
|
|
peer: peer.clone(),
|
|
payload: request,
|
|
pending_response: tx,
|
|
});
|
|
} else {
|
|
debug_assert!(false, "Received message on outbound-only protocol.");
|
|
}
|
|
|
|
let protocol = protocol.clone();
|
|
self.pending_responses.push(Box::pin(async move {
|
|
// The `tx` created above can be dropped if we are not capable of
|
|
// processing this request, which is reflected as a
|
|
// `InboundFailure::Omission` event.
|
|
if let Ok(response) = rx.await {
|
|
Some(RequestProcessingOutcome {
|
|
request_id, protocol, inner_channel: channel, response
|
|
})
|
|
} else {
|
|
None
|
|
}
|
|
}));
|
|
|
|
// This `continue` makes sure that `pending_responses` gets polled
|
|
// after we have added the new element.
|
|
continue 'poll_all;
|
|
}
|
|
|
|
// Received a response from a remote to one of our requests.
|
|
RequestResponseEvent::Message {
|
|
peer,
|
|
message: RequestResponseMessage::Response {
|
|
request_id,
|
|
response,
|
|
},
|
|
..
|
|
} => {
|
|
let (started, delivered) = match self.pending_requests.remove(
|
|
&(protocol.clone(), request_id).into(),
|
|
) {
|
|
Some((started, pending_response)) => {
|
|
let delivered = pending_response.send(
|
|
response.map_err(|()| RequestFailure::Refused),
|
|
).map_err(|_| RequestFailure::Obsolete);
|
|
(started, delivered)
|
|
}
|
|
None => {
|
|
log::warn!(
|
|
target: "sub-libp2p",
|
|
"Received `RequestResponseEvent::Message` with unexpected request id {:?}",
|
|
request_id,
|
|
);
|
|
debug_assert!(false);
|
|
continue;
|
|
}
|
|
};
|
|
|
|
let out = Event::RequestFinished {
|
|
peer,
|
|
protocol: protocol.clone(),
|
|
duration: started.elapsed(),
|
|
result: delivered,
|
|
};
|
|
|
|
return Poll::Ready(NetworkBehaviourAction::GenerateEvent(out));
|
|
}
|
|
|
|
// One of our requests has failed.
|
|
RequestResponseEvent::OutboundFailure {
|
|
peer,
|
|
request_id,
|
|
error,
|
|
..
|
|
} => {
|
|
let started = match self.pending_requests.remove(&(protocol.clone(), request_id).into()) {
|
|
Some((started, pending_response)) => {
|
|
if pending_response.send(
|
|
Err(RequestFailure::Network(error.clone())),
|
|
).is_err() {
|
|
log::debug!(
|
|
target: "sub-libp2p",
|
|
"Request with id {:?} failed. At the same time local \
|
|
node is no longer interested in the result.",
|
|
request_id,
|
|
);
|
|
}
|
|
started
|
|
}
|
|
None => {
|
|
log::warn!(
|
|
target: "sub-libp2p",
|
|
"Received `RequestResponseEvent::Message` with unexpected request id {:?}",
|
|
request_id,
|
|
);
|
|
debug_assert!(false);
|
|
continue;
|
|
}
|
|
};
|
|
|
|
let out = Event::RequestFinished {
|
|
peer,
|
|
protocol: protocol.clone(),
|
|
duration: started.elapsed(),
|
|
result: Err(RequestFailure::Network(error)),
|
|
};
|
|
|
|
return Poll::Ready(NetworkBehaviourAction::GenerateEvent(out));
|
|
}
|
|
|
|
// An inbound request failed, either while reading the request or due to failing
|
|
// to send a response.
|
|
RequestResponseEvent::InboundFailure { request_id, peer, error, .. } => {
|
|
self.pending_responses_arrival_time.remove(
|
|
&(protocol.clone(), request_id).into(),
|
|
);
|
|
let out = Event::InboundRequest {
|
|
peer,
|
|
protocol: protocol.clone(),
|
|
result: Err(ResponseFailure::Network(error)),
|
|
};
|
|
return Poll::Ready(NetworkBehaviourAction::GenerateEvent(out));
|
|
}
|
|
|
|
// A response to an inbound request has been sent.
|
|
RequestResponseEvent::ResponseSent { request_id, peer } => {
|
|
let arrival_time = self.pending_responses_arrival_time.remove(
|
|
&(protocol.clone(), request_id).into(),
|
|
)
|
|
.map(|t| t.elapsed())
|
|
.expect(
|
|
"Time is added for each inbound request on arrival and only \
|
|
removed on success (`ResponseSent`) or failure \
|
|
(`InboundFailure`). One can not receive a success event for a \
|
|
request that either never arrived, or that has previously \
|
|
failed; qed.",
|
|
);
|
|
|
|
let out = Event::InboundRequest {
|
|
peer,
|
|
protocol: protocol.clone(),
|
|
result: Ok(arrival_time),
|
|
};
|
|
return Poll::Ready(NetworkBehaviourAction::GenerateEvent(out));
|
|
|
|
}
|
|
};
|
|
}
|
|
}
|
|
|
|
break Poll::Pending;
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Error when registering a protocol.
|
|
#[derive(Debug, derive_more::Display, derive_more::Error)]
|
|
pub enum RegisterError {
|
|
/// A protocol has been specified multiple times.
|
|
DuplicateProtocol(#[error(ignore)] Cow<'static, str>),
|
|
}
|
|
|
|
/// Error in a request.
|
|
#[derive(Debug, derive_more::Display, derive_more::Error)]
|
|
pub enum RequestFailure {
|
|
/// We are not currently connected to the requested peer.
|
|
NotConnected,
|
|
/// Given protocol hasn't been registered.
|
|
UnknownProtocol,
|
|
/// Remote has closed the substream before answering, thereby signaling that it considers the
|
|
/// request as valid, but refused to answer it.
|
|
Refused,
|
|
/// The remote replied, but the local node is no longer interested in the response.
|
|
Obsolete,
|
|
/// Problem on the network.
|
|
#[display(fmt = "Problem on the network")]
|
|
Network(#[error(ignore)] OutboundFailure),
|
|
}
|
|
|
|
/// Error when processing a request sent by a remote.
|
|
#[derive(Debug, derive_more::Display, derive_more::Error)]
|
|
pub enum ResponseFailure {
|
|
/// Problem on the network.
|
|
#[display(fmt = "Problem on the network")]
|
|
Network(#[error(ignore)] InboundFailure),
|
|
}
|
|
|
|
/// Implements the libp2p [`RequestResponseCodec`] trait. Defines how streams of bytes are turned
|
|
/// into requests and responses and vice-versa.
|
|
#[derive(Debug, Clone)]
|
|
#[doc(hidden)] // Needs to be public in order to satisfy the Rust compiler.
|
|
pub struct GenericCodec {
|
|
max_request_size: u64,
|
|
max_response_size: u64,
|
|
}
|
|
|
|
#[async_trait::async_trait]
|
|
impl RequestResponseCodec for GenericCodec {
|
|
type Protocol = Vec<u8>;
|
|
type Request = Vec<u8>;
|
|
type Response = Result<Vec<u8>, ()>;
|
|
|
|
async fn read_request<T>(
|
|
&mut self,
|
|
_: &Self::Protocol,
|
|
mut io: &mut T,
|
|
) -> io::Result<Self::Request>
|
|
where
|
|
T: AsyncRead + Unpin + Send,
|
|
{
|
|
// Read the length.
|
|
let length = unsigned_varint::aio::read_usize(&mut io).await
|
|
.map_err(|err| io::Error::new(io::ErrorKind::InvalidInput, err))?;
|
|
if length > usize::try_from(self.max_request_size).unwrap_or(usize::max_value()) {
|
|
return Err(io::Error::new(
|
|
io::ErrorKind::InvalidInput,
|
|
format!("Request size exceeds limit: {} > {}", length, self.max_request_size)
|
|
));
|
|
}
|
|
|
|
// Read the payload.
|
|
let mut buffer = vec![0; length];
|
|
io.read_exact(&mut buffer).await?;
|
|
Ok(buffer)
|
|
}
|
|
|
|
async fn read_response<T>(
|
|
&mut self,
|
|
_: &Self::Protocol,
|
|
mut io: &mut T,
|
|
) -> io::Result<Self::Response>
|
|
where
|
|
T: AsyncRead + Unpin + Send,
|
|
{
|
|
// Note that this function returns a `Result<Result<...>>`. Returning an `Err` is
|
|
// considered as a protocol error and will result in the entire connection being closed.
|
|
// Returning `Ok(Err(_))` signifies that a response has successfully been fetched, and
|
|
// that this response is an error.
|
|
|
|
// Read the length.
|
|
let length = match unsigned_varint::aio::read_usize(&mut io).await {
|
|
Ok(l) => l,
|
|
Err(unsigned_varint::io::ReadError::Io(err))
|
|
if matches!(err.kind(), io::ErrorKind::UnexpectedEof) =>
|
|
{
|
|
return Ok(Err(()));
|
|
}
|
|
Err(err) => return Err(io::Error::new(io::ErrorKind::InvalidInput, err)),
|
|
};
|
|
|
|
if length > usize::try_from(self.max_response_size).unwrap_or(usize::max_value()) {
|
|
return Err(io::Error::new(
|
|
io::ErrorKind::InvalidInput,
|
|
format!("Response size exceeds limit: {} > {}", length, self.max_response_size)
|
|
));
|
|
}
|
|
|
|
// Read the payload.
|
|
let mut buffer = vec![0; length];
|
|
io.read_exact(&mut buffer).await?;
|
|
Ok(Ok(buffer))
|
|
}
|
|
|
|
async fn write_request<T>(
|
|
&mut self,
|
|
_: &Self::Protocol,
|
|
io: &mut T,
|
|
req: Self::Request,
|
|
) -> io::Result<()>
|
|
where
|
|
T: AsyncWrite + Unpin + Send,
|
|
{
|
|
// TODO: check the length?
|
|
// Write the length.
|
|
{
|
|
let mut buffer = unsigned_varint::encode::usize_buffer();
|
|
io.write_all(unsigned_varint::encode::usize(req.len(), &mut buffer)).await?;
|
|
}
|
|
|
|
// Write the payload.
|
|
io.write_all(&req).await?;
|
|
|
|
io.close().await?;
|
|
Ok(())
|
|
}
|
|
|
|
async fn write_response<T>(
|
|
&mut self,
|
|
_: &Self::Protocol,
|
|
io: &mut T,
|
|
res: Self::Response,
|
|
) -> io::Result<()>
|
|
where
|
|
T: AsyncWrite + Unpin + Send,
|
|
{
|
|
// If `res` is an `Err`, we jump to closing the substream without writing anything on it.
|
|
if let Ok(res) = res {
|
|
// TODO: check the length?
|
|
// Write the length.
|
|
{
|
|
let mut buffer = unsigned_varint::encode::usize_buffer();
|
|
io.write_all(unsigned_varint::encode::usize(res.len(), &mut buffer)).await?;
|
|
}
|
|
|
|
// Write the payload.
|
|
io.write_all(&res).await?;
|
|
}
|
|
|
|
io.close().await?;
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
use futures::channel::{mpsc, oneshot};
|
|
use futures::executor::LocalPool;
|
|
use futures::task::Spawn;
|
|
use libp2p::identity::Keypair;
|
|
use libp2p::Multiaddr;
|
|
use libp2p::core::upgrade;
|
|
use libp2p::core::transport::{Transport, MemoryTransport};
|
|
use libp2p::noise;
|
|
use libp2p::swarm::{Swarm, SwarmEvent};
|
|
use std::{iter, time::Duration};
|
|
|
|
fn build_swarm(list: impl Iterator<Item = ProtocolConfig>) -> (Swarm<RequestResponsesBehaviour>, Multiaddr) {
|
|
let keypair = Keypair::generate_ed25519();
|
|
|
|
let noise_keys = noise::Keypair::<noise::X25519Spec>::new()
|
|
.into_authentic(&keypair)
|
|
.unwrap();
|
|
|
|
let transport = MemoryTransport
|
|
.upgrade(upgrade::Version::V1)
|
|
.authenticate(noise::NoiseConfig::xx(noise_keys).into_authenticated())
|
|
.multiplex(libp2p::yamux::YamuxConfig::default())
|
|
.boxed();
|
|
|
|
let behaviour = RequestResponsesBehaviour::new(list).unwrap();
|
|
|
|
let mut swarm = Swarm::new(transport, behaviour, keypair.public().into_peer_id());
|
|
let listen_addr: Multiaddr = format!("/memory/{}", rand::random::<u64>()).parse().unwrap();
|
|
|
|
Swarm::listen_on(&mut swarm, listen_addr.clone()).unwrap();
|
|
(swarm, listen_addr)
|
|
}
|
|
|
|
#[test]
|
|
fn basic_request_response_works() {
|
|
let protocol_name = "/test/req-resp/1";
|
|
let mut pool = LocalPool::new();
|
|
|
|
// Build swarms whose behaviour is `RequestResponsesBehaviour`.
|
|
let mut swarms = (0..2)
|
|
.map(|_| {
|
|
let (tx, mut rx) = mpsc::channel::<IncomingRequest>(64);
|
|
|
|
pool.spawner().spawn_obj(async move {
|
|
while let Some(rq) = rx.next().await {
|
|
assert_eq!(rq.payload, b"this is a request");
|
|
let _ = rq.pending_response.send(b"this is a response".to_vec());
|
|
}
|
|
}.boxed().into()).unwrap();
|
|
|
|
let protocol_config = ProtocolConfig {
|
|
name: From::from(protocol_name),
|
|
max_request_size: 1024,
|
|
max_response_size: 1024 * 1024,
|
|
request_timeout: Duration::from_secs(30),
|
|
inbound_queue: Some(tx),
|
|
};
|
|
|
|
build_swarm(iter::once(protocol_config))
|
|
})
|
|
.collect::<Vec<_>>();
|
|
|
|
// Ask `swarm[0]` to dial `swarm[1]`. There isn't any discovery mechanism in place in
|
|
// this test, so they wouldn't connect to each other.
|
|
{
|
|
let dial_addr = swarms[1].1.clone();
|
|
Swarm::dial_addr(&mut swarms[0].0, dial_addr).unwrap();
|
|
}
|
|
|
|
// Running `swarm[0]` in the background.
|
|
pool.spawner().spawn_obj({
|
|
let (mut swarm, _) = swarms.remove(0);
|
|
async move {
|
|
loop {
|
|
match swarm.next_event().await {
|
|
SwarmEvent::Behaviour(Event::InboundRequest { result, .. }) => {
|
|
result.unwrap();
|
|
},
|
|
_ => {}
|
|
}
|
|
}
|
|
}.boxed().into()
|
|
}).unwrap();
|
|
|
|
// Remove and run the remaining swarm.
|
|
let (mut swarm, _) = swarms.remove(0);
|
|
pool.run_until(async move {
|
|
let mut response_receiver = None;
|
|
|
|
loop {
|
|
match swarm.next_event().await {
|
|
SwarmEvent::ConnectionEstablished { peer_id, .. } => {
|
|
let (sender, receiver) = oneshot::channel();
|
|
swarm.send_request(
|
|
&peer_id,
|
|
protocol_name,
|
|
b"this is a request".to_vec(),
|
|
sender,
|
|
);
|
|
assert!(response_receiver.is_none());
|
|
response_receiver = Some(receiver);
|
|
}
|
|
SwarmEvent::Behaviour(Event::RequestFinished {
|
|
result, ..
|
|
}) => {
|
|
result.unwrap();
|
|
break;
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
|
|
assert_eq!(response_receiver.unwrap().await.unwrap().unwrap(), b"this is a response");
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn max_response_size_exceeded() {
|
|
let protocol_name = "/test/req-resp/1";
|
|
let mut pool = LocalPool::new();
|
|
|
|
// Build swarms whose behaviour is `RequestResponsesBehaviour`.
|
|
let mut swarms = (0..2)
|
|
.map(|_| {
|
|
let (tx, mut rx) = mpsc::channel::<IncomingRequest>(64);
|
|
|
|
pool.spawner().spawn_obj(async move {
|
|
while let Some(rq) = rx.next().await {
|
|
assert_eq!(rq.payload, b"this is a request");
|
|
let _ = rq.pending_response.send(b"this response exceeds the limit".to_vec());
|
|
}
|
|
}.boxed().into()).unwrap();
|
|
|
|
let protocol_config = ProtocolConfig {
|
|
name: From::from(protocol_name),
|
|
max_request_size: 1024,
|
|
max_response_size: 8, // <-- important for the test
|
|
request_timeout: Duration::from_secs(30),
|
|
inbound_queue: Some(tx),
|
|
};
|
|
|
|
build_swarm(iter::once(protocol_config))
|
|
})
|
|
.collect::<Vec<_>>();
|
|
|
|
// Ask `swarm[0]` to dial `swarm[1]`. There isn't any discovery mechanism in place in
|
|
// this test, so they wouldn't connect to each other.
|
|
{
|
|
let dial_addr = swarms[1].1.clone();
|
|
Swarm::dial_addr(&mut swarms[0].0, dial_addr).unwrap();
|
|
}
|
|
|
|
// Running `swarm[0]` in the background until a `InboundRequest` event happens,
|
|
// which is a hint about the test having ended.
|
|
pool.spawner().spawn_obj({
|
|
let (mut swarm, _) = swarms.remove(0);
|
|
async move {
|
|
loop {
|
|
match swarm.next_event().await {
|
|
SwarmEvent::Behaviour(Event::InboundRequest { result, .. }) => {
|
|
assert!(result.is_ok());
|
|
break
|
|
},
|
|
_ => {}
|
|
}
|
|
}
|
|
}.boxed().into()
|
|
}).unwrap();
|
|
|
|
// Remove and run the remaining swarm.
|
|
let (mut swarm, _) = swarms.remove(0);
|
|
pool.run_until(async move {
|
|
let mut response_receiver = None;
|
|
|
|
loop {
|
|
match swarm.next_event().await {
|
|
SwarmEvent::ConnectionEstablished { peer_id, .. } => {
|
|
let (sender, receiver) = oneshot::channel();
|
|
swarm.send_request(
|
|
&peer_id,
|
|
protocol_name,
|
|
b"this is a request".to_vec(),
|
|
sender,
|
|
);
|
|
assert!(response_receiver.is_none());
|
|
response_receiver = Some(receiver);
|
|
}
|
|
SwarmEvent::Behaviour(Event::RequestFinished {
|
|
result, ..
|
|
}) => {
|
|
assert!(result.is_err());
|
|
break;
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
|
|
match response_receiver.unwrap().await.unwrap().unwrap_err() {
|
|
RequestFailure::Network(OutboundFailure::ConnectionClosed) => {},
|
|
_ => panic!()
|
|
}
|
|
});
|
|
}
|
|
|
|
/// A [`RequestId`] is a unique identifier among either all inbound or all outbound requests for
|
|
/// a single [`RequestResponse`] behaviour. It is not guaranteed to be unique across multiple
|
|
/// [`RequestResponse`] behaviours. Thus when handling [`RequestId`] in the context of multiple
|
|
/// [`RequestResponse`] behaviours, one needs to couple the protocol name with the [`RequestId`]
|
|
/// to get a unique request identifier.
|
|
///
|
|
/// This test ensures that two requests on different protocols can be handled concurrently
|
|
/// without a [`RequestId`] collision.
|
|
///
|
|
/// See [`ProtocolRequestId`] for additional information.
|
|
#[test]
|
|
fn request_id_collision() {
|
|
let protocol_name_1 = "/test/req-resp-1/1";
|
|
let protocol_name_2 = "/test/req-resp-2/1";
|
|
let mut pool = LocalPool::new();
|
|
|
|
let mut swarm_1 = {
|
|
let protocol_configs = vec![
|
|
ProtocolConfig {
|
|
name: From::from(protocol_name_1),
|
|
max_request_size: 1024,
|
|
max_response_size: 1024 * 1024,
|
|
request_timeout: Duration::from_secs(30),
|
|
inbound_queue: None,
|
|
},
|
|
ProtocolConfig {
|
|
name: From::from(protocol_name_2),
|
|
max_request_size: 1024,
|
|
max_response_size: 1024 * 1024,
|
|
request_timeout: Duration::from_secs(30),
|
|
inbound_queue: None,
|
|
},
|
|
];
|
|
|
|
build_swarm(protocol_configs.into_iter()).0
|
|
};
|
|
|
|
let (mut swarm_2, mut swarm_2_handler_1, mut swarm_2_handler_2, listen_add_2) = {
|
|
let (tx_1, rx_1) = mpsc::channel(64);
|
|
let (tx_2, rx_2) = mpsc::channel(64);
|
|
|
|
let protocol_configs = vec![
|
|
ProtocolConfig {
|
|
name: From::from(protocol_name_1),
|
|
max_request_size: 1024,
|
|
max_response_size: 1024 * 1024,
|
|
request_timeout: Duration::from_secs(30),
|
|
inbound_queue: Some(tx_1),
|
|
},
|
|
ProtocolConfig {
|
|
name: From::from(protocol_name_2),
|
|
max_request_size: 1024,
|
|
max_response_size: 1024 * 1024,
|
|
request_timeout: Duration::from_secs(30),
|
|
inbound_queue: Some(tx_2),
|
|
},
|
|
];
|
|
|
|
let (swarm, listen_addr) = build_swarm(protocol_configs.into_iter());
|
|
|
|
(swarm, rx_1, rx_2, listen_addr)
|
|
};
|
|
|
|
// Ask swarm 1 to dial swarm 2. There isn't any discovery mechanism in place in this test,
|
|
// so they wouldn't connect to each other.
|
|
Swarm::dial_addr(&mut swarm_1, listen_add_2).unwrap();
|
|
|
|
// Run swarm 2 in the background, receiving two requests.
|
|
pool.spawner().spawn_obj(
|
|
async move {
|
|
loop {
|
|
match swarm_2.next_event().await {
|
|
SwarmEvent::Behaviour(Event::InboundRequest { result, .. }) => {
|
|
result.unwrap();
|
|
},
|
|
_ => {}
|
|
}
|
|
}
|
|
}.boxed().into()
|
|
).unwrap();
|
|
|
|
// Handle both requests sent by swarm 1 to swarm 2 in the background.
|
|
//
|
|
// Make sure both requests overlap, by answering the first only after receiving the
|
|
// second.
|
|
pool.spawner().spawn_obj(async move {
|
|
let protocol_1_request = swarm_2_handler_1.next().await;
|
|
let protocol_2_request = swarm_2_handler_2.next().await;
|
|
|
|
protocol_1_request.unwrap()
|
|
.pending_response
|
|
.send(b"this is a response".to_vec())
|
|
.unwrap();
|
|
protocol_2_request.unwrap()
|
|
.pending_response
|
|
.send(b"this is a response".to_vec())
|
|
.unwrap();
|
|
}.boxed().into()).unwrap();
|
|
|
|
// Have swarm 1 send two requests to swarm 2 and await responses.
|
|
pool.run_until(
|
|
async move {
|
|
let mut response_receivers = None;
|
|
let mut num_responses = 0;
|
|
|
|
loop {
|
|
match swarm_1.next_event().await {
|
|
SwarmEvent::ConnectionEstablished { peer_id, .. } => {
|
|
let (sender_1, receiver_1) = oneshot::channel();
|
|
let (sender_2, receiver_2) = oneshot::channel();
|
|
swarm_1.send_request(
|
|
&peer_id,
|
|
protocol_name_1,
|
|
b"this is a request".to_vec(),
|
|
sender_1,
|
|
);
|
|
swarm_1.send_request(
|
|
&peer_id,
|
|
protocol_name_2,
|
|
b"this is a request".to_vec(),
|
|
sender_2,
|
|
);
|
|
assert!(response_receivers.is_none());
|
|
response_receivers = Some((receiver_1, receiver_2));
|
|
}
|
|
SwarmEvent::Behaviour(Event::RequestFinished {
|
|
result, ..
|
|
}) => {
|
|
num_responses += 1;
|
|
result.unwrap();
|
|
if num_responses == 2 {
|
|
break;
|
|
}
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
let (response_receiver_1, response_receiver_2) = response_receivers.unwrap();
|
|
assert_eq!(response_receiver_1.await.unwrap().unwrap(), b"this is a response");
|
|
assert_eq!(response_receiver_2.await.unwrap().unwrap(), b"this is a response");
|
|
}
|
|
);
|
|
}
|
|
}
|