Files
pezkuwi-subxt/substrate/frame/benchmarking
cheme 4c651637f2 Inner hashing of value in state trie (runtime versioning). (#9732)
* starting

* Updated from other branch.

* setting flag

* flag in storage struct

* fix flagging to access and insert.

* added todo to fix

* also missing serialize meta to storage proof

* extract meta.

* Isolate old trie layout.

* failing test that requires storing in meta when old hash scheme is used.

* old hash compatibility

* Db migrate.

* runing tests with both states when interesting.

* fix chain spec test with serde default.

* export state (missing trie function).

* Pending using new branch, lacking genericity on layout resolution.

* extract and set global meta

* Update to branch 4

* fix iterator with root flag (no longer insert node).

* fix trie root hashing of root

* complete basic backend.

* Remove old_hash meta from proof that do not use inner_hashing.

* fix trie test for empty (force layout on empty deltas).

* Root update fix.

* debug on meta

* Use trie key iteration that do not include value in proofs.

* switch default test ext to use inner hash.

* small integration test, and fix tx cache mgmt in ext.
test  failing

* Proof scenario at state-machine level.

* trace for db upgrade

* try different param

* act more like iter_from.

* Bigger batches.

* Update trie dependency.

* drafting codec changes and refact

* before removing unused branch no value alt hashing.
more work todo rename all flag var to alt_hash, and remove extrinsic
replace by storage query at every storage_root call.

* alt hashing only for branch with value.

* fix trie tests

* Hash of value include the encoded size.

* removing fields(broken)

* fix trie_stream to also include value length in inner hash.

* triedbmut only using alt type if inner hashing.

* trie_stream to also only use alt hashing type when actually alt hashing.

* Refactor meta state, logic should work with change of trie treshold.

* Remove NoMeta variant.

* Remove state_hashed trigger specific functions.

* pending switching to using threshold, new storage root api does not
make much sense.

* refactoring to use state from backend (not possible payload changes).

* Applying from previous state

* Remove default from storage, genesis need a special build.

* rem empty space

* Catch problem: when using triedb with default: we should not revert
nodes: otherwhise thing as trie codec cannot decode-encode without
changing state.

* fix compilation

* Right logic to avoid switch on reencode when default layout.

* Clean up some todos

* remove trie meta from root upstream

* update upstream and fix benches.

* split some long lines.

* UPdate trie crate to work with new design.

* Finish update to refactored upstream.

* update to latest triedb changes.

* Clean up.

* fix executor test.

* rust fmt from master.

* rust format.

* rustfmt

* fix

* start host function driven versioning

* update state-machine part

* still need access to state version from runtime

* state hash in mem: wrong

* direction likely correct, but passing call to code exec for genesis
init seem awkward.

* state version serialize in runtime, wrong approach, just initialize it
with no threshold for core api < 4 seems more proper.

* stateversion from runtime version (core api >= 4).

* update trie, fix tests

* unused import

* clean some TODOs

* Require RuntimeVersionOf for executor

* use RuntimeVersionOf to resolve genesis state version.

* update runtime version test

* fix state-machine tests

* TODO

* Use runtime version from storage wasm with fast sync.

* rustfmt

* fmt

* fix test

* revert useless changes.

* clean some unused changes

* fmt

* removing useless trait function.

* remove remaining reference to state_hash

* fix some imports

* Follow chain state version management.

* trie update, fix and constant threshold for trie layouts.

* update deps

* Update to latest trie pr changes.

* fix benches

* Verify proof requires right layout.

* update trie_root

* Update trie deps to  latest

* Update to latest trie versioning

* Removing patch

* update lock

* extrinsic for sc-service-test using layout v0.

* Adding RuntimeVersionOf to CallExecutor works.

* fmt

* error when resolving version and no wasm in storage.

* use existing utils to instantiate runtime code.

* Patch to delay runtime switch.

* Revert "Patch to delay runtime switch."

This reverts commit 67e55fee468f1a0cda853f5362b22e0d775786da.

* useless closure

* remove remaining state_hash variables.

* Remove outdated comment

* useless inner hash

* fmt

* fmt and opt-in feature to apply state change.

* feature gate core version, use new test feature for node and test node

* Use a 'State' api version instead of Core one.

* fix merge of test function

* use blake macro.

* Fix state api (require declaring the api in runtime).

* Opt out feature, fix macro for io to select a given version
instead of latest.

* run test nodes on new state.

* fix

* Apply review change (docs and error).

* fmt

* use explicit runtime_interface in doc test

* fix ui test

* fix doc test

* fmt

* use default for path and specname when resolving version.

* small review related changes.

* doc value size requirement.

* rename old_state feature

* Remove macro changes

* feature rename

* state version as host function parameter

* remove flag for client api

* fix tests

* switch storage chain proof to V1

* host functions, pass by state version enum

* use WrappedRuntimeCode

* start

* state_version in runtime version

* rust fmt

* Update storage proof of max size.

* fix runtime version rpc test

* right intent of convert from compat

* fix doc test

* fix doc test

* split proof

* decode without replay, and remove some reexports.

* Decode with compatibility by default.

* switch state_version to u8. And remove RuntimeVersionBasis.

* test

* use api when reading embedded version

* fix decode with apis

* extract core version instead

* test fix

* unused import

* review changes.

Co-authored-by: kianenigma <kian@parity.io>
2021-12-24 08:54:07 +00:00
..
2020-11-05 19:18:55 +01:00

Substrate Runtime Benchmarking Framework

This crate contains a set of utilities that can be used to benchmark and weigh FRAME pallets that you develop for your Substrate Runtime.

Overview

Substrate's FRAME framework allows you to develop custom logic for your blockchain that can be included in your runtime. This flexibility is key to help you design complex and interactive pallets, but without accurate weights assigned to dispatchables, your blockchain may become vulnerable to denial of service (DoS) attacks by malicious actors.

The Substrate Runtime Benchmarking Framework is a tool you can use to mitigate DoS attacks against your blockchain network by benchmarking the computational resources required to execute different functions in the runtime, for example extrinsics, on_initialize, verify_unsigned, etc...

The general philosophy behind the benchmarking system is: If your node can know ahead of time how long it will take to execute an extrinsic, it can safely make decisions to include or exclude that extrinsic based on its available resources. By doing this, it can keep the block production and import process running smoothly.

To achieve this, we need to model how long it takes to run each function in the runtime by:

  • Creating custom benchmarking logic that executes a specific code path of a function.
  • Executing the benchmark in the Wasm execution environment, on a specific set of hardware, with a custom runtime configuration, etc...
  • Executing the benchmark across controlled ranges of possible values that may affect the result of the benchmark (called "components").
  • Executing the benchmark multiple times at each point in order to isolate and remove outliers.
  • Using the results of the benchmark to create a linear model of the function across its components.

With this linear model, we are able to estimate ahead of time how long it takes to execute some logic, and thus make informed decisions without actually spending any significant resources at runtime.

Note that we assume that all extrinsics are assumed to be of linear complexity, which is why we are able to always fit them to a linear model. Quadratic or higher complexity functions are, in general, considered to be dangerous to the runtime as the weight of these functions may explode as the runtime state or input becomes too complex.

The benchmarking framework comes with the following tools:

The end-to-end benchmarking pipeline is disabled by default when compiling a node. If you want to run benchmarks, you need to enable it by compiling with a Rust feature flag runtime-benchmarks. More details about this below.

Weight

Substrate represents computational resources using a generic unit of measurement called "Weight". It defines 10^12 Weight as 1 second of computation on the physical machine used for benchmarking. This means that the weight of a function may change based on the specific hardware used to benchmark the runtime functions.

By modeling the expected weight of each runtime function, the blockchain is able to calculate how many transactions or system level functions it will be able to execute within a certain period of time. Often, the limiting factor for a blockchain is the fixed block production time for the network.

Within FRAME, each dispatchable function must have a #[weight] annotation with a function that can return the expected weight for the worst case scenario execution of that function given its inputs. This benchmarking framework will result in a file that automatically generates those formulas for you, which you can then use in your pallet.

Writing Benchmarks

Writing a runtime benchmark is much like writing a unit test for your pallet. It needs to be carefully crafted to execute a certain logical path in your code. In tests you want to check for various success and failure conditions, but with benchmarks you specifically look for the most computationally heavy path, a.k.a the "worst case scenario".

This means that if there are certain storage items or runtime state that may affect the complexity of the function, for example triggering more iterations in a for loop, to get an accurate result, you must set up your benchmark to trigger this.

It may be that there are multiple paths your function can go down, and it is not clear which one is the heaviest. In this case, you should just create a benchmark for each scenario! You may find that there are paths in your code where complexity may become unbounded depending on user input. This may be a hint that you should enforce sane boundaries for how a user can use your pallet. For example: limiting the number of elements in a vector, limiting the number of iterations in a for loop, etc...

Examples of end-to-end benchmarks can be found in the pallets provided by Substrate, and the specific details on how to use the benchmarks! macro can be found in its documentation.

Testing Benchmarks

You can test your benchmarks using the same test runtime that you created for your pallet's unit tests. By creating your benchmarks in the benchmarks! macro, it automatically generates test functions for you:

fn test_benchmark_[benchmark_name]<T>::() -> Result<(), &'static str>

Simply add these functions to a unit test and ensure that the result of the function is Ok(()).

Note: If your test runtime and production runtime have different configurations, you may get different results when testing your benchmark and actually running it.

In general, benchmarks returning Ok(()) is all you need to check for since it signals the executed extrinsic has completed successfully. However, you can optionally include a verify block with your benchmark, which can additionally verify any final conditions, such as the final state of your runtime.

These additional verify blocks will not affect the results of your final benchmarking process.

To run the tests, you need to enable the runtime-benchmarks feature flag. This may also mean you need to move into your node's binary folder. For example, with the Substrate repository, this is how you would test the Balances pallet's benchmarks:

cargo test -p pallet-balances --features runtime-benchmarks

NOTE: Substrate uses a virtual workspace which does not allow you to compile with feature flags.

error: --features is not allowed in the root of a virtual workspace`

To solve this, navigate to the folder of the node (cd bin/node/cli) or pallet (cd frame/pallet) and run the command there.

Adding Benchmarks

The benchmarks included with each pallet are not automatically added to your node. To actually execute these benchmarks, you need to implement the frame_benchmarking::Benchmark trait. You can see an example of how to do this in the included Substrate node.

Assuming there are already some benchmarks set up on your node, you just need to add another instance of the add_benchmark! macro:

///  configuration for running benchmarks
///               |    name of your pallet's crate (as imported)
///               v                   v
add_benchmark!(params, batches, pallet_balances, Balances);
///                       ^                          ^
///    where all benchmark results are saved         |
///            the `struct` created for your pallet by `construct_runtime!`

Once you have done this, you will need to compile your node binary with the runtime-benchmarks feature flag:

cd bin/node/cli
cargo build --release --features runtime-benchmarks

Running Benchmarks

Finally, once you have a node binary with benchmarks enabled, you need to execute your various benchmarks.

You can get a list of the available benchmarks by running:

./target/release/substrate benchmark --chain dev --pallet "*" --extrinsic "*" --repeat 0

Then you can run a benchmark like so:

./target/release/substrate benchmark \
    --chain dev \                  # Configurable Chain Spec
    --execution=wasm \             # Always test with Wasm
    --wasm-execution=compiled \    # Always used `wasm-time`
    --pallet pallet_balances \     # Select the pallet
    --extrinsic transfer \         # Select the extrinsic
    --steps 50 \                   # Number of samples across component ranges
    --repeat 20 \                  # Number of times we repeat a benchmark
    --output <path> \              # Output benchmark results into a folder or file

This will output a file pallet_name.rs which implements the WeightInfo trait you should include in your pallet. Each blockchain should generate their own benchmark file with their custom implementation of the WeightInfo trait. This means that you will be able to use these modular Substrate pallets while still keeping your network safe for your specific configuration and requirements.

The benchmarking CLI uses a Handlebars template to format the final output file. You can optionally pass the flag --template pointing to a custom template that can be used instead. Within the template, you have access to all the data provided by the TemplateData struct in the benchmarking CLI writer. You can find the default template used here.

There are some custom Handlebars helpers included with our output generation:

  • underscore: Add an underscore to every 3rd character from the right of a string. Primarily to be used for delimiting large numbers.
  • join: Join an array of strings into a space-separated string for the template. Primarily to be used for joining all the arguments passed to the CLI.

To get a full list of available options when running benchmarks, run:

./target/release/substrate benchmark --help

License: Apache-2.0