mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-28 21:27:25 +00:00
Niklas Adolfsson
e16ef0861f
This is a rather big change in jsonrpsee, the major things in this bump are: - Server backpressure (the subscription impls are modified to deal with that) - Allow custom error types / return types (remove jsonrpsee::core::Error and jsonrpee::core::CallError) - Bug fixes (graceful shutdown in particular not used by substrate anyway) - Less dependencies for the clients in particular - Return type requires Clone in method call responses - Moved to tokio channels - Async subscription API (not used in this PR) Major changes in this PR: - The subscriptions are now bounded and if subscription can't keep up with the server it is dropped - CLI: add parameter to configure the jsonrpc server bounded message buffer (default is 64) - Add our own subscription helper to deal with the unbounded streams in substrate The most important things in this PR to review is the added helpers functions in `substrate/client/rpc/src/utils.rs` and the rest is pretty much chore. Regarding the "bounded buffer limit" it may cause the server to handle the JSON-RPC calls slower than before. The message size limit is bounded by "--rpc-response-size" thus "by default 10MB * 64 = 640MB" but the subscription message size is not covered by this limit and could be capped as well. Hopefully the last release prior to 1.0, sorry in advance for a big PR Previous attempt: https://github.com/paritytech/substrate/pull/13992 Resolves https://github.com/paritytech/polkadot-sdk/issues/748, resolves https://github.com/paritytech/polkadot-sdk/issues/627
60 lines
2.0 KiB
Rust
60 lines
2.0 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
use super::*;
|
|
use assert_matches::assert_matches;
|
|
use sp_core::{offchain::storage::InMemOffchainStorage, Bytes};
|
|
|
|
#[test]
|
|
fn local_storage_should_work() {
|
|
let storage = InMemOffchainStorage::default();
|
|
let offchain = Offchain::new(storage, DenyUnsafe::No);
|
|
let key = Bytes(b"offchain_storage".to_vec());
|
|
let value = Bytes(b"offchain_value".to_vec());
|
|
|
|
assert_matches!(
|
|
offchain.set_local_storage(StorageKind::PERSISTENT, key.clone(), value.clone()),
|
|
Ok(())
|
|
);
|
|
assert_matches!(
|
|
offchain.get_local_storage(StorageKind::PERSISTENT, key),
|
|
Ok(Some(ref v)) if *v == value
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn offchain_calls_considered_unsafe() {
|
|
let storage = InMemOffchainStorage::default();
|
|
let offchain = Offchain::new(storage, DenyUnsafe::Yes);
|
|
let key = Bytes(b"offchain_storage".to_vec());
|
|
let value = Bytes(b"offchain_value".to_vec());
|
|
|
|
assert_matches!(
|
|
offchain.set_local_storage(StorageKind::PERSISTENT, key.clone(), value.clone()),
|
|
Err(Error::UnsafeRpcCalled(e)) => {
|
|
assert_eq!(e.to_string(), "RPC call is unsafe to be called externally")
|
|
}
|
|
);
|
|
assert_matches!(
|
|
offchain.get_local_storage(StorageKind::PERSISTENT, key),
|
|
Err(Error::UnsafeRpcCalled(e)) => {
|
|
assert_eq!(e.to_string(), "RPC call is unsafe to be called externally")
|
|
}
|
|
);
|
|
}
|