mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-20 06:55:42 +00:00
eaf057c5ed
* First baby steps * Split scheduler into several modules * Towards a more modular approach for scheduling * move free_cores; IntoInterator -> BTreeMap * Move clear() * Move more functions out of scheduler * Change weight composition * More abstraction * Further refactor * clippy * fmt * fix test-runtime * Add parathreads pallet to construct_runtime! * Make all runtimes use (Parachains, Parathreads) scheduling * Delete commented out code * Remove parathreads scheduler from westend, rococo, and kusama * fix rococo, westend, and kusama config * Revert "fix rococo, westend, and kusama config" This reverts commit 59e4de380d5c7d17eaaba5e2c2b81405de3465e3. * Revert "Remove parathreads scheduler from westend, rococo, and kusama" This reverts commit 4c44255296083ac5670560790ed77104917890a4. * Remove CoreIndex from free_cores * Remove unnecessary struct for parathreads * parathreads provider take 1 * Comment out parathread tests * Pop into lookahead * fmt * Fill lookahead with two entries for parachains * fmt * Current stage * Towards ab parathreads * no AB use * Make tests typecheck * quick hack to set scheduling lookahead to 1 * Fix scheduler tests * fix paras_inherent tests * misc * Update more of a test * cfg(test) * some cleanup * Undo paras_inherent changes * Adjust paras inherent tests * Undo changes to v2 primitives * Undo v2 mod changes to tests * minor * Remove parathreads assigner and pallet * minor * minor * more cleanup * fmt * minor * minor * minor * Remove on_new_session from assignment provider * Make adder collator integration test pass * disable failing unit tests * minor * minor * re-enable one unit test * minor * handle retries, add concluded para to pop interface * comment out unused code * Remove core_para from interface * Remove first claimqueue element on clear if None instead removing all Nones * Move claimqueue get out of loop * Use VecDeque instead of Ved in ClaimQueue * Make occupied() AB ready(?) * handle freed disputed in clear_and_fill_claimqueue * clear_and_fill_claimqueue returns scheduled Vec * Rename and minor refactor * return position of assignment taken from claimqueue * minor * Fix session boundary parachains number change + extended test * Fix runtimes * Fix polkadot runtime * Remove polkadot pallet from benchmarks * fix test runtime * Add storage migration * Minor refactor * Minor * migratin typechecks * Add migration to runtimes * Towards modular scheduling II (#6568) * Add post migration check * pebkac * Disable migrations but mine * Revert "Disable migrations but mine" This reverts commit 4fa5c5a370c199944a7e0926f50b08626bfbad4c. * Move scheduler migration * Revert "Move scheduler migration" This reverts commit a16b1659a907950bae048a9f7010f2aa76e02b6d. * Fix migration * cleanup * Don't lose retries value anymore * comment out test function * Remove retries value from Assignment again * minor * Make collator for parathreads optional * data type refactor * update scheduler tests * Change test function cfg * comment out test function * Try cfg(test) only * fix cfg flags * Add get_max_retries function to provider interface (#7047) * Fix merge commit * pebkac * fix merge * update cargo.lock * fix merge * fix merge * Use btreemap instead of vec, fix scheduler calls. * Use imported `ScheduledCore` * Remove unused import in inclusion tests * Use keys() instead of mapping over a BTreeMap * Fix migrations for parachains scheduler * Use BlockNumberFor<T> everywhere in scheduler * Add on demand assignment provider pallet (#7110) * Address some PR comments * minor * more cleanup * find_map and timeout availability fixes * Change default scheduling_lookahead to 1 * Add on demand assignment provider pallet * Move test-runtime to new assignment provider * Run cargo format on scheduler tests * minor * Mutate cores in single loop * timeout predicate simplification * claimqueue desired size fix * Replace expect by ok_or * More improvements * Fix push back order and next_up_on_timeout * minor * session change docs * Add pre_new_session call to hand pre session updates * Remove sc_network dependency and PeerId from unnecessary data structures * Remove unnecessary peer_ids * Add OnDemandOrdering proxy (#7156) * Add OnDemandBidding proxy * Fix names * OnDemandAssigner for rococo only * Check PeerId in collator protocol before fetching collation * On occupied, remove non occupied cores from the claimqueue front and refill * Add missing docs * Comment out unused field * fix ScheduledCore in tests * Fix the fix * pebkac * fmt * Fix occupied dropping * Remove double import * ScheduledCore fixes * Readd sc-network dep * pebkac * OpaquePeerId -> PeerId in can_collate interface * Cargo.lock update for interface change * Remove checks not needed anymore? * Drop occupied core on session change if it would time out after the new session * Add on demand assignment provider pallet * Move test-runtime to new assignment provider * Run cargo format on scheduler tests * Add OnDemandOrdering proxy (#7156) * Add OnDemandBidding proxy * Fix names * OnDemandAssigner for rococo only * Remove unneeded config values * Update comments * Use and_then for queue position * Return the max size of the spot queue on error * Add comments to add_parathread_entry * Add module comments * Add log for when can_collate fails * Change assigner queue type to `Assignment` * Update assignment provider tests * More logs * Remove unused keyring import * disable can_collate * comment out can_collate * Can collate first checks set if empty * Move can_collate call to collation advertisement * Fix backing test * map to loop * Remove obsolete check * Move invalid collation test from backing to collator-protocol * fix unused imports * fix test * fix Debug derivation * Increase time limit on zombienet predicates * Increase zombienet timeout * Minor * Address some PR comments * Address PR comments * Comment out failing assert due to on-demand assigner missing * remove collator_restrictions info from backing * Move can_collate to ActiveParas * minor * minor * Update weight information for on demand config * Add ttl to parasentry * Fix tests missing parasentry ttl * Adjust scheduler tests to use ttl default values * Use match instead of if let for ttl drop * Use RuntimeDebug trait for `ParasEntry` fields * Add comments to on demand assignment pallet * Fix spot traffic calculation * Revert runtimedebug changes to primitives * Remove runtimedebug derivation from `ParasEntry` * Mention affinity in pallet level docs * Use RuntimeDebug trait for ParasEntry child types * Remove collator restrictions * Fix primitive versioning and other merge issues * Fix tests post merge * Fix node side tests * Edit parascheduler migration for clarity * Move parascheduler migration up to next release * Remove vestiges from merge * Fix tests * Refactor ttl handling * Remove unused things from scheduler tests * Move on demand assigner to own directory * Update documentation * Remove unused sc-network dependency in primitives Was used for collator restrictions * Remove unused import * Reenable scheduler test * Remove unused storage value * Enable timeout predicate test and fix fn Turns out that the issue with the compiler is fixed and we can now use impl Trait in the manner used here. * Remove unused imports * Add benchmarking entry for perbill in config * Correct typo * Address review comments * Log out errors when calculating spot traffic. * Change parascheduler's log target name * Update scheduler_common documentation * Use mutate for affinity fns, add tests * Add another on demand affinity test * Unify parathreads and parachains in HostConfig (take 2) (#7452) * Unify parathreads and parachains in HostConfig * Fixed missed occurences * Remove commented out lines * `HostConfiguration v7` * Fix version check * Add `MigrateToV7` to `Unreleased` * fmt * fmt * Fix compilation errors after the rebase * Update runtime/parachains/src/scheduler/tests.rs Co-authored-by: Anton Vilhelm Ásgeirsson <antonva@users.noreply.github.com> * Update runtime/parachains/src/scheduler/tests.rs Co-authored-by: Anton Vilhelm Ásgeirsson <antonva@users.noreply.github.com> * fmt * Fix migration test * Fix tests * Remove unneeded assert from tests * parathread_cores -> on_demand_cores; parathread_retries -> on_demand_retries * Fix a compilation error in tests * Remove unused `use` * update colander image version --------- Co-authored-by: alexgparity <alex.gremm@parity.io> Co-authored-by: Anton Vilhelm Ásgeirsson <antonva@users.noreply.github.com> Co-authored-by: Javier Viola <javier@parity.io> * Fix branch after merge with master * Refactor out duplicate checks into a helper fn * Fix tests post merge * Rename add_parathread_assignment, add test * Update docs * Remove unused on_finalize function * Add weight info to on demand pallet * Update runtime/parachains/src/configuration.rs Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> * Update runtime/parachains/src/scheduler_common/mod.rs Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> * Update runtime/parachains/src/assigner_on_demand/mod.rs Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> * Add benchmarking to on demand pallet * Make place_order test check for success * Add on demand benchmarks * Add local test weights to rococo runtime * Modify TTL drop behaviour to not skip claims Previous behaviour would jump a new claim from the assignment provider ahead in the claimqueue, assuming lookahead is larger than 1. * Refactor ttl test to test claimqueue order * Disable place_order ext. when no on_demand cores * Use default genesis config for benchmark tests * Refactor config builder param * Move lifecycle test from scheduler to on demand * Remove unneeded lifecycle test Paras module via the parachain assignment provider doesn't provide new assignments if a parachain loses it's lease. The on demand assignment provider doesn't provide an assignment that is not a parathread. * Re enable validator shuffle test * More realistic weights for place_order * Remove redundant import * Fix backwards compatibility (hopefully) * ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=runtime_parachains::assigner_on_demand * Fix tests. * Fix off-by-one. * Re enable claimqueue fills test * Re enable schedule_rotates_groups test * Fix fill_claimqueue_fills test * Re enable next_up_on_timeout test, move fn * Do not pop from assignment provider when retrying * Fix tests missing collator in scheduledcore * Add comment about timeout predicate. * Rename parasentry retries to availability timeouts * Re enable schedule_schedules... test * Refactor prune retried test to new scheduler * Have all scheduler tests use genesis_cfg fn * Update docs * Update copyright notices on new files * Rename is_parachain_core to is_bulk_core * Remove erroneous TODO * Simplify import * ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=runtime_parachains::configuration * Revert AdvertiseCollation order shuffle * Refactor place_order into keepalive and allowdeath * Revert rename of hrmp max inbound channels parachain encompasses both on demand and slot auction / bulk. * Restore availability_timeout_predicate function * Clean up leftover comments * Update runtime/parachains/src/scheduler/tests.rs Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> * ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=westend --target_dir=polkadot --pallet=runtime_parachains::configuration --------- Co-authored-by: alexgparity <alex.gremm@parity.io> Co-authored-by: alexgparity <115470171+alexgparity@users.noreply.github.com> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: command-bot <> * On Demand - update weights and small nits (#7605) * Remove collator restriction test in inclusion On demand parachains won't have collator restrictions implemented in this way but will instead use a preferred collator registered to a `ParaId` in `paras_registrar`. * Remove redundant config guard for test fns * Update weights * Update WeightInfo for on_demand assigner * Unify assignment provider parameters into one call (#7606) * Combine assignmentprovider params into one fn call * Move scheduler_common to a module under scheduler * Fix ttl handling in benchmark builder * Run cargo format * Remove obsolete test. * Small improvement. * Use same migration pattern as config module * Remove old TODO * Change log target name for assigner on demand * Fix migration * Fix clippy warnings * Add HostConfiguration storage migration to V8 * Add `MigrateToV8` to unreleased migrations for all runtimes * Fix storage version check for config v8 * Set `StorageVersion` to 8 in `MigrateToV8` * Remove dups. * Update primitives/src/v5/mod.rs Co-authored-by: Bastian Köcher <git@kchr.de> --------- Co-authored-by: alexgparity <alex.gremm@parity.io> Co-authored-by: alexgparity <115470171+alexgparity@users.noreply.github.com> Co-authored-by: antonva <anton.asgeirsson@parity.io> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: Anton Vilhelm Ásgeirsson <antonva@users.noreply.github.com> Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Bastian Köcher <git@kchr.de>
212 lines
6.7 KiB
Rust
212 lines
6.7 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
use super::*;
|
|
use crate::{
|
|
configuration::HostConfiguration,
|
|
initializer::SessionChangeNotification,
|
|
mock::{
|
|
new_test_ext, Configuration, MockGenesisConfig, ParasShared, RuntimeOrigin, SessionInfo,
|
|
System, Test,
|
|
},
|
|
util::take_active_subset,
|
|
};
|
|
use keyring::Sr25519Keyring;
|
|
use primitives::{BlockNumber, ValidatorId, ValidatorIndex};
|
|
|
|
fn run_to_block(
|
|
to: BlockNumber,
|
|
new_session: impl Fn(BlockNumber) -> Option<SessionChangeNotification<BlockNumber>>,
|
|
) {
|
|
while System::block_number() < to {
|
|
let b = System::block_number();
|
|
|
|
SessionInfo::initializer_finalize();
|
|
ParasShared::initializer_finalize();
|
|
Configuration::initializer_finalize();
|
|
|
|
if let Some(notification) = new_session(b + 1) {
|
|
Configuration::initializer_on_new_session(¬ification.session_index);
|
|
ParasShared::initializer_on_new_session(
|
|
notification.session_index,
|
|
notification.random_seed,
|
|
¬ification.new_config,
|
|
notification.validators.clone(),
|
|
);
|
|
SessionInfo::initializer_on_new_session(¬ification);
|
|
}
|
|
|
|
System::on_finalize(b);
|
|
|
|
System::on_initialize(b + 1);
|
|
System::set_block_number(b + 1);
|
|
|
|
Configuration::initializer_initialize(b + 1);
|
|
ParasShared::initializer_initialize(b + 1);
|
|
SessionInfo::initializer_initialize(b + 1);
|
|
}
|
|
}
|
|
|
|
fn default_config() -> HostConfiguration<BlockNumber> {
|
|
HostConfiguration {
|
|
on_demand_cores: 1,
|
|
dispute_period: 2,
|
|
needed_approvals: 3,
|
|
..Default::default()
|
|
}
|
|
}
|
|
|
|
fn genesis_config() -> MockGenesisConfig {
|
|
MockGenesisConfig {
|
|
configuration: configuration::GenesisConfig { config: default_config() },
|
|
..Default::default()
|
|
}
|
|
}
|
|
|
|
fn session_changes(n: BlockNumber) -> Option<SessionChangeNotification<BlockNumber>> {
|
|
if n % 10 == 0 {
|
|
Some(SessionChangeNotification { session_index: n / 10, ..Default::default() })
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
|
|
fn new_session_every_block(n: BlockNumber) -> Option<SessionChangeNotification<BlockNumber>> {
|
|
Some(SessionChangeNotification { session_index: n, ..Default::default() })
|
|
}
|
|
|
|
#[test]
|
|
fn session_pruning_is_based_on_dispute_period() {
|
|
new_test_ext(genesis_config()).execute_with(|| {
|
|
// Dispute period starts at 2
|
|
let config = Configuration::config();
|
|
assert_eq!(config.dispute_period, 2);
|
|
|
|
// Move to session 10
|
|
run_to_block(100, session_changes);
|
|
// Earliest stored session is 10 - 2 = 8
|
|
assert_eq!(EarliestStoredSession::<Test>::get(), 8);
|
|
// Pruning works as expected
|
|
assert!(Sessions::<Test>::get(7).is_none());
|
|
assert!(Sessions::<Test>::get(8).is_some());
|
|
assert!(Sessions::<Test>::get(9).is_some());
|
|
|
|
// changing `dispute_period` works
|
|
let dispute_period = 5;
|
|
Configuration::set_dispute_period(RuntimeOrigin::root(), dispute_period).unwrap();
|
|
|
|
// Dispute period does not automatically change
|
|
let config = Configuration::config();
|
|
assert_eq!(config.dispute_period, 2);
|
|
// Two sessions later it will though
|
|
run_to_block(120, session_changes);
|
|
let config = Configuration::config();
|
|
assert_eq!(config.dispute_period, 5);
|
|
|
|
run_to_block(200, session_changes);
|
|
assert_eq!(EarliestStoredSession::<Test>::get(), 20 - dispute_period);
|
|
|
|
// Increase dispute period even more
|
|
let new_dispute_period = 16;
|
|
Configuration::set_dispute_period(RuntimeOrigin::root(), new_dispute_period).unwrap();
|
|
|
|
run_to_block(210, session_changes);
|
|
assert_eq!(EarliestStoredSession::<Test>::get(), 21 - dispute_period);
|
|
|
|
// Two sessions later it kicks in
|
|
run_to_block(220, session_changes);
|
|
let config = Configuration::config();
|
|
assert_eq!(config.dispute_period, 16);
|
|
// Earliest session stays the same
|
|
assert_eq!(EarliestStoredSession::<Test>::get(), 21 - dispute_period);
|
|
|
|
// We still don't have enough stored sessions to start pruning
|
|
run_to_block(300, session_changes);
|
|
assert_eq!(EarliestStoredSession::<Test>::get(), 21 - dispute_period);
|
|
|
|
// now we do
|
|
run_to_block(420, session_changes);
|
|
assert_eq!(EarliestStoredSession::<Test>::get(), 42 - new_dispute_period);
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn session_info_is_based_on_config() {
|
|
new_test_ext(genesis_config()).execute_with(|| {
|
|
run_to_block(1, new_session_every_block);
|
|
let session = Sessions::<Test>::get(&1).unwrap();
|
|
assert_eq!(session.needed_approvals, 3);
|
|
|
|
// change some param
|
|
Configuration::set_needed_approvals(RuntimeOrigin::root(), 42).unwrap();
|
|
// 2 sessions later
|
|
run_to_block(3, new_session_every_block);
|
|
let session = Sessions::<Test>::get(&3).unwrap();
|
|
assert_eq!(session.needed_approvals, 42);
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn session_info_active_subsets() {
|
|
let unscrambled = vec![
|
|
Sr25519Keyring::Alice,
|
|
Sr25519Keyring::Bob,
|
|
Sr25519Keyring::Charlie,
|
|
Sr25519Keyring::Dave,
|
|
Sr25519Keyring::Eve,
|
|
];
|
|
|
|
let active_set = vec![ValidatorIndex(4), ValidatorIndex(0), ValidatorIndex(2)];
|
|
|
|
let unscrambled_validators: Vec<ValidatorId> =
|
|
unscrambled.iter().map(|v| v.public().into()).collect();
|
|
let unscrambled_discovery: Vec<AuthorityDiscoveryId> =
|
|
unscrambled.iter().map(|v| v.public().into()).collect();
|
|
let unscrambled_assignment: Vec<AssignmentId> =
|
|
unscrambled.iter().map(|v| v.public().into()).collect();
|
|
|
|
let validators = take_active_subset(&active_set, &unscrambled_validators);
|
|
|
|
new_test_ext(genesis_config()).execute_with(|| {
|
|
ParasShared::set_active_validators_with_indices(active_set.clone(), validators.clone());
|
|
|
|
assert_eq!(ParasShared::active_validator_indices(), active_set);
|
|
|
|
AssignmentKeysUnsafe::<Test>::set(unscrambled_assignment.clone());
|
|
crate::mock::set_discovery_authorities(unscrambled_discovery.clone());
|
|
assert_eq!(<Test>::authorities(), unscrambled_discovery);
|
|
|
|
// invoke directly, because `run_to_block` will invoke `Shared` and clobber our
|
|
// values.
|
|
SessionInfo::initializer_on_new_session(&SessionChangeNotification {
|
|
session_index: 1,
|
|
validators: validators.clone(),
|
|
..Default::default()
|
|
});
|
|
let session = Sessions::<Test>::get(&1).unwrap();
|
|
|
|
assert_eq!(session.validators.to_vec(), validators);
|
|
assert_eq!(
|
|
session.discovery_keys,
|
|
take_active_subset_and_inactive(&active_set, &unscrambled_discovery),
|
|
);
|
|
assert_eq!(
|
|
session.assignment_keys,
|
|
take_active_subset(&active_set, &unscrambled_assignment),
|
|
);
|
|
})
|
|
}
|