mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-31 14:31:02 +00:00
3d9439f646
## Problem During the bumping of the `polkadot-fellows` repository to `polkadot-sdk@1.6.0`, I encountered a situation where the benchmarks `teleport_assets` and `reserve_transfer_assets` in AssetHubKusama started to fail. This issue arose due to a decreased ED balance for AssetHubs introduced [here](https://github.com/polkadot-fellows/runtimes/pull/158/files#diff-80668ff8e793b64f36a9a3ec512df5cbca4ad448c157a5d81abda1b15f35f1daR213), and also because of a [missing CI pipeline](https://github.com/polkadot-fellows/runtimes/issues/197) to check the benchmarks, which went unnoticed. These benchmarks expect the `caller` to have enough: 1. balance to transfer (BTT) 2. balance for paying delivery (BFPD). So the initial balance was calculated as `ED * 100`, which seems reasonable: ``` const ED_MULTIPLIER: u32 = 100; let balance = existential_deposit.saturating_mul(ED_MULTIPLIER.into());` ``` The problem arises when the price for delivery is 100 times higher than the existential deposit. In other words, when `ED * 100` does not cover `BTT` + `BFPD`. I check AHR/AHW/AHK/AHP and this problem has only AssetHubKusama ``` ED: 3333333 calculated price to parent delivery: 1031666634 (from xcm logs from the benchmark) --- 3333333 * 100 - BTT(3333333) - BFPD(1031666634) = −701666667 ``` which results in the error; ``` 2024-02-23 09:19:42 Unable to charge fee with error Module(ModuleError { index: 31, error: [17, 0, 0, 0], message: Some("FeesNotMet") }) Error: Input("Benchmark pallet_xcm::reserve_transfer_assets failed: FeesNotMet") ``` ## Solution The benchmarks `teleport_assets` and `reserve_transfer_assets` were fixed by removing `ED * 100` and replacing it with `DeliveryHelper` logic, which calculates the (almost real) price for delivery and sets it along with the existential deposit as the initial balance for the account used in the benchmark. ## TODO - [ ] patch for 1.6 - https://github.com/paritytech/polkadot-sdk/pull/3466 - [ ] patch for 1.7 - https://github.com/paritytech/polkadot-sdk/pull/3465 - [ ] patch for 1.8 - TODO: PR --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
309 lines
10 KiB
Rust
309 lines
10 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Adapters to work with [`frame_support::traits::fungible`] through XCM.
|
|
|
|
use super::MintLocation;
|
|
use frame_support::traits::{
|
|
tokens::{
|
|
fungible, Fortitude::Polite, Precision::Exact, Preservation::Preserve, Provenance::Minted,
|
|
},
|
|
Get,
|
|
};
|
|
use sp_std::{marker::PhantomData, prelude::*, result};
|
|
use xcm::latest::prelude::*;
|
|
use xcm_executor::{
|
|
traits::{ConvertLocation, Error as MatchError, MatchesFungible, TransactAsset},
|
|
AssetsInHolding,
|
|
};
|
|
|
|
/// [`TransactAsset`] implementation that allows the use of a [`fungible`] implementation for
|
|
/// handling an asset in the XCM executor.
|
|
/// Only works for transfers.
|
|
pub struct FungibleTransferAdapter<Fungible, Matcher, AccountIdConverter, AccountId>(
|
|
PhantomData<(Fungible, Matcher, AccountIdConverter, AccountId)>,
|
|
);
|
|
impl<
|
|
Fungible: fungible::Mutate<AccountId>,
|
|
Matcher: MatchesFungible<Fungible::Balance>,
|
|
AccountIdConverter: ConvertLocation<AccountId>,
|
|
AccountId: Eq + Clone,
|
|
> TransactAsset for FungibleTransferAdapter<Fungible, Matcher, AccountIdConverter, AccountId>
|
|
{
|
|
fn internal_transfer_asset(
|
|
what: &Asset,
|
|
from: &Location,
|
|
to: &Location,
|
|
_context: &XcmContext,
|
|
) -> result::Result<AssetsInHolding, XcmError> {
|
|
log::trace!(
|
|
target: "xcm::fungible_adapter",
|
|
"internal_transfer_asset what: {:?}, from: {:?}, to: {:?}",
|
|
what, from, to
|
|
);
|
|
// Check we handle the asset
|
|
let amount = Matcher::matches_fungible(what).ok_or(MatchError::AssetNotHandled)?;
|
|
let source = AccountIdConverter::convert_location(from)
|
|
.ok_or(MatchError::AccountIdConversionFailed)?;
|
|
let dest = AccountIdConverter::convert_location(to)
|
|
.ok_or(MatchError::AccountIdConversionFailed)?;
|
|
Fungible::transfer(&source, &dest, amount, Preserve)
|
|
.map_err(|error| XcmError::FailedToTransactAsset(error.into()))?;
|
|
Ok(what.clone().into())
|
|
}
|
|
}
|
|
|
|
/// [`TransactAsset`] implementation that allows the use of a [`fungible`] implementation for
|
|
/// handling an asset in the XCM executor.
|
|
/// Works for everything but transfers.
|
|
pub struct FungibleMutateAdapter<Fungible, Matcher, AccountIdConverter, AccountId, CheckingAccount>(
|
|
PhantomData<(Fungible, Matcher, AccountIdConverter, AccountId, CheckingAccount)>,
|
|
);
|
|
|
|
impl<
|
|
Fungible: fungible::Mutate<AccountId>,
|
|
Matcher: MatchesFungible<Fungible::Balance>,
|
|
AccountIdConverter: ConvertLocation<AccountId>,
|
|
AccountId: Eq + Clone,
|
|
CheckingAccount: Get<Option<(AccountId, MintLocation)>>,
|
|
> FungibleMutateAdapter<Fungible, Matcher, AccountIdConverter, AccountId, CheckingAccount>
|
|
{
|
|
fn can_accrue_checked(checking_account: AccountId, amount: Fungible::Balance) -> XcmResult {
|
|
Fungible::can_deposit(&checking_account, amount, Minted)
|
|
.into_result()
|
|
.map_err(|_| XcmError::NotDepositable)
|
|
}
|
|
|
|
fn can_reduce_checked(checking_account: AccountId, amount: Fungible::Balance) -> XcmResult {
|
|
Fungible::can_withdraw(&checking_account, amount)
|
|
.into_result(false)
|
|
.map_err(|_| XcmError::NotWithdrawable)
|
|
.map(|_| ())
|
|
}
|
|
|
|
fn accrue_checked(checking_account: AccountId, amount: Fungible::Balance) {
|
|
let ok = Fungible::mint_into(&checking_account, amount).is_ok();
|
|
debug_assert!(ok, "`can_accrue_checked` must have returned `true` immediately prior; qed");
|
|
}
|
|
|
|
fn reduce_checked(checking_account: AccountId, amount: Fungible::Balance) {
|
|
let ok = Fungible::burn_from(&checking_account, amount, Exact, Polite).is_ok();
|
|
debug_assert!(ok, "`can_reduce_checked` must have returned `true` immediately prior; qed");
|
|
}
|
|
}
|
|
|
|
impl<
|
|
Fungible: fungible::Mutate<AccountId>,
|
|
Matcher: MatchesFungible<Fungible::Balance>,
|
|
AccountIdConverter: ConvertLocation<AccountId>,
|
|
AccountId: Eq + Clone,
|
|
CheckingAccount: Get<Option<(AccountId, MintLocation)>>,
|
|
> TransactAsset
|
|
for FungibleMutateAdapter<Fungible, Matcher, AccountIdConverter, AccountId, CheckingAccount>
|
|
{
|
|
fn can_check_in(_origin: &Location, what: &Asset, _context: &XcmContext) -> XcmResult {
|
|
log::trace!(
|
|
target: "xcm::fungible_adapter",
|
|
"can_check_in origin: {:?}, what: {:?}",
|
|
_origin, what
|
|
);
|
|
// Check we handle this asset
|
|
let amount = Matcher::matches_fungible(what).ok_or(MatchError::AssetNotHandled)?;
|
|
match CheckingAccount::get() {
|
|
Some((checking_account, MintLocation::Local)) =>
|
|
Self::can_reduce_checked(checking_account, amount),
|
|
Some((checking_account, MintLocation::NonLocal)) =>
|
|
Self::can_accrue_checked(checking_account, amount),
|
|
None => Ok(()),
|
|
}
|
|
}
|
|
|
|
fn check_in(_origin: &Location, what: &Asset, _context: &XcmContext) {
|
|
log::trace!(
|
|
target: "xcm::fungible_adapter",
|
|
"check_in origin: {:?}, what: {:?}",
|
|
_origin, what
|
|
);
|
|
if let Some(amount) = Matcher::matches_fungible(what) {
|
|
match CheckingAccount::get() {
|
|
Some((checking_account, MintLocation::Local)) =>
|
|
Self::reduce_checked(checking_account, amount),
|
|
Some((checking_account, MintLocation::NonLocal)) =>
|
|
Self::accrue_checked(checking_account, amount),
|
|
None => (),
|
|
}
|
|
}
|
|
}
|
|
|
|
fn can_check_out(_dest: &Location, what: &Asset, _context: &XcmContext) -> XcmResult {
|
|
log::trace!(
|
|
target: "xcm::fungible_adapter",
|
|
"can_check_out dest: {:?}, what: {:?}",
|
|
_dest,
|
|
what
|
|
);
|
|
let amount = Matcher::matches_fungible(what).ok_or(MatchError::AssetNotHandled)?;
|
|
match CheckingAccount::get() {
|
|
Some((checking_account, MintLocation::Local)) =>
|
|
Self::can_accrue_checked(checking_account, amount),
|
|
Some((checking_account, MintLocation::NonLocal)) =>
|
|
Self::can_reduce_checked(checking_account, amount),
|
|
None => Ok(()),
|
|
}
|
|
}
|
|
|
|
fn check_out(_dest: &Location, what: &Asset, _context: &XcmContext) {
|
|
log::trace!(
|
|
target: "xcm::fungible_adapter",
|
|
"check_out dest: {:?}, what: {:?}",
|
|
_dest,
|
|
what
|
|
);
|
|
if let Some(amount) = Matcher::matches_fungible(what) {
|
|
match CheckingAccount::get() {
|
|
Some((checking_account, MintLocation::Local)) =>
|
|
Self::accrue_checked(checking_account, amount),
|
|
Some((checking_account, MintLocation::NonLocal)) =>
|
|
Self::reduce_checked(checking_account, amount),
|
|
None => (),
|
|
}
|
|
}
|
|
}
|
|
|
|
fn deposit_asset(what: &Asset, who: &Location, _context: Option<&XcmContext>) -> XcmResult {
|
|
log::trace!(
|
|
target: "xcm::fungible_adapter",
|
|
"deposit_asset what: {:?}, who: {:?}",
|
|
what, who,
|
|
);
|
|
let amount = Matcher::matches_fungible(what).ok_or(MatchError::AssetNotHandled)?;
|
|
let who = AccountIdConverter::convert_location(who)
|
|
.ok_or(MatchError::AccountIdConversionFailed)?;
|
|
Fungible::mint_into(&who, amount)
|
|
.map_err(|error| XcmError::FailedToTransactAsset(error.into()))?;
|
|
Ok(())
|
|
}
|
|
|
|
fn withdraw_asset(
|
|
what: &Asset,
|
|
who: &Location,
|
|
_context: Option<&XcmContext>,
|
|
) -> result::Result<AssetsInHolding, XcmError> {
|
|
log::trace!(
|
|
target: "xcm::fungible_adapter",
|
|
"withdraw_asset what: {:?}, who: {:?}",
|
|
what, who,
|
|
);
|
|
let amount = Matcher::matches_fungible(what).ok_or(MatchError::AssetNotHandled)?;
|
|
let who = AccountIdConverter::convert_location(who)
|
|
.ok_or(MatchError::AccountIdConversionFailed)?;
|
|
Fungible::burn_from(&who, amount, Exact, Polite)
|
|
.map_err(|error| XcmError::FailedToTransactAsset(error.into()))?;
|
|
Ok(what.clone().into())
|
|
}
|
|
}
|
|
|
|
/// [`TransactAsset`] implementation that allows the use of a [`fungible`] implementation for
|
|
/// handling an asset in the XCM executor.
|
|
/// Works for everything, transfers and teleport bookkeeping.
|
|
pub struct FungibleAdapter<Fungible, Matcher, AccountIdConverter, AccountId, CheckingAccount>(
|
|
PhantomData<(Fungible, Matcher, AccountIdConverter, AccountId, CheckingAccount)>,
|
|
);
|
|
impl<
|
|
Fungible: fungible::Mutate<AccountId>,
|
|
Matcher: MatchesFungible<Fungible::Balance>,
|
|
AccountIdConverter: ConvertLocation<AccountId>,
|
|
AccountId: Eq + Clone,
|
|
CheckingAccount: Get<Option<(AccountId, MintLocation)>>,
|
|
> TransactAsset
|
|
for FungibleAdapter<Fungible, Matcher, AccountIdConverter, AccountId, CheckingAccount>
|
|
{
|
|
fn can_check_in(origin: &Location, what: &Asset, context: &XcmContext) -> XcmResult {
|
|
FungibleMutateAdapter::<
|
|
Fungible,
|
|
Matcher,
|
|
AccountIdConverter,
|
|
AccountId,
|
|
CheckingAccount,
|
|
>::can_check_in(origin, what, context)
|
|
}
|
|
|
|
fn check_in(origin: &Location, what: &Asset, context: &XcmContext) {
|
|
FungibleMutateAdapter::<
|
|
Fungible,
|
|
Matcher,
|
|
AccountIdConverter,
|
|
AccountId,
|
|
CheckingAccount,
|
|
>::check_in(origin, what, context)
|
|
}
|
|
|
|
fn can_check_out(dest: &Location, what: &Asset, context: &XcmContext) -> XcmResult {
|
|
FungibleMutateAdapter::<
|
|
Fungible,
|
|
Matcher,
|
|
AccountIdConverter,
|
|
AccountId,
|
|
CheckingAccount,
|
|
>::can_check_out(dest, what, context)
|
|
}
|
|
|
|
fn check_out(dest: &Location, what: &Asset, context: &XcmContext) {
|
|
FungibleMutateAdapter::<
|
|
Fungible,
|
|
Matcher,
|
|
AccountIdConverter,
|
|
AccountId,
|
|
CheckingAccount,
|
|
>::check_out(dest, what, context)
|
|
}
|
|
|
|
fn deposit_asset(what: &Asset, who: &Location, context: Option<&XcmContext>) -> XcmResult {
|
|
FungibleMutateAdapter::<
|
|
Fungible,
|
|
Matcher,
|
|
AccountIdConverter,
|
|
AccountId,
|
|
CheckingAccount,
|
|
>::deposit_asset(what, who, context)
|
|
}
|
|
|
|
fn withdraw_asset(
|
|
what: &Asset,
|
|
who: &Location,
|
|
maybe_context: Option<&XcmContext>,
|
|
) -> result::Result<AssetsInHolding, XcmError> {
|
|
FungibleMutateAdapter::<
|
|
Fungible,
|
|
Matcher,
|
|
AccountIdConverter,
|
|
AccountId,
|
|
CheckingAccount,
|
|
>::withdraw_asset(what, who, maybe_context)
|
|
}
|
|
|
|
fn internal_transfer_asset(
|
|
what: &Asset,
|
|
from: &Location,
|
|
to: &Location,
|
|
context: &XcmContext,
|
|
) -> result::Result<AssetsInHolding, XcmError> {
|
|
FungibleTransferAdapter::<Fungible, Matcher, AccountIdConverter, AccountId>::internal_transfer_asset(
|
|
what, from, to, context
|
|
)
|
|
}
|
|
}
|