mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-25 03:41:08 +00:00
c7d1204ce5
* Introduce inherent digests * Implement inherent digests * fix silly error * Implementation of inherent digests in BABE All tests pass. There are still limitations: 1. The runtime strips out inherent digests, so BABE must re-add them. 2. The test runtime checks that it can re-compute all digests. It can’t, so I had to comment out that test. * Fix compilation and seal import Seals were not imported correctly: the pre-digest was imported twice, instead of both it and the seal being imported. Also, other parts of the code did not compile due to incomplete refactoring. * Remove bogus assertion * Fix testsuite compilation * Remove unused import * Fix compiler diagnostics * Add inherent digest parameters to block constructors This enforces that inherent digests are added first. * Fixup Cargo.lock * Fix build errors * Re-add an incorrectly removed import * Bump primitive-types version * Update Cargo.lock * Refactoring * Use inherent digests for AuRa They do reach the runtime, but get stripped. I have not figured out where. * Fix compilation errors * Fix compilation errors due to incorrect types * Fix whitespace Suggested-by: Tomasz Drwiega <tomasz@parity.io> * Add preamble Suggested-by: Tomasz Drwiega <tomasz@parity.io> * Fix silly compile error * Refactor pre-digest finding code into a separate function * Remove unwanted assertion It is too likely to bring down the entire blockchain. Suggested-by: Tomasz Drwiega <tomasz@parity.io> * Use `find_pre_digest` after runtime, too Also, use `Member` trait rather than rolling our own requirements. Suggested-by: Tomasz Drwiega <tomasz@parity.io> * Fix various warnings mostly due to upgrading the dependency on `error_chain`. * Pre-digests nearly complete This nearly completes the implementation of pre-runtime digests. * `Seal2` → `Seal` and fix test suite * Try to fix the storage error * Try to fix storage (again) * Fix tests * Hopefully finish pre-runtime digests The key is to pass *only* the pre-runtime digests to the runtime. The others must be stripped out by `initialize_block`. * Fix silly typo * Fix another silly mistake * Remove unnecessary filtering of BABE pre-digests We no longer get duplicate BABE pre-digests, so if they appear, the header should be rejected outright. * Update Cargo.lock files * Reformatting * Fix silly typo in inherent digest code Also, revert `error.rs` files that contained calls to the `error_chain!` macro. * Try to keep the runtime from stripping pre-digests Currently runs into the “Storage root must match that calculated” assertion. * Don’t compute storage root until storage changes are done. Also, fix a compilation error. * Fix compile-time error * Fix compilation errors * Fix more compile errors * Hopefully it compiles this time… * Fix compilation and add docs * Prevent BABE from adding duplicate pre-runtime digests Found by comparing with the AuRa code. I also did some refactoring. * Respond to review and fix some warnings * Delete some dead code introduced earlier * More dead code goes away * `ref mut` → `&mut` * Respond to review and fix some warnings * Fix compilation error * Remove unneeded `HashT` type parameter Suggested-by: Robert Habermeier <robert@parity.io> * Remove spurious #[allow(deprecated)] * Document inherent digest parameter to `build_block` * Delete `Simple` trait It wasn’t needed * delete wrongly added files * Fix trait bounds * Digest serialization tests I also did some reformatting and cleanup. * Apply suggestions from code review Reformatting Co-Authored-By: André Silva <andre.beat@gmail.com> * Swap two arguments to `propose` and `propose_with` Also, remove some needless unsafe code. * Remove bogus `#![allow(deprecated)]` annotations With the removal of the deprecated `Seal` variant, these are not needed. * Add a missing `#[allow(deprecated)]` in the AuRa tests * Fix silly compile error * Fix silly compiler error RLS did not tell me that I hadn’t fixed `babe/lib.rs`, so I missed it. * Fixes made automatically by Cargo
93 lines
2.9 KiB
Rust
93 lines
2.9 KiB
Rust
// Copyright 2017-2019 Parity Technologies (UK) Ltd.
|
|
// This file is part of Substrate.
|
|
|
|
// Substrate is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Substrate is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Substrate. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Tests for the module.
|
|
|
|
#![cfg(test)]
|
|
|
|
use lazy_static::lazy_static;
|
|
use crate::mock::{System, Aura, new_test_ext};
|
|
use primitives::traits::Header;
|
|
use runtime_io::with_externalities;
|
|
use parking_lot::Mutex;
|
|
use crate::{AuraReport, HandleReport};
|
|
|
|
#[test]
|
|
fn aura_report_gets_skipped_correctly() {
|
|
let mut report = AuraReport {
|
|
start_slot: 3,
|
|
skipped: 15,
|
|
};
|
|
|
|
let mut validators = vec![0; 10];
|
|
report.punish(10, |idx, count| validators[idx] += count);
|
|
assert_eq!(validators, vec![0, 0, 0, 0, 0, 0, 0, 0, 0, 0]);
|
|
|
|
let mut validators = vec![0; 10];
|
|
report.skipped = 5;
|
|
report.punish(10, |idx, count| validators[idx] += count);
|
|
assert_eq!(validators, vec![0, 0, 0, 1, 1, 1, 1, 1, 0, 0]);
|
|
|
|
let mut validators = vec![0; 10];
|
|
report.start_slot = 8;
|
|
report.punish(10, |idx, count| validators[idx] += count);
|
|
assert_eq!(validators, vec![1, 1, 1, 0, 0, 0, 0, 0, 1, 1]);
|
|
|
|
let mut validators = vec![0; 4];
|
|
report.start_slot = 1;
|
|
report.skipped = 3;
|
|
report.punish(4, |idx, count| validators[idx] += count);
|
|
assert_eq!(validators, vec![0, 1, 1, 1]);
|
|
|
|
let mut validators = vec![0; 4];
|
|
report.start_slot = 2;
|
|
report.punish(4, |idx, count| validators[idx] += count);
|
|
assert_eq!(validators, vec![1, 0, 1, 1]);
|
|
}
|
|
|
|
#[test]
|
|
fn aura_reports_offline() {
|
|
lazy_static! {
|
|
static ref SLASH_COUNTS: Mutex<Vec<usize>> = Mutex::new(vec![0; 4]);
|
|
}
|
|
|
|
struct HandleTestReport;
|
|
impl HandleReport for HandleTestReport {
|
|
fn handle_report(report: AuraReport) {
|
|
let mut counts = SLASH_COUNTS.lock();
|
|
report.punish(counts.len(), |idx, count| counts[idx] += count);
|
|
}
|
|
}
|
|
|
|
with_externalities(&mut new_test_ext(vec![0, 1, 2, 3]), || {
|
|
System::initialize(&1, &Default::default(), &Default::default(), &Default::default());
|
|
let slot_duration = Aura::slot_duration();
|
|
|
|
Aura::on_timestamp_set::<HandleTestReport>(5 * slot_duration, slot_duration);
|
|
let header = System::finalize();
|
|
|
|
// no slashing when last step was 0.
|
|
assert_eq!(SLASH_COUNTS.lock().as_slice(), &[0, 0, 0, 0]);
|
|
|
|
System::initialize(&2, &header.hash(), &Default::default(), &Default::default());
|
|
Aura::on_timestamp_set::<HandleTestReport>(8 * slot_duration, slot_duration);
|
|
let _header = System::finalize();
|
|
|
|
// Steps 6 and 7 were skipped.
|
|
assert_eq!(SLASH_COUNTS.lock().as_slice(), &[0, 0, 1, 1]);
|
|
});
|
|
}
|