mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-31 21:31:02 +00:00
8428f678fe
# Note for reviewer
Most changes are just syntax changes necessary for the new version.
Most important files should be the ones under the `xcm` folder.
# Description
Added XCMv4.
## Removed `Multi` prefix
The following types have been renamed:
- MultiLocation -> Location
- MultiAsset -> Asset
- MultiAssets -> Assets
- InteriorMultiLocation -> InteriorLocation
- MultiAssetFilter -> AssetFilter
- VersionedMultiAsset -> VersionedAsset
- WildMultiAsset -> WildAsset
- VersionedMultiLocation -> VersionedLocation
In order to fix a name conflict, the `Assets` in `xcm-executor` were
renamed to `HoldingAssets`, as they represent assets in holding.
## Removed `Abstract` asset id
It was not being used anywhere and this simplifies the code.
Now assets are just constructed as follows:
```rust
let asset: Asset = (AssetId(Location::new(1, Here)), 100u128).into();
```
No need for specifying `Concrete` anymore.
## Outcome is now a named fields struct
Instead of
```rust
pub enum Outcome {
Complete(Weight),
Incomplete(Weight, Error),
Error(Error),
}
```
we now have
```rust
pub enum Outcome {
Complete { used: Weight },
Incomplete { used: Weight, error: Error },
Error { error: Error },
}
```
## Added Reanchorable trait
Now both locations and assets implement this trait, making it easier to
reanchor both.
## New syntax for building locations and junctions
Now junctions are built using the following methods:
```rust
let location = Location {
parents: 1,
interior: [Parachain(1000), PalletInstance(50), GeneralIndex(1984)].into()
};
```
or
```rust
let location = Location::new(1, [Parachain(1000), PalletInstance(50), GeneralIndex(1984)]);
```
And they are matched like so:
```rust
match location.unpack() {
(1, [Parachain(id)]) => ...
(0, Here) => ...,
(1, [_]) => ...,
}
```
This syntax is mandatory in v4, and has been also implemented for v2 and
v3 for easier migration.
This was needed to make all sizes smaller.
# TODO
- [x] Scaffold v4
- [x] Port github.com/paritytech/polkadot/pull/7236
- [x] Remove `Multi` prefix
- [x] Remove `Abstract` asset id
---------
Co-authored-by: command-bot <>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
192 lines
5.4 KiB
Rust
192 lines
5.4 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn simple_version_subscriptions_should_work() {
|
|
AllowSubsFrom::set(vec![Parent.into()]);
|
|
|
|
let origin = Parachain(1000);
|
|
let message = Xcm::<TestCall>(vec![
|
|
SetAppendix(Xcm(vec![])),
|
|
SubscribeVersion { query_id: 42, max_response_weight: Weight::from_parts(5000, 5000) },
|
|
]);
|
|
let mut hash = fake_message_hash(&message);
|
|
let weight_limit = Weight::from_parts(20, 20);
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
origin,
|
|
message,
|
|
&mut hash,
|
|
weight_limit,
|
|
Weight::zero(),
|
|
);
|
|
assert_eq!(r, Outcome::Error { error: XcmError::Barrier });
|
|
|
|
let origin = Parachain(1000);
|
|
let message = Xcm::<TestCall>(vec![SubscribeVersion {
|
|
query_id: 42,
|
|
max_response_weight: Weight::from_parts(5000, 5000),
|
|
}]);
|
|
let mut hash = fake_message_hash(&message);
|
|
let weight_limit = Weight::from_parts(10, 10);
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
origin,
|
|
message.clone(),
|
|
&mut hash,
|
|
weight_limit,
|
|
Weight::zero(),
|
|
);
|
|
assert_eq!(r, Outcome::Error { error: XcmError::Barrier });
|
|
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
Parent,
|
|
message,
|
|
&mut hash,
|
|
weight_limit,
|
|
Weight::zero(),
|
|
);
|
|
assert_eq!(r, Outcome::Complete { used: Weight::from_parts(10, 10) });
|
|
|
|
assert_eq!(
|
|
SubscriptionRequests::get(),
|
|
vec![(Parent.into(), Some((42, Weight::from_parts(5000, 5000))))]
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn version_subscription_instruction_should_work() {
|
|
let origin = Parachain(1000);
|
|
let message = Xcm::<TestCall>(vec![
|
|
DescendOrigin([AccountIndex64 { index: 1, network: None }].into()),
|
|
SubscribeVersion { query_id: 42, max_response_weight: Weight::from_parts(5000, 5000) },
|
|
]);
|
|
let mut hash = fake_message_hash(&message);
|
|
let weight_limit = Weight::from_parts(20, 20);
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
origin,
|
|
message,
|
|
&mut hash,
|
|
weight_limit,
|
|
weight_limit,
|
|
);
|
|
assert_eq!(
|
|
r,
|
|
Outcome::Incomplete { used: Weight::from_parts(20, 20), error: XcmError::BadOrigin }
|
|
);
|
|
|
|
let message = Xcm::<TestCall>(vec![
|
|
SetAppendix(Xcm(vec![])),
|
|
SubscribeVersion { query_id: 42, max_response_weight: Weight::from_parts(5000, 5000) },
|
|
]);
|
|
let mut hash = fake_message_hash(&message);
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
origin,
|
|
message,
|
|
&mut hash,
|
|
weight_limit,
|
|
weight_limit,
|
|
);
|
|
assert_eq!(r, Outcome::Complete { used: Weight::from_parts(20, 20) });
|
|
|
|
assert_eq!(
|
|
SubscriptionRequests::get(),
|
|
vec![(Parachain(1000).into(), Some((42, Weight::from_parts(5000, 5000))))]
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn simple_version_unsubscriptions_should_work() {
|
|
AllowSubsFrom::set(vec![Parent.into()]);
|
|
|
|
let origin = Parachain(1000);
|
|
let message = Xcm::<TestCall>(vec![SetAppendix(Xcm(vec![])), UnsubscribeVersion]);
|
|
let mut hash = fake_message_hash(&message);
|
|
let weight_limit = Weight::from_parts(20, 20);
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
origin,
|
|
message,
|
|
&mut hash,
|
|
weight_limit,
|
|
Weight::zero(),
|
|
);
|
|
assert_eq!(r, Outcome::Error { error: XcmError::Barrier });
|
|
|
|
let origin = Parachain(1000);
|
|
let message = Xcm::<TestCall>(vec![UnsubscribeVersion]);
|
|
let mut hash = fake_message_hash(&message);
|
|
let weight_limit = Weight::from_parts(10, 10);
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
origin,
|
|
message.clone(),
|
|
&mut hash,
|
|
weight_limit,
|
|
Weight::zero(),
|
|
);
|
|
assert_eq!(r, Outcome::Error { error: XcmError::Barrier });
|
|
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
Parent,
|
|
message,
|
|
&mut hash,
|
|
weight_limit,
|
|
Weight::zero(),
|
|
);
|
|
assert_eq!(r, Outcome::Complete { used: Weight::from_parts(10, 10) });
|
|
|
|
assert_eq!(SubscriptionRequests::get(), vec![(Parent.into(), None)]);
|
|
assert_eq!(sent_xcm(), vec![]);
|
|
}
|
|
|
|
#[test]
|
|
fn version_unsubscription_instruction_should_work() {
|
|
let origin = Parachain(1000);
|
|
|
|
// Not allowed to do it when origin has been changed.
|
|
let message = Xcm::<TestCall>(vec![
|
|
DescendOrigin([AccountIndex64 { index: 1, network: None }].into()),
|
|
UnsubscribeVersion,
|
|
]);
|
|
let mut hash = fake_message_hash(&message);
|
|
let weight_limit = Weight::from_parts(20, 20);
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
origin,
|
|
message,
|
|
&mut hash,
|
|
weight_limit,
|
|
weight_limit,
|
|
);
|
|
assert_eq!(
|
|
r,
|
|
Outcome::Incomplete { used: Weight::from_parts(20, 20), error: XcmError::BadOrigin }
|
|
);
|
|
|
|
// Fine to do it when origin is untouched.
|
|
let message = Xcm::<TestCall>(vec![SetAppendix(Xcm(vec![])), UnsubscribeVersion]);
|
|
let mut hash = fake_message_hash(&message);
|
|
let r = XcmExecutor::<TestConfig>::prepare_and_execute(
|
|
origin,
|
|
message,
|
|
&mut hash,
|
|
weight_limit,
|
|
weight_limit,
|
|
);
|
|
assert_eq!(r, Outcome::Complete { used: Weight::from_parts(20, 20) });
|
|
|
|
assert_eq!(SubscriptionRequests::get(), vec![(Parachain(1000).into(), None)]);
|
|
assert_eq!(sent_xcm(), vec![]);
|
|
}
|