mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-22 01:01:03 +00:00
Dastan
e54279699b
closes #1324 #### Problem Currently, it is possible to accidentally use inner unversioned migration instead of `VersionedMigration` since both implement `OnRuntimeUpgrade`. #### Solution With this change, we make it clear that value of `Inner` is not intended to be used directly. It is achieved by bounding `Inner` to new trait `UncheckedOnRuntimeUpgrade`, which has the same interface (except `unchecked_` prefix) as `OnRuntimeUpgrade`. #### `try-runtime` functions Since developers can implement `try-runtime` for `Inner` value in `VersionedMigration` and have custom logic for it, I added the same `try-runtime` functions to `UncheckedOnRuntimeUpgrade`. I looked for a ways to not duplicate functions, but couldn't find anything that doesn't significantly change the codebase. So I would appreciate If you have any suggestions to improve this cc @liamaharon @xlc polkadot address: 16FqwPZ8GRC5U5D4Fu7W33nA55ZXzXGWHwmbnE1eT6pxuqcT --------- Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
73 lines
2.7 KiB
Rust
73 lines
2.7 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
use super::{Config, MaxPermanentSlots, MaxTemporarySlots, Pallet, LOG_TARGET};
|
|
use frame_support::traits::{Get, GetStorageVersion, UncheckedOnRuntimeUpgrade};
|
|
|
|
#[cfg(feature = "try-runtime")]
|
|
use frame_support::ensure;
|
|
#[cfg(feature = "try-runtime")]
|
|
use sp_std::vec::Vec;
|
|
|
|
pub mod v1 {
|
|
use super::*;
|
|
pub struct VersionUncheckedMigrateToV1<T>(sp_std::marker::PhantomData<T>);
|
|
impl<T: Config> UncheckedOnRuntimeUpgrade for VersionUncheckedMigrateToV1<T> {
|
|
#[cfg(feature = "try-runtime")]
|
|
fn pre_upgrade() -> Result<Vec<u8>, sp_runtime::TryRuntimeError> {
|
|
let on_chain_version = Pallet::<T>::on_chain_storage_version();
|
|
ensure!(on_chain_version < 1, "assigned_slots::MigrateToV1 migration can be deleted");
|
|
Ok(Default::default())
|
|
}
|
|
|
|
fn on_runtime_upgrade() -> frame_support::weights::Weight {
|
|
let on_chain_version = Pallet::<T>::on_chain_storage_version();
|
|
if on_chain_version < 1 {
|
|
const MAX_PERMANENT_SLOTS: u32 = 100;
|
|
const MAX_TEMPORARY_SLOTS: u32 = 100;
|
|
|
|
<MaxPermanentSlots<T>>::put(MAX_PERMANENT_SLOTS);
|
|
<MaxTemporarySlots<T>>::put(MAX_TEMPORARY_SLOTS);
|
|
// Return the weight consumed by the migration.
|
|
T::DbWeight::get().reads_writes(1, 3)
|
|
} else {
|
|
log::info!(target: LOG_TARGET, "MigrateToV1 should be removed");
|
|
T::DbWeight::get().reads(1)
|
|
}
|
|
}
|
|
|
|
#[cfg(feature = "try-runtime")]
|
|
fn post_upgrade(_state: Vec<u8>) -> Result<(), sp_runtime::TryRuntimeError> {
|
|
let on_chain_version = Pallet::<T>::on_chain_storage_version();
|
|
ensure!(on_chain_version == 1, "assigned_slots::MigrateToV1 needs to be run");
|
|
assert_eq!(<MaxPermanentSlots<T>>::get(), 100);
|
|
assert_eq!(<MaxTemporarySlots<T>>::get(), 100);
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
/// [`VersionUncheckedMigrateToV1`] wrapped in a
|
|
/// [`VersionedMigration`](frame_support::migrations::VersionedMigration), ensuring the
|
|
/// migration is only performed when on-chain version is 0.
|
|
pub type MigrateToV1<T> = frame_support::migrations::VersionedMigration<
|
|
0,
|
|
1,
|
|
VersionUncheckedMigrateToV1<T>,
|
|
Pallet<T>,
|
|
<T as frame_system::Config>::DbWeight,
|
|
>;
|
|
}
|