mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-13 08:05:50 +00:00
00b85c51df
helps https://github.com/paritytech/polkadot-sdk/issues/439. closes https://github.com/paritytech/polkadot-sdk/issues/473. PR link in the older substrate repository: https://github.com/paritytech/substrate/pull/13498. # Context Rewards payout is processed today in a single block and limited to `MaxNominatorRewardedPerValidator`. This number is currently 512 on both Kusama and Polkadot. This PR tries to scale the nominators payout to an unlimited count in a multi-block fashion. Exposures are stored in pages, with each page capped to a certain number (`MaxExposurePageSize`). Starting out, this number would be the same as `MaxNominatorRewardedPerValidator`, but eventually, this number can be lowered through new runtime upgrades to limit the rewardeable nominators per dispatched call instruction. The changes in the PR are backward compatible. ## How payouts would work like after this change Staking exposes two calls, 1) the existing `payout_stakers` and 2) `payout_stakers_by_page`. ### payout_stakers This remains backward compatible with no signature change. If for a given era a validator has multiple pages, they can call `payout_stakers` multiple times. The pages are executed in an ascending sequence and the runtime takes care of preventing double claims. ### payout_stakers_by_page Very similar to `payout_stakers` but also accepts an extra param `page_index`. An account can choose to payout rewards only for an explicitly passed `page_index`. **Lets look at an example scenario** Given an active validator on Kusama had 1100 nominators, `MaxExposurePageSize` set to 512 for Era e. In order to pay out rewards to all nominators, the caller would need to call `payout_stakers` 3 times. - `payout_stakers(origin, stash, e)` => will pay the first 512 nominators. - `payout_stakers(origin, stash, e)` => will pay the second set of 512 nominators. - `payout_stakers(origin, stash, e)` => will pay the last set of 76 nominators. ... - `payout_stakers(origin, stash, e)` => calling it the 4th time would return an error `InvalidPage`. The above calls can also be replaced by `payout_stakers_by_page` and passing a `page_index` explicitly. ## Commission note Validator commission is paid out in chunks across all the pages where each commission chunk is proportional to the total stake of the current page. This implies higher the total stake of a page, higher will be the commission. If all the pages of a validator's single era are paid out, the sum of commission paid to the validator across all pages should be equal to what the commission would have been if we had a non-paged exposure. ### Migration Note Strictly speaking, we did not need to bump our storage version since there is no migration of storage in this PR. But it is still useful to mark a storage upgrade for the following reasons: - New storage items are introduced in this PR while some older storage items are deprecated. - For the next `HistoryDepth` eras, the exposure would be incrementally migrated to its corresponding paged storage item. - Runtimes using staking pallet would strictly need to wait at least `HistoryDepth` eras with current upgraded version (14) for the migration to complete. At some era `E` such that `E > era_at_which_V14_gets_into_effect + HistoryDepth`, we will upgrade to version X which will remove the deprecated storage items. In other words, it is a strict requirement that E<sub>x</sub> - E<sub>14</sub> > `HistoryDepth`, where E<sub>x</sub> = Era at which deprecated storages are removed from runtime, E<sub>14</sub> = Era at which runtime is upgraded to version 14. - For Polkadot and Kusama, there is a [tracker ticket](https://github.com/paritytech/polkadot-sdk/issues/433) to clean up the deprecated storage items. ### Storage Changes #### Added - ErasStakersOverview - ClaimedRewards - ErasStakersPaged #### Deprecated The following can be cleaned up after 84 eras which is tracked [here](https://github.com/paritytech/polkadot-sdk/issues/433). - ErasStakers. - ErasStakersClipped. - StakingLedger.claimed_rewards, renamed to StakingLedger.legacy_claimed_rewards. ### Config Changes - Renamed MaxNominatorRewardedPerValidator to MaxExposurePageSize. ### TODO - [x] Tracker ticket for cleaning up the old code after 84 eras. - [x] Add companion. - [x] Redo benchmarks before merge. - [x] Add Changelog for pallet_staking. - [x] Pallet should be configurable to enable/disable paged rewards. - [x] Commission payouts are distributed across pages. - [x] Review documentation thoroughly. - [x] Rename `MaxNominatorRewardedPerValidator` -> `MaxExposurePageSize`. - [x] NMap for `ErasStakersPaged`. - [x] Deprecate ErasStakers. - [x] Integrity tests. ### Followup issues [Runtime api for deprecated ErasStakers storage item](https://github.com/paritytech/polkadot-sdk/issues/426) --------- Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: command-bot <>
351 lines
10 KiB
Rust
351 lines
10 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use super::*;
|
|
use crate as root_offences;
|
|
|
|
use frame_election_provider_support::{
|
|
bounds::{ElectionBounds, ElectionBoundsBuilder},
|
|
onchain, SequentialPhragmen,
|
|
};
|
|
use frame_support::{
|
|
parameter_types,
|
|
traits::{ConstU32, ConstU64, Hooks, OneSessionHandler},
|
|
};
|
|
use pallet_staking::StakerStatus;
|
|
use sp_core::H256;
|
|
use sp_runtime::{
|
|
curve::PiecewiseLinear,
|
|
testing::UintAuthorityId,
|
|
traits::{BlakeTwo256, IdentityLookup, Zero},
|
|
BuildStorage,
|
|
};
|
|
use sp_staking::{EraIndex, SessionIndex};
|
|
use sp_std::collections::btree_map::BTreeMap;
|
|
|
|
type Block = frame_system::mocking::MockBlock<Test>;
|
|
type AccountId = u64;
|
|
type Balance = u64;
|
|
type BlockNumber = u64;
|
|
|
|
pub const INIT_TIMESTAMP: u64 = 30_000;
|
|
pub const BLOCK_TIME: u64 = 1000;
|
|
|
|
frame_support::construct_runtime!(
|
|
pub enum Test
|
|
{
|
|
System: frame_system::{Pallet, Call, Config<T>, Storage, Event<T>},
|
|
Timestamp: pallet_timestamp::{Pallet, Call, Storage, Inherent},
|
|
Balances: pallet_balances::{Pallet, Call, Storage, Config<T>, Event<T>},
|
|
Staking: pallet_staking::{Pallet, Call, Config<T>, Storage, Event<T>},
|
|
Session: pallet_session::{Pallet, Call, Storage, Event, Config<T>},
|
|
RootOffences: root_offences::{Pallet, Call, Storage, Event<T>},
|
|
Historical: pallet_session::historical::{Pallet, Storage},
|
|
}
|
|
);
|
|
|
|
/// Another session handler struct to test on_disabled.
|
|
pub struct OtherSessionHandler;
|
|
impl OneSessionHandler<AccountId> for OtherSessionHandler {
|
|
type Key = UintAuthorityId;
|
|
|
|
fn on_genesis_session<'a, I: 'a>(_: I)
|
|
where
|
|
I: Iterator<Item = (&'a AccountId, Self::Key)>,
|
|
AccountId: 'a,
|
|
{
|
|
}
|
|
|
|
fn on_new_session<'a, I: 'a>(_: bool, _: I, _: I)
|
|
where
|
|
I: Iterator<Item = (&'a AccountId, Self::Key)>,
|
|
AccountId: 'a,
|
|
{
|
|
}
|
|
|
|
fn on_disabled(_validator_index: u32) {}
|
|
}
|
|
|
|
impl sp_runtime::BoundToRuntimeAppPublic for OtherSessionHandler {
|
|
type Public = UintAuthorityId;
|
|
}
|
|
|
|
impl frame_system::Config for Test {
|
|
type BaseCallFilter = frame_support::traits::Everything;
|
|
type BlockWeights = ();
|
|
type BlockLength = ();
|
|
type DbWeight = ();
|
|
type RuntimeOrigin = RuntimeOrigin;
|
|
type Nonce = u64;
|
|
type Hash = H256;
|
|
type RuntimeCall = RuntimeCall;
|
|
type Hashing = BlakeTwo256;
|
|
type AccountId = u64;
|
|
type Lookup = IdentityLookup<Self::AccountId>;
|
|
type Block = Block;
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type BlockHashCount = ConstU64<250>;
|
|
type Version = ();
|
|
type PalletInfo = PalletInfo;
|
|
type AccountData = pallet_balances::AccountData<u64>;
|
|
type OnNewAccount = ();
|
|
type OnKilledAccount = ();
|
|
type SystemWeightInfo = ();
|
|
type SS58Prefix = ();
|
|
type OnSetCode = ();
|
|
type MaxConsumers = ConstU32<16>;
|
|
}
|
|
|
|
impl pallet_balances::Config for Test {
|
|
type MaxLocks = ();
|
|
type MaxReserves = ();
|
|
type ReserveIdentifier = [u8; 8];
|
|
type Balance = Balance;
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type DustRemoval = ();
|
|
type ExistentialDeposit = ConstU64<1>;
|
|
type AccountStore = System;
|
|
type WeightInfo = ();
|
|
type FreezeIdentifier = ();
|
|
type MaxFreezes = ();
|
|
type RuntimeHoldReason = ();
|
|
type RuntimeFreezeReason = ();
|
|
type MaxHolds = ();
|
|
}
|
|
|
|
pallet_staking_reward_curve::build! {
|
|
const REWARD_CURVE: PiecewiseLinear<'static> = curve!(
|
|
min_inflation: 0_025_000u64,
|
|
max_inflation: 0_100_000,
|
|
ideal_stake: 0_500_000,
|
|
falloff: 0_050_000,
|
|
max_piece_count: 40,
|
|
test_precision: 0_005_000,
|
|
);
|
|
}
|
|
|
|
parameter_types! {
|
|
pub static ElectionsBounds: ElectionBounds = ElectionBoundsBuilder::default().build();
|
|
}
|
|
|
|
pub struct OnChainSeqPhragmen;
|
|
impl onchain::Config for OnChainSeqPhragmen {
|
|
type System = Test;
|
|
type Solver = SequentialPhragmen<AccountId, Perbill>;
|
|
type DataProvider = Staking;
|
|
type WeightInfo = ();
|
|
type MaxWinners = ConstU32<100>;
|
|
type Bounds = ElectionsBounds;
|
|
}
|
|
|
|
parameter_types! {
|
|
pub const RewardCurve: &'static PiecewiseLinear<'static> = &REWARD_CURVE;
|
|
pub static Offset: BlockNumber = 0;
|
|
pub const Period: BlockNumber = 1;
|
|
pub static SessionsPerEra: SessionIndex = 3;
|
|
pub static SlashDeferDuration: EraIndex = 0;
|
|
pub const BondingDuration: EraIndex = 3;
|
|
pub static LedgerSlashPerEra: (BalanceOf<Test>, BTreeMap<EraIndex, BalanceOf<Test>>) = (Zero::zero(), BTreeMap::new());
|
|
pub const OffendingValidatorsThreshold: Perbill = Perbill::from_percent(75);
|
|
}
|
|
|
|
impl pallet_staking::Config for Test {
|
|
type Currency = Balances;
|
|
type CurrencyBalance = <Self as pallet_balances::Config>::Balance;
|
|
type UnixTime = Timestamp;
|
|
type CurrencyToVote = ();
|
|
type RewardRemainder = ();
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type Slash = ();
|
|
type Reward = ();
|
|
type SessionsPerEra = SessionsPerEra;
|
|
type SlashDeferDuration = SlashDeferDuration;
|
|
type AdminOrigin = frame_system::EnsureRoot<Self::AccountId>;
|
|
type BondingDuration = BondingDuration;
|
|
type SessionInterface = Self;
|
|
type EraPayout = pallet_staking::ConvertCurve<RewardCurve>;
|
|
type NextNewSession = Session;
|
|
type MaxExposurePageSize = ConstU32<64>;
|
|
type OffendingValidatorsThreshold = OffendingValidatorsThreshold;
|
|
type ElectionProvider = onchain::OnChainExecution<OnChainSeqPhragmen>;
|
|
type GenesisElectionProvider = Self::ElectionProvider;
|
|
type TargetList = pallet_staking::UseValidatorsMap<Self>;
|
|
type NominationsQuota = pallet_staking::FixedNominationsQuota<16>;
|
|
type MaxUnlockingChunks = ConstU32<32>;
|
|
type HistoryDepth = ConstU32<84>;
|
|
type VoterList = pallet_staking::UseNominatorsAndValidatorsMap<Self>;
|
|
type EventListeners = ();
|
|
type BenchmarkingConfig = pallet_staking::TestBenchmarkingConfig;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl pallet_session::historical::Config for Test {
|
|
type FullIdentification = pallet_staking::Exposure<AccountId, Balance>;
|
|
type FullIdentificationOf = pallet_staking::ExposureOf<Test>;
|
|
}
|
|
|
|
sp_runtime::impl_opaque_keys! {
|
|
pub struct SessionKeys {
|
|
pub other: OtherSessionHandler,
|
|
}
|
|
}
|
|
|
|
impl pallet_session::Config for Test {
|
|
type SessionManager = pallet_session::historical::NoteHistoricalRoot<Test, Staking>;
|
|
type Keys = SessionKeys;
|
|
type ShouldEndSession = pallet_session::PeriodicSessions<Period, Offset>;
|
|
type SessionHandler = (OtherSessionHandler,);
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type ValidatorId = AccountId;
|
|
type ValidatorIdOf = pallet_staking::StashOf<Test>;
|
|
type NextSessionRotation = pallet_session::PeriodicSessions<Period, Offset>;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl pallet_timestamp::Config for Test {
|
|
type Moment = u64;
|
|
type OnTimestampSet = ();
|
|
type MinimumPeriod = ConstU64<5>;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl Config for Test {
|
|
type RuntimeEvent = RuntimeEvent;
|
|
}
|
|
|
|
pub struct ExtBuilder {
|
|
validator_count: u32,
|
|
minimum_validator_count: u32,
|
|
invulnerables: Vec<AccountId>,
|
|
balance_factor: Balance,
|
|
}
|
|
|
|
impl Default for ExtBuilder {
|
|
fn default() -> Self {
|
|
Self {
|
|
validator_count: 2,
|
|
minimum_validator_count: 0,
|
|
invulnerables: vec![],
|
|
balance_factor: 1,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl ExtBuilder {
|
|
fn build(self) -> sp_io::TestExternalities {
|
|
let mut storage = frame_system::GenesisConfig::<Test>::default().build_storage().unwrap();
|
|
|
|
pallet_balances::GenesisConfig::<Test> {
|
|
balances: vec![
|
|
// controllers (still used in some tests. Soon to be deprecated).
|
|
(10, self.balance_factor * 50),
|
|
(20, self.balance_factor * 50),
|
|
(30, self.balance_factor * 50),
|
|
(40, self.balance_factor * 50),
|
|
// stashes
|
|
(11, self.balance_factor * 1000),
|
|
(21, self.balance_factor * 1000),
|
|
(31, self.balance_factor * 500),
|
|
(41, self.balance_factor * 1000),
|
|
],
|
|
}
|
|
.assimilate_storage(&mut storage)
|
|
.unwrap();
|
|
|
|
let stakers = vec![
|
|
// (stash, ctrl, stake, status)
|
|
// these two will be elected in the default test where we elect 2.
|
|
(11, 11, 1000, StakerStatus::<AccountId>::Validator),
|
|
(21, 21, 1000, StakerStatus::<AccountId>::Validator),
|
|
// a loser validator
|
|
(31, 31, 500, StakerStatus::<AccountId>::Validator),
|
|
// an idle validator
|
|
(41, 41, 1000, StakerStatus::<AccountId>::Idle),
|
|
];
|
|
|
|
let _ = pallet_staking::GenesisConfig::<Test> {
|
|
stakers: stakers.clone(),
|
|
..Default::default()
|
|
};
|
|
|
|
let _ = pallet_staking::GenesisConfig::<Test> {
|
|
stakers: stakers.clone(),
|
|
validator_count: self.validator_count,
|
|
minimum_validator_count: self.minimum_validator_count,
|
|
invulnerables: self.invulnerables,
|
|
slash_reward_fraction: Perbill::from_percent(10),
|
|
..Default::default()
|
|
}
|
|
.assimilate_storage(&mut storage);
|
|
|
|
let _ = pallet_session::GenesisConfig::<Test> {
|
|
keys: stakers
|
|
.into_iter()
|
|
.map(|(id, ..)| (id, id, SessionKeys { other: id.into() }))
|
|
.collect(),
|
|
}
|
|
.assimilate_storage(&mut storage);
|
|
|
|
storage.into()
|
|
}
|
|
|
|
pub fn build_and_execute(self, test: impl FnOnce() -> ()) {
|
|
let mut ext = self.build();
|
|
ext.execute_with(test);
|
|
}
|
|
}
|
|
|
|
/// Progresses from the current block number (whatever that may be) to the `P * session_index + 1`.
|
|
pub(crate) fn start_session(session_index: SessionIndex) {
|
|
let end: u64 = if Offset::get().is_zero() {
|
|
(session_index as u64) * Period::get()
|
|
} else {
|
|
Offset::get() + (session_index.saturating_sub(1) as u64) * Period::get()
|
|
};
|
|
run_to_block(end);
|
|
// session must have progressed properly.
|
|
assert_eq!(
|
|
Session::current_index(),
|
|
session_index,
|
|
"current session index = {}, expected = {}",
|
|
Session::current_index(),
|
|
session_index,
|
|
);
|
|
}
|
|
|
|
/// Progress to the given block, triggering session and era changes as we progress.
|
|
///
|
|
/// This will finalize the previous block, initialize up to the given block, essentially simulating
|
|
/// a block import/propose process where we first initialize the block, then execute some stuff (not
|
|
/// in the function), and then finalize the block.
|
|
pub(crate) fn run_to_block(n: BlockNumber) {
|
|
Staking::on_finalize(System::block_number());
|
|
for b in (System::block_number() + 1)..=n {
|
|
System::set_block_number(b);
|
|
Session::on_initialize(b);
|
|
<Staking as Hooks<u64>>::on_initialize(b);
|
|
Timestamp::set_timestamp(System::block_number() * BLOCK_TIME + INIT_TIMESTAMP);
|
|
if b != n {
|
|
Staking::on_finalize(System::block_number());
|
|
}
|
|
}
|
|
}
|
|
|
|
pub(crate) fn active_era() -> EraIndex {
|
|
Staking::active_era().unwrap().index
|
|
}
|