mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-06 05:38:00 +00:00
Branislav Kontur
3d9439f646
## Problem During the bumping of the `polkadot-fellows` repository to `polkadot-sdk@1.6.0`, I encountered a situation where the benchmarks `teleport_assets` and `reserve_transfer_assets` in AssetHubKusama started to fail. This issue arose due to a decreased ED balance for AssetHubs introduced [here](https://github.com/polkadot-fellows/runtimes/pull/158/files#diff-80668ff8e793b64f36a9a3ec512df5cbca4ad448c157a5d81abda1b15f35f1daR213), and also because of a [missing CI pipeline](https://github.com/polkadot-fellows/runtimes/issues/197) to check the benchmarks, which went unnoticed. These benchmarks expect the `caller` to have enough: 1. balance to transfer (BTT) 2. balance for paying delivery (BFPD). So the initial balance was calculated as `ED * 100`, which seems reasonable: ``` const ED_MULTIPLIER: u32 = 100; let balance = existential_deposit.saturating_mul(ED_MULTIPLIER.into());` ``` The problem arises when the price for delivery is 100 times higher than the existential deposit. In other words, when `ED * 100` does not cover `BTT` + `BFPD`. I check AHR/AHW/AHK/AHP and this problem has only AssetHubKusama ``` ED: 3333333 calculated price to parent delivery: 1031666634 (from xcm logs from the benchmark) --- 3333333 * 100 - BTT(3333333) - BFPD(1031666634) = −701666667 ``` which results in the error; ``` 2024-02-23 09:19:42 Unable to charge fee with error Module(ModuleError { index: 31, error: [17, 0, 0, 0], message: Some("FeesNotMet") }) Error: Input("Benchmark pallet_xcm::reserve_transfer_assets failed: FeesNotMet") ``` ## Solution The benchmarks `teleport_assets` and `reserve_transfer_assets` were fixed by removing `ED * 100` and replacing it with `DeliveryHelper` logic, which calculates the (almost real) price for delivery and sets it along with the existential deposit as the initial balance for the account used in the benchmark. ## TODO - [ ] patch for 1.6 - https://github.com/paritytech/polkadot-sdk/pull/3466 - [ ] patch for 1.7 - https://github.com/paritytech/polkadot-sdk/pull/3465 - [ ] patch for 1.8 - TODO: PR --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
122 lines
4.7 KiB
TOML
122 lines
4.7 KiB
TOML
[package]
|
|
name = "cumulus-pallet-parachain-system"
|
|
version = "0.7.0"
|
|
authors.workspace = true
|
|
edition.workspace = true
|
|
description = "Base pallet for cumulus-based parachains"
|
|
license = "Apache-2.0"
|
|
|
|
[lints]
|
|
workspace = true
|
|
|
|
[dependencies]
|
|
bytes = { version = "1.4.0", default-features = false }
|
|
codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
|
|
environmental = { version = "1.1.4", default-features = false }
|
|
impl-trait-for-tuples = "0.2.1"
|
|
log = { workspace = true }
|
|
trie-db = { version = "0.28.0", default-features = false }
|
|
scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
|
|
|
|
# Substrate
|
|
frame-benchmarking = { path = "../../../substrate/frame/benchmarking", default-features = false, optional = true }
|
|
frame-support = { path = "../../../substrate/frame/support", default-features = false }
|
|
frame-system = { path = "../../../substrate/frame/system", default-features = false }
|
|
pallet-message-queue = { path = "../../../substrate/frame/message-queue", default-features = false }
|
|
sp-core = { path = "../../../substrate/primitives/core", default-features = false }
|
|
sp-externalities = { path = "../../../substrate/primitives/externalities", default-features = false }
|
|
sp-inherents = { path = "../../../substrate/primitives/inherents", default-features = false }
|
|
sp-io = { path = "../../../substrate/primitives/io", default-features = false }
|
|
sp-runtime = { path = "../../../substrate/primitives/runtime", default-features = false }
|
|
sp-state-machine = { path = "../../../substrate/primitives/state-machine", default-features = false }
|
|
sp-std = { path = "../../../substrate/primitives/std", default-features = false }
|
|
sp-trie = { path = "../../../substrate/primitives/trie", default-features = false }
|
|
sp-version = { path = "../../../substrate/primitives/version", default-features = false }
|
|
|
|
# Polkadot
|
|
polkadot-parachain-primitives = { path = "../../../polkadot/parachain", default-features = false, features = ["wasm-api"] }
|
|
polkadot-runtime-parachains = { path = "../../../polkadot/runtime/parachains", default-features = false }
|
|
polkadot-runtime-common = { path = "../../../polkadot/runtime/common", default-features = false, optional = true }
|
|
xcm = { package = "staging-xcm", path = "../../../polkadot/xcm", default-features = false }
|
|
|
|
# Cumulus
|
|
cumulus-pallet-parachain-system-proc-macro = { path = "proc-macro", default-features = false }
|
|
cumulus-primitives-core = { path = "../../primitives/core", default-features = false }
|
|
cumulus-primitives-parachain-inherent = { path = "../../primitives/parachain-inherent", default-features = false }
|
|
cumulus-primitives-proof-size-hostfunction = { path = "../../primitives/proof-size-hostfunction", default-features = false }
|
|
|
|
[dev-dependencies]
|
|
assert_matches = "1.5"
|
|
hex-literal = "0.4.1"
|
|
lazy_static = "1.4"
|
|
trie-standardmap = "0.16.0"
|
|
rand = "0.8.5"
|
|
futures = "0.3.28"
|
|
|
|
# Substrate
|
|
sc-client-api = { path = "../../../substrate/client/api" }
|
|
sp-keyring = { path = "../../../substrate/primitives/keyring" }
|
|
sp-crypto-hashing = { path = "../../../substrate/primitives/crypto/hashing" }
|
|
sp-tracing = { path = "../../../substrate/primitives/tracing" }
|
|
sp-version = { path = "../../../substrate/primitives/version" }
|
|
|
|
# Cumulus
|
|
cumulus-test-client = { path = "../../test/client" }
|
|
cumulus-test-relay-sproof-builder = { path = "../../test/relay-sproof-builder" }
|
|
|
|
[features]
|
|
default = ["std"]
|
|
std = [
|
|
"bytes/std",
|
|
"codec/std",
|
|
"cumulus-pallet-parachain-system-proc-macro/std",
|
|
"cumulus-primitives-core/std",
|
|
"cumulus-primitives-parachain-inherent/std",
|
|
"cumulus-primitives-proof-size-hostfunction/std",
|
|
"environmental/std",
|
|
"frame-benchmarking/std",
|
|
"frame-support/std",
|
|
"frame-system/std",
|
|
"log/std",
|
|
"pallet-message-queue/std",
|
|
"polkadot-parachain-primitives/std",
|
|
"polkadot-runtime-common/std",
|
|
"polkadot-runtime-parachains/std",
|
|
"scale-info/std",
|
|
"sp-core/std",
|
|
"sp-externalities/std",
|
|
"sp-inherents/std",
|
|
"sp-io/std",
|
|
"sp-runtime/std",
|
|
"sp-state-machine/std",
|
|
"sp-std/std",
|
|
"sp-tracing/std",
|
|
"sp-trie/std",
|
|
"trie-db/std",
|
|
"xcm/std",
|
|
]
|
|
|
|
runtime-benchmarks = [
|
|
"cumulus-primitives-core/runtime-benchmarks",
|
|
"cumulus-test-client/runtime-benchmarks",
|
|
"frame-benchmarking/runtime-benchmarks",
|
|
"frame-support/runtime-benchmarks",
|
|
"frame-system/runtime-benchmarks",
|
|
"pallet-message-queue/runtime-benchmarks",
|
|
"polkadot-parachain-primitives/runtime-benchmarks",
|
|
"polkadot-runtime-common/runtime-benchmarks",
|
|
"polkadot-runtime-parachains/runtime-benchmarks",
|
|
"sp-runtime/runtime-benchmarks",
|
|
]
|
|
|
|
try-runtime = [
|
|
"frame-support/try-runtime",
|
|
"frame-system/try-runtime",
|
|
"pallet-message-queue/try-runtime",
|
|
"polkadot-runtime-common?/try-runtime",
|
|
"polkadot-runtime-parachains/try-runtime",
|
|
"sp-runtime/try-runtime",
|
|
]
|
|
|
|
parameterized-consensus-hook = []
|