Files
pezkuwi-subxt/substrate/node/rpc/src/accounts.rs
T
Svyatoslav Nikolsky 387c31598d Prepare for asynchronous transaction validation in tx pool (#3650)
* async txpool API

* Update core/rpc/src/author/mod.rs

Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* Update core/transaction-pool/graph/src/pool.rs

Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* Pool -> Pool + ValidatedPool

* removed lost block_on when importing xt from network

* fix grumbles

* alias for future::Executor in rpc

* removed executor from Author RPCs

* Pool + SharedValidatedPool -> Pool

* fix compilation after merge

* another fix

* another fix
2019-10-01 12:14:25 +03:00

156 lines
4.9 KiB
Rust

// Copyright 2019 Parity Technologies (UK) Ltd.
// This file is part of Substrate.
// Substrate is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// Substrate is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with Substrate. If not, see <http://www.gnu.org/licenses/>.
//! Node-specific RPC methods for Accounts.
use std::sync::Arc;
use client::blockchain::HeaderBackend;
use jsonrpc_core::{Result, Error, ErrorCode};
use jsonrpc_derive::rpc;
use node_primitives::{
AccountId, Index, AccountNonceApi, Block, BlockId,
};
use codec::Encode;
use sr_primitives::traits;
use substrate_primitives::hexdisplay::HexDisplay;
use transaction_pool::txpool::{self, Pool};
pub use self::gen_client::Client as AccountsClient;
/// Accounts RPC methods.
#[rpc]
pub trait AccountsApi {
/// Returns the next valid index (aka nonce) for given account.
///
/// This method takes into consideration all pending transactions
/// currently in the pool and if no transactions are found in the pool
/// it fallbacks to query the index from the runtime (aka. state nonce).
#[rpc(name = "account_nextIndex")]
fn nonce(&self, account: AccountId) -> Result<Index>;
}
/// An implementation of Accounts specific RPC methods.
pub struct Accounts<P: txpool::ChainApi, C> {
client: Arc<C>,
pool: Arc<Pool<P>>,
}
impl<P: txpool::ChainApi, C> Accounts<P, C> {
/// Create new `Accounts` given client and transaction pool.
pub fn new(client: Arc<C>, pool: Arc<Pool<P>>) -> Self {
Accounts {
client,
pool
}
}
}
impl<P, C> AccountsApi for Accounts<P, C>
where
C: traits::ProvideRuntimeApi,
C: HeaderBackend<Block>,
C: Send + Sync + 'static,
C::Api: AccountNonceApi<Block>,
P: txpool::ChainApi + Sync + Send + 'static,
{
fn nonce(&self, account: AccountId) -> Result<Index> {
let api = self.client.runtime_api();
let best = self.client.info().best_hash;
let at = BlockId::hash(best);
let nonce = api.account_nonce(&at, account.clone()).map_err(|e| Error {
code: ErrorCode::ServerError(crate::constants::RUNTIME_ERROR),
message: "Unable to query nonce.".into(),
data: Some(format!("{:?}", e).into()),
})?;
log::debug!(target: "rpc", "State nonce for {}: {}", account, nonce);
// Now we need to query the transaction pool
// and find transactions originating from the same sender.
//
// Since extrinsics are opaque to us, we look for them using
// `provides` tag. And increment the nonce if we find a transaction
// that matches the current one.
let mut current_nonce = nonce;
let mut current_tag = (account.clone(), nonce).encode();
for tx in self.pool.ready() {
log::debug!(
target: "rpc",
"Current nonce to {:?}, checking {} vs {:?}",
current_nonce,
HexDisplay::from(&current_tag),
tx.provides.iter().map(|x| format!("{}", HexDisplay::from(x))).collect::<Vec<_>>(),
);
// since transactions in `ready()` need to be ordered by nonce
// it's fine to continue with current iterator.
if tx.provides.get(0) == Some(&current_tag) {
current_nonce += 1;
current_tag = (account.clone(), current_nonce).encode();
}
}
Ok(current_nonce)
}
}
#[cfg(test)]
mod tests {
use super::*;
use futures03::executor::block_on;
use node_runtime::{CheckedExtrinsic, Call, TimestampCall};
use codec::Decode;
use node_testing::{
client::{ClientExt, TestClientBuilder, TestClientBuilderExt},
keyring::{self, alice, signed_extra},
};
const VERSION: u32 = node_runtime::VERSION.spec_version;
#[test]
fn should_return_next_nonce_for_some_account() {
// given
let _ = env_logger::try_init();
let client = Arc::new(TestClientBuilder::new().build());
let pool = Arc::new(Pool::new(Default::default(), transaction_pool::FullChainApi::new(client.clone())));
let new_transaction = |extra| {
let ex = CheckedExtrinsic {
signed: Some((alice().into(), extra)),
function: Call::Timestamp(TimestampCall::set(5)),
};
let xt = keyring::sign(ex, VERSION, client.genesis_hash().into());
// Convert to OpaqueExtrinsic
let encoded = xt.encode();
node_primitives::UncheckedExtrinsic::decode(&mut &*encoded).unwrap()
};
// Populate the pool
let ext0 = new_transaction(signed_extra(0, 0));
block_on(pool.submit_one(&BlockId::number(0), ext0)).unwrap();
let ext1 = new_transaction(signed_extra(1, 0));
block_on(pool.submit_one(&BlockId::number(0), ext1)).unwrap();
let accounts = Accounts::new(client, pool);
// when
let nonce = accounts.nonce(alice().into());
// then
assert_eq!(nonce.unwrap(), 2);
}
}