mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-10 13:27:30 +00:00
fd5f9292f5
Closes #2160 First part of [Extrinsic Horizon](https://github.com/paritytech/polkadot-sdk/issues/2415) Introduces a new trait `TransactionExtension` to replace `SignedExtension`. Introduce the idea of transactions which obey the runtime's extensions and have according Extension data (né Extra data) yet do not have hard-coded signatures. Deprecate the terminology of "Unsigned" when used for transactions/extrinsics owing to there now being "proper" unsigned transactions which obey the extension framework and "old-style" unsigned which do not. Instead we have __*General*__ for the former and __*Bare*__ for the latter. (Ultimately, the latter will be phased out as a type of transaction, and Bare will only be used for Inherents.) Types of extrinsic are now therefore: - Bare (no hardcoded signature, no Extra data; used to be known as "Unsigned") - Bare transactions (deprecated): Gossiped, validated with `ValidateUnsigned` (deprecated) and the `_bare_compat` bits of `TransactionExtension` (deprecated). - Inherents: Not gossiped, validated with `ProvideInherent`. - Extended (Extra data): Gossiped, validated via `TransactionExtension`. - Signed transactions (with a hardcoded signature). - General transactions (without a hardcoded signature). `TransactionExtension` differs from `SignedExtension` because: - A signature on the underlying transaction may validly not be present. - It may alter the origin during validation. - `pre_dispatch` is renamed to `prepare` and need not contain the checks present in `validate`. - `validate` and `prepare` is passed an `Origin` rather than a `AccountId`. - `validate` may pass arbitrary information into `prepare` via a new user-specifiable type `Val`. - `AdditionalSigned`/`additional_signed` is renamed to `Implicit`/`implicit`. It is encoded *for the entire transaction* and passed in to each extension as a new argument to `validate`. This facilitates the ability of extensions to acts as underlying crypto. There is a new `DispatchTransaction` trait which contains only default function impls and is impl'ed for any `TransactionExtension` impler. It provides several utility functions which reduce some of the tedium from using `TransactionExtension` (indeed, none of its regular functions should now need to be called directly). Three transaction version discriminator ("versions") are now permissible: - 0b000000100: Bare (used to be called "Unsigned"): contains Signature or Extra (extension data). After bare transactions are no longer supported, this will strictly identify an Inherents only. - 0b100000100: Old-school "Signed" Transaction: contains Signature and Extra (extension data). - 0b010000100: New-school "General" Transaction: contains Extra (extension data), but no Signature. For the New-school General Transaction, it becomes trivial for authors to publish extensions to the mechanism for authorizing an Origin, e.g. through new kinds of key-signing schemes, ZK proofs, pallet state, mutations over pre-authenticated origins or any combination of the above. ## Code Migration ### NOW: Getting it to build Wrap your `SignedExtension`s in `AsTransactionExtension`. This should be accompanied by renaming your aggregate type in line with the new terminology. E.g. Before: ```rust /// The SignedExtension to the basic transaction logic. pub type SignedExtra = ( /* snip */ MySpecialSignedExtension, ); /// Unchecked extrinsic type as expected by this runtime. pub type UncheckedExtrinsic = generic::UncheckedExtrinsic<Address, RuntimeCall, Signature, SignedExtra>; ``` After: ```rust /// The extension to the basic transaction logic. pub type TxExtension = ( /* snip */ AsTransactionExtension<MySpecialSignedExtension>, ); /// Unchecked extrinsic type as expected by this runtime. pub type UncheckedExtrinsic = generic::UncheckedExtrinsic<Address, RuntimeCall, Signature, TxExtension>; ``` You'll also need to alter any transaction building logic to add a `.into()` to make the conversion happen. E.g. Before: ```rust fn construct_extrinsic( /* snip */ ) -> UncheckedExtrinsic { let extra: SignedExtra = ( /* snip */ MySpecialSignedExtension::new(/* snip */), ); let payload = SignedPayload::new(call.clone(), extra.clone()).unwrap(); let signature = payload.using_encoded(|e| sender.sign(e)); UncheckedExtrinsic::new_signed( /* snip */ Signature::Sr25519(signature), extra, ) } ``` After: ```rust fn construct_extrinsic( /* snip */ ) -> UncheckedExtrinsic { let tx_ext: TxExtension = ( /* snip */ MySpecialSignedExtension::new(/* snip */).into(), ); let payload = SignedPayload::new(call.clone(), tx_ext.clone()).unwrap(); let signature = payload.using_encoded(|e| sender.sign(e)); UncheckedExtrinsic::new_signed( /* snip */ Signature::Sr25519(signature), tx_ext, ) } ``` ### SOON: Migrating to `TransactionExtension` Most `SignedExtension`s can be trivially converted to become a `TransactionExtension`. There are a few things to know. - Instead of a single trait like `SignedExtension`, you should now implement two traits individually: `TransactionExtensionBase` and `TransactionExtension`. - Weights are now a thing and must be provided via the new function `fn weight`. #### `TransactionExtensionBase` This trait takes care of anything which is not dependent on types specific to your runtime, most notably `Call`. - `AdditionalSigned`/`additional_signed` is renamed to `Implicit`/`implicit`. - Weight must be returned by implementing the `weight` function. If your extension is associated with a pallet, you'll probably want to do this via the pallet's existing benchmarking infrastructure. #### `TransactionExtension` Generally: - `pre_dispatch` is now `prepare` and you *should not reexecute the `validate` functionality in there*! - You don't get an account ID any more; you get an origin instead. If you need to presume an account ID, then you can use the trait function `AsSystemOriginSigner::as_system_origin_signer`. - You get an additional ticket, similar to `Pre`, called `Val`. This defines data which is passed from `validate` into `prepare`. This is important since you should not be duplicating logic from `validate` to `prepare`, you need a way of passing your working from the former into the latter. This is it. - This trait takes two type parameters: `Call` and `Context`. `Call` is the runtime call type which used to be an associated type; you can just move it to become a type parameter for your trait impl. `Context` is not currently used and you can safely implement over it as an unbounded type. - There's no `AccountId` associated type any more. Just remove it. Regarding `validate`: - You get three new parameters in `validate`; all can be ignored when migrating from `SignedExtension`. - `validate` returns a tuple on success; the second item in the tuple is the new ticket type `Self::Val` which gets passed in to `prepare`. If you use any information extracted during `validate` (off-chain and on-chain, non-mutating) in `prepare` (on-chain, mutating) then you can pass it through with this. For the tuple's last item, just return the `origin` argument. Regarding `prepare`: - This is renamed from `pre_dispatch`, but there is one change: - FUNCTIONALITY TO VALIDATE THE TRANSACTION NEED NOT BE DUPLICATED FROM `validate`!! - (This is different to `SignedExtension` which was required to run the same checks in `pre_dispatch` as in `validate`.) Regarding `post_dispatch`: - Since there are no unsigned transactions handled by `TransactionExtension`, `Pre` is always defined, so the first parameter is `Self::Pre` rather than `Option<Self::Pre>`. If you make use of `SignedExtension::validate_unsigned` or `SignedExtension::pre_dispatch_unsigned`, then: - Just use the regular versions of these functions instead. - Have your logic execute in the case that the `origin` is `None`. - Ensure your transaction creation logic creates a General Transaction rather than a Bare Transaction; this means having to include all `TransactionExtension`s' data. - `ValidateUnsigned` can still be used (for now) if you need to be able to construct transactions which contain none of the extension data, however these will be phased out in stage 2 of the Transactions Horizon, so you should consider moving to an extension-centric design. ## TODO - [x] Introduce `CheckSignature` impl of `TransactionExtension` to ensure it's possible to have crypto be done wholly in a `TransactionExtension`. - [x] Deprecate `SignedExtension` and move all uses in codebase to `TransactionExtension`. - [x] `ChargeTransactionPayment` - [x] `DummyExtension` - [x] `ChargeAssetTxPayment` (asset-tx-payment) - [x] `ChargeAssetTxPayment` (asset-conversion-tx-payment) - [x] `CheckWeight` - [x] `CheckTxVersion` - [x] `CheckSpecVersion` - [x] `CheckNonce` - [x] `CheckNonZeroSender` - [x] `CheckMortality` - [x] `CheckGenesis` - [x] `CheckOnlySudoAccount` - [x] `WatchDummy` - [x] `PrevalidateAttests` - [x] `GenericSignedExtension` - [x] `SignedExtension` (chain-polkadot-bulletin) - [x] `RefundSignedExtensionAdapter` - [x] Implement `fn weight` across the board. - [ ] Go through all pre-existing extensions which assume an account signer and explicitly handle the possibility of another kind of origin. - [x] `CheckNonce` should probably succeed in the case of a non-account origin. - [x] `CheckNonZeroSender` should succeed in the case of a non-account origin. - [x] `ChargeTransactionPayment` and family should fail in the case of a non-account origin. - [ ] - [x] Fix any broken tests. --------- Signed-off-by: georgepisaltu <george.pisaltu@parity.io> Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io> Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: Nikhil Gupta <17176722+gupnik@users.noreply.github.com> Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com> Co-authored-by: Chevdor <chevdor@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Maciej <maciej.zyszkiewicz@parity.io> Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: Marcin S. <marcin@realemail.net> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: Javier Bullrich <javier@bullrich.dev> Co-authored-by: Koute <koute@users.noreply.github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Vladimir Istyufeev <vladimir@parity.io> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com> Co-authored-by: ordian <write@reusable.software> Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com> Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Julian Eager <eagr@tutanota.com> Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com> Co-authored-by: Davide Galassi <davxy@datawok.net> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: yjh <yjh465402634@gmail.com> Co-authored-by: Tom Mi <tommi@niemi.lol> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will | Paradox | ParaNodes.io <79228812+paradox-tt@users.noreply.github.com> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com> Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com> Co-authored-by: PG Herveou <pgherveou@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Juan Girini <juangirini@gmail.com> Co-authored-by: bader y <ibnbassem@gmail.com> Co-authored-by: James Wilson <james@jsdw.me> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: asynchronous rob <rphmeier@gmail.com> Co-authored-by: Parth <desaiparth08@gmail.com> Co-authored-by: Andrew Jones <ascjones@gmail.com> Co-authored-by: Jonathan Udd <jonathan@dwellir.com> Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: Egor_P <egor@parity.io> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Evgeny Snitko <evgeny@parity.io> Co-authored-by: Just van Stam <vstam1@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com> Co-authored-by: dzmitry-lahoda <dzmitry@lahoda.pro> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com> Co-authored-by: Anwesh <anweshknayak@gmail.com> Co-authored-by: cheme <emericchevalier.pro@gmail.com> Co-authored-by: Sam Johnson <sam@durosoft.com> Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> Co-authored-by: Muharem <ismailov.m.h@gmail.com> Co-authored-by: joepetrowski <joe@parity.io> Co-authored-by: Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com> Co-authored-by: Gabriel Facco de Arruda <arrudagates@gmail.com> Co-authored-by: Squirrel <gilescope@gmail.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: georgepisaltu <george.pisaltu@parity.io> Co-authored-by: command-bot <>
512 lines
15 KiB
Rust
512 lines
15 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
//! Tests for the im-online module.
|
|
|
|
#![cfg(test)]
|
|
|
|
use super::*;
|
|
use crate::mock::*;
|
|
use frame_support::{assert_noop, dispatch};
|
|
use sp_core::offchain::{
|
|
testing::{TestOffchainExt, TestTransactionPoolExt},
|
|
OffchainDbExt, OffchainWorkerExt, TransactionPoolExt,
|
|
};
|
|
use sp_runtime::{
|
|
testing::UintAuthorityId,
|
|
transaction_validity::{InvalidTransaction, TransactionValidityError},
|
|
};
|
|
|
|
#[test]
|
|
fn test_unresponsiveness_slash_fraction() {
|
|
let dummy_offence =
|
|
UnresponsivenessOffence { session_index: 0, validator_set_count: 50, offenders: vec![()] };
|
|
// A single case of unresponsiveness is not slashed.
|
|
assert_eq!(dummy_offence.slash_fraction(1), Perbill::zero());
|
|
|
|
assert_eq!(
|
|
dummy_offence.slash_fraction(5),
|
|
Perbill::zero(), // 0%
|
|
);
|
|
|
|
assert_eq!(
|
|
dummy_offence.slash_fraction(7),
|
|
Perbill::from_parts(4200000), // 0.42%
|
|
);
|
|
|
|
// One third offline should be punished around 5%.
|
|
assert_eq!(
|
|
dummy_offence.slash_fraction(17),
|
|
Perbill::from_parts(46200000), // 4.62%
|
|
);
|
|
|
|
// Offline offences should never lead to being disabled.
|
|
assert_eq!(dummy_offence.disable_strategy(), DisableStrategy::Never);
|
|
}
|
|
|
|
#[test]
|
|
fn should_report_offline_validators() {
|
|
new_test_ext().execute_with(|| {
|
|
// given
|
|
let block = 1;
|
|
System::set_block_number(block);
|
|
// buffer new validators
|
|
advance_session();
|
|
// enact the change and buffer another one
|
|
let validators = vec![1, 2, 3, 4, 5, 6];
|
|
Validators::mutate(|l| *l = Some(validators.clone()));
|
|
advance_session();
|
|
|
|
// when
|
|
// we end current session and start the next one
|
|
advance_session();
|
|
|
|
// then
|
|
let offences = Offences::take();
|
|
assert_eq!(
|
|
offences,
|
|
vec![(
|
|
vec![],
|
|
UnresponsivenessOffence {
|
|
session_index: 2,
|
|
validator_set_count: 3,
|
|
offenders: vec![(1, 1), (2, 2), (3, 3),],
|
|
}
|
|
)]
|
|
);
|
|
|
|
// should not report when heartbeat is sent
|
|
for (idx, v) in validators.into_iter().take(4).enumerate() {
|
|
let _ = heartbeat(block, 3, idx as u32, v.into(), Session::validators()).unwrap();
|
|
}
|
|
advance_session();
|
|
|
|
// then
|
|
let offences = Offences::take();
|
|
assert_eq!(
|
|
offences,
|
|
vec![(
|
|
vec![],
|
|
UnresponsivenessOffence {
|
|
session_index: 3,
|
|
validator_set_count: 6,
|
|
offenders: vec![(5, 5), (6, 6),],
|
|
}
|
|
)]
|
|
);
|
|
});
|
|
}
|
|
|
|
fn heartbeat(
|
|
block_number: u64,
|
|
session_index: u32,
|
|
authority_index: u32,
|
|
id: UintAuthorityId,
|
|
validators: Vec<u64>,
|
|
) -> dispatch::DispatchResult {
|
|
let heartbeat = Heartbeat {
|
|
block_number,
|
|
session_index,
|
|
authority_index,
|
|
validators_len: validators.len() as u32,
|
|
};
|
|
let signature = id.sign(&heartbeat.encode()).unwrap();
|
|
|
|
ImOnline::pre_dispatch(&crate::Call::heartbeat {
|
|
heartbeat: heartbeat.clone(),
|
|
signature: signature.clone(),
|
|
})
|
|
.map_err(|e| match e {
|
|
TransactionValidityError::Invalid(InvalidTransaction::Custom(INVALID_VALIDATORS_LEN)) =>
|
|
"invalid validators len",
|
|
e @ _ => <&'static str>::from(e),
|
|
})?;
|
|
ImOnline::heartbeat(RuntimeOrigin::none(), heartbeat, signature)
|
|
}
|
|
|
|
#[test]
|
|
fn should_mark_online_validator_when_heartbeat_is_received() {
|
|
new_test_ext().execute_with(|| {
|
|
advance_session();
|
|
// given
|
|
Validators::mutate(|l| *l = Some(vec![1, 2, 3, 4, 5, 6]));
|
|
assert_eq!(Session::validators(), Vec::<u64>::new());
|
|
// enact the change and buffer another one
|
|
advance_session();
|
|
|
|
assert_eq!(Session::current_index(), 2);
|
|
assert_eq!(Session::validators(), vec![1, 2, 3]);
|
|
|
|
assert!(!ImOnline::is_online(0));
|
|
assert!(!ImOnline::is_online(1));
|
|
assert!(!ImOnline::is_online(2));
|
|
|
|
// when
|
|
let _ = heartbeat(1, 2, 0, 1.into(), Session::validators()).unwrap();
|
|
|
|
// then
|
|
assert!(ImOnline::is_online(0));
|
|
assert!(!ImOnline::is_online(1));
|
|
assert!(!ImOnline::is_online(2));
|
|
|
|
// and when
|
|
let _ = heartbeat(1, 2, 2, 3.into(), Session::validators()).unwrap();
|
|
|
|
// then
|
|
assert!(ImOnline::is_online(0));
|
|
assert!(!ImOnline::is_online(1));
|
|
assert!(ImOnline::is_online(2));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn late_heartbeat_and_invalid_keys_len_should_fail() {
|
|
new_test_ext().execute_with(|| {
|
|
advance_session();
|
|
// given
|
|
Validators::mutate(|l| *l = Some(vec![1, 2, 3, 4, 5, 6]));
|
|
assert_eq!(Session::validators(), Vec::<u64>::new());
|
|
// enact the change and buffer another one
|
|
advance_session();
|
|
|
|
assert_eq!(Session::current_index(), 2);
|
|
assert_eq!(Session::validators(), vec![1, 2, 3]);
|
|
|
|
// when
|
|
assert_noop!(
|
|
heartbeat(1, 3, 0, 1.into(), Session::validators()),
|
|
"Transaction is outdated"
|
|
);
|
|
assert_noop!(
|
|
heartbeat(1, 1, 0, 1.into(), Session::validators()),
|
|
"Transaction is outdated"
|
|
);
|
|
|
|
// invalid validators_len
|
|
assert_noop!(heartbeat(1, 2, 0, 1.into(), vec![]), "invalid validators len");
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn should_generate_heartbeats() {
|
|
let mut ext = new_test_ext();
|
|
let (offchain, _state) = TestOffchainExt::new();
|
|
let (pool, state) = TestTransactionPoolExt::new();
|
|
ext.register_extension(OffchainDbExt::new(offchain.clone()));
|
|
ext.register_extension(OffchainWorkerExt::new(offchain));
|
|
ext.register_extension(TransactionPoolExt::new(pool));
|
|
|
|
ext.execute_with(|| {
|
|
// given
|
|
let block = 1;
|
|
System::set_block_number(block);
|
|
UintAuthorityId::set_all_keys(vec![0, 1, 2]);
|
|
// buffer new validators
|
|
Session::rotate_session();
|
|
// enact the change and buffer another one
|
|
Validators::mutate(|l| *l = Some(vec![1, 2, 3, 4, 5, 6]));
|
|
Session::rotate_session();
|
|
|
|
// when
|
|
ImOnline::offchain_worker(block);
|
|
|
|
// then
|
|
let transaction = state.write().transactions.pop().unwrap();
|
|
// All validators have `0` as their session key, so we generate 2 transactions.
|
|
assert_eq!(state.read().transactions.len(), 2);
|
|
|
|
// check stuff about the transaction.
|
|
let ex: Extrinsic = Decode::decode(&mut &*transaction).unwrap();
|
|
let heartbeat = match ex.function {
|
|
crate::mock::RuntimeCall::ImOnline(crate::Call::heartbeat { heartbeat, .. }) =>
|
|
heartbeat,
|
|
e => panic!("Unexpected call: {:?}", e),
|
|
};
|
|
|
|
assert_eq!(
|
|
heartbeat,
|
|
Heartbeat {
|
|
block_number: block,
|
|
session_index: 2,
|
|
authority_index: 2,
|
|
validators_len: 3,
|
|
}
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn should_cleanup_received_heartbeats_on_session_end() {
|
|
new_test_ext().execute_with(|| {
|
|
advance_session();
|
|
|
|
Validators::mutate(|l| *l = Some(vec![1, 2, 3]));
|
|
assert_eq!(Session::validators(), Vec::<u64>::new());
|
|
|
|
// enact the change and buffer another one
|
|
advance_session();
|
|
|
|
assert_eq!(Session::current_index(), 2);
|
|
assert_eq!(Session::validators(), vec![1, 2, 3]);
|
|
|
|
// send an heartbeat from authority id 0 at session 2
|
|
let _ = heartbeat(1, 2, 0, 1.into(), Session::validators()).unwrap();
|
|
|
|
// the heartbeat is stored
|
|
assert!(!ImOnline::received_heartbeats(&2, &0).is_none());
|
|
|
|
advance_session();
|
|
|
|
// after the session has ended we have already processed the heartbeat
|
|
// message, so any messages received on the previous session should have
|
|
// been pruned.
|
|
assert!(ImOnline::received_heartbeats(&2, &0).is_none());
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn should_mark_online_validator_when_block_is_authored() {
|
|
use pallet_authorship::EventHandler;
|
|
|
|
new_test_ext().execute_with(|| {
|
|
advance_session();
|
|
// given
|
|
Validators::mutate(|l| *l = Some(vec![1, 2, 3, 4, 5, 6]));
|
|
assert_eq!(Session::validators(), Vec::<u64>::new());
|
|
// enact the change and buffer another one
|
|
advance_session();
|
|
|
|
assert_eq!(Session::current_index(), 2);
|
|
assert_eq!(Session::validators(), vec![1, 2, 3]);
|
|
|
|
for i in 0..3 {
|
|
assert!(!ImOnline::is_online(i));
|
|
}
|
|
|
|
// when
|
|
ImOnline::note_author(1);
|
|
|
|
// then
|
|
assert!(ImOnline::is_online(0));
|
|
assert!(!ImOnline::is_online(1));
|
|
assert!(!ImOnline::is_online(2));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn should_not_send_a_report_if_already_online() {
|
|
use pallet_authorship::EventHandler;
|
|
|
|
let mut ext = new_test_ext();
|
|
let (offchain, _state) = TestOffchainExt::new();
|
|
let (pool, pool_state) = TestTransactionPoolExt::new();
|
|
ext.register_extension(OffchainDbExt::new(offchain.clone()));
|
|
ext.register_extension(OffchainWorkerExt::new(offchain));
|
|
ext.register_extension(TransactionPoolExt::new(pool));
|
|
|
|
ext.execute_with(|| {
|
|
advance_session();
|
|
// given
|
|
Validators::mutate(|l| *l = Some(vec![1, 2, 3, 4, 5, 6]));
|
|
assert_eq!(Session::validators(), Vec::<u64>::new());
|
|
// enact the change and buffer another one
|
|
advance_session();
|
|
assert_eq!(Session::current_index(), 2);
|
|
assert_eq!(Session::validators(), vec![1, 2, 3]);
|
|
ImOnline::note_author(2);
|
|
ImOnline::note_author(3);
|
|
|
|
// when
|
|
UintAuthorityId::set_all_keys(vec![1, 2, 3]);
|
|
// we expect error, since the authority is already online.
|
|
let mut res = ImOnline::send_heartbeats(4).unwrap();
|
|
res.next().unwrap().unwrap();
|
|
assert_eq!(res.next().unwrap().unwrap_err(), OffchainErr::AlreadyOnline(1));
|
|
assert_eq!(res.next().unwrap().unwrap_err(), OffchainErr::AlreadyOnline(2));
|
|
assert_eq!(res.next(), None);
|
|
|
|
// then
|
|
let transaction = pool_state.write().transactions.pop().unwrap();
|
|
// All validators have `0` as their session key, but we should only produce 1 heartbeat.
|
|
assert_eq!(pool_state.read().transactions.len(), 0);
|
|
// check stuff about the transaction.
|
|
let ex: Extrinsic = Decode::decode(&mut &*transaction).unwrap();
|
|
let heartbeat = match ex.function {
|
|
crate::mock::RuntimeCall::ImOnline(crate::Call::heartbeat { heartbeat, .. }) =>
|
|
heartbeat,
|
|
e => panic!("Unexpected call: {:?}", e),
|
|
};
|
|
|
|
assert_eq!(
|
|
heartbeat,
|
|
Heartbeat { block_number: 4, session_index: 2, authority_index: 0, validators_len: 3 }
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn should_handle_missing_progress_estimates() {
|
|
let mut ext = new_test_ext();
|
|
let (offchain, _state) = TestOffchainExt::new();
|
|
let (pool, state) = TestTransactionPoolExt::new();
|
|
ext.register_extension(OffchainDbExt::new(offchain.clone()));
|
|
ext.register_extension(OffchainWorkerExt::new(offchain));
|
|
ext.register_extension(TransactionPoolExt::new(pool));
|
|
|
|
ext.execute_with(|| {
|
|
let block = 1;
|
|
|
|
System::set_block_number(block);
|
|
UintAuthorityId::set_all_keys(vec![0, 1, 2]);
|
|
|
|
// buffer new validators
|
|
Session::rotate_session();
|
|
|
|
// enact the change and buffer another one
|
|
Validators::mutate(|l| *l = Some(vec![0, 1, 2]));
|
|
Session::rotate_session();
|
|
|
|
// we will return `None` on the next call to `estimate_current_session_progress`
|
|
// and the offchain worker should fallback to checking `HeartbeatAfter`
|
|
MockCurrentSessionProgress::mutate(|p| *p = Some(None));
|
|
ImOnline::offchain_worker(block);
|
|
|
|
assert_eq!(state.read().transactions.len(), 3);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn should_handle_non_linear_session_progress() {
|
|
// NOTE: this is the reason why we started using `EstimateNextSessionRotation` to figure out if
|
|
// we should send a heartbeat, it's possible that between successive blocks we progress through
|
|
// the session more than just one block increment (in BABE session length is defined in slots,
|
|
// not block numbers).
|
|
|
|
let mut ext = new_test_ext();
|
|
let (offchain, _state) = TestOffchainExt::new();
|
|
let (pool, _) = TestTransactionPoolExt::new();
|
|
ext.register_extension(OffchainDbExt::new(offchain.clone()));
|
|
ext.register_extension(OffchainWorkerExt::new(offchain));
|
|
ext.register_extension(TransactionPoolExt::new(pool));
|
|
|
|
ext.execute_with(|| {
|
|
UintAuthorityId::set_all_keys(vec![0, 1, 2]);
|
|
|
|
// buffer new validator
|
|
Session::rotate_session();
|
|
|
|
// mock the session length as being 10 blocks long,
|
|
// enact the change and buffer another one
|
|
Validators::mutate(|l| *l = Some(vec![0, 1, 2]));
|
|
|
|
// mock the session length has being 10 which should make us assume the fallback for half
|
|
// session will be reached by block 5.
|
|
MockAverageSessionLength::mutate(|p| *p = Some(10));
|
|
|
|
Session::rotate_session();
|
|
|
|
// if we don't have valid results for the current session progres then
|
|
// we'll fallback to `HeartbeatAfter` and only heartbeat on block 5.
|
|
MockCurrentSessionProgress::mutate(|p| *p = Some(None));
|
|
assert_eq!(ImOnline::send_heartbeats(2).err(), Some(OffchainErr::TooEarly));
|
|
|
|
MockCurrentSessionProgress::mutate(|p| *p = Some(None));
|
|
assert!(ImOnline::send_heartbeats(5).ok().is_some());
|
|
|
|
// if we have a valid current session progress then we'll heartbeat as soon
|
|
// as we're past 80% of the session regardless of the block number
|
|
MockCurrentSessionProgress::mutate(|p| *p = Some(Some(Permill::from_percent(81))));
|
|
|
|
assert!(ImOnline::send_heartbeats(2).ok().is_some());
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn test_does_not_heartbeat_early_in_the_session() {
|
|
let mut ext = new_test_ext();
|
|
let (offchain, _state) = TestOffchainExt::new();
|
|
let (pool, _) = TestTransactionPoolExt::new();
|
|
ext.register_extension(OffchainDbExt::new(offchain.clone()));
|
|
ext.register_extension(OffchainWorkerExt::new(offchain));
|
|
ext.register_extension(TransactionPoolExt::new(pool));
|
|
|
|
ext.execute_with(|| {
|
|
// mock current session progress as being 5%. we only randomly start
|
|
// heartbeating after 10% of the session has elapsed.
|
|
MockCurrentSessionProgress::mutate(|p| *p = Some(Some(Permill::from_float(0.05))));
|
|
assert_eq!(ImOnline::send_heartbeats(2).err(), Some(OffchainErr::TooEarly));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn test_probability_of_heartbeating_increases_with_session_progress() {
|
|
let mut ext = new_test_ext();
|
|
let (offchain, state) = TestOffchainExt::new();
|
|
let (pool, _) = TestTransactionPoolExt::new();
|
|
ext.register_extension(OffchainDbExt::new(offchain.clone()));
|
|
ext.register_extension(OffchainWorkerExt::new(offchain));
|
|
ext.register_extension(TransactionPoolExt::new(pool));
|
|
|
|
ext.execute_with(|| {
|
|
let set_test = |progress, random: f64| {
|
|
// the average session length is 100 blocks, therefore the residual
|
|
// probability of sending a heartbeat is 1%
|
|
MockAverageSessionLength::mutate(|p| *p = Some(100));
|
|
MockCurrentSessionProgress::mutate(|p| *p = Some(Some(Permill::from_float(progress))));
|
|
|
|
let mut seed = [0u8; 32];
|
|
let encoded = ((random * Permill::ACCURACY as f64) as u32).encode();
|
|
seed[0..4].copy_from_slice(&encoded);
|
|
state.write().seed = seed;
|
|
};
|
|
|
|
let assert_too_early = |progress, random| {
|
|
set_test(progress, random);
|
|
assert_eq!(ImOnline::send_heartbeats(2).err(), Some(OffchainErr::TooEarly));
|
|
};
|
|
|
|
let assert_heartbeat_ok = |progress, random| {
|
|
set_test(progress, random);
|
|
assert!(ImOnline::send_heartbeats(2).ok().is_some());
|
|
};
|
|
|
|
assert_too_early(0.05, 1.0);
|
|
|
|
assert_too_early(0.1, 0.1);
|
|
assert_too_early(0.1, 0.011);
|
|
assert_heartbeat_ok(0.1, 0.010);
|
|
|
|
assert_too_early(0.4, 0.015);
|
|
assert_heartbeat_ok(0.4, 0.014);
|
|
|
|
assert_too_early(0.5, 0.026);
|
|
assert_heartbeat_ok(0.5, 0.025);
|
|
|
|
assert_too_early(0.6, 0.057);
|
|
assert_heartbeat_ok(0.6, 0.056);
|
|
|
|
assert_too_early(0.65, 0.086);
|
|
assert_heartbeat_ok(0.65, 0.085);
|
|
|
|
assert_too_early(0.7, 0.13);
|
|
assert_heartbeat_ok(0.7, 0.12);
|
|
|
|
assert_too_early(0.75, 0.19);
|
|
assert_heartbeat_ok(0.75, 0.18);
|
|
});
|
|
}
|