mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-28 09:47:56 +00:00
9a650c46fd
This PR provides the infrastructure for the pov-reclaim mechanism discussed in #209. The goal is to provide the current proof size to the runtime so it can be used to reclaim storage weight. ## New Host Function - A new host function is provided [here](https://github.com/skunert/polkadot-sdk/blob/5b317fda3be205f4136f10d4490387ccd4f9765d/cumulus/primitives/pov-reclaim/src/lib.rs#L23). It returns the size of the current proof size to the runtime. If recording is not enabled, it returns 0. ## Implementation Overview - Implement option to enable proof recording during import in the client. This is currently enabled for `polkadot-parachain`, `parachain-template` and the cumulus test node. - Make the proof recorder ready for no-std. It was previously only enabled for std environments, but we need to record the proof size in `validate_block` too. - Provide a recorder implementation that only the records the size of incoming nodes and does not store the nodes itself. - Fix benchmarks that were broken by async backing changes - Provide new externalities extension that is registered by default if proof recording is enabled. - I think we should discuss the naming, pov-reclaim was more intuitive to me, but we could also go with clawback like in the issue. ## Impact of proof recording during import With proof recording: 6.3058 Kelem/s Without proof recording: 6.3427 Kelem/s The measured impact on the importing performance is quite low on my machine using the block import benchmark. With proof recording I am seeing a performance hit of 0.585%. --------- Co-authored-by: command-bot <> Co-authored-by: Davide Galassi <davxy@datawok.net> Co-authored-by: Bastian Köcher <git@kchr.de>
131 lines
4.4 KiB
Rust
131 lines
4.4 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
//! Execution extensions for runtime calls.
|
|
//!
|
|
//! This module is responsible for defining the execution
|
|
//! strategy for the runtime calls and provide the right `Externalities`
|
|
//! extensions to support APIs for particular execution context & capabilities.
|
|
|
|
use parking_lot::RwLock;
|
|
use sp_core::traits::{ReadRuntimeVersion, ReadRuntimeVersionExt};
|
|
use sp_externalities::{Extension, Extensions};
|
|
use sp_runtime::traits::{Block as BlockT, NumberFor};
|
|
use std::{marker::PhantomData, sync::Arc};
|
|
|
|
/// Generate the starting set of [`Extensions`].
|
|
///
|
|
/// These [`Extensions`] are passed to the environment a runtime is executed in.
|
|
pub trait ExtensionsFactory<Block: BlockT>: Send + Sync {
|
|
/// Create [`Extensions`] for the given input.
|
|
///
|
|
/// - `block_hash`: The hash of the block in the context that extensions will be used.
|
|
/// - `block_number`: The number of the block in the context that extensions will be used.
|
|
fn extensions_for(&self, block_hash: Block::Hash, block_number: NumberFor<Block>)
|
|
-> Extensions;
|
|
}
|
|
|
|
impl<Block: BlockT> ExtensionsFactory<Block> for () {
|
|
fn extensions_for(&self, _: Block::Hash, _: NumberFor<Block>) -> Extensions {
|
|
Extensions::new()
|
|
}
|
|
}
|
|
|
|
impl<Block: BlockT, T: ExtensionsFactory<Block>> ExtensionsFactory<Block> for Vec<T> {
|
|
fn extensions_for(
|
|
&self,
|
|
block_hash: Block::Hash,
|
|
block_number: NumberFor<Block>,
|
|
) -> Extensions {
|
|
let mut exts = Extensions::new();
|
|
exts.extend(self.iter().map(|e| e.extensions_for(block_hash, block_number)));
|
|
exts
|
|
}
|
|
}
|
|
|
|
/// An [`ExtensionsFactory`] that registers an [`Extension`] before a certain block.
|
|
pub struct ExtensionBeforeBlock<Block: BlockT, Ext> {
|
|
before: NumberFor<Block>,
|
|
_marker: PhantomData<fn(Ext) -> Ext>,
|
|
}
|
|
|
|
impl<Block: BlockT, Ext> ExtensionBeforeBlock<Block, Ext> {
|
|
/// Create the extension factory.
|
|
///
|
|
/// - `before`: The block number until the extension should be registered.
|
|
pub fn new(before: NumberFor<Block>) -> Self {
|
|
Self { before, _marker: PhantomData }
|
|
}
|
|
}
|
|
|
|
impl<Block: BlockT, Ext: Default + Extension> ExtensionsFactory<Block>
|
|
for ExtensionBeforeBlock<Block, Ext>
|
|
{
|
|
fn extensions_for(&self, _: Block::Hash, block_number: NumberFor<Block>) -> Extensions {
|
|
let mut exts = Extensions::new();
|
|
|
|
if block_number < self.before {
|
|
exts.register(Ext::default());
|
|
}
|
|
|
|
exts
|
|
}
|
|
}
|
|
|
|
/// A producer of execution extensions for offchain calls.
|
|
///
|
|
/// This crate aggregates extensions available for the offchain calls
|
|
/// and is responsible for producing a correct `Extensions` object.
|
|
pub struct ExecutionExtensions<Block: BlockT> {
|
|
extensions_factory: RwLock<Box<dyn ExtensionsFactory<Block>>>,
|
|
read_runtime_version: Arc<dyn ReadRuntimeVersion>,
|
|
}
|
|
|
|
impl<Block: BlockT> ExecutionExtensions<Block> {
|
|
/// Create new `ExecutionExtensions` given an `extensions_factory`.
|
|
pub fn new(
|
|
extensions_factory: Option<Box<dyn ExtensionsFactory<Block>>>,
|
|
read_runtime_version: Arc<dyn ReadRuntimeVersion>,
|
|
) -> Self {
|
|
Self {
|
|
extensions_factory: extensions_factory
|
|
.map(RwLock::new)
|
|
.unwrap_or_else(|| RwLock::new(Box::new(()))),
|
|
read_runtime_version,
|
|
}
|
|
}
|
|
|
|
/// Set the new extensions_factory
|
|
pub fn set_extensions_factory(&self, maker: impl ExtensionsFactory<Block> + 'static) {
|
|
*self.extensions_factory.write() = Box::new(maker);
|
|
}
|
|
|
|
/// Produces default extensions based on the input parameters.
|
|
pub fn extensions(
|
|
&self,
|
|
block_hash: Block::Hash,
|
|
block_number: NumberFor<Block>,
|
|
) -> Extensions {
|
|
let mut extensions =
|
|
self.extensions_factory.read().extensions_for(block_hash, block_number);
|
|
|
|
extensions.register(ReadRuntimeVersionExt::new(self.read_runtime_version.clone()));
|
|
extensions
|
|
}
|
|
}
|