mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-06 21:58:06 +00:00
6cc4495700
* Remove offline slashing logic from staking. * Initial version of reworked offence module, can report offences * Clean up staking example. * Commit SlashingOffence * Force new era on slash. * Add offenders in the SlashingOffence trait. * Introduce the ReportOffence trait. * Rename `Offence`. * Add on_before_session_ending handler. * Move offence related stuff under sr-primitives. * Fix cargo check. * Import new im-online implementation. * Adding validator count to historical session storage as it's needed for slash calculations * Add a comment about offence. * Add BabeEquivocationOffence * GrandpaEquivocationOffence * slash_fraction and fix * current_era_start_session_index * UnresponsivnessOffence * Finalise OnOffenceHandler traits, and stub impl for staking. * slash_fraction doesn't really need &self * Note that offenders count is greater than 0 * Add a test to ensure that I got the math right * Use FullIdentification in offences. * Use FullIndentification. * Hook up the offences module. * Report unresponsive validators * Make sure eras have the same length. * Slashing and rewards. * Fix compilation. * Distribute rewards. * Supply validators_count * Use identificationTuple in Unresponsivness report * Fix merge. * Make sure we don't slash if amount is zero. * We don't return an error from report_offence anymo * We actually can use vec! * Prevent division by zero if the reporters is empty * offence_forces_new_era/nominators_also_get_slashed * advance_session * Fix tests. * Update srml/staking/src/lib.rs Co-Authored-By: Robert Habermeier <rphmeier@gmail.com> * slashing_performed_according_exposure * Check that reporters receive their slice. * Small clean-up. * invulnerables_are_not_slashed * Minor clean ups. * Improve docs. * dont_slash_if_fraction_is_zero * Remove session dependency from offences. * Introduce sr-staking-primitives * Move offence under sr_staking_primitives * rename session_index * Resolves todos re using SessionIndex * Fix staking tests. * Properly scale denominator. * Fix UnresponsivnessOffence * Fix compilation. * Tests for offences. * Clean offences tests. * Fix staking doc test. * Bump spec version * Fix aura tests. * Fix node_executor * Deposit an event on offence. * Fix compilation of node-runtime * Remove aura slashing logic. * Remove HandleReport * Update docs for timeslot. * rename with_on_offence_fractions * Add should_properly_count_offences * Replace ValidatorIdByIndex with CurrentElectedSet ValidatorIdByIndex was querying the current_elected set in each call, doing loading (even though its from cache), deserializing and cloning of element. Instead of this it is more efficient to use `CurrentElectedSet`. As a small bonus, the invariant became a little bit easier: now we just rely on the fact that `keys` and `current_elected` set are of the same length rather than relying on the fact that `validator_id_by_index` would work similar to `<[T]>::get`. * Clarify babe equivocation * Fix offences. * Rename validators_count to validator_set_count * Fix squaring. * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: Gavin Wood <gavin@parity.io> * Docs for CurrentElectedSet. * Don't punish only invulnerables * Use `get/insert` instead of `mutate`. * Fix compilation * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: Gavin Wood <gavin@parity.io> * Update srml/offences/src/lib.rs Co-Authored-By: Robert Habermeier <rphmeier@gmail.com> * Update srml/im-online/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update srml/im-online/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update srml/im-online/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update srml/babe/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Add aura todo. * Allow multiple reports for single offence report. * Fix slash_fraction calculation. * Fix typos. * Fix compilation and tests. * Fix staking tests. * Update srml/im-online/src/lib.rs Co-Authored-By: Logan Saether <x@logansaether.com> * Fix doc on time_slot * Allow slashing only on current era (#3411) * only slash in current era * prune journal for last era * comment own_slash * emit an event when old slashing events are discarded * Pave the way for pruning * Address issues. * Try to refactor collect_offence_reports * Other fixes. * More fixes.
283 lines
8.9 KiB
Rust
283 lines
8.9 KiB
Rust
// Copyright 2019 Parity Technologies (UK) Ltd.
|
|
// This file is part of Substrate.
|
|
|
|
// Substrate is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Substrate is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Substrate. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! # Offences Module
|
|
//!
|
|
//! Tracks reported offences
|
|
|
|
// Ensure we're `no_std` when compiling for Wasm.
|
|
#![cfg_attr(not(feature = "std"), no_std)]
|
|
|
|
mod mock;
|
|
mod tests;
|
|
|
|
use rstd::{
|
|
vec::Vec,
|
|
collections::btree_set::BTreeSet,
|
|
};
|
|
use support::{
|
|
StorageMap, StorageDoubleMap, decl_module, decl_event, decl_storage, Parameter,
|
|
};
|
|
use sr_primitives::{
|
|
Perbill,
|
|
traits::Hash,
|
|
};
|
|
use sr_staking_primitives::{
|
|
offence::{Offence, ReportOffence, Kind, OnOffenceHandler, OffenceDetails},
|
|
};
|
|
use codec::{Encode, Decode};
|
|
|
|
/// A binary blob which represents a SCALE codec-encoded `O::TimeSlot`.
|
|
type OpaqueTimeSlot = Vec<u8>;
|
|
|
|
/// A type alias for a report identifier.
|
|
type ReportIdOf<T> = <T as system::Trait>::Hash;
|
|
|
|
/// Offences trait
|
|
pub trait Trait: system::Trait {
|
|
/// The overarching event type.
|
|
type Event: From<Event> + Into<<Self as system::Trait>::Event>;
|
|
/// Full identification of the validator.
|
|
type IdentificationTuple: Parameter + Ord;
|
|
/// A handler called for every offence report.
|
|
type OnOffenceHandler: OnOffenceHandler<Self::AccountId, Self::IdentificationTuple>;
|
|
}
|
|
|
|
decl_storage! {
|
|
trait Store for Module<T: Trait> as Offences {
|
|
/// The primary structure that holds all offence records keyed by report identifiers.
|
|
Reports get(reports): map ReportIdOf<T> => Option<OffenceDetails<T::AccountId, T::IdentificationTuple>>;
|
|
|
|
/// A vector of reports of the same kind that happened at the same time slot.
|
|
ConcurrentReportsIndex: double_map Kind, blake2_256(OpaqueTimeSlot) => Vec<ReportIdOf<T>>;
|
|
|
|
/// Enumerates all reports of a kind along with the time they happened.
|
|
///
|
|
/// All reports are sorted by the time of offence.
|
|
///
|
|
/// Note that the actual type of this mapping is `Vec<u8>`, this is because values of
|
|
/// different types are not supported at the moment so we are doing the manual serialization.
|
|
ReportsByKindIndex: map Kind => Vec<u8>; // (O::TimeSlot, ReportIdOf<T>)
|
|
}
|
|
}
|
|
|
|
decl_event!(
|
|
pub enum Event {
|
|
/// There is an offence reported of the given `kind` happened at the `session_index` and
|
|
/// (kind-specific) time slot. This event is not deposited for duplicate slashes.
|
|
Offence(Kind, OpaqueTimeSlot),
|
|
}
|
|
);
|
|
|
|
decl_module! {
|
|
/// Offences module, currently just responsible for taking offence reports.
|
|
pub struct Module<T: Trait> for enum Call where origin: T::Origin {
|
|
fn deposit_event() = default;
|
|
}
|
|
}
|
|
impl<T: Trait, O: Offence<T::IdentificationTuple>>
|
|
ReportOffence<T::AccountId, T::IdentificationTuple, O> for Module<T>
|
|
where
|
|
T::IdentificationTuple: Clone,
|
|
{
|
|
fn report_offence(reporters: Vec<T::AccountId>, offence: O) {
|
|
let offenders = offence.offenders();
|
|
let time_slot = offence.time_slot();
|
|
let validator_set_count = offence.validator_set_count();
|
|
|
|
// Go through all offenders in the offence report and find all offenders that was spotted
|
|
// in unique reports.
|
|
let TriageOutcome {
|
|
new_offenders,
|
|
concurrent_offenders,
|
|
} = match Self::triage_offence_report::<O>(reporters, &time_slot, offenders) {
|
|
Some(triage) => triage,
|
|
// The report contained only duplicates, so there is no need to slash again.
|
|
None => return,
|
|
};
|
|
|
|
// Deposit the event.
|
|
Self::deposit_event(Event::Offence(O::ID, time_slot.encode()));
|
|
|
|
let offenders_count = concurrent_offenders.len() as u32;
|
|
let previous_offenders_count = offenders_count - new_offenders.len() as u32;
|
|
|
|
// The amount new offenders are slashed
|
|
let new_fraction = O::slash_fraction(offenders_count, validator_set_count);
|
|
|
|
// The amount previous offenders are slashed additionally.
|
|
//
|
|
// Since they were slashed in the past, we slash by:
|
|
// x = (new - prev) / (1 - prev)
|
|
// because:
|
|
// Y = X * (1 - prev)
|
|
// Z = Y * (1 - x)
|
|
// Z = X * (1 - new)
|
|
let old_fraction = if previous_offenders_count > 0 {
|
|
let previous_fraction = O::slash_fraction(
|
|
offenders_count.saturating_sub(previous_offenders_count),
|
|
validator_set_count,
|
|
);
|
|
let numerator = new_fraction
|
|
.into_parts()
|
|
.saturating_sub(previous_fraction.into_parts());
|
|
let denominator =
|
|
Perbill::from_parts(Perbill::one().into_parts() - previous_fraction.into_parts());
|
|
Perbill::from_parts(denominator * numerator)
|
|
} else {
|
|
new_fraction.clone()
|
|
};
|
|
|
|
// calculate how much to slash
|
|
let slash_perbill = concurrent_offenders
|
|
.iter()
|
|
.map(|details| {
|
|
if previous_offenders_count > 0 && new_offenders.contains(&details.offender) {
|
|
new_fraction.clone()
|
|
} else {
|
|
old_fraction.clone()
|
|
}
|
|
})
|
|
.collect::<Vec<_>>();
|
|
|
|
T::OnOffenceHandler::on_offence(&concurrent_offenders, &slash_perbill);
|
|
}
|
|
}
|
|
|
|
impl<T: Trait> Module<T> {
|
|
/// Compute the ID for the given report properties.
|
|
///
|
|
/// The report id depends on the offence kind, time slot and the id of offender.
|
|
fn report_id<O: Offence<T::IdentificationTuple>>(
|
|
time_slot: &O::TimeSlot,
|
|
offender: &T::IdentificationTuple,
|
|
) -> ReportIdOf<T> {
|
|
(O::ID, time_slot.encode(), offender).using_encoded(T::Hashing::hash)
|
|
}
|
|
|
|
/// Triages the offence report and returns the set of offenders that was involved in unique
|
|
/// reports along with the list of the concurrent offences.
|
|
fn triage_offence_report<O: Offence<T::IdentificationTuple>>(
|
|
reporters: Vec<T::AccountId>,
|
|
time_slot: &O::TimeSlot,
|
|
offenders: Vec<T::IdentificationTuple>,
|
|
) -> Option<TriageOutcome<T>> {
|
|
let mut storage = ReportIndexStorage::<T, O>::load(time_slot);
|
|
let mut new_offenders = BTreeSet::new();
|
|
|
|
for offender in offenders {
|
|
let report_id = Self::report_id::<O>(time_slot, &offender);
|
|
|
|
if !<Reports<T>>::exists(&report_id) {
|
|
new_offenders.insert(offender.clone());
|
|
<Reports<T>>::insert(
|
|
&report_id,
|
|
OffenceDetails {
|
|
offender,
|
|
reporters: reporters.clone(),
|
|
},
|
|
);
|
|
|
|
storage.insert(time_slot, report_id);
|
|
}
|
|
}
|
|
|
|
if !new_offenders.is_empty() {
|
|
// Load report details for the all reports happened at the same time.
|
|
let concurrent_offenders = storage.concurrent_reports
|
|
.iter()
|
|
.filter_map(|report_id| <Reports<T>>::get(report_id))
|
|
.collect::<Vec<_>>();
|
|
|
|
storage.save();
|
|
|
|
Some(TriageOutcome {
|
|
new_offenders,
|
|
concurrent_offenders,
|
|
})
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
}
|
|
|
|
struct TriageOutcome<T: Trait> {
|
|
/// Offenders that was spotted in the unique reports.
|
|
new_offenders: BTreeSet<T::IdentificationTuple>,
|
|
/// Other reports for the same report kinds.
|
|
concurrent_offenders: Vec<OffenceDetails<T::AccountId, T::IdentificationTuple>>,
|
|
}
|
|
|
|
/// An auxilary struct for working with storage of indexes localized for a specific offence
|
|
/// kind (specified by the `O` type parameter).
|
|
///
|
|
/// This struct is responsible for aggregating storage writes and the underlying storage should not
|
|
/// accessed directly meanwhile.
|
|
#[must_use = "The changes are not saved without called `save`"]
|
|
struct ReportIndexStorage<T: Trait, O: Offence<T::IdentificationTuple>> {
|
|
opaque_time_slot: OpaqueTimeSlot,
|
|
concurrent_reports: Vec<ReportIdOf<T>>,
|
|
same_kind_reports: Vec<(O::TimeSlot, ReportIdOf<T>)>,
|
|
}
|
|
|
|
impl<T: Trait, O: Offence<T::IdentificationTuple>> ReportIndexStorage<T, O> {
|
|
/// Preload indexes from the storage for the specific `time_slot` and the kind of the offence.
|
|
fn load(time_slot: &O::TimeSlot) -> Self {
|
|
let opaque_time_slot = time_slot.encode();
|
|
|
|
let same_kind_reports = <ReportsByKindIndex>::get(&O::ID);
|
|
let same_kind_reports =
|
|
Vec::<(O::TimeSlot, ReportIdOf<T>)>::decode(&mut &same_kind_reports[..])
|
|
.unwrap_or_default();
|
|
|
|
let concurrent_reports = <ConcurrentReportsIndex<T>>::get(&O::ID, &opaque_time_slot);
|
|
|
|
Self {
|
|
opaque_time_slot,
|
|
concurrent_reports,
|
|
same_kind_reports,
|
|
}
|
|
}
|
|
|
|
/// Insert a new report to the index.
|
|
fn insert(&mut self, time_slot: &O::TimeSlot, report_id: ReportIdOf<T>) {
|
|
// Insert the report id into the list while maintaining the ordering by the time
|
|
// slot.
|
|
let pos = match self
|
|
.same_kind_reports
|
|
.binary_search_by_key(&time_slot, |&(ref when, _)| when)
|
|
{
|
|
Ok(pos) => pos,
|
|
Err(pos) => pos,
|
|
};
|
|
self.same_kind_reports
|
|
.insert(pos, (time_slot.clone(), report_id));
|
|
|
|
// Update the list of concurrent reports.
|
|
self.concurrent_reports.push(report_id);
|
|
}
|
|
|
|
/// Dump the indexes to the storage.
|
|
fn save(self) {
|
|
<ReportsByKindIndex>::insert(&O::ID, self.same_kind_reports.encode());
|
|
<ConcurrentReportsIndex<T>>::insert(
|
|
&O::ID,
|
|
&self.opaque_time_slot,
|
|
&self.concurrent_reports,
|
|
);
|
|
}
|
|
}
|