mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-19 11:05:40 +00:00
80616f6d03
[litep2p](https://github.com/altonen/litep2p) is a libp2p-compatible P2P networking library. It supports all of the features of `rust-libp2p` that are currently being utilized by Polkadot SDK. Compared to `rust-libp2p`, `litep2p` has a quite different architecture which is why the new `litep2p` network backend is only able to use a little of the existing code in `sc-network`. The design has been mainly influenced by how we'd wish to structure our networking-related code in Polkadot SDK: independent higher-levels protocols directly communicating with the network over links that support bidirectional backpressure. A good example would be `NotificationHandle`/`RequestResponseHandle` abstractions which allow, e.g., `SyncingEngine` to directly communicate with peers to announce/request blocks. I've tried running `polkadot --network-backend litep2p` with a few different peer configurations and there is a noticeable reduction in networking CPU usage. For high load (`--out-peers 200`), networking CPU usage goes down from ~110% to ~30% (80 pp) and for normal load (`--out-peers 40`), the usage goes down from ~55% to ~18% (37 pp). These should not be taken as final numbers because: a) there are still some low-hanging optimization fruits, such as enabling [receive window auto-tuning](https://github.com/libp2p/rust-yamux/pull/176), integrating `Peerset` more closely with `litep2p` or improving memory usage of the WebSocket transport b) fixing bugs/instabilities that incorrectly cause `litep2p` to do less work will increase the networking CPU usage c) verification in a more diverse set of tests/conditions is needed Nevertheless, these numbers should give an early estimate for CPU usage of the new networking backend. This PR consists of three separate changes: * introduce a generic `PeerId` (wrapper around `Multihash`) so that we don't have use `NetworkService::PeerId` in every part of the code that uses a `PeerId` * introduce `NetworkBackend` trait, implement it for the libp2p network stack and make Polkadot SDK generic over `NetworkBackend` * implement `NetworkBackend` for litep2p The new library should be considered experimental which is why `rust-libp2p` will remain as the default option for the time being. This PR currently depends on the master branch of `litep2p` but I'll cut a new release for the library once all review comments have been addresses. --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by: Alexandru Vasile <alexandru.vasile@parity.io>
129 lines
3.7 KiB
Rust
129 lines
3.7 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
//! Logic for keeping track of BEEFY peers.
|
|
|
|
use sc_network::ReputationChange;
|
|
use sc_network_types::PeerId;
|
|
use sp_runtime::traits::{Block, NumberFor, Zero};
|
|
use std::collections::{HashMap, VecDeque};
|
|
|
|
/// Report specifying a reputation change for a given peer.
|
|
#[derive(Debug, PartialEq)]
|
|
pub struct PeerReport {
|
|
pub who: PeerId,
|
|
pub cost_benefit: ReputationChange,
|
|
}
|
|
|
|
struct PeerData<B: Block> {
|
|
last_voted_on: NumberFor<B>,
|
|
}
|
|
|
|
impl<B: Block> Default for PeerData<B> {
|
|
fn default() -> Self {
|
|
PeerData { last_voted_on: Zero::zero() }
|
|
}
|
|
}
|
|
|
|
/// Keep a simple map of connected peers
|
|
/// and the most recent voting round they participated in.
|
|
pub struct KnownPeers<B: Block> {
|
|
live: HashMap<PeerId, PeerData<B>>,
|
|
}
|
|
|
|
impl<B: Block> KnownPeers<B> {
|
|
pub fn new() -> Self {
|
|
Self { live: HashMap::new() }
|
|
}
|
|
|
|
/// Note vote round number for `peer`.
|
|
pub fn note_vote_for(&mut self, peer: PeerId, round: NumberFor<B>) {
|
|
let data = self.live.entry(peer).or_default();
|
|
data.last_voted_on = round.max(data.last_voted_on);
|
|
}
|
|
|
|
/// Remove connected `peer`.
|
|
pub fn remove(&mut self, peer: &PeerId) {
|
|
self.live.remove(peer);
|
|
}
|
|
|
|
/// Return _filtered and cloned_ list of peers that have voted on higher than `block`.
|
|
pub fn further_than(&self, block: NumberFor<B>) -> VecDeque<PeerId> {
|
|
self.live
|
|
.iter()
|
|
.filter_map(|(k, v)| (v.last_voted_on > block).then_some(k))
|
|
.cloned()
|
|
.collect()
|
|
}
|
|
|
|
/// Answer whether `peer` is part of `KnownPeers` set.
|
|
pub fn contains(&self, peer: &PeerId) -> bool {
|
|
self.live.contains_key(peer)
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn should_track_known_peers_progress() {
|
|
let (alice, bob, charlie) = (PeerId::random(), PeerId::random(), PeerId::random());
|
|
let mut peers = KnownPeers::<sc_network_test::Block>::new();
|
|
assert!(peers.live.is_empty());
|
|
|
|
// 'Tracked' Bob seen voting for 5.
|
|
peers.note_vote_for(bob, 5);
|
|
// Previously unseen Charlie now seen voting for 10.
|
|
peers.note_vote_for(charlie, 10);
|
|
|
|
assert_eq!(peers.live.len(), 2);
|
|
assert!(!peers.contains(&alice));
|
|
assert!(peers.contains(&bob));
|
|
assert!(peers.contains(&charlie));
|
|
|
|
// Get peers at block > 4
|
|
let further_than_4 = peers.further_than(4);
|
|
// Should be Bob and Charlie
|
|
assert_eq!(further_than_4.len(), 2);
|
|
assert!(further_than_4.contains(&bob));
|
|
assert!(further_than_4.contains(&charlie));
|
|
|
|
// 'Tracked' Alice seen voting for 10.
|
|
peers.note_vote_for(alice, 10);
|
|
|
|
// Get peers at block > 9
|
|
let further_than_9 = peers.further_than(9);
|
|
// Should be Charlie and Alice
|
|
assert_eq!(further_than_9.len(), 2);
|
|
assert!(further_than_9.contains(&charlie));
|
|
assert!(further_than_9.contains(&alice));
|
|
|
|
// Remove Alice
|
|
peers.remove(&alice);
|
|
assert_eq!(peers.live.len(), 2);
|
|
assert!(!peers.contains(&alice));
|
|
|
|
// Get peers at block >= 9
|
|
let further_than_9 = peers.further_than(9);
|
|
// Now should be just Charlie
|
|
assert_eq!(further_than_9.len(), 1);
|
|
assert!(further_than_9.contains(&charlie));
|
|
}
|
|
}
|