mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-01 01:01:01 +00:00
b0b2b6799c
* Decrease peer reputation for duplicate GRANDPA neighbor messages. * Fix comparison * Fix update_peer_state() validity condition * Add negative test * Rework update_peer_state() validity condition, add tests * update_peer_state() validity condition: invert comparison * Split InvalidViewChange and DuplicateNeighborMessage misbehaviors * Enforce rate-limiting of duplicate GRANDPA neighbor packets * Update client/finality-grandpa/src/communication/gossip.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Make rolling clock back in a test safer Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
117 lines
4.0 KiB
Rust
117 lines
4.0 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) 2019-2022 Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
//! Periodic rebroadcast of neighbor packets.
|
|
|
|
use futures::{future::FutureExt as _, prelude::*, ready, stream::Stream};
|
|
use futures_timer::Delay;
|
|
use log::debug;
|
|
use sc_utils::mpsc::{tracing_unbounded, TracingUnboundedReceiver, TracingUnboundedSender};
|
|
use std::{
|
|
pin::Pin,
|
|
task::{Context, Poll},
|
|
time::Duration,
|
|
};
|
|
|
|
use super::gossip::{GossipMessage, NeighborPacket};
|
|
use sc_network::PeerId;
|
|
use sp_runtime::traits::{Block as BlockT, NumberFor};
|
|
|
|
/// A sender used to send neighbor packets to a background job.
|
|
#[derive(Clone)]
|
|
pub(super) struct NeighborPacketSender<B: BlockT>(
|
|
TracingUnboundedSender<(Vec<PeerId>, NeighborPacket<NumberFor<B>>)>,
|
|
);
|
|
|
|
impl<B: BlockT> NeighborPacketSender<B> {
|
|
/// Send a neighbor packet for the background worker to gossip to peers.
|
|
pub fn send(
|
|
&self,
|
|
who: Vec<sc_network::PeerId>,
|
|
neighbor_packet: NeighborPacket<NumberFor<B>>,
|
|
) {
|
|
if let Err(err) = self.0.unbounded_send((who, neighbor_packet)) {
|
|
debug!(target: "afg", "Failed to send neighbor packet: {:?}", err);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// NeighborPacketWorker is listening on a channel for new neighbor packets being produced by
|
|
/// components within `finality-grandpa` and forwards those packets to the underlying
|
|
/// `NetworkEngine` through the `NetworkBridge` that it is being polled by (see `Stream`
|
|
/// implementation). Periodically it sends out the last packet in cases where no new ones arrive.
|
|
pub(super) struct NeighborPacketWorker<B: BlockT> {
|
|
last: Option<(Vec<PeerId>, NeighborPacket<NumberFor<B>>)>,
|
|
rebroadcast_period: Duration,
|
|
delay: Delay,
|
|
rx: TracingUnboundedReceiver<(Vec<PeerId>, NeighborPacket<NumberFor<B>>)>,
|
|
}
|
|
|
|
impl<B: BlockT> Unpin for NeighborPacketWorker<B> {}
|
|
|
|
impl<B: BlockT> NeighborPacketWorker<B> {
|
|
pub(super) fn new(rebroadcast_period: Duration) -> (Self, NeighborPacketSender<B>) {
|
|
let (tx, rx) = tracing_unbounded::<(Vec<PeerId>, NeighborPacket<NumberFor<B>>)>(
|
|
"mpsc_grandpa_neighbor_packet_worker",
|
|
);
|
|
let delay = Delay::new(rebroadcast_period);
|
|
|
|
(
|
|
NeighborPacketWorker { last: None, rebroadcast_period, delay, rx },
|
|
NeighborPacketSender(tx),
|
|
)
|
|
}
|
|
}
|
|
|
|
impl<B: BlockT> Stream for NeighborPacketWorker<B> {
|
|
type Item = (Vec<PeerId>, GossipMessage<B>);
|
|
|
|
fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context) -> Poll<Option<Self::Item>> {
|
|
let this = &mut *self;
|
|
match this.rx.poll_next_unpin(cx) {
|
|
Poll::Ready(None) => return Poll::Ready(None),
|
|
Poll::Ready(Some((to, packet))) => {
|
|
this.delay.reset(this.rebroadcast_period);
|
|
this.last = Some((to.clone(), packet.clone()));
|
|
|
|
return Poll::Ready(Some((to, GossipMessage::<B>::from(packet))))
|
|
},
|
|
// Don't return yet, maybe the timer fired.
|
|
Poll::Pending => {},
|
|
};
|
|
|
|
ready!(this.delay.poll_unpin(cx));
|
|
|
|
// Getting this far here implies that the timer fired.
|
|
|
|
this.delay.reset(this.rebroadcast_period);
|
|
|
|
// Make sure the underlying task is scheduled for wake-up.
|
|
//
|
|
// Note: In case poll_unpin is called after the resetted delay fires again, this
|
|
// will drop one tick. Deemed as very unlikely and also not critical.
|
|
while let Poll::Ready(()) = this.delay.poll_unpin(cx) {}
|
|
|
|
if let Some((ref to, ref packet)) = this.last {
|
|
return Poll::Ready(Some((to.clone(), GossipMessage::<B>::from(packet.clone()))))
|
|
}
|
|
|
|
Poll::Pending
|
|
}
|
|
}
|