mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-06 20:48:02 +00:00
Bastian Köcher
1bc0885829
The trie cache implementation was ignoring the `storage_root` when setting up the value cache. The problem with this is that the value cache works using `storage_keys` and these keys are not unique across different tries. A block can actually have different tries (main trie and multiple child tries). This pull request fixes the issue by not ignoring the `storage_root` and returning an unique `value_cache` per `storage_root`. It also adds a test for the seen bug and improves documentation that this doesn't happen again.
96 lines
3.1 KiB
Rust
96 lines
3.1 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Cumulus.
|
|
|
|
// Cumulus is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Cumulus is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Cumulus. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/// A special pallet that exposes dispatchables that are only useful for testing.
|
|
pub use pallet::*;
|
|
|
|
/// Some key that we set in genesis and only read in [`TestOnRuntimeUpgrade`] to ensure that
|
|
/// [`OnRuntimeUpgrade`] works as expected.
|
|
pub const TEST_RUNTIME_UPGRADE_KEY: &[u8] = b"+test_runtime_upgrade_key+";
|
|
|
|
#[frame_support::pallet(dev_mode)]
|
|
pub mod pallet {
|
|
use crate::test_pallet::TEST_RUNTIME_UPGRADE_KEY;
|
|
use frame_support::pallet_prelude::*;
|
|
use frame_system::pallet_prelude::*;
|
|
|
|
#[pallet::pallet]
|
|
pub struct Pallet<T>(_);
|
|
|
|
#[pallet::config]
|
|
pub trait Config: frame_system::Config + cumulus_pallet_parachain_system::Config {}
|
|
|
|
#[pallet::hooks]
|
|
impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {}
|
|
|
|
#[pallet::call]
|
|
impl<T: Config> Pallet<T> {
|
|
/// A test dispatchable for setting a custom head data in `validate_block`.
|
|
#[pallet::weight(0)]
|
|
pub fn set_custom_validation_head_data(
|
|
_: OriginFor<T>,
|
|
custom_header: sp_std::vec::Vec<u8>,
|
|
) -> DispatchResult {
|
|
cumulus_pallet_parachain_system::Pallet::<T>::set_custom_validation_head_data(
|
|
custom_header,
|
|
);
|
|
Ok(())
|
|
}
|
|
|
|
/// A dispatchable that first reads two values from two different child tries, asserts they
|
|
/// are the expected values (if the values exist in the state) and then writes two different
|
|
/// values to these child tries.
|
|
#[pallet::weight(0)]
|
|
pub fn read_and_write_child_tries(_: OriginFor<T>) -> DispatchResult {
|
|
let key = &b"hello"[..];
|
|
let first_trie = &b"first"[..];
|
|
let second_trie = &b"second"[..];
|
|
let first_value = "world1".encode();
|
|
let second_value = "world2".encode();
|
|
|
|
if let Some(res) = sp_io::default_child_storage::get(first_trie, key) {
|
|
assert_eq!(first_value, res);
|
|
}
|
|
if let Some(res) = sp_io::default_child_storage::get(second_trie, key) {
|
|
assert_eq!(second_value, res);
|
|
}
|
|
|
|
sp_io::default_child_storage::set(first_trie, key, &first_value);
|
|
sp_io::default_child_storage::set(second_trie, key, &second_value);
|
|
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
#[derive(frame_support::DefaultNoBound)]
|
|
#[pallet::genesis_config]
|
|
pub struct GenesisConfig<T: Config> {
|
|
pub self_para_id: Option<cumulus_primitives_core::ParaId>,
|
|
#[serde(skip)]
|
|
pub _config: sp_std::marker::PhantomData<T>,
|
|
}
|
|
|
|
#[pallet::genesis_build]
|
|
impl<T: Config> BuildGenesisConfig for GenesisConfig<T> {
|
|
fn build(&self) {
|
|
sp_io::storage::set(TEST_RUNTIME_UPGRADE_KEY, &[1, 2, 3, 4]);
|
|
self.self_para_id.map(|para_id| {
|
|
crate::ParachainId::set(¶_id);
|
|
});
|
|
}
|
|
}
|
|
}
|