Files
pezkuwi-subxt/substrate/core/sr-arithmetic/fuzzer/src/biguint.rs
T
Ashley 141a64cf41 Move sr-arithmetic to a new crate and add in a fuzzer (#3799)
* Split up sr_arithmetic.rs

* Add some basic fuzzing

* Add more tests

* Add printing to fuzzing

* Clean things up

* Remove arbitrary

* Remove comments

* More cleaning, fix small error that was causing a panic

* Add rational128

* Remove old random tests

* introduce panic

* fuzzing should panic properly

* Bit of cleanup

* Add a test uncovered via fuzzing that fails!

* Few small changes

* Move sr-arithmetic to its own crate

* Fix fuzzing

* Got rid of fuzzer Cargo.lock

* Added no_std

* re-export assert_eq_error_rate

* bump impl and spec version

* re add convert into

* Add an ignore to the test

* Enabled benchmarking

* Reindent

* Clean up biguint fuzzer

* Clean up biguint more

* shuffle sr-primitives/traits about

* Remove unused dependencies

* Apply clippy suggestions

* upgrade primitive-types versions

* Run tests against num-bigint

* Get rid of allocation in assert_biguints_eq

* Add an optimisation to multiply_by_rational

* rename parts_per_x -> per_things

* Change fuzzer cargo.toml

* Remove allocation from BigUint PartialEq impl

* Remove accidental indentation

* Renmove Lazy and Convert traits

* Copy assert_eq_error_rate macro back to sr-primitives

* Add documentation to fuzzers

* fix sr-primitives assert_eq_error_rate

* add cfg(test)

* Update core/sr-arithmetic/src/traits.rs

Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update core/sr-arithmetic/src/traits.rs

Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update core/sr-arithmetic/fuzzer/src/biguint.rs

Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Allow rounding up in rational128

* Make changes to biguint.rs

* Update core/sr-arithmetic/src/traits.rs

Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Final touches

* Convert to num_bigint::BigUint to compare

* remove unused mut

* more small changes

* shuffle sr-primitives trait imports

* more code review

* move assert_eq_error_rate to lib.rs

* Update core/sr-arithmetic/fuzzer/src/biguint.rs

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

* Get rid of S

* Simplify rational128 honggfuzz link

* Insignificantly change rational128 fuzzing code

* Slightly tidy up some of the arithmetic logic

* Get rid of sr_arithmetic again(?) and fix sr-primitives/weights

* Apply updates to sr_arithmetic.rs to crate
2019-10-19 09:36:43 +02:00

182 lines
5.0 KiB
Rust

// Copyright 2019 Parity Technologies (UK) Ltd.
// This file is part of Substrate.
// Substrate is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// Substrate is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with Substrate. If not, see <http://www.gnu.org/licenses/>.
//! # Running
//! Running this fuzzer can be done with `cargo hfuzz run biguint`. `honggfuzz` CLI options can
//! be used by setting `HFUZZ_RUN_ARGS`, such as `-n 4` to use 4 threads.
//!
//! # Debugging a panic
//! Once a panic is found, it can be debugged with
//! `cargo hfuzz run-debug biguint hfuzz_workspace/biguint/*.fuzz`.
//!
//! # More infomation
//! More information about `honggfuzz` can be found
//! [here](https://docs.rs/honggfuzz/).
use honggfuzz::fuzz;
use sr_arithmetic::biguint::{BigUint, Single};
use std::convert::TryFrom;
fn main() {
loop {
fuzz!(|data: (Vec<Single>, Vec<Single>, bool)| {
let (mut digits_u, mut digits_v, return_remainder) = data;
let mut u = BigUint::from_limbs(&digits_u);
let mut v = BigUint::from_limbs(&digits_v);
u.lstrip();
v.lstrip();
let ue = u128::try_from(u.clone());
let ve = u128::try_from(v.clone());
digits_u.reverse();
digits_v.reverse();
let num_u = num_bigint::BigUint::new(digits_u.clone());
let num_v = num_bigint::BigUint::new(digits_v.clone());
if check_digit_lengths(&u, &v, 4) {
assert_eq!(u.cmp(&v), ue.cmp(&ve));
assert_eq!(u.eq(&v), ue.eq(&ve));
}
if check_digit_lengths(&u, &v, 3) {
let expected = ue.unwrap() + ve.unwrap();
let t = u.clone().add(&v);
assert_eq!(
u128::try_from(t.clone()).unwrap(), expected,
"{:?} + {:?} ===> {:?} != {:?}", u, v, t, expected,
);
}
if check_digit_lengths(&u, &v, 4) {
let expected = ue.unwrap().checked_sub(ve.unwrap());
let t = u.clone().sub(&v);
if expected.is_none() {
assert!(t.is_err())
} else {
let t = t.unwrap();
let expected = expected.unwrap();
assert_eq!(
u128::try_from(t.clone()).unwrap(), expected,
"{:?} - {:?} ===> {:?} != {:?}", u, v, t, expected,
);
}
}
if check_digit_lengths(&u, &v, 2) {
let expected = ue.unwrap() * ve.unwrap();
let t = u.clone().mul(&v);
assert_eq!(
u128::try_from(t.clone()).unwrap(), expected,
"{:?} * {:?} ===> {:?} != {:?}", u, v, t, expected,
);
}
if check_digit_lengths(&u, &v, 4) {
let (ue, ve) = (ue.unwrap(), ve.unwrap());
if ve == 0 {
return;
}
let (q, r) = (ue / ve, ue % ve);
if let Some((qq, rr)) = u.clone().div(&v, true) {
assert_eq!(
u128::try_from(qq.clone()).unwrap(), q,
"{:?} / {:?} ===> {:?} != {:?}", u, v, qq, q,
);
assert_eq!(
u128::try_from(rr.clone()).unwrap(), r,
"{:?} % {:?} ===> {:?} != {:?}", u, v, rr, r,
);
} else if v.len() == 1 {
let qq = u.clone().div_unit(ve as Single);
assert_eq!(
u128::try_from(qq.clone()).unwrap(), q,
"[single] {:?} / {:?} ===> {:?} != {:?}", u, v, qq, q,
);
} else if v.msb() != 0 && u.msb() != 0 && u.len() > v.len() {
panic!("div returned none for an unexpected reason");
}
}
// Test against num_bigint
// Equality
assert_eq!(u.cmp(&v), num_u.cmp(&num_v));
// Addition
let w = u.clone().add(&v);
let num_w = num_u.clone() + &num_v;
assert_biguints_eq(&w, &num_w);
// Subtraction
if let Ok(w) = u.clone().sub(&v) {
let num_w = num_u.clone() - &num_v;
assert_biguints_eq(&w, &num_w);
}
// Multiplication
let w = u.clone().mul(&v);
let num_w = num_u.clone() * &num_v;
assert_biguints_eq(&w, &num_w);
// Division
if v.len() == 1 && v.get(0) != 0 {
let w = u.clone().div_unit(v.get(0));
let num_w = num_u.clone() / &num_v;
assert_biguints_eq(&w, &num_w);
} else if u.len() > v.len() && v.len() > 0 {
let num_remainder = num_u.clone() % num_v.clone();
let (w, remainder) = u.clone().div(&v, return_remainder).unwrap();
let num_w = num_u.clone() / &num_v;
assert_biguints_eq(&w, &num_w);
if return_remainder {
assert_biguints_eq(&remainder, &num_remainder);
}
}
});
}
}
fn check_digit_lengths(u: &BigUint, v: &BigUint, max_limbs: usize) -> bool {
1 <= u.len() && u.len() <= max_limbs && 1 <= v.len() && v.len() <= max_limbs
}
fn assert_biguints_eq(a: &BigUint, b: &num_bigint::BigUint) {
let mut a = a.clone();
a.lstrip();
// `num_bigint::BigUint` doesn't expose it's internals, so we need to convert into that to
// compare.
let limbs = (0 .. a.len()).map(|i| a.get(i)).collect();
let num_a = num_bigint::BigUint::new(limbs);
assert!(&num_a == b, "\narithmetic: {:?}\nnum-bigint: {:?}", a, b);
}