mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-28 09:47:56 +00:00
6cc4495700
* Remove offline slashing logic from staking. * Initial version of reworked offence module, can report offences * Clean up staking example. * Commit SlashingOffence * Force new era on slash. * Add offenders in the SlashingOffence trait. * Introduce the ReportOffence trait. * Rename `Offence`. * Add on_before_session_ending handler. * Move offence related stuff under sr-primitives. * Fix cargo check. * Import new im-online implementation. * Adding validator count to historical session storage as it's needed for slash calculations * Add a comment about offence. * Add BabeEquivocationOffence * GrandpaEquivocationOffence * slash_fraction and fix * current_era_start_session_index * UnresponsivnessOffence * Finalise OnOffenceHandler traits, and stub impl for staking. * slash_fraction doesn't really need &self * Note that offenders count is greater than 0 * Add a test to ensure that I got the math right * Use FullIdentification in offences. * Use FullIndentification. * Hook up the offences module. * Report unresponsive validators * Make sure eras have the same length. * Slashing and rewards. * Fix compilation. * Distribute rewards. * Supply validators_count * Use identificationTuple in Unresponsivness report * Fix merge. * Make sure we don't slash if amount is zero. * We don't return an error from report_offence anymo * We actually can use vec! * Prevent division by zero if the reporters is empty * offence_forces_new_era/nominators_also_get_slashed * advance_session * Fix tests. * Update srml/staking/src/lib.rs Co-Authored-By: Robert Habermeier <rphmeier@gmail.com> * slashing_performed_according_exposure * Check that reporters receive their slice. * Small clean-up. * invulnerables_are_not_slashed * Minor clean ups. * Improve docs. * dont_slash_if_fraction_is_zero * Remove session dependency from offences. * Introduce sr-staking-primitives * Move offence under sr_staking_primitives * rename session_index * Resolves todos re using SessionIndex * Fix staking tests. * Properly scale denominator. * Fix UnresponsivnessOffence * Fix compilation. * Tests for offences. * Clean offences tests. * Fix staking doc test. * Bump spec version * Fix aura tests. * Fix node_executor * Deposit an event on offence. * Fix compilation of node-runtime * Remove aura slashing logic. * Remove HandleReport * Update docs for timeslot. * rename with_on_offence_fractions * Add should_properly_count_offences * Replace ValidatorIdByIndex with CurrentElectedSet ValidatorIdByIndex was querying the current_elected set in each call, doing loading (even though its from cache), deserializing and cloning of element. Instead of this it is more efficient to use `CurrentElectedSet`. As a small bonus, the invariant became a little bit easier: now we just rely on the fact that `keys` and `current_elected` set are of the same length rather than relying on the fact that `validator_id_by_index` would work similar to `<[T]>::get`. * Clarify babe equivocation * Fix offences. * Rename validators_count to validator_set_count * Fix squaring. * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: Gavin Wood <gavin@parity.io> * Docs for CurrentElectedSet. * Don't punish only invulnerables * Use `get/insert` instead of `mutate`. * Fix compilation * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: Gavin Wood <gavin@parity.io> * Update srml/offences/src/lib.rs Co-Authored-By: Robert Habermeier <rphmeier@gmail.com> * Update srml/im-online/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update srml/im-online/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update srml/im-online/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update srml/babe/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update core/sr-staking-primitives/src/offence.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Add aura todo. * Allow multiple reports for single offence report. * Fix slash_fraction calculation. * Fix typos. * Fix compilation and tests. * Fix staking tests. * Update srml/im-online/src/lib.rs Co-Authored-By: Logan Saether <x@logansaether.com> * Fix doc on time_slot * Allow slashing only on current era (#3411) * only slash in current era * prune journal for last era * comment own_slash * emit an event when old slashing events are discarded * Pave the way for pruning * Address issues. * Try to refactor collect_offence_reports * Other fixes. * More fixes.
143 lines
5.6 KiB
Rust
143 lines
5.6 KiB
Rust
// Copyright 2019 Parity Technologies (UK) Ltd.
|
|
// This file is part of Substrate.
|
|
|
|
// Substrate is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Substrate is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Substrate. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Common traits and types that are useful for describing offences for usage in environments
|
|
//! that use staking.
|
|
|
|
use rstd::vec::Vec;
|
|
|
|
use codec::{Encode, Decode};
|
|
use sr_primitives::Perbill;
|
|
|
|
use crate::SessionIndex;
|
|
|
|
/// The kind of an offence, is a byte string representing some kind identifier
|
|
/// e.g. `b"im-online:offlin"`, `b"babe:equivocatio"`
|
|
// TODO [slashing]: Is there something better we can have here that is more natural but still
|
|
// flexible? as you see in examples, they get cut off with long names.
|
|
pub type Kind = [u8; 16];
|
|
|
|
/// Number of times the offence of this authority was already reported in the past.
|
|
///
|
|
/// Note that we don't buffer offence reporting, so every time we see a new offence
|
|
/// of the same kind, we will report past authorities again.
|
|
/// This counter keeps track of how many times the authority was already reported in the past,
|
|
/// so that we can slash it accordingly.
|
|
pub type OffenceCount = u32;
|
|
|
|
/// A trait implemented by an offence report.
|
|
///
|
|
/// This trait assumes that the offence is legitimate and was validated already.
|
|
///
|
|
/// Examples of offences include: a BABE equivocation or a GRANDPA unjustified vote.
|
|
pub trait Offence<Offender> {
|
|
/// Identifier which is unique for this kind of an offence.
|
|
const ID: Kind;
|
|
|
|
/// A type that represents a point in time on an abstract timescale.
|
|
///
|
|
/// See `Offence::time_slot` for details. The only requirement is that such timescale could be
|
|
/// represented by a single `u128` value.
|
|
type TimeSlot: Clone + codec::Codec + Ord;
|
|
|
|
/// The list of all offenders involved in this incident.
|
|
///
|
|
/// The list has no duplicates, so it is rather a set.
|
|
fn offenders(&self) -> Vec<Offender>;
|
|
|
|
/// The session index that is used for querying the validator set for the `slash_fraction`
|
|
/// function.
|
|
///
|
|
/// This is used for filtering historical sessions.
|
|
fn session_index(&self) -> SessionIndex;
|
|
|
|
/// Return a validator set count at the time when the offence took place.
|
|
fn validator_set_count(&self) -> u32;
|
|
|
|
/// A point in time when this offence happened.
|
|
///
|
|
/// This is used for looking up offences that happened at the "same time".
|
|
///
|
|
/// The timescale is abstract and doesn't have to be the same across different implementations
|
|
/// of this trait. The value doesn't represent absolute timescale though since it is interpreted
|
|
/// along with the `session_index`. Two offences are considered to happen at the same time iff
|
|
/// both `session_index` and `time_slot` are equal.
|
|
///
|
|
/// As an example, for GRANDPA timescale could be a round number and for BABE it could be a slot
|
|
/// number. Note that for GRANDPA the round number is reset each epoch.
|
|
fn time_slot(&self) -> Self::TimeSlot;
|
|
|
|
/// A slash fraction of the total exposure that should be slashed for this
|
|
/// particular offence kind for the given parameters that happened at a singular `TimeSlot`.
|
|
///
|
|
/// `offenders_count` - the count of unique offending authorities. It is >0.
|
|
/// `validator_set_count` - the cardinality of the validator set at the time of offence.
|
|
fn slash_fraction(
|
|
offenders_count: u32,
|
|
validator_set_count: u32,
|
|
) -> Perbill;
|
|
}
|
|
|
|
/// A trait for decoupling offence reporters from the actual handling of offence reports.
|
|
pub trait ReportOffence<Reporter, Offender, O: Offence<Offender>> {
|
|
/// Report an `offence` and reward given `reporters`.
|
|
fn report_offence(reporters: Vec<Reporter>, offence: O);
|
|
}
|
|
|
|
impl<Reporter, Offender, O: Offence<Offender>> ReportOffence<Reporter, Offender, O> for () {
|
|
fn report_offence(_reporters: Vec<Reporter>, _offence: O) {}
|
|
}
|
|
|
|
/// A trait to take action on an offence.
|
|
///
|
|
/// Used to decouple the module that handles offences and
|
|
/// the one that should punish for those offences.
|
|
pub trait OnOffenceHandler<Reporter, Offender> {
|
|
/// A handler for an offence of a particular kind.
|
|
///
|
|
/// Note that this contains a list of all previous offenders
|
|
/// as well. The implementer should cater for a case, where
|
|
/// the same authorities were reported for the same offence
|
|
/// in the past (see `OffenceCount`).
|
|
///
|
|
/// The vector of `slash_fraction` contains `Perbill`s
|
|
/// the authorities should be slashed and is computed
|
|
/// according to the `OffenceCount` already. This is of the same length as `offenders.`
|
|
/// Zero is a valid value for a fraction.
|
|
fn on_offence(
|
|
offenders: &[OffenceDetails<Reporter, Offender>],
|
|
slash_fraction: &[Perbill],
|
|
);
|
|
}
|
|
|
|
impl<Reporter, Offender> OnOffenceHandler<Reporter, Offender> for () {
|
|
fn on_offence(
|
|
_offenders: &[OffenceDetails<Reporter, Offender>],
|
|
_slash_fraction: &[Perbill],
|
|
) {}
|
|
}
|
|
|
|
/// A details about an offending authority for a particular kind of offence.
|
|
#[derive(Clone, PartialEq, Eq, Encode, Decode)]
|
|
#[cfg_attr(feature = "std", derive(Debug))]
|
|
pub struct OffenceDetails<Reporter, Offender> {
|
|
/// The offending authority id
|
|
pub offender: Offender,
|
|
/// A list of reporters of offences of this authority ID. Possibly empty where there are no
|
|
/// particular reporters.
|
|
pub reporters: Vec<Reporter>,
|
|
}
|