mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-30 21:01:02 +00:00
bb8ddc46c1
I started this investigation/issue based on @liamaharon question [here](https://github.com/paritytech/polkadot-sdk/pull/1801#discussion_r1410452499). ## Problem The `pallet_balances` integrity test should correctly detect that the runtime has correct distinct `HoldReasons` variant count. I assume the same situation exists for RuntimeFreezeReason. It is not a critical problem, if we set `MaxHolds` with a sufficiently large value, everything should be ok. However, in this case, the integrity_test check becomes less useful. **Situation for "any" runtime:** - `HoldReason` enums from different pallets: ```rust /// from pallet_nis #[pallet::composite_enum] pub enum HoldReason { NftReceipt, } /// from pallet_preimage #[pallet::composite_enum] pub enum HoldReason { Preimage, } // from pallet_state-trie-migration #[pallet::composite_enum] pub enum HoldReason { SlashForContinueMigrate, SlashForMigrateCustomTop, SlashForMigrateCustomChild, } ``` - generated `RuntimeHoldReason` enum looks like: ```rust pub enum RuntimeHoldReason { #[codec(index = 32u8)] Preimage(pallet_preimage::HoldReason), #[codec(index = 38u8)] Nis(pallet_nis::HoldReason), #[codec(index = 42u8)] StateTrieMigration(pallet_state_trie_migration::HoldReason), } ``` - composite enum `RuntimeHoldReason` variant count is detected as `3` - we set `type MaxHolds = ConstU32<3>` - `pallet_balances::integrity_test` is ok with `3`(at least 3) However, the real problem can occur in a live runtime where some functionality might stop working. This is due to a total of 5 distinct hold reasons (for pallets with multi-instance support, it is even more), and not all of them can be used because of an incorrect `MaxHolds`, which is deemed acceptable according to the `integrity_test`: ``` // pseudo-code - if we try to call all of these: T::Currency::hold(&pallet_nis::HoldReason::NftReceipt.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_preimage::HoldReason::Preimage.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForContinueMigrate.into(), &nft_owner, deposit)?; // With `type MaxHolds = ConstU32<3>` these two will fail T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomTop.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomChild.into(), &nft_owner, deposit)?; ``` ## Solutions A macro `#[pallet::*]` expansion is extended of `VariantCount` implementation for the `#[pallet::composite_enum]` enum type. This expansion generates the `VariantCount` implementation for pallets' `HoldReason`, `FreezeReason`, `LockId`, and `SlashReason`. Enum variants must be plain enum values without fields to ensure a deterministic count. The composite runtime enum, `RuntimeHoldReason` and `RuntimeFreezeReason`, now sets `VariantCount::VARIANT_COUNT` as the sum of pallets' enum `VariantCount::VARIANT_COUNT`: ```rust #[frame_support::pallet(dev_mode)] mod module_single_instance { #[pallet::composite_enum] pub enum HoldReason { ModuleSingleInstanceReason1, ModuleSingleInstanceReason2, } ... } #[frame_support::pallet(dev_mode)] mod module_multi_instance { #[pallet::composite_enum] pub enum HoldReason<I: 'static = ()> { ModuleMultiInstanceReason1, ModuleMultiInstanceReason2, ModuleMultiInstanceReason3, } ... } impl self::sp_api_hidden_includes_construct_runtime::hidden_include::traits::VariantCount for RuntimeHoldReason { const VARIANT_COUNT: u32 = 0 + module_single_instance::HoldReason::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance1>::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance2>::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance3>::VARIANT_COUNT; } ``` In addition, `MaxHolds` is removed (as suggested [here](https://github.com/paritytech/polkadot-sdk/pull/2657#discussion_r1443324573)) from `pallet_balances`, and its `Holds` are now bounded to `RuntimeHoldReason::VARIANT_COUNT`. Therefore, there is no need to let the runtime specify `MaxHolds`. ## For reviewers Relevant changes can be found here: - `substrate/frame/support/procedural/src/lib.rs` - `substrate/frame/support/procedural/src/pallet/parse/composite.rs` - `substrate/frame/support/procedural/src/pallet/expand/composite.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/composite_helper.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/hold_reason.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/freeze_reason.rs` - `substrate/frame/support/src/traits/misc.rs` And the rest of the files is just about removed `MaxHolds` from `pallet_balances` ## Next steps Do the same for `MaxFreezes` https://github.com/paritytech/polkadot-sdk/issues/2997. --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
163 lines
6.7 KiB
Rust
163 lines
6.7 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Cumulus.
|
|
|
|
// Cumulus is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Cumulus is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Cumulus. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Autogenerated weights for `pallet_balances`
|
|
//!
|
|
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 32.0.0
|
|
//! DATE: 2024-01-31, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
|
|
//! WORST CASE MAP SIZE: `1000000`
|
|
//! HOSTNAME: `runner-8idpd4bs-project-674-concurrent-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
|
|
//! WASM-EXECUTION: `Compiled`, CHAIN: `Some("collectives-westend-dev")`, DB CACHE: 1024
|
|
|
|
// Executed Command:
|
|
// target/production/polkadot-parachain
|
|
// benchmark
|
|
// pallet
|
|
// --steps=50
|
|
// --repeat=20
|
|
// --extrinsic=*
|
|
// --wasm-execution=compiled
|
|
// --heap-pages=4096
|
|
// --json-file=/builds/parity/mirrors/polkadot-sdk/.git/.artifacts/bench.json
|
|
// --pallet=pallet_balances
|
|
// --chain=collectives-westend-dev
|
|
// --header=./cumulus/file_header.txt
|
|
// --output=./cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/
|
|
|
|
#![cfg_attr(rustfmt, rustfmt_skip)]
|
|
#![allow(unused_parens)]
|
|
#![allow(unused_imports)]
|
|
#![allow(missing_docs)]
|
|
|
|
use frame_support::{traits::Get, weights::Weight};
|
|
use core::marker::PhantomData;
|
|
|
|
/// Weight functions for `pallet_balances`.
|
|
pub struct WeightInfo<T>(PhantomData<T>);
|
|
impl<T: frame_system::Config> pallet_balances::WeightInfo for WeightInfo<T> {
|
|
/// Storage: `System::Account` (r:1 w:1)
|
|
/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
|
|
fn transfer_allow_death() -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `0`
|
|
// Estimated: `3593`
|
|
// Minimum execution time: 45_085_000 picoseconds.
|
|
Weight::from_parts(45_772_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 3593))
|
|
.saturating_add(T::DbWeight::get().reads(1))
|
|
.saturating_add(T::DbWeight::get().writes(1))
|
|
}
|
|
/// Storage: `System::Account` (r:1 w:1)
|
|
/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
|
|
fn transfer_keep_alive() -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `0`
|
|
// Estimated: `3593`
|
|
// Minimum execution time: 35_447_000 picoseconds.
|
|
Weight::from_parts(36_143_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 3593))
|
|
.saturating_add(T::DbWeight::get().reads(1))
|
|
.saturating_add(T::DbWeight::get().writes(1))
|
|
}
|
|
/// Storage: `System::Account` (r:1 w:1)
|
|
/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
|
|
fn force_set_balance_creating() -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `103`
|
|
// Estimated: `3593`
|
|
// Minimum execution time: 12_314_000 picoseconds.
|
|
Weight::from_parts(12_679_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 3593))
|
|
.saturating_add(T::DbWeight::get().reads(1))
|
|
.saturating_add(T::DbWeight::get().writes(1))
|
|
}
|
|
/// Storage: `System::Account` (r:1 w:1)
|
|
/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
|
|
fn force_set_balance_killing() -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `103`
|
|
// Estimated: `3593`
|
|
// Minimum execution time: 17_455_000 picoseconds.
|
|
Weight::from_parts(17_902_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 3593))
|
|
.saturating_add(T::DbWeight::get().reads(1))
|
|
.saturating_add(T::DbWeight::get().writes(1))
|
|
}
|
|
/// Storage: `System::Account` (r:2 w:2)
|
|
/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
|
|
fn force_transfer() -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `103`
|
|
// Estimated: `6196`
|
|
// Minimum execution time: 46_785_000 picoseconds.
|
|
Weight::from_parts(47_436_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 6196))
|
|
.saturating_add(T::DbWeight::get().reads(2))
|
|
.saturating_add(T::DbWeight::get().writes(2))
|
|
}
|
|
/// Storage: `System::Account` (r:1 w:1)
|
|
/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
|
|
fn transfer_all() -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `0`
|
|
// Estimated: `3593`
|
|
// Minimum execution time: 43_948_000 picoseconds.
|
|
Weight::from_parts(44_680_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 3593))
|
|
.saturating_add(T::DbWeight::get().reads(1))
|
|
.saturating_add(T::DbWeight::get().writes(1))
|
|
}
|
|
/// Storage: `System::Account` (r:1 w:1)
|
|
/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
|
|
fn force_unreserve() -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `103`
|
|
// Estimated: `3593`
|
|
// Minimum execution time: 15_267_000 picoseconds.
|
|
Weight::from_parts(15_499_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 3593))
|
|
.saturating_add(T::DbWeight::get().reads(1))
|
|
.saturating_add(T::DbWeight::get().writes(1))
|
|
}
|
|
/// Storage: `System::Account` (r:999 w:999)
|
|
/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
|
|
/// The range of component `u` is `[1, 1000]`.
|
|
fn upgrade_accounts(u: u32, ) -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `0 + u * (136 ±0)`
|
|
// Estimated: `990 + u * (2603 ±0)`
|
|
// Minimum execution time: 14_817_000 picoseconds.
|
|
Weight::from_parts(15_287_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 990))
|
|
// Standard Error: 11_738
|
|
.saturating_add(Weight::from_parts(13_511_800, 0).saturating_mul(u.into()))
|
|
.saturating_add(T::DbWeight::get().reads((1_u64).saturating_mul(u.into())))
|
|
.saturating_add(T::DbWeight::get().writes((1_u64).saturating_mul(u.into())))
|
|
.saturating_add(Weight::from_parts(0, 2603).saturating_mul(u.into()))
|
|
}
|
|
/// Storage: `Balances::InactiveIssuance` (r:1 w:0)
|
|
/// Proof: `Balances::InactiveIssuance` (`max_values`: Some(1), `max_size`: Some(16), added: 511, mode: `MaxEncodedLen`)
|
|
fn force_adjust_total_issuance() -> Weight {
|
|
// Proof Size summary in bytes:
|
|
// Measured: `0`
|
|
// Estimated: `1501`
|
|
// Minimum execution time: 5_382_000 picoseconds.
|
|
Weight::from_parts(5_768_000, 0)
|
|
.saturating_add(Weight::from_parts(0, 1501))
|
|
.saturating_add(T::DbWeight::get().reads(1))
|
|
}
|
|
}
|