mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-27 17:25:46 +00:00
s0me0ne-unkn0wn
3e8139e7de
Currently, collators and their alongside nodes spin up a full-scale overseer running a bunch of subsystems that are not needed if the node is not a validator. That was considered to be harmless; however, we've got problems with unused subsystems getting stalled for a reason not currently known, resulting in the overseer exiting and bringing down the whole node. This PR aims to only run needed subsystems on such nodes, replacing the rest with `DummySubsystem`. It also enables collator-optimized availability recovery subsystem implementation. Partially solves #1730.
102 lines
3.2 KiB
Rust
102 lines
3.2 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! This variant of Malus overrides the `disabled_validators` runtime API
|
|
//! to always return an empty set of disabled validators.
|
|
|
|
use polkadot_cli::{
|
|
service::{
|
|
AuthorityDiscoveryApi, AuxStore, BabeApi, Block, Error, ExtendedOverseerGenArgs,
|
|
HeaderBackend, Overseer, OverseerConnector, OverseerGen, OverseerGenArgs, OverseerHandle,
|
|
ParachainHost, ProvideRuntimeApi,
|
|
},
|
|
validator_overseer_builder, Cli,
|
|
};
|
|
use polkadot_node_subsystem::SpawnGlue;
|
|
use polkadot_node_subsystem_types::DefaultSubsystemClient;
|
|
use sp_core::traits::SpawnNamed;
|
|
|
|
use crate::interceptor::*;
|
|
|
|
use std::sync::Arc;
|
|
|
|
#[derive(Debug, clap::Parser)]
|
|
#[clap(rename_all = "kebab-case")]
|
|
#[allow(missing_docs)]
|
|
pub struct SupportDisabledOptions {
|
|
#[clap(flatten)]
|
|
pub cli: Cli,
|
|
}
|
|
|
|
/// Generates an overseer with a custom runtime API subsystem.
|
|
pub(crate) struct SupportDisabled;
|
|
|
|
impl OverseerGen for SupportDisabled {
|
|
fn generate<Spawner, RuntimeClient>(
|
|
&self,
|
|
connector: OverseerConnector,
|
|
args: OverseerGenArgs<'_, Spawner, RuntimeClient>,
|
|
ext_args: Option<ExtendedOverseerGenArgs>,
|
|
) -> Result<
|
|
(Overseer<SpawnGlue<Spawner>, Arc<DefaultSubsystemClient<RuntimeClient>>>, OverseerHandle),
|
|
Error,
|
|
>
|
|
where
|
|
RuntimeClient: 'static + ProvideRuntimeApi<Block> + HeaderBackend<Block> + AuxStore,
|
|
RuntimeClient::Api: ParachainHost<Block> + BabeApi<Block> + AuthorityDiscoveryApi<Block>,
|
|
Spawner: 'static + SpawnNamed + Clone + Unpin,
|
|
{
|
|
validator_overseer_builder(
|
|
args,
|
|
ext_args.expect("Extended arguments required to build validator overseer are provided"),
|
|
)?
|
|
.replace_runtime_api(move |ra_subsystem| {
|
|
InterceptedSubsystem::new(ra_subsystem, IgnoreDisabled)
|
|
})
|
|
.build_with_connector(connector)
|
|
.map_err(|e| e.into())
|
|
}
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
struct IgnoreDisabled;
|
|
|
|
impl<Sender> MessageInterceptor<Sender> for IgnoreDisabled
|
|
where
|
|
Sender: overseer::RuntimeApiSenderTrait + Clone + Send + 'static,
|
|
{
|
|
type Message = RuntimeApiMessage;
|
|
|
|
/// Intercept incoming runtime api requests.
|
|
fn intercept_incoming(
|
|
&self,
|
|
_subsystem_sender: &mut Sender,
|
|
msg: FromOrchestra<Self::Message>,
|
|
) -> Option<FromOrchestra<Self::Message>> {
|
|
match msg {
|
|
FromOrchestra::Communication {
|
|
msg:
|
|
RuntimeApiMessage::Request(_relay_parent, RuntimeApiRequest::DisabledValidators(tx)),
|
|
} => {
|
|
let _ = tx.send(Ok(Vec::new()));
|
|
None
|
|
},
|
|
FromOrchestra::Communication { msg } => Some(FromOrchestra::Communication { msg }),
|
|
FromOrchestra::Signal(signal) => Some(FromOrchestra::Signal(signal)),
|
|
}
|
|
}
|
|
}
|