mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-25 04:51:08 +00:00
Alexandru Gheorghe
a84dd0dba5
Initial implementation for the plan discussed here: https://github.com/paritytech/polkadot-sdk/issues/701 Built on top of https://github.com/paritytech/polkadot-sdk/pull/1178 v0: https://github.com/paritytech/polkadot/pull/7554, ## Overall idea When approval-voting checks a candidate and is ready to advertise the approval, defer it in a per-relay chain block until we either have MAX_APPROVAL_COALESCE_COUNT candidates to sign or a candidate has stayed MAX_APPROVALS_COALESCE_TICKS in the queue, in both cases we sign what candidates we have available. This should allow us to reduce the number of approvals messages we have to create/send/verify. The parameters are configurable, so we should find some values that balance: - Security of the network: Delaying broadcasting of an approval shouldn't but the finality at risk and to make sure that never happens we won't delay sending a vote if we are past 2/3 from the no-show time. - Scalability of the network: MAX_APPROVAL_COALESCE_COUNT = 1 & MAX_APPROVALS_COALESCE_TICKS =0, is what we have now and we know from the measurements we did on versi, it bottlenecks approval-distribution/approval-voting when increase significantly the number of validators and parachains - Block storage: In case of disputes we have to import this votes on chain and that increase the necessary storage with MAX_APPROVAL_COALESCE_COUNT * CandidateHash per vote. Given that disputes are not the normal way of the network functioning and we will limit MAX_APPROVAL_COALESCE_COUNT in the single digits numbers, this should be good enough. Alternatively, we could try to create a better way to store this on-chain through indirection, if that's needed. ## Other fixes: - Fixed the fact that we were sending random assignments to non-validators, that was wrong because those won't do anything with it and they won't gossip it either because they do not have a grid topology set, so we would waste the random assignments. - Added metrics to be able to debug potential no-shows and mis-processing of approvals/assignments. ## TODO: - [x] Get feedback, that this is moving in the right direction. @ordian @sandreim @eskimor @burdges, let me know what you think. - [x] More and more testing. - [x] Test in versi. - [x] Make MAX_APPROVAL_COALESCE_COUNT & MAX_APPROVAL_COALESCE_WAIT_MILLIS a parachain host configuration. - [x] Make sure the backwards compatibility works correctly - [x] Make sure this direction is compatible with other streams of work: https://github.com/paritytech/polkadot-sdk/issues/635 & https://github.com/paritytech/polkadot-sdk/issues/742 - [x] Final versi burn-in before merging --------- Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
78 lines
2.6 KiB
TOML
78 lines
2.6 KiB
TOML
[package]
|
|
name = "polkadot-cli"
|
|
description = "Polkadot Relay-chain Client Node"
|
|
version = "1.1.0"
|
|
authors.workspace = true
|
|
edition.workspace = true
|
|
license.workspace = true
|
|
|
|
[package.metadata.wasm-pack.profile.release]
|
|
# `wasm-opt` has some problems on Linux, see
|
|
# https://github.com/rustwasm/wasm-pack/issues/781 etc.
|
|
wasm-opt = false
|
|
|
|
[lib]
|
|
crate-type = ["cdylib", "rlib"]
|
|
|
|
[dependencies]
|
|
cfg-if = "1.0"
|
|
clap = { version = "4.4.11", features = ["derive"], optional = true }
|
|
log = "0.4.17"
|
|
thiserror = "1.0.48"
|
|
futures = "0.3.21"
|
|
pyro = { package = "pyroscope", version = "0.5.3", optional = true }
|
|
pyroscope_pprofrs = { version = "0.2", optional = true }
|
|
|
|
service = { package = "polkadot-service", path = "../node/service", default-features = false, optional = true }
|
|
|
|
sp-core = { path = "../../substrate/primitives/core" }
|
|
sp-io = { path = "../../substrate/primitives/io" }
|
|
sp-keyring = { path = "../../substrate/primitives/keyring" }
|
|
sp-maybe-compressed-blob = { path = "../../substrate/primitives/maybe-compressed-blob" }
|
|
frame-benchmarking-cli = { path = "../../substrate/utils/frame/benchmarking-cli", optional = true }
|
|
try-runtime-cli = { path = "../../substrate/utils/frame/try-runtime/cli", optional = true }
|
|
sc-cli = { path = "../../substrate/client/cli", optional = true }
|
|
sc-service = { path = "../../substrate/client/service", optional = true }
|
|
polkadot-node-metrics = { path = "../node/metrics" }
|
|
polkadot-node-primitives = { path = "../node/primitives" }
|
|
sc-tracing = { path = "../../substrate/client/tracing", optional = true }
|
|
sc-sysinfo = { path = "../../substrate/client/sysinfo" }
|
|
sc-executor = { path = "../../substrate/client/executor" }
|
|
sc-storage-monitor = { path = "../../substrate/client/storage-monitor" }
|
|
|
|
[build-dependencies]
|
|
substrate-build-script-utils = { path = "../../substrate/utils/build-script-utils" }
|
|
|
|
[features]
|
|
default = ["cli", "db", "full-node"]
|
|
db = ["service/db"]
|
|
cli = [
|
|
"clap",
|
|
"frame-benchmarking-cli",
|
|
"sc-cli",
|
|
"sc-service",
|
|
"sc-tracing",
|
|
"service",
|
|
"try-runtime-cli",
|
|
]
|
|
runtime-benchmarks = [
|
|
"frame-benchmarking-cli?/runtime-benchmarks",
|
|
"polkadot-node-metrics/runtime-benchmarks",
|
|
"sc-service?/runtime-benchmarks",
|
|
"service/runtime-benchmarks",
|
|
]
|
|
full-node = ["service/full-node"]
|
|
try-runtime = ["service/try-runtime", "try-runtime-cli/try-runtime"]
|
|
fast-runtime = ["service/fast-runtime"]
|
|
pyroscope = ["pyro", "pyroscope_pprofrs"]
|
|
|
|
# Configure the native runtimes to use.
|
|
westend-native = ["service/westend-native"]
|
|
rococo-native = ["service/rococo-native"]
|
|
|
|
malus = ["full-node", "service/malus"]
|
|
runtime-metrics = [
|
|
"polkadot-node-metrics/runtime-metrics",
|
|
"service/runtime-metrics",
|
|
]
|