mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-27 04:37:57 +00:00
c7d1204ce5
* Introduce inherent digests * Implement inherent digests * fix silly error * Implementation of inherent digests in BABE All tests pass. There are still limitations: 1. The runtime strips out inherent digests, so BABE must re-add them. 2. The test runtime checks that it can re-compute all digests. It can’t, so I had to comment out that test. * Fix compilation and seal import Seals were not imported correctly: the pre-digest was imported twice, instead of both it and the seal being imported. Also, other parts of the code did not compile due to incomplete refactoring. * Remove bogus assertion * Fix testsuite compilation * Remove unused import * Fix compiler diagnostics * Add inherent digest parameters to block constructors This enforces that inherent digests are added first. * Fixup Cargo.lock * Fix build errors * Re-add an incorrectly removed import * Bump primitive-types version * Update Cargo.lock * Refactoring * Use inherent digests for AuRa They do reach the runtime, but get stripped. I have not figured out where. * Fix compilation errors * Fix compilation errors due to incorrect types * Fix whitespace Suggested-by: Tomasz Drwiega <tomasz@parity.io> * Add preamble Suggested-by: Tomasz Drwiega <tomasz@parity.io> * Fix silly compile error * Refactor pre-digest finding code into a separate function * Remove unwanted assertion It is too likely to bring down the entire blockchain. Suggested-by: Tomasz Drwiega <tomasz@parity.io> * Use `find_pre_digest` after runtime, too Also, use `Member` trait rather than rolling our own requirements. Suggested-by: Tomasz Drwiega <tomasz@parity.io> * Fix various warnings mostly due to upgrading the dependency on `error_chain`. * Pre-digests nearly complete This nearly completes the implementation of pre-runtime digests. * `Seal2` → `Seal` and fix test suite * Try to fix the storage error * Try to fix storage (again) * Fix tests * Hopefully finish pre-runtime digests The key is to pass *only* the pre-runtime digests to the runtime. The others must be stripped out by `initialize_block`. * Fix silly typo * Fix another silly mistake * Remove unnecessary filtering of BABE pre-digests We no longer get duplicate BABE pre-digests, so if they appear, the header should be rejected outright. * Update Cargo.lock files * Reformatting * Fix silly typo in inherent digest code Also, revert `error.rs` files that contained calls to the `error_chain!` macro. * Try to keep the runtime from stripping pre-digests Currently runs into the “Storage root must match that calculated” assertion. * Don’t compute storage root until storage changes are done. Also, fix a compilation error. * Fix compile-time error * Fix compilation errors * Fix more compile errors * Hopefully it compiles this time… * Fix compilation and add docs * Prevent BABE from adding duplicate pre-runtime digests Found by comparing with the AuRa code. I also did some refactoring. * Respond to review and fix some warnings * Delete some dead code introduced earlier * More dead code goes away * `ref mut` → `&mut` * Respond to review and fix some warnings * Fix compilation error * Remove unneeded `HashT` type parameter Suggested-by: Robert Habermeier <robert@parity.io> * Remove spurious #[allow(deprecated)] * Document inherent digest parameter to `build_block` * Delete `Simple` trait It wasn’t needed * delete wrongly added files * Fix trait bounds * Digest serialization tests I also did some reformatting and cleanup. * Apply suggestions from code review Reformatting Co-Authored-By: André Silva <andre.beat@gmail.com> * Swap two arguments to `propose` and `propose_with` Also, remove some needless unsafe code. * Remove bogus `#![allow(deprecated)]` annotations With the removal of the deprecated `Seal` variant, these are not needed. * Add a missing `#[allow(deprecated)]` in the AuRa tests * Fix silly compile error * Fix silly compiler error RLS did not tell me that I hadn’t fixed `babe/lib.rs`, so I missed it. * Fixes made automatically by Cargo
194 lines
7.2 KiB
Rust
194 lines
7.2 KiB
Rust
// Copyright 2019 Parity Technologies (UK) Ltd.
|
|
// This file is part of Substrate.
|
|
|
|
// Substrate is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Substrate is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Substrate. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
use test_client::{
|
|
AccountKeyring, runtime::{TestAPI, DecodeFails, Transfer, Header},
|
|
NativeExecutor, LocalExecutor,
|
|
};
|
|
use runtime_primitives::{
|
|
generic::BlockId,
|
|
traits::{ProvideRuntimeApi, Header as HeaderT, Hash as HashT},
|
|
};
|
|
use state_machine::{
|
|
ExecutionStrategy, create_proof_check_backend,
|
|
execution_proof_check_on_trie_backend,
|
|
};
|
|
|
|
use client::LongestChain;
|
|
use consensus_common::SelectChain;
|
|
use codec::Encode;
|
|
|
|
fn calling_function_with_strat(strat: ExecutionStrategy) {
|
|
let client = test_client::new_with_execution_strategy(strat);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
|
|
assert_eq!(runtime_api.benchmark_add_one(&block_id, &1).unwrap(), 2);
|
|
}
|
|
|
|
#[test]
|
|
fn calling_native_runtime_function() {
|
|
calling_function_with_strat(ExecutionStrategy::NativeWhenPossible);
|
|
}
|
|
|
|
#[test]
|
|
fn calling_wasm_runtime_function() {
|
|
calling_function_with_strat(ExecutionStrategy::AlwaysWasm);
|
|
}
|
|
|
|
#[test]
|
|
#[should_panic(expected = "Could not convert parameter `param` between node and runtime!")]
|
|
fn calling_native_runtime_function_with_non_decodable_parameter() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::NativeWhenPossible);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
runtime_api.fail_convert_parameter(&block_id, DecodeFails::new()).unwrap();
|
|
}
|
|
|
|
#[test]
|
|
#[should_panic(expected = "Could not convert return value from runtime to node!")]
|
|
fn calling_native_runtime_function_with_non_decodable_return_value() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::NativeWhenPossible);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
runtime_api.fail_convert_return_value(&block_id).unwrap();
|
|
}
|
|
|
|
#[test]
|
|
fn calling_native_runtime_signature_changed_function() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::NativeWhenPossible);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
|
|
assert_eq!(runtime_api.function_signature_changed(&block_id).unwrap(), 1);
|
|
}
|
|
|
|
#[test]
|
|
fn calling_wasm_runtime_signature_changed_old_function() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::AlwaysWasm);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
|
|
#[allow(deprecated)]
|
|
let res = runtime_api.function_signature_changed_before_version_2(&block_id).unwrap();
|
|
assert_eq!(&res, &[1, 2]);
|
|
}
|
|
|
|
#[test]
|
|
fn calling_with_both_strategy_and_fail_on_wasm_should_return_error() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::Both);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
assert!(runtime_api.fail_on_wasm(&block_id).is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn calling_with_both_strategy_and_fail_on_native_should_work() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::Both);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
assert_eq!(runtime_api.fail_on_native(&block_id).unwrap(), 1);
|
|
}
|
|
|
|
|
|
#[test]
|
|
fn calling_with_native_else_wasm_and_faild_on_wasm_should_work() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::NativeElseWasm);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
assert_eq!(runtime_api.fail_on_wasm(&block_id).unwrap(), 1);
|
|
}
|
|
|
|
#[test]
|
|
fn calling_with_native_else_wasm_and_fail_on_native_should_work() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::NativeElseWasm);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
assert_eq!(runtime_api.fail_on_native(&block_id).unwrap(), 1);
|
|
}
|
|
|
|
#[test]
|
|
fn use_trie_function() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::AlwaysWasm);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
assert_eq!(runtime_api.use_trie(&block_id).unwrap(), 2);
|
|
}
|
|
|
|
#[test]
|
|
fn initialize_block_works() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::Both);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
assert_eq!(runtime_api.get_block_number(&block_id).unwrap(), 1);
|
|
}
|
|
|
|
#[test]
|
|
fn initialize_block_is_called_only_once() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::Both);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
assert_eq!(runtime_api.take_block_number(&block_id).unwrap(), Some(1));
|
|
assert_eq!(runtime_api.take_block_number(&block_id).unwrap(), None);
|
|
}
|
|
|
|
#[test]
|
|
fn initialize_block_is_skipped() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::Both);
|
|
let runtime_api = client.runtime_api();
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
assert!(runtime_api.without_initialize_block(&block_id).unwrap());
|
|
}
|
|
|
|
#[test]
|
|
fn record_proof_works() {
|
|
let client = test_client::new_with_execution_strategy(ExecutionStrategy::Both);
|
|
|
|
let block_id = BlockId::Number(client.info().unwrap().chain.best_number);
|
|
#[allow(deprecated)]
|
|
let storage_root = LongestChain::new(client.backend().clone(), client.import_lock())
|
|
.best_chain().unwrap().state_root().clone();
|
|
|
|
let transaction = Transfer {
|
|
amount: 1000,
|
|
nonce: 0,
|
|
from: AccountKeyring::Alice.into(),
|
|
to: Default::default(),
|
|
}.into_signed_tx();
|
|
|
|
// Build the block and record proof
|
|
let mut builder = client
|
|
.new_block_at_with_proof_recording(&block_id, Default::default())
|
|
.expect("Creates block builder");
|
|
builder.push(transaction.clone()).unwrap();
|
|
let (block, proof) = builder.bake_and_extract_proof().expect("Bake block");
|
|
|
|
let backend = create_proof_check_backend::<<<Header as HeaderT>::Hashing as HashT>::Hasher>(
|
|
storage_root,
|
|
proof.expect("Proof was generated"),
|
|
).expect("Creates proof backend.");
|
|
|
|
// Use the proof backend to execute `execute_block`.
|
|
let mut overlay = Default::default();
|
|
let executor = NativeExecutor::<LocalExecutor>::new(None);
|
|
execution_proof_check_on_trie_backend(
|
|
&backend,
|
|
&mut overlay,
|
|
&executor,
|
|
"Core_execute_block",
|
|
&block.encode(),
|
|
).expect("Executes block while using the proof backend");
|
|
} |