mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-30 04:57:57 +00:00
141a64cf41
* Split up sr_arithmetic.rs * Add some basic fuzzing * Add more tests * Add printing to fuzzing * Clean things up * Remove arbitrary * Remove comments * More cleaning, fix small error that was causing a panic * Add rational128 * Remove old random tests * introduce panic * fuzzing should panic properly * Bit of cleanup * Add a test uncovered via fuzzing that fails! * Few small changes * Move sr-arithmetic to its own crate * Fix fuzzing * Got rid of fuzzer Cargo.lock * Added no_std * re-export assert_eq_error_rate * bump impl and spec version * re add convert into * Add an ignore to the test * Enabled benchmarking * Reindent * Clean up biguint fuzzer * Clean up biguint more * shuffle sr-primitives/traits about * Remove unused dependencies * Apply clippy suggestions * upgrade primitive-types versions * Run tests against num-bigint * Get rid of allocation in assert_biguints_eq * Add an optimisation to multiply_by_rational * rename parts_per_x -> per_things * Change fuzzer cargo.toml * Remove allocation from BigUint PartialEq impl * Remove accidental indentation * Renmove Lazy and Convert traits * Copy assert_eq_error_rate macro back to sr-primitives * Add documentation to fuzzers * fix sr-primitives assert_eq_error_rate * add cfg(test) * Update core/sr-arithmetic/src/traits.rs Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update core/sr-arithmetic/src/traits.rs Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update core/sr-arithmetic/fuzzer/src/biguint.rs Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Allow rounding up in rational128 * Make changes to biguint.rs * Update core/sr-arithmetic/src/traits.rs Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Final touches * Convert to num_bigint::BigUint to compare * remove unused mut * more small changes * shuffle sr-primitives trait imports * more code review * move assert_eq_error_rate to lib.rs * Update core/sr-arithmetic/fuzzer/src/biguint.rs Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com> * Get rid of S * Simplify rational128 honggfuzz link * Insignificantly change rational128 fuzzing code * Slightly tidy up some of the arithmetic logic * Get rid of sr_arithmetic again(?) and fix sr-primitives/weights * Apply updates to sr_arithmetic.rs to crate
113 lines
3.8 KiB
Rust
113 lines
3.8 KiB
Rust
// Copyright 2019 Parity Technologies (UK) Ltd.
|
|
// This file is part of Substrate.
|
|
|
|
// Substrate is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Substrate is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Substrate. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Some helper functions to work with 128bit numbers. Note that the functionality provided here is
|
|
//! only sensible to use with 128bit numbers because for smaller sizes, you can always rely on
|
|
//! assumptions of a bigger type (u128) being available, or simply create a per-thing and use the
|
|
//! multiplication implementation provided there.
|
|
|
|
use crate::biguint;
|
|
use num_traits::Zero;
|
|
use rstd::{cmp::{min, max}, convert::TryInto, mem};
|
|
|
|
/// Helper gcd function used in Rational128 implementation.
|
|
pub fn gcd(a: u128, b: u128) -> u128 {
|
|
match ((a, b), (a & 1, b & 1)) {
|
|
((x, y), _) if x == y => y,
|
|
((0, x), _) | ((x, 0), _) => x,
|
|
((x, y), (0, 1)) | ((y, x), (1, 0)) => gcd(x >> 1, y),
|
|
((x, y), (0, 0)) => gcd(x >> 1, y >> 1) << 1,
|
|
((x, y), (1, 1)) => {
|
|
let (x, y) = (min(x, y), max(x, y));
|
|
gcd((y - x) >> 1, x)
|
|
},
|
|
_ => unreachable!(),
|
|
}
|
|
}
|
|
|
|
/// split a u128 into two u64 limbs
|
|
pub fn split(a: u128) -> (u64, u64) {
|
|
let al = a as u64;
|
|
let ah = (a >> 64) as u64;
|
|
(ah, al)
|
|
}
|
|
|
|
/// Convert a u128 to a u32 based biguint.
|
|
pub fn to_big_uint(x: u128) -> biguint::BigUint {
|
|
let (xh, xl) = split(x);
|
|
let (xhh, xhl) = biguint::split(xh);
|
|
let (xlh, xll) = biguint::split(xl);
|
|
let mut n = biguint::BigUint::from_limbs(&[xhh, xhl, xlh, xll]);
|
|
n.lstrip();
|
|
n
|
|
}
|
|
|
|
/// Safely and accurately compute `a * b / c`. The approach is:
|
|
/// - Simply try `a * b / c`.
|
|
/// - Else, convert them both into big numbers and re-try. `Err` is returned if the result
|
|
/// cannot be safely casted back to u128.
|
|
///
|
|
/// Invariant: c must be greater than or equal to 1.
|
|
pub fn multiply_by_rational(mut a: u128, mut b: u128, mut c: u128) -> Result<u128, &'static str> {
|
|
if a.is_zero() || b.is_zero() { return Ok(Zero::zero()); }
|
|
c = c.max(1);
|
|
|
|
// a and b are interchangeable by definition in this function. It always helps to assume the
|
|
// bigger of which is being multiplied by a `0 < b/c < 1`. Hence, a should be the bigger and
|
|
// b the smaller one.
|
|
if b > a {
|
|
mem::swap(&mut a, &mut b);
|
|
}
|
|
|
|
// Attempt to perform the division first
|
|
if a % c == 0 {
|
|
a /= c;
|
|
c = 1;
|
|
} else if b % c == 0 {
|
|
b /= c;
|
|
c = 1;
|
|
}
|
|
|
|
if let Some(x) = a.checked_mul(b) {
|
|
// This is the safest way to go. Try it.
|
|
Ok(x / c)
|
|
} else {
|
|
let a_num = to_big_uint(a);
|
|
let b_num = to_big_uint(b);
|
|
let c_num = to_big_uint(c);
|
|
|
|
let mut ab = a_num * b_num;
|
|
ab.lstrip();
|
|
let mut q = if c_num.len() == 1 {
|
|
// PROOF: if `c_num.len() == 1` then `c` fits in one limb.
|
|
ab.div_unit(c as biguint::Single)
|
|
} else {
|
|
// PROOF: both `ab` and `c` cannot have leading zero limbs; if length of `c` is 1,
|
|
// the previous branch would handle. Also, if ab for sure has a bigger size than
|
|
// c, because `a.checked_mul(b)` has failed, hence ab must be at least one limb
|
|
// bigger than c. In this case, returning zero is defensive-only and div should
|
|
// always return Some.
|
|
let (mut q, r) = ab.div(&c_num, true).unwrap_or((Zero::zero(), Zero::zero()));
|
|
let r: u128 = r.try_into()
|
|
.expect("reminder of div by c is always less than c; qed");
|
|
if r > (c / 2) { q = q.add(&to_big_uint(1)); }
|
|
q
|
|
};
|
|
q.lstrip();
|
|
q.try_into().map_err(|_| "result cannot fit in u128")
|
|
}
|
|
}
|