mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-20 17:31:02 +00:00
e16ef0861f
This is a rather big change in jsonrpsee, the major things in this bump are: - Server backpressure (the subscription impls are modified to deal with that) - Allow custom error types / return types (remove jsonrpsee::core::Error and jsonrpee::core::CallError) - Bug fixes (graceful shutdown in particular not used by substrate anyway) - Less dependencies for the clients in particular - Return type requires Clone in method call responses - Moved to tokio channels - Async subscription API (not used in this PR) Major changes in this PR: - The subscriptions are now bounded and if subscription can't keep up with the server it is dropped - CLI: add parameter to configure the jsonrpc server bounded message buffer (default is 64) - Add our own subscription helper to deal with the unbounded streams in substrate The most important things in this PR to review is the added helpers functions in `substrate/client/rpc/src/utils.rs` and the rest is pretty much chore. Regarding the "bounded buffer limit" it may cause the server to handle the JSON-RPC calls slower than before. The message size limit is bounded by "--rpc-response-size" thus "by default 10MB * 64 = 640MB" but the subscription message size is not covered by this limit and could be capped as well. Hopefully the last release prior to 1.0, sorry in advance for a big PR Previous attempt: https://github.com/paritytech/substrate/pull/13992 Resolves https://github.com/paritytech/polkadot-sdk/issues/748, resolves https://github.com/paritytech/polkadot-sdk/issues/627
170 lines
5.3 KiB
Rust
170 lines
5.3 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
//! RPC interface for the `ManualSeal` Engine.
|
|
|
|
use crate::error::Error;
|
|
use futures::{
|
|
channel::{mpsc, oneshot},
|
|
SinkExt,
|
|
};
|
|
use jsonrpsee::{core::async_trait, proc_macros::rpc};
|
|
use sc_consensus::ImportedAux;
|
|
use serde::{Deserialize, Serialize};
|
|
use sp_runtime::EncodedJustification;
|
|
|
|
/// Sender passed to the authorship task to report errors or successes.
|
|
pub type Sender<T> = Option<oneshot::Sender<std::result::Result<T, Error>>>;
|
|
|
|
/// Message sent to the background authorship task, usually by RPC.
|
|
pub enum EngineCommand<Hash> {
|
|
/// Tells the engine to propose a new block
|
|
///
|
|
/// if create_empty == true, it will create empty blocks if there are no transactions
|
|
/// in the transaction pool.
|
|
///
|
|
/// if finalize == true, the block will be instantly finalized.
|
|
SealNewBlock {
|
|
/// if true, empty blocks(without extrinsics) will be created.
|
|
/// otherwise, will return Error::EmptyTransactionPool.
|
|
create_empty: bool,
|
|
/// instantly finalize this block?
|
|
finalize: bool,
|
|
/// specify the parent hash of the about-to-created block
|
|
parent_hash: Option<Hash>,
|
|
/// sender to report errors/success to the rpc.
|
|
sender: Sender<CreatedBlock<Hash>>,
|
|
},
|
|
/// Tells the engine to finalize the block with the supplied hash
|
|
FinalizeBlock {
|
|
/// hash of the block
|
|
hash: Hash,
|
|
/// sender to report errors/success to the rpc.
|
|
sender: Sender<()>,
|
|
/// finalization justification
|
|
justification: Option<EncodedJustification>,
|
|
},
|
|
}
|
|
|
|
/// RPC trait that provides methods for interacting with the manual-seal authorship task over rpc.
|
|
#[rpc(client, server)]
|
|
pub trait ManualSealApi<Hash> {
|
|
/// Instructs the manual-seal authorship task to create a new block
|
|
#[method(name = "engine_createBlock")]
|
|
async fn create_block(
|
|
&self,
|
|
create_empty: bool,
|
|
finalize: bool,
|
|
parent_hash: Option<Hash>,
|
|
) -> Result<CreatedBlock<Hash>, Error>;
|
|
|
|
/// Instructs the manual-seal authorship task to finalize a block
|
|
#[method(name = "engine_finalizeBlock")]
|
|
async fn finalize_block(
|
|
&self,
|
|
hash: Hash,
|
|
justification: Option<EncodedJustification>,
|
|
) -> Result<bool, Error>;
|
|
}
|
|
|
|
/// A struct that implements the [`ManualSealApiServer`].
|
|
pub struct ManualSeal<Hash> {
|
|
import_block_channel: mpsc::Sender<EngineCommand<Hash>>,
|
|
}
|
|
|
|
/// return type of `engine_createBlock`
|
|
#[derive(Clone, Debug, Deserialize, Serialize, PartialEq, Eq)]
|
|
pub struct CreatedBlock<Hash> {
|
|
/// hash of the created block.
|
|
pub hash: Hash,
|
|
/// some extra details about the import operation
|
|
pub aux: ImportedAux,
|
|
/// uncompacted storage proof size (zero mean that there is no proof)
|
|
pub proof_size: usize,
|
|
}
|
|
|
|
impl<Hash> ManualSeal<Hash> {
|
|
/// Create new `ManualSeal` with the given reference to the client.
|
|
pub fn new(import_block_channel: mpsc::Sender<EngineCommand<Hash>>) -> Self {
|
|
Self { import_block_channel }
|
|
}
|
|
}
|
|
|
|
#[async_trait]
|
|
impl<Hash: Send + 'static> ManualSealApiServer<Hash> for ManualSeal<Hash> {
|
|
async fn create_block(
|
|
&self,
|
|
create_empty: bool,
|
|
finalize: bool,
|
|
parent_hash: Option<Hash>,
|
|
) -> Result<CreatedBlock<Hash>, Error> {
|
|
let mut sink = self.import_block_channel.clone();
|
|
let (sender, receiver) = oneshot::channel();
|
|
// NOTE: this sends a Result over the channel.
|
|
let command = EngineCommand::SealNewBlock {
|
|
create_empty,
|
|
finalize,
|
|
parent_hash,
|
|
sender: Some(sender),
|
|
};
|
|
|
|
sink.send(command).await?;
|
|
|
|
match receiver.await {
|
|
Ok(Ok(rx)) => Ok(rx),
|
|
Ok(Err(e)) => Err(e.into()),
|
|
Err(e) => Err(e.into()),
|
|
}
|
|
}
|
|
|
|
async fn finalize_block(
|
|
&self,
|
|
hash: Hash,
|
|
justification: Option<EncodedJustification>,
|
|
) -> Result<bool, Error> {
|
|
let mut sink = self.import_block_channel.clone();
|
|
let (sender, receiver) = oneshot::channel();
|
|
let command = EngineCommand::FinalizeBlock { hash, sender: Some(sender), justification };
|
|
sink.send(command).await?;
|
|
receiver.await.map(|_| true).map_err(Into::into)
|
|
}
|
|
}
|
|
|
|
/// report any errors or successes encountered by the authorship task back
|
|
/// to the rpc
|
|
pub fn send_result<T: std::fmt::Debug>(
|
|
sender: &mut Sender<T>,
|
|
result: std::result::Result<T, crate::Error>,
|
|
) {
|
|
if let Some(sender) = sender.take() {
|
|
if let Err(err) = sender.send(result) {
|
|
match err {
|
|
Ok(value) => log::warn!("Server is shutting down: {:?}", value),
|
|
Err(error) => log::warn!("Server is shutting down with error: {}", error),
|
|
}
|
|
}
|
|
} else {
|
|
// Sealing/Finalization with no RPC sender such as instant seal or delayed finalize doesn't
|
|
// report errors over rpc, simply log them.
|
|
match result {
|
|
Ok(r) => log::info!("Consensus with no RPC sender success: {:?}", r),
|
|
Err(e) => log::error!("Consensus with no RPC sender encountered an error: {}", e),
|
|
}
|
|
}
|
|
}
|