mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-07 22:28:02 +00:00
80616f6d03
[litep2p](https://github.com/altonen/litep2p) is a libp2p-compatible P2P networking library. It supports all of the features of `rust-libp2p` that are currently being utilized by Polkadot SDK. Compared to `rust-libp2p`, `litep2p` has a quite different architecture which is why the new `litep2p` network backend is only able to use a little of the existing code in `sc-network`. The design has been mainly influenced by how we'd wish to structure our networking-related code in Polkadot SDK: independent higher-levels protocols directly communicating with the network over links that support bidirectional backpressure. A good example would be `NotificationHandle`/`RequestResponseHandle` abstractions which allow, e.g., `SyncingEngine` to directly communicate with peers to announce/request blocks. I've tried running `polkadot --network-backend litep2p` with a few different peer configurations and there is a noticeable reduction in networking CPU usage. For high load (`--out-peers 200`), networking CPU usage goes down from ~110% to ~30% (80 pp) and for normal load (`--out-peers 40`), the usage goes down from ~55% to ~18% (37 pp). These should not be taken as final numbers because: a) there are still some low-hanging optimization fruits, such as enabling [receive window auto-tuning](https://github.com/libp2p/rust-yamux/pull/176), integrating `Peerset` more closely with `litep2p` or improving memory usage of the WebSocket transport b) fixing bugs/instabilities that incorrectly cause `litep2p` to do less work will increase the networking CPU usage c) verification in a more diverse set of tests/conditions is needed Nevertheless, these numbers should give an early estimate for CPU usage of the new networking backend. This PR consists of three separate changes: * introduce a generic `PeerId` (wrapper around `Multihash`) so that we don't have use `NetworkService::PeerId` in every part of the code that uses a `PeerId` * introduce `NetworkBackend` trait, implement it for the libp2p network stack and make Polkadot SDK generic over `NetworkBackend` * implement `NetworkBackend` for litep2p The new library should be considered experimental which is why `rust-libp2p` will remain as the default option for the time being. This PR currently depends on the master branch of `litep2p` but I'll cut a new release for the library once all review comments have been addresses. --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by: Alexandru Vasile <alexandru.vasile@parity.io>
115 lines
3.6 KiB
Rust
115 lines
3.6 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
use sc_network::{multiaddr, Multiaddr};
|
|
use serde::{Deserialize, Deserializer, Serialize};
|
|
|
|
/// List of telemetry servers we want to talk to. Contains the URL of the server, and the
|
|
/// maximum verbosity level.
|
|
///
|
|
/// The URL string can be either a URL or a multiaddress.
|
|
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq, Hash)]
|
|
pub struct TelemetryEndpoints(
|
|
#[serde(deserialize_with = "url_or_multiaddr_deser")] pub(crate) Vec<(Multiaddr, u8)>,
|
|
);
|
|
|
|
/// Custom deserializer for TelemetryEndpoints, used to convert urls or multiaddr to multiaddr.
|
|
fn url_or_multiaddr_deser<'de, D>(deserializer: D) -> Result<Vec<(Multiaddr, u8)>, D::Error>
|
|
where
|
|
D: Deserializer<'de>,
|
|
{
|
|
Vec::<(String, u8)>::deserialize(deserializer)?
|
|
.iter()
|
|
.map(|e| url_to_multiaddr(&e.0).map_err(serde::de::Error::custom).map(|m| (m, e.1)))
|
|
.collect()
|
|
}
|
|
|
|
impl TelemetryEndpoints {
|
|
/// Create a `TelemetryEndpoints` based on a list of `(String, u8)`.
|
|
pub fn new(endpoints: Vec<(String, u8)>) -> Result<Self, multiaddr::Error> {
|
|
let endpoints: Result<Vec<(Multiaddr, u8)>, multiaddr::Error> =
|
|
endpoints.iter().map(|e| Ok((url_to_multiaddr(&e.0)?, e.1))).collect();
|
|
endpoints.map(Self)
|
|
}
|
|
}
|
|
|
|
impl TelemetryEndpoints {
|
|
/// Return `true` if there are no telemetry endpoints, `false` otherwise.
|
|
pub fn is_empty(&self) -> bool {
|
|
self.0.is_empty()
|
|
}
|
|
}
|
|
|
|
/// Parses a WebSocket URL into a libp2p `Multiaddr`.
|
|
fn url_to_multiaddr(url: &str) -> Result<Multiaddr, multiaddr::Error> {
|
|
// First, assume that we have a `Multiaddr`.
|
|
let parse_error = match url.parse() {
|
|
Ok(ma) => return Ok(ma),
|
|
Err(err) => err,
|
|
};
|
|
|
|
// If not, try the `ws://path/url` format.
|
|
if let Ok(ma) = multiaddr::from_url(url) {
|
|
return Ok(ma)
|
|
}
|
|
|
|
// If we have no clue about the format of that string, assume that we were expecting a
|
|
// `Multiaddr`.
|
|
Err(parse_error)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::{url_to_multiaddr, Multiaddr, TelemetryEndpoints};
|
|
|
|
#[test]
|
|
fn valid_endpoints() {
|
|
let endp = vec![
|
|
("wss://telemetry.polkadot.io/submit/".into(), 3),
|
|
("/ip4/80.123.90.4/tcp/5432".into(), 4),
|
|
];
|
|
let telem =
|
|
TelemetryEndpoints::new(endp.clone()).expect("Telemetry endpoint should be valid");
|
|
let mut res: Vec<(Multiaddr, u8)> = vec![];
|
|
for (a, b) in endp.iter() {
|
|
res.push((url_to_multiaddr(a).expect("provided url should be valid"), *b))
|
|
}
|
|
assert_eq!(telem.0, res);
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_endpoints() {
|
|
let endp = vec![
|
|
("/ip4/...80.123.90.4/tcp/5432".into(), 3),
|
|
("/ip4/no:!?;rlkqre;;::::///tcp/5432".into(), 4),
|
|
];
|
|
let telem = TelemetryEndpoints::new(endp);
|
|
assert!(telem.is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn valid_and_invalid_endpoints() {
|
|
let endp = vec![
|
|
("/ip4/80.123.90.4/tcp/5432".into(), 3),
|
|
("/ip4/no:!?;rlkqre;;::::///tcp/5432".into(), 4),
|
|
];
|
|
let telem = TelemetryEndpoints::new(endp);
|
|
assert!(telem.is_err());
|
|
}
|
|
}
|