mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-09 09:27:59 +00:00
0d6884b919
* primitives/runtime: initial changes on supporting multiple Justifications * primitives/runtime: make Justifications strongly typed * Encode/decode Justifications * primitives/runtime: add Justification type * backend: apply_finality and finalize_block takes a single Justification * manual-seal: create engine id and let rpc take encoded justification * backend: skeleton functions for appending justifications * backend: initial implementation append_justification Initial implementation of append_justification on the Backend trait, and also remove unused skeleton functions for append_justificaton on Finaziler trait. k * backend: guard against duplicate consensus engine id * client/db: add check for block finality * client/api: add append_justification to in_mem db * client/light: add no-op append_justification * network: fix decode call for Justification * network: only send a single Justification in BlockData * network: minor comment update * protocol: update field names to distinguish single justification * client: further field renames to plural * client: update function names to plural justifications * client/db: upgrade existing database for new format * network: remove dependency on grandpa crate * db: fix check for finalized block * grandpa: check for multiple grandpa justifications hwne importing * backend: update Finalizer trait to take multiple Justifications * db: remove debugging statements in migration code * manual-seal: update note about engine id * db: fix check for finalized block * client: update variable name to reflect it is now plural * grandpa: fix incorrect empty Justications in test * primitives: make Justifications opaque to avoid being empty * network: fix detecting empty Justification * runtime: doc strings for Justifications functions * runtime: add into_justifications * primitives: check for duplicates in when adding to Justifications * network/test: use real grandpa engine id in test * client: fix reviewer comments * primitives: rename Justifications::push to append * backend: revert changes to Finalizer trait * backend: revert mark_finalized * backend: revert changes to finalize_block * backend: revert finalized_blocks * db: add a quick early return for performance * client: minor reviewer comments * service/test: use local ConsensusEngineId * network: add link to issue for sending multiple Justifications * Apply suggestions from code review Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> * Apply suggestions from code review Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> * network: tweaks to review suggestions * network: revert change to BlockData for backwards compatibility * Apply suggestion from code review Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> * Apply suggestions from code review Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * primitives: update doc comment for Justifications * client/db/upgrade: avoid grandpa crate dependency * consensus: revert to single Justification for import_justification * primitives: improve justifications docs * style cleanups * use and_then * client: rename JUSTIFICATIONS db column * network: revert to using FRNK in network-test Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by: André Silva <andrerfosilva@gmail.com>
185 lines
6.5 KiB
Rust
185 lines
6.5 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) 2019-2021 Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
//! Database upgrade logic.
|
|
|
|
use std::fs;
|
|
use std::io::{Read, Write, ErrorKind};
|
|
use std::path::{Path, PathBuf};
|
|
|
|
use sp_runtime::traits::Block as BlockT;
|
|
use crate::{columns, utils::DatabaseType};
|
|
use kvdb_rocksdb::{Database, DatabaseConfig};
|
|
use codec::Encode;
|
|
|
|
/// Version file name.
|
|
const VERSION_FILE_NAME: &'static str = "db_version";
|
|
|
|
/// Current db version.
|
|
const CURRENT_VERSION: u32 = 3;
|
|
|
|
/// Number of columns in v1.
|
|
const V1_NUM_COLUMNS: u32 = 11;
|
|
const V2_NUM_COLUMNS: u32 = 12;
|
|
|
|
/// Upgrade database to current version.
|
|
pub fn upgrade_db<Block: BlockT>(db_path: &Path, db_type: DatabaseType) -> sp_blockchain::Result<()> {
|
|
let is_empty = db_path.read_dir().map_or(true, |mut d| d.next().is_none());
|
|
if !is_empty {
|
|
let db_version = current_version(db_path)?;
|
|
match db_version {
|
|
0 => Err(sp_blockchain::Error::Backend(format!("Unsupported database version: {}", db_version)))?,
|
|
1 => {
|
|
migrate_1_to_2::<Block>(db_path, db_type)?;
|
|
migrate_2_to_3::<Block>(db_path, db_type)?
|
|
},
|
|
2 => migrate_2_to_3::<Block>(db_path, db_type)?,
|
|
CURRENT_VERSION => (),
|
|
_ => Err(sp_blockchain::Error::Backend(format!("Future database version: {}", db_version)))?,
|
|
}
|
|
}
|
|
|
|
update_version(db_path)
|
|
}
|
|
|
|
/// Migration from version1 to version2:
|
|
/// 1) the number of columns has changed from 11 to 12;
|
|
/// 2) transactions column is added;
|
|
fn migrate_1_to_2<Block: BlockT>(db_path: &Path, _db_type: DatabaseType) -> sp_blockchain::Result<()> {
|
|
let db_path = db_path.to_str()
|
|
.ok_or_else(|| sp_blockchain::Error::Backend("Invalid database path".into()))?;
|
|
let db_cfg = DatabaseConfig::with_columns(V1_NUM_COLUMNS);
|
|
let db = Database::open(&db_cfg, db_path).map_err(db_err)?;
|
|
db.add_column().map_err(db_err)
|
|
}
|
|
|
|
/// Migration from version2 to version3:
|
|
/// - The format of the stored Justification changed to support multiple Justifications.
|
|
fn migrate_2_to_3<Block: BlockT>(db_path: &Path, _db_type: DatabaseType) -> sp_blockchain::Result<()> {
|
|
let db_path = db_path.to_str()
|
|
.ok_or_else(|| sp_blockchain::Error::Backend("Invalid database path".into()))?;
|
|
let db_cfg = DatabaseConfig::with_columns(V2_NUM_COLUMNS);
|
|
let db = Database::open(&db_cfg, db_path).map_err(db_err)?;
|
|
|
|
// Get all the keys we need to update
|
|
let keys: Vec<_> = db.iter(columns::JUSTIFICATIONS).map(|entry| entry.0).collect();
|
|
|
|
// Read and update each entry
|
|
let mut transaction = db.transaction();
|
|
for key in keys {
|
|
if let Some(justification) = db.get(columns::JUSTIFICATIONS, &key).map_err(db_err)? {
|
|
// Tag each Justification with the hardcoded ID for GRANDPA. Avoid the dependency on the GRANDPA crate
|
|
let justifications = sp_runtime::Justifications::from((*b"FRNK", justification));
|
|
transaction.put_vec(columns::JUSTIFICATIONS, &key, justifications.encode());
|
|
}
|
|
}
|
|
db.write(transaction).map_err(db_err)?;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
/// Reads current database version from the file at given path.
|
|
/// If the file does not exist returns 0.
|
|
fn current_version(path: &Path) -> sp_blockchain::Result<u32> {
|
|
let unknown_version_err = || sp_blockchain::Error::Backend("Unknown database version".into());
|
|
|
|
match fs::File::open(version_file_path(path)) {
|
|
Err(ref err) if err.kind() == ErrorKind::NotFound => Ok(0),
|
|
Err(_) => Err(unknown_version_err()),
|
|
Ok(mut file) => {
|
|
let mut s = String::new();
|
|
file.read_to_string(&mut s).map_err(|_| unknown_version_err())?;
|
|
u32::from_str_radix(&s, 10).map_err(|_| unknown_version_err())
|
|
},
|
|
}
|
|
}
|
|
|
|
/// Maps database error to client error
|
|
fn db_err(err: std::io::Error) -> sp_blockchain::Error {
|
|
sp_blockchain::Error::Backend(format!("{}", err))
|
|
}
|
|
|
|
/// Writes current database version to the file.
|
|
/// Creates a new file if the version file does not exist yet.
|
|
fn update_version(path: &Path) -> sp_blockchain::Result<()> {
|
|
fs::create_dir_all(path).map_err(db_err)?;
|
|
let mut file = fs::File::create(version_file_path(path)).map_err(db_err)?;
|
|
file.write_all(format!("{}", CURRENT_VERSION).as_bytes()).map_err(db_err)?;
|
|
Ok(())
|
|
}
|
|
|
|
/// Returns the version file path.
|
|
fn version_file_path(path: &Path) -> PathBuf {
|
|
let mut file_path = path.to_owned();
|
|
file_path.push(VERSION_FILE_NAME);
|
|
file_path
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use sc_state_db::PruningMode;
|
|
use crate::{DatabaseSettings, DatabaseSettingsSrc, KeepBlocks, TransactionStorageMode};
|
|
use crate::tests::Block;
|
|
use super::*;
|
|
|
|
fn create_db(db_path: &Path, version: Option<u32>) {
|
|
if let Some(version) = version {
|
|
fs::create_dir_all(db_path).unwrap();
|
|
let mut file = fs::File::create(version_file_path(db_path)).unwrap();
|
|
file.write_all(format!("{}", version).as_bytes()).unwrap();
|
|
}
|
|
}
|
|
|
|
fn open_database(db_path: &Path) -> sp_blockchain::Result<()> {
|
|
crate::utils::open_database::<Block>(&DatabaseSettings {
|
|
state_cache_size: 0,
|
|
state_cache_child_ratio: None,
|
|
state_pruning: PruningMode::ArchiveAll,
|
|
source: DatabaseSettingsSrc::RocksDb { path: db_path.to_owned(), cache_size: 128 },
|
|
keep_blocks: KeepBlocks::All,
|
|
transaction_storage: TransactionStorageMode::BlockBody,
|
|
}, DatabaseType::Full).map(|_| ())
|
|
}
|
|
|
|
#[test]
|
|
fn downgrade_never_happens() {
|
|
let db_dir = tempfile::TempDir::new().unwrap();
|
|
create_db(db_dir.path(), Some(CURRENT_VERSION + 1));
|
|
assert!(open_database(db_dir.path()).is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn open_empty_database_works() {
|
|
let db_dir = tempfile::TempDir::new().unwrap();
|
|
open_database(db_dir.path()).unwrap();
|
|
open_database(db_dir.path()).unwrap();
|
|
assert_eq!(current_version(db_dir.path()).unwrap(), CURRENT_VERSION);
|
|
}
|
|
|
|
#[test]
|
|
fn upgrade_to_3_works() {
|
|
for version_from_file in &[None, Some(1), Some(2)] {
|
|
let db_dir = tempfile::TempDir::new().unwrap();
|
|
let db_path = db_dir.path();
|
|
create_db(db_path, *version_from_file);
|
|
open_database(db_path).unwrap();
|
|
assert_eq!(current_version(db_path).unwrap(), CURRENT_VERSION);
|
|
}
|
|
}
|
|
}
|