Files
pezkuwi-subxt/substrate/client/mixnet/src/sync_with_runtime.rs
T
Aaro Altonen 80616f6d03 Integrate litep2p into Polkadot SDK (#2944)
[litep2p](https://github.com/altonen/litep2p) is a libp2p-compatible P2P
networking library. It supports all of the features of `rust-libp2p`
that are currently being utilized by Polkadot SDK.

Compared to `rust-libp2p`, `litep2p` has a quite different architecture
which is why the new `litep2p` network backend is only able to use a
little of the existing code in `sc-network`. The design has been mainly
influenced by how we'd wish to structure our networking-related code in
Polkadot SDK: independent higher-levels protocols directly communicating
with the network over links that support bidirectional backpressure. A
good example would be `NotificationHandle`/`RequestResponseHandle`
abstractions which allow, e.g., `SyncingEngine` to directly communicate
with peers to announce/request blocks.

I've tried running `polkadot --network-backend litep2p` with a few
different peer configurations and there is a noticeable reduction in
networking CPU usage. For high load (`--out-peers 200`), networking CPU
usage goes down from ~110% to ~30% (80 pp) and for normal load
(`--out-peers 40`), the usage goes down from ~55% to ~18% (37 pp).

These should not be taken as final numbers because:

a) there are still some low-hanging optimization fruits, such as
enabling [receive window
auto-tuning](https://github.com/libp2p/rust-yamux/pull/176), integrating
`Peerset` more closely with `litep2p` or improving memory usage of the
WebSocket transport
b) fixing bugs/instabilities that incorrectly cause `litep2p` to do less
work will increase the networking CPU usage
c) verification in a more diverse set of tests/conditions is needed

Nevertheless, these numbers should give an early estimate for CPU usage
of the new networking backend.

This PR consists of three separate changes:
* introduce a generic `PeerId` (wrapper around `Multihash`) so that we
don't have use `NetworkService::PeerId` in every part of the code that
uses a `PeerId`
* introduce `NetworkBackend` trait, implement it for the libp2p network
stack and make Polkadot SDK generic over `NetworkBackend`
  * implement `NetworkBackend` for litep2p

The new library should be considered experimental which is why
`rust-libp2p` will remain as the default option for the time being. This
PR currently depends on the master branch of `litep2p` but I'll cut a
new release for the library once all review comments have been
addresses.

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: Alexandru Vasile <alexandru.vasile@parity.io>
2024-04-08 16:44:13 +00:00

230 lines
7.5 KiB
Rust

// This file is part of Substrate.
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
//! [`sync_with_runtime`] synchronises the session status and mixnode sets from the blockchain
//! runtime to the core mixnet state. It is called every time a block is finalised.
use super::peer_id::from_core_peer_id;
use log::{debug, info};
use mixnet::core::{
Mixnet, Mixnode as CoreMixnode, MixnodesErr as CoreMixnodesErr, RelSessionIndex,
SessionPhase as CoreSessionPhase, SessionStatus as CoreSessionStatus,
};
use multiaddr::{multiaddr, Multiaddr, Protocol};
use sc_network_types::PeerId;
use sp_api::{ApiError, ApiRef};
use sp_mixnet::{
runtime_api::MixnetApi,
types::{
Mixnode as RuntimeMixnode, MixnodesErr as RuntimeMixnodesErr,
SessionPhase as RuntimeSessionPhase, SessionStatus as RuntimeSessionStatus,
},
};
use sp_runtime::traits::Block;
const LOG_TARGET: &str = "mixnet";
/// Convert a [`RuntimeSessionStatus`] to a [`CoreSessionStatus`].
///
/// The [`RuntimeSessionStatus`] and [`CoreSessionStatus`] types are effectively the same.
/// [`RuntimeSessionStatus`] is used in the runtime to avoid depending on the [`mixnet`] crate
/// there.
fn to_core_session_status(status: RuntimeSessionStatus) -> CoreSessionStatus {
CoreSessionStatus {
current_index: status.current_index,
phase: match status.phase {
RuntimeSessionPhase::CoverToCurrent => CoreSessionPhase::CoverToCurrent,
RuntimeSessionPhase::RequestsToCurrent => CoreSessionPhase::RequestsToCurrent,
RuntimeSessionPhase::CoverToPrev => CoreSessionPhase::CoverToPrev,
RuntimeSessionPhase::DisconnectFromPrev => CoreSessionPhase::DisconnectFromPrev,
},
}
}
fn parse_external_addresses(external_addresses: Vec<Vec<u8>>) -> Vec<Multiaddr> {
external_addresses
.into_iter()
.flat_map(|addr| {
let addr = match String::from_utf8(addr) {
Ok(addr) => addr,
Err(addr) => {
debug!(
target: LOG_TARGET,
"Mixnode external address {:x?} is not valid UTF-8",
addr.into_bytes(),
);
return None
},
};
match addr.parse() {
Ok(addr) => Some(addr),
Err(err) => {
debug!(
target: LOG_TARGET,
"Could not parse mixnode address {addr}: {err}",
);
None
},
}
})
.collect()
}
/// Modify `external_addresses` such that there is at least one address and the final component of
/// each address matches `peer_id`.
fn fixup_external_addresses(external_addresses: &mut Vec<Multiaddr>, peer_id: &PeerId) {
// Ensure the final component of each address matches peer_id
external_addresses.retain_mut(|addr| match PeerId::try_from_multiaddr(addr) {
Some(addr_peer_id) if addr_peer_id == *peer_id => true,
Some(_) => {
debug!(
target: LOG_TARGET,
"Mixnode address {} does not match mixnode peer ID {}, ignoring",
addr,
peer_id
);
false
},
None if matches!(addr.iter().last(), Some(Protocol::P2p(_))) => {
debug!(
target: LOG_TARGET,
"Mixnode address {} has unrecognised P2P protocol, ignoring",
addr
);
false
},
None => {
addr.push(Protocol::P2p(*peer_id.as_ref()));
true
},
});
// If there are no addresses, insert one consisting of just the peer ID
if external_addresses.is_empty() {
external_addresses.push(multiaddr!(P2p(*peer_id.as_ref())));
}
}
/// Convert a [`RuntimeMixnode`] to a [`CoreMixnode`]. If the conversion fails, an error message is
/// logged, but a [`CoreMixnode`] is still returned.
///
/// It would be possible to handle conversion failure in a better way, but this would complicate
/// things for what should be a rare case. Note that even if the conversion here succeeds, there is
/// no guarantee that we will be able to connect to the mixnode or send packets to it. The most
/// common failure case is expected to be that a mixnode is simply unreachable over the network.
fn into_core_mixnode(mixnode: RuntimeMixnode) -> CoreMixnode<Vec<Multiaddr>> {
let external_addresses = if let Some(peer_id) = from_core_peer_id(&mixnode.peer_id) {
let mut external_addresses = parse_external_addresses(mixnode.external_addresses);
fixup_external_addresses(&mut external_addresses, &peer_id);
external_addresses
} else {
debug!(
target: LOG_TARGET,
"Failed to convert mixnet peer ID {:x?} to libp2p peer ID",
mixnode.peer_id,
);
Vec::new()
};
CoreMixnode {
kx_public: mixnode.kx_public,
peer_id: mixnode.peer_id,
extra: external_addresses,
}
}
fn maybe_set_mixnodes(
mixnet: &mut Mixnet<Vec<Multiaddr>>,
rel_session_index: RelSessionIndex,
mixnodes: &dyn Fn() -> Result<Result<Vec<RuntimeMixnode>, RuntimeMixnodesErr>, ApiError>,
) {
let current_session_index = mixnet.session_status().current_index;
mixnet.maybe_set_mixnodes(rel_session_index, &mut || {
// Note that RelSessionIndex::Prev + 0 would panic, but this closure will not get called in
// that case so we are fine. Do not move this out of the closure!
let session_index = rel_session_index + current_session_index;
match mixnodes() {
Ok(Ok(mixnodes)) => Ok(mixnodes.into_iter().map(into_core_mixnode).collect()),
Ok(Err(err)) => {
info!(target: LOG_TARGET, "Session {session_index}: Mixnet disabled: {err}");
Err(CoreMixnodesErr::Permanent) // Disable the session slot
},
Err(err) => {
debug!(
target: LOG_TARGET,
"Session {session_index}: Error getting mixnodes from runtime: {err}"
);
Err(CoreMixnodesErr::Transient) // Just leave the session slot empty; try again next block
},
}
});
}
pub fn sync_with_runtime<B, A>(mixnet: &mut Mixnet<Vec<Multiaddr>>, api: ApiRef<A>, hash: B::Hash)
where
B: Block,
A: MixnetApi<B>,
{
let session_status = match api.session_status(hash) {
Ok(session_status) => session_status,
Err(err) => {
debug!(target: LOG_TARGET, "Error getting session status from runtime: {err}");
return
},
};
mixnet.set_session_status(to_core_session_status(session_status));
maybe_set_mixnodes(mixnet, RelSessionIndex::Prev, &|| api.prev_mixnodes(hash));
maybe_set_mixnodes(mixnet, RelSessionIndex::Current, &|| api.current_mixnodes(hash));
}
#[cfg(test)]
mod tests {
use super::*;
use multiaddr::multiaddr;
#[test]
fn fixup_empty_external_addresses() {
let peer_id = PeerId::random();
let mut external_addresses = Vec::new();
fixup_external_addresses(&mut external_addresses, &peer_id);
assert_eq!(external_addresses, vec![multiaddr!(P2p(peer_id))]);
}
#[test]
fn fixup_misc_external_addresses() {
let peer_id = PeerId::random();
let other_peer_id = PeerId::random();
let mut external_addresses = vec![
multiaddr!(Tcp(0u16), P2p(peer_id)),
multiaddr!(Tcp(1u16), P2p(other_peer_id)),
multiaddr!(Tcp(2u16)),
Multiaddr::empty(),
];
fixup_external_addresses(&mut external_addresses, &peer_id);
assert_eq!(
external_addresses,
vec![
multiaddr!(Tcp(0u16), P2p(peer_id)),
multiaddr!(Tcp(2u16), P2p(peer_id)),
multiaddr!(P2p(peer_id)),
]
);
}
}