mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-25 17:41:08 +00:00
00b85c51df
helps https://github.com/paritytech/polkadot-sdk/issues/439. closes https://github.com/paritytech/polkadot-sdk/issues/473. PR link in the older substrate repository: https://github.com/paritytech/substrate/pull/13498. # Context Rewards payout is processed today in a single block and limited to `MaxNominatorRewardedPerValidator`. This number is currently 512 on both Kusama and Polkadot. This PR tries to scale the nominators payout to an unlimited count in a multi-block fashion. Exposures are stored in pages, with each page capped to a certain number (`MaxExposurePageSize`). Starting out, this number would be the same as `MaxNominatorRewardedPerValidator`, but eventually, this number can be lowered through new runtime upgrades to limit the rewardeable nominators per dispatched call instruction. The changes in the PR are backward compatible. ## How payouts would work like after this change Staking exposes two calls, 1) the existing `payout_stakers` and 2) `payout_stakers_by_page`. ### payout_stakers This remains backward compatible with no signature change. If for a given era a validator has multiple pages, they can call `payout_stakers` multiple times. The pages are executed in an ascending sequence and the runtime takes care of preventing double claims. ### payout_stakers_by_page Very similar to `payout_stakers` but also accepts an extra param `page_index`. An account can choose to payout rewards only for an explicitly passed `page_index`. **Lets look at an example scenario** Given an active validator on Kusama had 1100 nominators, `MaxExposurePageSize` set to 512 for Era e. In order to pay out rewards to all nominators, the caller would need to call `payout_stakers` 3 times. - `payout_stakers(origin, stash, e)` => will pay the first 512 nominators. - `payout_stakers(origin, stash, e)` => will pay the second set of 512 nominators. - `payout_stakers(origin, stash, e)` => will pay the last set of 76 nominators. ... - `payout_stakers(origin, stash, e)` => calling it the 4th time would return an error `InvalidPage`. The above calls can also be replaced by `payout_stakers_by_page` and passing a `page_index` explicitly. ## Commission note Validator commission is paid out in chunks across all the pages where each commission chunk is proportional to the total stake of the current page. This implies higher the total stake of a page, higher will be the commission. If all the pages of a validator's single era are paid out, the sum of commission paid to the validator across all pages should be equal to what the commission would have been if we had a non-paged exposure. ### Migration Note Strictly speaking, we did not need to bump our storage version since there is no migration of storage in this PR. But it is still useful to mark a storage upgrade for the following reasons: - New storage items are introduced in this PR while some older storage items are deprecated. - For the next `HistoryDepth` eras, the exposure would be incrementally migrated to its corresponding paged storage item. - Runtimes using staking pallet would strictly need to wait at least `HistoryDepth` eras with current upgraded version (14) for the migration to complete. At some era `E` such that `E > era_at_which_V14_gets_into_effect + HistoryDepth`, we will upgrade to version X which will remove the deprecated storage items. In other words, it is a strict requirement that E<sub>x</sub> - E<sub>14</sub> > `HistoryDepth`, where E<sub>x</sub> = Era at which deprecated storages are removed from runtime, E<sub>14</sub> = Era at which runtime is upgraded to version 14. - For Polkadot and Kusama, there is a [tracker ticket](https://github.com/paritytech/polkadot-sdk/issues/433) to clean up the deprecated storage items. ### Storage Changes #### Added - ErasStakersOverview - ClaimedRewards - ErasStakersPaged #### Deprecated The following can be cleaned up after 84 eras which is tracked [here](https://github.com/paritytech/polkadot-sdk/issues/433). - ErasStakers. - ErasStakersClipped. - StakingLedger.claimed_rewards, renamed to StakingLedger.legacy_claimed_rewards. ### Config Changes - Renamed MaxNominatorRewardedPerValidator to MaxExposurePageSize. ### TODO - [x] Tracker ticket for cleaning up the old code after 84 eras. - [x] Add companion. - [x] Redo benchmarks before merge. - [x] Add Changelog for pallet_staking. - [x] Pallet should be configurable to enable/disable paged rewards. - [x] Commission payouts are distributed across pages. - [x] Review documentation thoroughly. - [x] Rename `MaxNominatorRewardedPerValidator` -> `MaxExposurePageSize`. - [x] NMap for `ErasStakersPaged`. - [x] Deprecate ErasStakers. - [x] Integrity tests. ### Followup issues [Runtime api for deprecated ErasStakers storage item](https://github.com/paritytech/polkadot-sdk/issues/426) --------- Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: command-bot <>
419 lines
13 KiB
Rust
419 lines
13 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
//! Test utilities
|
|
|
|
use crate::{self as pallet_babe, Config, CurrentSlot};
|
|
use codec::Encode;
|
|
use frame_election_provider_support::{
|
|
bounds::{ElectionBounds, ElectionBoundsBuilder},
|
|
onchain, SequentialPhragmen,
|
|
};
|
|
use frame_support::{
|
|
derive_impl, parameter_types,
|
|
traits::{ConstU128, ConstU32, ConstU64, KeyOwnerProofSystem, OnInitialize},
|
|
};
|
|
use pallet_session::historical as pallet_session_historical;
|
|
use pallet_staking::FixedNominationsQuota;
|
|
use sp_consensus_babe::{AuthorityId, AuthorityPair, Randomness, Slot, VrfSignature};
|
|
use sp_core::{
|
|
crypto::{KeyTypeId, Pair, VrfSecret},
|
|
U256,
|
|
};
|
|
use sp_io;
|
|
use sp_runtime::{
|
|
curve::PiecewiseLinear,
|
|
impl_opaque_keys,
|
|
testing::{Digest, DigestItem, Header, TestXt},
|
|
traits::{Header as _, OpaqueKeys},
|
|
BuildStorage, Perbill,
|
|
};
|
|
use sp_staking::{EraIndex, SessionIndex};
|
|
|
|
type DummyValidatorId = u64;
|
|
|
|
type Block = frame_system::mocking::MockBlock<Test>;
|
|
|
|
frame_support::construct_runtime!(
|
|
pub enum Test
|
|
{
|
|
System: frame_system,
|
|
Authorship: pallet_authorship,
|
|
Balances: pallet_balances,
|
|
Historical: pallet_session_historical,
|
|
Offences: pallet_offences,
|
|
Babe: pallet_babe,
|
|
Staking: pallet_staking,
|
|
Session: pallet_session,
|
|
Timestamp: pallet_timestamp,
|
|
}
|
|
);
|
|
|
|
#[derive_impl(frame_system::config_preludes::TestDefaultConfig as frame_system::DefaultConfig)]
|
|
impl frame_system::Config for Test {
|
|
type Block = Block;
|
|
type AccountData = pallet_balances::AccountData<u128>;
|
|
}
|
|
|
|
impl<C> frame_system::offchain::SendTransactionTypes<C> for Test
|
|
where
|
|
RuntimeCall: From<C>,
|
|
{
|
|
type OverarchingCall = RuntimeCall;
|
|
type Extrinsic = TestXt<RuntimeCall, ()>;
|
|
}
|
|
|
|
impl_opaque_keys! {
|
|
pub struct MockSessionKeys {
|
|
pub babe_authority: super::Pallet<Test>,
|
|
}
|
|
}
|
|
|
|
impl pallet_session::Config for Test {
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type ValidatorId = <Self as frame_system::Config>::AccountId;
|
|
type ValidatorIdOf = pallet_staking::StashOf<Self>;
|
|
type ShouldEndSession = Babe;
|
|
type NextSessionRotation = Babe;
|
|
type SessionManager = pallet_session::historical::NoteHistoricalRoot<Self, Staking>;
|
|
type SessionHandler = <MockSessionKeys as OpaqueKeys>::KeyTypeIdProviders;
|
|
type Keys = MockSessionKeys;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl pallet_session::historical::Config for Test {
|
|
type FullIdentification = pallet_staking::Exposure<u64, u128>;
|
|
type FullIdentificationOf = pallet_staking::ExposureOf<Self>;
|
|
}
|
|
|
|
impl pallet_authorship::Config for Test {
|
|
type FindAuthor = pallet_session::FindAccountFromAuthorIndex<Self, Babe>;
|
|
type EventHandler = ();
|
|
}
|
|
|
|
impl pallet_timestamp::Config for Test {
|
|
type Moment = u64;
|
|
type OnTimestampSet = Babe;
|
|
type MinimumPeriod = ConstU64<1>;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl pallet_balances::Config for Test {
|
|
type MaxLocks = ();
|
|
type MaxReserves = ();
|
|
type ReserveIdentifier = [u8; 8];
|
|
type Balance = u128;
|
|
type DustRemoval = ();
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type ExistentialDeposit = ConstU128<1>;
|
|
type AccountStore = System;
|
|
type WeightInfo = ();
|
|
type FreezeIdentifier = ();
|
|
type MaxFreezes = ();
|
|
type RuntimeHoldReason = ();
|
|
type RuntimeFreezeReason = ();
|
|
type MaxHolds = ();
|
|
}
|
|
|
|
pallet_staking_reward_curve::build! {
|
|
const REWARD_CURVE: PiecewiseLinear<'static> = curve!(
|
|
min_inflation: 0_025_000u64,
|
|
max_inflation: 0_100_000,
|
|
ideal_stake: 0_500_000,
|
|
falloff: 0_050_000,
|
|
max_piece_count: 40,
|
|
test_precision: 0_005_000,
|
|
);
|
|
}
|
|
|
|
parameter_types! {
|
|
pub const SessionsPerEra: SessionIndex = 3;
|
|
pub const BondingDuration: EraIndex = 3;
|
|
pub const SlashDeferDuration: EraIndex = 0;
|
|
pub const RewardCurve: &'static PiecewiseLinear<'static> = &REWARD_CURVE;
|
|
pub const OffendingValidatorsThreshold: Perbill = Perbill::from_percent(16);
|
|
pub static ElectionsBounds: ElectionBounds = ElectionBoundsBuilder::default().build();
|
|
}
|
|
|
|
pub struct OnChainSeqPhragmen;
|
|
impl onchain::Config for OnChainSeqPhragmen {
|
|
type System = Test;
|
|
type Solver = SequentialPhragmen<DummyValidatorId, Perbill>;
|
|
type DataProvider = Staking;
|
|
type WeightInfo = ();
|
|
type MaxWinners = ConstU32<100>;
|
|
type Bounds = ElectionsBounds;
|
|
}
|
|
|
|
impl pallet_staking::Config for Test {
|
|
type RewardRemainder = ();
|
|
type CurrencyToVote = ();
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type Currency = Balances;
|
|
type CurrencyBalance = <Self as pallet_balances::Config>::Balance;
|
|
type Slash = ();
|
|
type Reward = ();
|
|
type SessionsPerEra = SessionsPerEra;
|
|
type BondingDuration = BondingDuration;
|
|
type SlashDeferDuration = SlashDeferDuration;
|
|
type AdminOrigin = frame_system::EnsureRoot<Self::AccountId>;
|
|
type SessionInterface = Self;
|
|
type UnixTime = pallet_timestamp::Pallet<Test>;
|
|
type EraPayout = pallet_staking::ConvertCurve<RewardCurve>;
|
|
type MaxExposurePageSize = ConstU32<64>;
|
|
type OffendingValidatorsThreshold = OffendingValidatorsThreshold;
|
|
type NextNewSession = Session;
|
|
type ElectionProvider = onchain::OnChainExecution<OnChainSeqPhragmen>;
|
|
type GenesisElectionProvider = Self::ElectionProvider;
|
|
type VoterList = pallet_staking::UseNominatorsAndValidatorsMap<Self>;
|
|
type TargetList = pallet_staking::UseValidatorsMap<Self>;
|
|
type NominationsQuota = FixedNominationsQuota<16>;
|
|
type MaxUnlockingChunks = ConstU32<32>;
|
|
type HistoryDepth = ConstU32<84>;
|
|
type EventListeners = ();
|
|
type BenchmarkingConfig = pallet_staking::TestBenchmarkingConfig;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl pallet_offences::Config for Test {
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type IdentificationTuple = pallet_session::historical::IdentificationTuple<Self>;
|
|
type OnOffenceHandler = Staking;
|
|
}
|
|
|
|
parameter_types! {
|
|
pub const EpochDuration: u64 = 3;
|
|
pub const ReportLongevity: u64 =
|
|
BondingDuration::get() as u64 * SessionsPerEra::get() as u64 * EpochDuration::get();
|
|
}
|
|
|
|
impl Config for Test {
|
|
type EpochDuration = EpochDuration;
|
|
type ExpectedBlockTime = ConstU64<1>;
|
|
type EpochChangeTrigger = crate::ExternalTrigger;
|
|
type DisabledValidators = Session;
|
|
type WeightInfo = ();
|
|
type MaxAuthorities = ConstU32<10>;
|
|
type MaxNominators = ConstU32<100>;
|
|
type KeyOwnerProof = <Historical as KeyOwnerProofSystem<(KeyTypeId, AuthorityId)>>::Proof;
|
|
type EquivocationReportSystem =
|
|
super::EquivocationReportSystem<Self, Offences, Historical, ReportLongevity>;
|
|
}
|
|
|
|
pub fn go_to_block(n: u64, s: u64) {
|
|
use frame_support::traits::OnFinalize;
|
|
|
|
Babe::on_finalize(System::block_number());
|
|
Session::on_finalize(System::block_number());
|
|
Staking::on_finalize(System::block_number());
|
|
|
|
let parent_hash = if System::block_number() > 1 {
|
|
let hdr = System::finalize();
|
|
hdr.hash()
|
|
} else {
|
|
System::parent_hash()
|
|
};
|
|
|
|
let pre_digest = make_secondary_plain_pre_digest(0, s.into());
|
|
|
|
System::reset_events();
|
|
System::initialize(&n, &parent_hash, &pre_digest);
|
|
|
|
Babe::on_initialize(n);
|
|
Session::on_initialize(n);
|
|
Staking::on_initialize(n);
|
|
}
|
|
|
|
/// Slots will grow accordingly to blocks
|
|
pub fn progress_to_block(n: u64) {
|
|
let mut slot = u64::from(Babe::current_slot()) + 1;
|
|
for i in System::block_number() + 1..=n {
|
|
go_to_block(i, slot);
|
|
slot += 1;
|
|
}
|
|
}
|
|
|
|
/// Progress to the first block at the given session
|
|
pub fn start_session(session_index: SessionIndex) {
|
|
let missing = (session_index - Session::current_index()) * 3;
|
|
progress_to_block(System::block_number() + missing as u64 + 1);
|
|
assert_eq!(Session::current_index(), session_index);
|
|
}
|
|
|
|
/// Progress to the first block at the given era
|
|
pub fn start_era(era_index: EraIndex) {
|
|
start_session((era_index * 3).into());
|
|
assert_eq!(Staking::current_era(), Some(era_index));
|
|
}
|
|
|
|
pub fn make_primary_pre_digest(
|
|
authority_index: sp_consensus_babe::AuthorityIndex,
|
|
slot: sp_consensus_babe::Slot,
|
|
vrf_signature: VrfSignature,
|
|
) -> Digest {
|
|
let digest_data = sp_consensus_babe::digests::PreDigest::Primary(
|
|
sp_consensus_babe::digests::PrimaryPreDigest { authority_index, slot, vrf_signature },
|
|
);
|
|
let log = DigestItem::PreRuntime(sp_consensus_babe::BABE_ENGINE_ID, digest_data.encode());
|
|
Digest { logs: vec![log] }
|
|
}
|
|
|
|
pub fn make_secondary_plain_pre_digest(
|
|
authority_index: sp_consensus_babe::AuthorityIndex,
|
|
slot: sp_consensus_babe::Slot,
|
|
) -> Digest {
|
|
let digest_data = sp_consensus_babe::digests::PreDigest::SecondaryPlain(
|
|
sp_consensus_babe::digests::SecondaryPlainPreDigest { authority_index, slot },
|
|
);
|
|
let log = DigestItem::PreRuntime(sp_consensus_babe::BABE_ENGINE_ID, digest_data.encode());
|
|
Digest { logs: vec![log] }
|
|
}
|
|
|
|
pub fn make_secondary_vrf_pre_digest(
|
|
authority_index: sp_consensus_babe::AuthorityIndex,
|
|
slot: sp_consensus_babe::Slot,
|
|
vrf_signature: VrfSignature,
|
|
) -> Digest {
|
|
let digest_data = sp_consensus_babe::digests::PreDigest::SecondaryVRF(
|
|
sp_consensus_babe::digests::SecondaryVRFPreDigest { authority_index, slot, vrf_signature },
|
|
);
|
|
let log = DigestItem::PreRuntime(sp_consensus_babe::BABE_ENGINE_ID, digest_data.encode());
|
|
Digest { logs: vec![log] }
|
|
}
|
|
|
|
pub fn make_vrf_signature_and_randomness(
|
|
slot: Slot,
|
|
pair: &sp_consensus_babe::AuthorityPair,
|
|
) -> (VrfSignature, Randomness) {
|
|
let transcript = sp_consensus_babe::make_vrf_transcript(&Babe::randomness(), slot, 0);
|
|
|
|
let randomness =
|
|
pair.as_ref().make_bytes(sp_consensus_babe::RANDOMNESS_VRF_CONTEXT, &transcript);
|
|
|
|
let signature = pair.as_ref().vrf_sign(&transcript.into());
|
|
|
|
(signature, randomness)
|
|
}
|
|
|
|
pub fn new_test_ext(authorities_len: usize) -> sp_io::TestExternalities {
|
|
new_test_ext_with_pairs(authorities_len).1
|
|
}
|
|
|
|
pub fn new_test_ext_with_pairs(
|
|
authorities_len: usize,
|
|
) -> (Vec<AuthorityPair>, sp_io::TestExternalities) {
|
|
let pairs = (0..authorities_len)
|
|
.map(|i| AuthorityPair::from_seed(&U256::from(i).into()))
|
|
.collect::<Vec<_>>();
|
|
|
|
let public = pairs.iter().map(|p| p.public()).collect();
|
|
|
|
(pairs, new_test_ext_raw_authorities(public))
|
|
}
|
|
|
|
pub fn new_test_ext_raw_authorities(authorities: Vec<AuthorityId>) -> sp_io::TestExternalities {
|
|
let mut t = frame_system::GenesisConfig::<Test>::default().build_storage().unwrap();
|
|
|
|
let balances: Vec<_> = (0..authorities.len()).map(|i| (i as u64, 10_000_000)).collect();
|
|
|
|
pallet_balances::GenesisConfig::<Test> { balances }
|
|
.assimilate_storage(&mut t)
|
|
.unwrap();
|
|
|
|
// stashes are the index.
|
|
let session_keys: Vec<_> = authorities
|
|
.iter()
|
|
.enumerate()
|
|
.map(|(i, k)| {
|
|
(i as u64, i as u64, MockSessionKeys { babe_authority: AuthorityId::from(k.clone()) })
|
|
})
|
|
.collect();
|
|
|
|
// NOTE: this will initialize the babe authorities
|
|
// through OneSessionHandler::on_genesis_session
|
|
pallet_session::GenesisConfig::<Test> { keys: session_keys }
|
|
.assimilate_storage(&mut t)
|
|
.unwrap();
|
|
|
|
// controllers are same as stash
|
|
let stakers: Vec<_> = (0..authorities.len())
|
|
.map(|i| (i as u64, i as u64, 10_000, pallet_staking::StakerStatus::<u64>::Validator))
|
|
.collect();
|
|
|
|
let staking_config = pallet_staking::GenesisConfig::<Test> {
|
|
stakers,
|
|
validator_count: 8,
|
|
force_era: pallet_staking::Forcing::ForceNew,
|
|
minimum_validator_count: 0,
|
|
invulnerables: vec![],
|
|
..Default::default()
|
|
};
|
|
|
|
staking_config.assimilate_storage(&mut t).unwrap();
|
|
|
|
t.into()
|
|
}
|
|
|
|
/// Creates an equivocation at the current block, by generating two headers.
|
|
pub fn generate_equivocation_proof(
|
|
offender_authority_index: u32,
|
|
offender_authority_pair: &AuthorityPair,
|
|
slot: Slot,
|
|
) -> sp_consensus_babe::EquivocationProof<Header> {
|
|
use sp_consensus_babe::digests::CompatibleDigestItem;
|
|
|
|
let current_block = System::block_number();
|
|
let current_slot = CurrentSlot::<Test>::get();
|
|
|
|
let make_header = || {
|
|
let parent_hash = System::parent_hash();
|
|
let pre_digest = make_secondary_plain_pre_digest(offender_authority_index, slot);
|
|
System::reset_events();
|
|
System::initialize(¤t_block, &parent_hash, &pre_digest);
|
|
System::set_block_number(current_block);
|
|
Timestamp::set_timestamp(*current_slot * Babe::slot_duration());
|
|
System::finalize()
|
|
};
|
|
|
|
// sign the header prehash and sign it, adding it to the block as the seal
|
|
// digest item
|
|
let seal_header = |header: &mut Header| {
|
|
let prehash = header.hash();
|
|
let seal = <DigestItem as CompatibleDigestItem>::babe_seal(
|
|
offender_authority_pair.sign(prehash.as_ref()),
|
|
);
|
|
header.digest_mut().push(seal);
|
|
};
|
|
|
|
// generate two headers at the current block
|
|
let mut h1 = make_header();
|
|
let mut h2 = make_header();
|
|
|
|
seal_header(&mut h1);
|
|
seal_header(&mut h2);
|
|
|
|
// restore previous runtime state
|
|
go_to_block(current_block, *current_slot);
|
|
|
|
sp_consensus_babe::EquivocationProof {
|
|
slot,
|
|
offender: offender_authority_pair.public(),
|
|
first_header: h1,
|
|
second_header: h2,
|
|
}
|
|
}
|