mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-28 20:17:57 +00:00
1943e25cb9
* frame-executive: Reject invalid inherents in the executive We already had support for making a block fail if an inherent returned, but it was part of the signed extension `CheckWeight`. Rejecting blocks with invalid inherents should happen on the `frame-executive` level without requiring any special signed extension. This is crucial to prevent any kind of spamming of the network that could may happen with blocks that include failing inherents. * FMT * Update frame/executive/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update primitives/runtime/src/transaction_validity.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: parity-processbot <> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
715 lines
22 KiB
Rust
715 lines
22 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) 2017-2022 Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use crate::{limits::BlockWeights, Config, Pallet};
|
|
use codec::{Decode, Encode};
|
|
use frame_support::{
|
|
dispatch::{DispatchInfo, PostDispatchInfo},
|
|
traits::Get,
|
|
};
|
|
use scale_info::TypeInfo;
|
|
use sp_runtime::{
|
|
traits::{DispatchInfoOf, Dispatchable, PostDispatchInfoOf, SignedExtension},
|
|
transaction_validity::{InvalidTransaction, TransactionValidity, TransactionValidityError},
|
|
DispatchResult,
|
|
};
|
|
use sp_weights::Weight;
|
|
|
|
/// Block resource (weight) limit check.
|
|
///
|
|
/// # Transaction Validity
|
|
///
|
|
/// This extension does not influence any fields of `TransactionValidity` in case the
|
|
/// transaction is valid.
|
|
#[derive(Encode, Decode, Clone, Eq, PartialEq, Default, TypeInfo)]
|
|
#[scale_info(skip_type_params(T))]
|
|
pub struct CheckWeight<T: Config + Send + Sync>(sp_std::marker::PhantomData<T>);
|
|
|
|
impl<T: Config + Send + Sync> CheckWeight<T>
|
|
where
|
|
T::RuntimeCall: Dispatchable<Info = DispatchInfo, PostInfo = PostDispatchInfo>,
|
|
{
|
|
/// Checks if the current extrinsic does not exceed the maximum weight a single extrinsic
|
|
/// with given `DispatchClass` can have.
|
|
fn check_extrinsic_weight(
|
|
info: &DispatchInfoOf<T::RuntimeCall>,
|
|
) -> Result<(), TransactionValidityError> {
|
|
let max = T::BlockWeights::get().get(info.class).max_extrinsic;
|
|
match max {
|
|
Some(max) if info.weight.any_gt(max) =>
|
|
Err(InvalidTransaction::ExhaustsResources.into()),
|
|
_ => Ok(()),
|
|
}
|
|
}
|
|
|
|
/// Checks if the current extrinsic can fit into the block with respect to block weight limits.
|
|
///
|
|
/// Upon successes, it returns the new block weight as a `Result`.
|
|
fn check_block_weight(
|
|
info: &DispatchInfoOf<T::RuntimeCall>,
|
|
) -> Result<crate::ConsumedWeight, TransactionValidityError> {
|
|
let maximum_weight = T::BlockWeights::get();
|
|
let all_weight = Pallet::<T>::block_weight();
|
|
calculate_consumed_weight::<T::RuntimeCall>(maximum_weight, all_weight, info)
|
|
}
|
|
|
|
/// Checks if the current extrinsic can fit into the block with respect to block length limits.
|
|
///
|
|
/// Upon successes, it returns the new block length as a `Result`.
|
|
fn check_block_length(
|
|
info: &DispatchInfoOf<T::RuntimeCall>,
|
|
len: usize,
|
|
) -> Result<u32, TransactionValidityError> {
|
|
let length_limit = T::BlockLength::get();
|
|
let current_len = Pallet::<T>::all_extrinsics_len();
|
|
let added_len = len as u32;
|
|
let next_len = current_len.saturating_add(added_len);
|
|
if next_len > *length_limit.max.get(info.class) {
|
|
Err(InvalidTransaction::ExhaustsResources.into())
|
|
} else {
|
|
Ok(next_len)
|
|
}
|
|
}
|
|
|
|
/// Creates new `SignedExtension` to check weight of the extrinsic.
|
|
pub fn new() -> Self {
|
|
Self(Default::default())
|
|
}
|
|
|
|
/// Do the pre-dispatch checks. This can be applied to both signed and unsigned.
|
|
///
|
|
/// It checks and notes the new weight and length.
|
|
pub fn do_pre_dispatch(
|
|
info: &DispatchInfoOf<T::RuntimeCall>,
|
|
len: usize,
|
|
) -> Result<(), TransactionValidityError> {
|
|
let next_len = Self::check_block_length(info, len)?;
|
|
let next_weight = Self::check_block_weight(info)?;
|
|
Self::check_extrinsic_weight(info)?;
|
|
|
|
crate::AllExtrinsicsLen::<T>::put(next_len);
|
|
crate::BlockWeight::<T>::put(next_weight);
|
|
Ok(())
|
|
}
|
|
|
|
/// Do the validate checks. This can be applied to both signed and unsigned.
|
|
///
|
|
/// It only checks that the block weight and length limit will not exceed.
|
|
pub fn do_validate(info: &DispatchInfoOf<T::RuntimeCall>, len: usize) -> TransactionValidity {
|
|
// ignore the next length. If they return `Ok`, then it is below the limit.
|
|
let _ = Self::check_block_length(info, len)?;
|
|
// during validation we skip block limit check. Since the `validate_transaction`
|
|
// call runs on an empty block anyway, by this we prevent `on_initialize` weight
|
|
// consumption from causing false negatives.
|
|
Self::check_extrinsic_weight(info)?;
|
|
|
|
Ok(Default::default())
|
|
}
|
|
}
|
|
|
|
pub fn calculate_consumed_weight<Call>(
|
|
maximum_weight: BlockWeights,
|
|
mut all_weight: crate::ConsumedWeight,
|
|
info: &DispatchInfoOf<Call>,
|
|
) -> Result<crate::ConsumedWeight, TransactionValidityError>
|
|
where
|
|
Call: Dispatchable<Info = DispatchInfo, PostInfo = PostDispatchInfo>,
|
|
{
|
|
let extrinsic_weight =
|
|
info.weight.saturating_add(maximum_weight.get(info.class).base_extrinsic);
|
|
let limit_per_class = maximum_weight.get(info.class);
|
|
|
|
// add the weight. If class is unlimited, use saturating add instead of checked one.
|
|
if limit_per_class.max_total.is_none() && limit_per_class.reserved.is_none() {
|
|
all_weight.add(extrinsic_weight, info.class)
|
|
} else {
|
|
all_weight
|
|
.checked_add(extrinsic_weight, info.class)
|
|
.map_err(|_| InvalidTransaction::ExhaustsResources)?;
|
|
}
|
|
|
|
let per_class = *all_weight.get(info.class);
|
|
|
|
// Check if we don't exceed per-class allowance
|
|
match limit_per_class.max_total {
|
|
Some(max) if per_class.any_gt(max) =>
|
|
return Err(InvalidTransaction::ExhaustsResources.into()),
|
|
// There is no `max_total` limit (`None`),
|
|
// or we are below the limit.
|
|
_ => {},
|
|
}
|
|
|
|
// In cases total block weight is exceeded, we need to fall back
|
|
// to `reserved` pool if there is any.
|
|
if all_weight.total().any_gt(maximum_weight.max_block) {
|
|
match limit_per_class.reserved {
|
|
// We are over the limit in reserved pool.
|
|
Some(reserved) if per_class.any_gt(reserved) =>
|
|
return Err(InvalidTransaction::ExhaustsResources.into()),
|
|
// There is either no limit in reserved pool (`None`),
|
|
// or we are below the limit.
|
|
_ => {},
|
|
}
|
|
}
|
|
|
|
Ok(all_weight)
|
|
}
|
|
|
|
impl<T: Config + Send + Sync> SignedExtension for CheckWeight<T>
|
|
where
|
|
T::RuntimeCall: Dispatchable<Info = DispatchInfo, PostInfo = PostDispatchInfo>,
|
|
{
|
|
type AccountId = T::AccountId;
|
|
type Call = T::RuntimeCall;
|
|
type AdditionalSigned = ();
|
|
type Pre = ();
|
|
const IDENTIFIER: &'static str = "CheckWeight";
|
|
|
|
fn additional_signed(&self) -> sp_std::result::Result<(), TransactionValidityError> {
|
|
Ok(())
|
|
}
|
|
|
|
fn pre_dispatch(
|
|
self,
|
|
_who: &Self::AccountId,
|
|
_call: &Self::Call,
|
|
info: &DispatchInfoOf<Self::Call>,
|
|
len: usize,
|
|
) -> Result<(), TransactionValidityError> {
|
|
Self::do_pre_dispatch(info, len)
|
|
}
|
|
|
|
fn validate(
|
|
&self,
|
|
_who: &Self::AccountId,
|
|
_call: &Self::Call,
|
|
info: &DispatchInfoOf<Self::Call>,
|
|
len: usize,
|
|
) -> TransactionValidity {
|
|
Self::do_validate(info, len)
|
|
}
|
|
|
|
fn pre_dispatch_unsigned(
|
|
_call: &Self::Call,
|
|
info: &DispatchInfoOf<Self::Call>,
|
|
len: usize,
|
|
) -> Result<(), TransactionValidityError> {
|
|
Self::do_pre_dispatch(info, len)
|
|
}
|
|
|
|
fn validate_unsigned(
|
|
_call: &Self::Call,
|
|
info: &DispatchInfoOf<Self::Call>,
|
|
len: usize,
|
|
) -> TransactionValidity {
|
|
Self::do_validate(info, len)
|
|
}
|
|
|
|
fn post_dispatch(
|
|
_pre: Option<Self::Pre>,
|
|
info: &DispatchInfoOf<Self::Call>,
|
|
post_info: &PostDispatchInfoOf<Self::Call>,
|
|
_len: usize,
|
|
_result: &DispatchResult,
|
|
) -> Result<(), TransactionValidityError> {
|
|
let unspent = post_info.calc_unspent(info);
|
|
if unspent.any_gt(Weight::zero()) {
|
|
crate::BlockWeight::<T>::mutate(|current_weight| {
|
|
current_weight.sub(unspent, info.class);
|
|
})
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
impl<T: Config + Send + Sync> sp_std::fmt::Debug for CheckWeight<T> {
|
|
#[cfg(feature = "std")]
|
|
fn fmt(&self, f: &mut sp_std::fmt::Formatter) -> sp_std::fmt::Result {
|
|
write!(f, "CheckWeight")
|
|
}
|
|
|
|
#[cfg(not(feature = "std"))]
|
|
fn fmt(&self, _: &mut sp_std::fmt::Formatter) -> sp_std::fmt::Result {
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use crate::{
|
|
mock::{new_test_ext, System, Test, CALL},
|
|
AllExtrinsicsLen, BlockWeight, DispatchClass,
|
|
};
|
|
use frame_support::{assert_err, assert_ok, dispatch::Pays, weights::Weight};
|
|
use sp_std::marker::PhantomData;
|
|
|
|
fn block_weights() -> crate::limits::BlockWeights {
|
|
<Test as crate::Config>::BlockWeights::get()
|
|
}
|
|
|
|
fn normal_weight_limit() -> Weight {
|
|
block_weights()
|
|
.get(DispatchClass::Normal)
|
|
.max_total
|
|
.unwrap_or_else(|| block_weights().max_block)
|
|
}
|
|
|
|
fn block_weight_limit() -> Weight {
|
|
block_weights().max_block
|
|
}
|
|
|
|
fn normal_length_limit() -> u32 {
|
|
*<Test as Config>::BlockLength::get().max.get(DispatchClass::Normal)
|
|
}
|
|
|
|
#[test]
|
|
fn mandatory_extrinsic_doesnt_care_about_limits() {
|
|
fn check(call: impl FnOnce(&DispatchInfo, usize)) {
|
|
new_test_ext().execute_with(|| {
|
|
let max = DispatchInfo {
|
|
weight: Weight::MAX,
|
|
class: DispatchClass::Mandatory,
|
|
..Default::default()
|
|
};
|
|
let len = 0_usize;
|
|
|
|
call(&max, len);
|
|
});
|
|
}
|
|
|
|
check(|max, len| {
|
|
assert_ok!(CheckWeight::<Test>::do_pre_dispatch(max, len));
|
|
assert_eq!(System::block_weight().total(), Weight::MAX);
|
|
assert!(System::block_weight().total().ref_time() > block_weight_limit().ref_time());
|
|
});
|
|
check(|max, len| {
|
|
assert_ok!(CheckWeight::<Test>::do_validate(max, len));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn normal_extrinsic_limited_by_maximum_extrinsic_weight() {
|
|
new_test_ext().execute_with(|| {
|
|
let max = DispatchInfo {
|
|
weight: block_weights().get(DispatchClass::Normal).max_extrinsic.unwrap() +
|
|
Weight::from_ref_time(1),
|
|
class: DispatchClass::Normal,
|
|
..Default::default()
|
|
};
|
|
let len = 0_usize;
|
|
assert_err!(
|
|
CheckWeight::<Test>::do_validate(&max, len),
|
|
InvalidTransaction::ExhaustsResources
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn operational_extrinsic_limited_by_operational_space_limit() {
|
|
new_test_ext().execute_with(|| {
|
|
let weights = block_weights();
|
|
let operational_limit = weights
|
|
.get(DispatchClass::Operational)
|
|
.max_total
|
|
.unwrap_or_else(|| weights.max_block);
|
|
let base_weight = weights.get(DispatchClass::Operational).base_extrinsic;
|
|
|
|
let weight = operational_limit - base_weight;
|
|
let okay =
|
|
DispatchInfo { weight, class: DispatchClass::Operational, ..Default::default() };
|
|
let max = DispatchInfo {
|
|
weight: weight + Weight::from_ref_time(1),
|
|
class: DispatchClass::Operational,
|
|
..Default::default()
|
|
};
|
|
let len = 0_usize;
|
|
|
|
assert_eq!(CheckWeight::<Test>::do_validate(&okay, len), Ok(Default::default()));
|
|
assert_err!(
|
|
CheckWeight::<Test>::do_validate(&max, len),
|
|
InvalidTransaction::ExhaustsResources
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn register_extra_weight_unchecked_doesnt_care_about_limits() {
|
|
new_test_ext().execute_with(|| {
|
|
System::register_extra_weight_unchecked(Weight::MAX, DispatchClass::Normal);
|
|
assert_eq!(System::block_weight().total(), Weight::MAX);
|
|
assert!(System::block_weight().total().ref_time() > block_weight_limit().ref_time());
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn full_block_with_normal_and_operational() {
|
|
new_test_ext().execute_with(|| {
|
|
// Max block is 1024
|
|
// Max normal is 768 (75%)
|
|
// 10 is taken for block execution weight
|
|
// So normal extrinsic can be 758 weight (-5 for base extrinsic weight)
|
|
// And Operational can be 246 to produce a full block (-10 for base)
|
|
let max_normal =
|
|
DispatchInfo { weight: Weight::from_ref_time(753), ..Default::default() };
|
|
let rest_operational = DispatchInfo {
|
|
weight: Weight::from_ref_time(246),
|
|
class: DispatchClass::Operational,
|
|
..Default::default()
|
|
};
|
|
|
|
let len = 0_usize;
|
|
|
|
assert_ok!(CheckWeight::<Test>::do_pre_dispatch(&max_normal, len));
|
|
assert_eq!(System::block_weight().total(), Weight::from_ref_time(768));
|
|
assert_ok!(CheckWeight::<Test>::do_pre_dispatch(&rest_operational, len));
|
|
assert_eq!(block_weight_limit(), Weight::from_ref_time(1024).set_proof_size(u64::MAX));
|
|
assert_eq!(System::block_weight().total(), block_weight_limit().set_proof_size(0));
|
|
// Checking single extrinsic should not take current block weight into account.
|
|
assert_eq!(CheckWeight::<Test>::check_extrinsic_weight(&rest_operational), Ok(()));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn dispatch_order_does_not_effect_weight_logic() {
|
|
new_test_ext().execute_with(|| {
|
|
// We switch the order of `full_block_with_normal_and_operational`
|
|
let max_normal =
|
|
DispatchInfo { weight: Weight::from_ref_time(753), ..Default::default() };
|
|
let rest_operational = DispatchInfo {
|
|
weight: Weight::from_ref_time(246),
|
|
class: DispatchClass::Operational,
|
|
..Default::default()
|
|
};
|
|
|
|
let len = 0_usize;
|
|
|
|
assert_ok!(CheckWeight::<Test>::do_pre_dispatch(&rest_operational, len));
|
|
// Extra 20 here from block execution + base extrinsic weight
|
|
assert_eq!(System::block_weight().total(), Weight::from_ref_time(266));
|
|
assert_ok!(CheckWeight::<Test>::do_pre_dispatch(&max_normal, len));
|
|
assert_eq!(block_weight_limit(), Weight::from_ref_time(1024).set_proof_size(u64::MAX));
|
|
assert_eq!(System::block_weight().total(), block_weight_limit().set_proof_size(0));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn operational_works_on_full_block() {
|
|
new_test_ext().execute_with(|| {
|
|
// An on_initialize takes up the whole block! (Every time!)
|
|
System::register_extra_weight_unchecked(Weight::MAX, DispatchClass::Mandatory);
|
|
let dispatch_normal = DispatchInfo {
|
|
weight: Weight::from_ref_time(251),
|
|
class: DispatchClass::Normal,
|
|
..Default::default()
|
|
};
|
|
let dispatch_operational = DispatchInfo {
|
|
weight: Weight::from_ref_time(246),
|
|
class: DispatchClass::Operational,
|
|
..Default::default()
|
|
};
|
|
let len = 0_usize;
|
|
|
|
assert_err!(
|
|
CheckWeight::<Test>::do_pre_dispatch(&dispatch_normal, len),
|
|
InvalidTransaction::ExhaustsResources
|
|
);
|
|
// Thank goodness we can still do an operational transaction to possibly save the
|
|
// blockchain.
|
|
assert_ok!(CheckWeight::<Test>::do_pre_dispatch(&dispatch_operational, len));
|
|
// Not too much though
|
|
assert_err!(
|
|
CheckWeight::<Test>::do_pre_dispatch(&dispatch_operational, len),
|
|
InvalidTransaction::ExhaustsResources
|
|
);
|
|
// Even with full block, validity of single transaction should be correct.
|
|
assert_eq!(CheckWeight::<Test>::check_extrinsic_weight(&dispatch_operational), Ok(()));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn signed_ext_check_weight_works_operational_tx() {
|
|
new_test_ext().execute_with(|| {
|
|
let normal = DispatchInfo { weight: Weight::from_ref_time(100), ..Default::default() };
|
|
let op = DispatchInfo {
|
|
weight: Weight::from_ref_time(100),
|
|
class: DispatchClass::Operational,
|
|
pays_fee: Pays::Yes,
|
|
};
|
|
let len = 0_usize;
|
|
let normal_limit = normal_weight_limit();
|
|
|
|
// given almost full block
|
|
BlockWeight::<Test>::mutate(|current_weight| {
|
|
current_weight.set(normal_limit, DispatchClass::Normal)
|
|
});
|
|
// will not fit.
|
|
assert_err!(
|
|
CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, &normal, len),
|
|
InvalidTransaction::ExhaustsResources
|
|
);
|
|
// will fit.
|
|
assert_ok!(CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, &op, len));
|
|
|
|
// likewise for length limit.
|
|
let len = 100_usize;
|
|
AllExtrinsicsLen::<Test>::put(normal_length_limit());
|
|
assert_err!(
|
|
CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, &normal, len),
|
|
InvalidTransaction::ExhaustsResources
|
|
);
|
|
assert_ok!(CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, &op, len));
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn signed_ext_check_weight_block_size_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let normal = DispatchInfo::default();
|
|
let normal_limit = normal_weight_limit().ref_time() as usize;
|
|
let reset_check_weight = |tx, s, f| {
|
|
AllExtrinsicsLen::<Test>::put(0);
|
|
let r = CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, tx, s);
|
|
if f {
|
|
assert!(r.is_err())
|
|
} else {
|
|
assert!(r.is_ok())
|
|
}
|
|
};
|
|
|
|
reset_check_weight(&normal, normal_limit - 1, false);
|
|
reset_check_weight(&normal, normal_limit, false);
|
|
reset_check_weight(&normal, normal_limit + 1, true);
|
|
|
|
// Operational ones don't have this limit.
|
|
let op = DispatchInfo {
|
|
weight: Weight::zero(),
|
|
class: DispatchClass::Operational,
|
|
pays_fee: Pays::Yes,
|
|
};
|
|
reset_check_weight(&op, normal_limit, false);
|
|
reset_check_weight(&op, normal_limit + 100, false);
|
|
reset_check_weight(&op, 1024, false);
|
|
reset_check_weight(&op, 1025, true);
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn signed_ext_check_weight_works_normal_tx() {
|
|
new_test_ext().execute_with(|| {
|
|
let normal_limit = normal_weight_limit();
|
|
let small = DispatchInfo { weight: Weight::from_ref_time(100), ..Default::default() };
|
|
let base_extrinsic = block_weights().get(DispatchClass::Normal).base_extrinsic;
|
|
let medium =
|
|
DispatchInfo { weight: normal_limit - base_extrinsic, ..Default::default() };
|
|
let big = DispatchInfo {
|
|
weight: normal_limit - base_extrinsic + Weight::from_ref_time(1),
|
|
..Default::default()
|
|
};
|
|
let len = 0_usize;
|
|
|
|
let reset_check_weight = |i, f, s| {
|
|
BlockWeight::<Test>::mutate(|current_weight| {
|
|
current_weight.set(s, DispatchClass::Normal)
|
|
});
|
|
let r = CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, i, len);
|
|
if f {
|
|
assert!(r.is_err())
|
|
} else {
|
|
assert!(r.is_ok())
|
|
}
|
|
};
|
|
|
|
reset_check_weight(&small, false, Weight::zero());
|
|
reset_check_weight(&medium, false, Weight::zero());
|
|
reset_check_weight(&big, true, Weight::from_ref_time(1));
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn signed_ext_check_weight_refund_works() {
|
|
new_test_ext().execute_with(|| {
|
|
// This is half of the max block weight
|
|
let info = DispatchInfo { weight: Weight::from_ref_time(512), ..Default::default() };
|
|
let post_info = PostDispatchInfo {
|
|
actual_weight: Some(Weight::from_ref_time(128)),
|
|
pays_fee: Default::default(),
|
|
};
|
|
let len = 0_usize;
|
|
let base_extrinsic = block_weights().get(DispatchClass::Normal).base_extrinsic;
|
|
|
|
// We allow 75% for normal transaction, so we put 25% - extrinsic base weight
|
|
BlockWeight::<Test>::mutate(|current_weight| {
|
|
current_weight.set(Weight::zero(), DispatchClass::Mandatory);
|
|
current_weight
|
|
.set(Weight::from_ref_time(256) - base_extrinsic, DispatchClass::Normal);
|
|
});
|
|
|
|
let pre = CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, &info, len).unwrap();
|
|
assert_eq!(
|
|
BlockWeight::<Test>::get().total(),
|
|
info.weight + Weight::from_ref_time(256)
|
|
);
|
|
|
|
assert_ok!(CheckWeight::<Test>::post_dispatch(
|
|
Some(pre),
|
|
&info,
|
|
&post_info,
|
|
len,
|
|
&Ok(())
|
|
));
|
|
assert_eq!(
|
|
BlockWeight::<Test>::get().total(),
|
|
post_info.actual_weight.unwrap() + Weight::from_ref_time(256)
|
|
);
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn signed_ext_check_weight_actual_weight_higher_than_max_is_capped() {
|
|
new_test_ext().execute_with(|| {
|
|
let info = DispatchInfo { weight: Weight::from_ref_time(512), ..Default::default() };
|
|
let post_info = PostDispatchInfo {
|
|
actual_weight: Some(Weight::from_ref_time(700)),
|
|
pays_fee: Default::default(),
|
|
};
|
|
let len = 0_usize;
|
|
|
|
BlockWeight::<Test>::mutate(|current_weight| {
|
|
current_weight.set(Weight::zero(), DispatchClass::Mandatory);
|
|
current_weight.set(Weight::from_ref_time(128), DispatchClass::Normal);
|
|
});
|
|
|
|
let pre = CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, &info, len).unwrap();
|
|
assert_eq!(
|
|
BlockWeight::<Test>::get().total(),
|
|
info.weight +
|
|
Weight::from_ref_time(128) +
|
|
block_weights().get(DispatchClass::Normal).base_extrinsic,
|
|
);
|
|
|
|
assert_ok!(CheckWeight::<Test>::post_dispatch(
|
|
Some(pre),
|
|
&info,
|
|
&post_info,
|
|
len,
|
|
&Ok(())
|
|
));
|
|
assert_eq!(
|
|
BlockWeight::<Test>::get().total(),
|
|
info.weight +
|
|
Weight::from_ref_time(128) +
|
|
block_weights().get(DispatchClass::Normal).base_extrinsic,
|
|
);
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn zero_weight_extrinsic_still_has_base_weight() {
|
|
new_test_ext().execute_with(|| {
|
|
let weights = block_weights();
|
|
let free = DispatchInfo { weight: Weight::zero(), ..Default::default() };
|
|
let len = 0_usize;
|
|
|
|
// Initial weight from `weights.base_block`
|
|
assert_eq!(System::block_weight().total(), weights.base_block);
|
|
assert_ok!(CheckWeight::<Test>(PhantomData).pre_dispatch(&1, CALL, &free, len));
|
|
assert_eq!(
|
|
System::block_weight().total(),
|
|
weights.get(DispatchClass::Normal).base_extrinsic + weights.base_block
|
|
);
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn normal_and_mandatory_tracked_separately() {
|
|
new_test_ext().execute_with(|| {
|
|
// Max block is 1024
|
|
// Max normal is 768 (75%)
|
|
// Max mandatory is unlimited
|
|
let max_normal =
|
|
DispatchInfo { weight: Weight::from_ref_time(753), ..Default::default() };
|
|
let mandatory = DispatchInfo {
|
|
weight: Weight::from_ref_time(1019),
|
|
class: DispatchClass::Mandatory,
|
|
..Default::default()
|
|
};
|
|
|
|
let len = 0_usize;
|
|
|
|
assert_ok!(CheckWeight::<Test>::do_pre_dispatch(&max_normal, len));
|
|
assert_eq!(System::block_weight().total(), Weight::from_ref_time(768));
|
|
assert_ok!(CheckWeight::<Test>::do_pre_dispatch(&mandatory, len));
|
|
assert_eq!(block_weight_limit(), Weight::from_ref_time(1024).set_proof_size(u64::MAX));
|
|
assert_eq!(System::block_weight().total(), Weight::from_ref_time(1024 + 768));
|
|
assert_eq!(CheckWeight::<Test>::check_extrinsic_weight(&mandatory), Ok(()));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn no_max_total_should_still_be_limited_by_max_block() {
|
|
// given
|
|
let maximum_weight = BlockWeights::builder()
|
|
.base_block(Weight::zero())
|
|
.for_class(DispatchClass::non_mandatory(), |w| {
|
|
w.base_extrinsic = Weight::zero();
|
|
w.max_total = Some(Weight::from_ref_time(20).set_proof_size(u64::MAX));
|
|
})
|
|
.for_class(DispatchClass::Mandatory, |w| {
|
|
w.base_extrinsic = Weight::zero();
|
|
w.reserved = Some(Weight::from_ref_time(5).set_proof_size(u64::MAX));
|
|
w.max_total = None;
|
|
})
|
|
.build_or_panic();
|
|
let all_weight = crate::ConsumedWeight::new(|class| match class {
|
|
DispatchClass::Normal => Weight::from_ref_time(10),
|
|
DispatchClass::Operational => Weight::from_ref_time(10),
|
|
DispatchClass::Mandatory => Weight::zero(),
|
|
});
|
|
assert_eq!(maximum_weight.max_block, all_weight.total().set_proof_size(u64::MAX));
|
|
|
|
// fits into reserved
|
|
let mandatory1 = DispatchInfo {
|
|
weight: Weight::from_ref_time(5),
|
|
class: DispatchClass::Mandatory,
|
|
..Default::default()
|
|
};
|
|
// does not fit into reserved and the block is full.
|
|
let mandatory2 = DispatchInfo {
|
|
weight: Weight::from_ref_time(6),
|
|
class: DispatchClass::Mandatory,
|
|
..Default::default()
|
|
};
|
|
|
|
// when
|
|
assert_ok!(calculate_consumed_weight::<<Test as Config>::RuntimeCall>(
|
|
maximum_weight.clone(),
|
|
all_weight.clone(),
|
|
&mandatory1
|
|
));
|
|
assert_err!(
|
|
calculate_consumed_weight::<<Test as Config>::RuntimeCall>(
|
|
maximum_weight,
|
|
all_weight,
|
|
&mandatory2
|
|
),
|
|
InvalidTransaction::ExhaustsResources
|
|
);
|
|
}
|
|
}
|