Files
pezkuwi-subxt/substrate/frame/lottery/src/lib.rs
T
Robert Habermeier e2960c383e more clear randomness API for BABE (#8180)
* more clear randomness API for BABE

* babe: move randomness utilities to its own file

* node: use babe::RandomnessFromOneEpochAgo in random_seed implementation

* frame-support: annotate randomness trait with block number

* pallet-randomness-collective-flip: fix for new randomness trait

* pallet-society: fix randomness usage

* pallet-lottery: fix randomness usage

* pallet-contracts: fix randomness usage

* pallet-babe: fix randomness usage

we need to track when the current and previous epoch started so that we
know the block number by each existing on-chain was known

* node: fix random_seed

* node-template: fix random_seed

* frame-support: extend docs

* babe: add test for epoch starting block number tracking

* babe: fix epoch randomness docs

* frame: add todos for dealing with randomness api changes

Co-authored-by: André Silva <andrerfosilva@gmail.com>
2021-03-10 16:31:49 +00:00

455 lines
16 KiB
Rust

// This file is part of Substrate.
// Copyright (C) 2021 Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: Apache-2.0
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//! A lottery pallet that uses participation in the network to purchase tickets.
//!
//! With this pallet, you can configure a lottery, which is a pot of money that
//! users contribute to, and that is reallocated to a single user at the end of
//! the lottery period. Just like a normal lottery system, to participate, you
//! need to "buy a ticket", which is used to fund the pot.
//!
//! The unique feature of this lottery system is that tickets can only be
//! purchased by making a "valid call" dispatched through this pallet.
//! By configuring certain calls to be valid for the lottery, you can encourage
//! users to make those calls on your network. An example of how this could be
//! used is to set validator nominations as a valid lottery call. If the lottery
//! is set to repeat every month, then users would be encouraged to re-nominate
//! validators every month. A user can ony purchase one ticket per valid call
//! per lottery.
//!
//! This pallet can be configured to use dynamically set calls or statically set
//! calls. Call validation happens through the `ValidateCall` implementation.
//! This pallet provides one implementation of this using the `CallIndices`
//! storage item. You can also make your own implementation at the runtime level
//! which can contain much more complex logic, such as validation of the
//! parameters, which this pallet alone cannot do.
//!
//! This pallet uses the modulus operator to pick a random winner. It is known
//! that this might introduce a bias if the random number chosen in a range that
//! is not perfectly divisible by the total number of participants. The
//! `MaxGenerateRandom` configuration can help mitigate this by generating new
//! numbers until we hit the limit or we find a "fair" number. This is best
//! effort only.
#![cfg_attr(not(feature = "std"), no_std)]
#[cfg(test)]
mod mock;
#[cfg(test)]
mod tests;
mod benchmarking;
pub mod weights;
use sp_std::prelude::*;
use sp_runtime::{
DispatchError, ModuleId,
traits::{AccountIdConversion, Saturating, Zero},
};
use frame_support::{
Parameter, decl_module, decl_error, decl_event, decl_storage, ensure, RuntimeDebug,
dispatch::{Dispatchable, DispatchResult, GetDispatchInfo},
traits::{
Currency, ReservableCurrency, Get, EnsureOrigin, ExistenceRequirement::KeepAlive, Randomness,
},
};
use frame_support::weights::Weight;
use frame_system::ensure_signed;
use codec::{Encode, Decode};
pub use weights::WeightInfo;
type BalanceOf<T> = <<T as Config>::Currency as Currency<<T as frame_system::Config>::AccountId>>::Balance;
/// The module's config trait.
pub trait Config: frame_system::Config {
/// The Lottery's module id
type ModuleId: Get<ModuleId>;
/// A dispatchable call.
type Call: Parameter + Dispatchable<Origin=Self::Origin> + GetDispatchInfo + From<frame_system::Call<Self>>;
/// The currency trait.
type Currency: ReservableCurrency<Self::AccountId>;
/// Something that provides randomness in the runtime.
type Randomness: Randomness<Self::Hash, Self::BlockNumber>;
/// The overarching event type.
type Event: From<Event<Self>> + Into<<Self as frame_system::Config>::Event>;
/// The manager origin.
type ManagerOrigin: EnsureOrigin<Self::Origin>;
/// The max number of calls available in a single lottery.
type MaxCalls: Get<usize>;
/// Used to determine if a call would be valid for purchasing a ticket.
///
/// Be conscious of the implementation used here. We assume at worst that
/// a vector of `MaxCalls` indices are queried for any call validation.
/// You may need to provide a custom benchmark if this assumption is broken.
type ValidateCall: ValidateCall<Self>;
/// Number of time we should try to generate a random number that has no modulo bias.
/// The larger this number, the more potential computation is used for picking the winner,
/// but also the more likely that the chosen winner is done fairly.
type MaxGenerateRandom: Get<u32>;
/// Weight information for extrinsics in this pallet.
type WeightInfo: WeightInfo;
}
// Any runtime call can be encoded into two bytes which represent the pallet and call index.
// We use this to uniquely match someone's incoming call with the calls configured for the lottery.
type CallIndex = (u8, u8);
#[derive(Encode, Decode, Default, Eq, PartialEq, RuntimeDebug)]
pub struct LotteryConfig<BlockNumber, Balance> {
/// Price per entry.
price: Balance,
/// Starting block of the lottery.
start: BlockNumber,
/// Length of the lottery (start + length = end).
length: BlockNumber,
/// Delay for choosing the winner of the lottery. (start + length + delay = payout).
/// Randomness in the "payout" block will be used to determine the winner.
delay: BlockNumber,
/// Whether this lottery will repeat after it completes.
repeat: bool,
}
pub trait ValidateCall<T: Config> {
fn validate_call(call: &<T as Config>::Call) -> bool;
}
impl<T: Config> ValidateCall<T> for () {
fn validate_call(_: &<T as Config>::Call) -> bool { false }
}
impl<T: Config> ValidateCall<T> for Module<T> {
fn validate_call(call: &<T as Config>::Call) -> bool {
let valid_calls = CallIndices::get();
let call_index = match Self::call_to_index(&call) {
Ok(call_index) => call_index,
Err(_) => return false,
};
valid_calls.iter().any(|c| call_index == *c)
}
}
decl_storage! {
trait Store for Module<T: Config> as Lottery {
LotteryIndex: u32;
/// The configuration for the current lottery.
Lottery: Option<LotteryConfig<T::BlockNumber, BalanceOf<T>>>;
/// Users who have purchased a ticket. (Lottery Index, Tickets Purchased)
Participants: map hasher(twox_64_concat) T::AccountId => (u32, Vec<CallIndex>);
/// Total number of tickets sold.
TicketsCount: u32;
/// Each ticket's owner.
///
/// May have residual storage from previous lotteries. Use `TicketsCount` to see which ones
/// are actually valid ticket mappings.
Tickets: map hasher(twox_64_concat) u32 => Option<T::AccountId>;
/// The calls stored in this pallet to be used in an active lottery if configured
/// by `Config::ValidateCall`.
CallIndices: Vec<CallIndex>;
}
}
decl_event!(
pub enum Event<T> where
<T as frame_system::Config>::AccountId,
Balance = BalanceOf<T>,
{
/// A lottery has been started!
LotteryStarted,
/// A new set of calls have been set!
CallsUpdated,
/// A winner has been chosen!
Winner(AccountId, Balance),
/// A ticket has been bought!
TicketBought(AccountId, CallIndex),
}
);
decl_error! {
pub enum Error for Module<T: Config> {
/// An overflow has occurred.
Overflow,
/// A lottery has not been configured.
NotConfigured,
/// A lottery is already in progress.
InProgress,
/// A lottery has already ended.
AlreadyEnded,
/// The call is not valid for an open lottery.
InvalidCall,
/// You are already participating in the lottery with this call.
AlreadyParticipating,
/// Too many calls for a single lottery.
TooManyCalls,
/// Failed to encode calls
EncodingFailed,
}
}
decl_module! {
pub struct Module<T: Config> for enum Call where origin: T::Origin, system = frame_system {
const ModuleId: ModuleId = T::ModuleId::get();
const MaxCalls: u32 = T::MaxCalls::get() as u32;
fn deposit_event() = default;
/// Buy a ticket to enter the lottery.
///
/// This extrinsic acts as a passthrough function for `call`. In all
/// situations where `call` alone would succeed, this extrinsic should
/// succeed.
///
/// If `call` is successful, then we will attempt to purchase a ticket,
/// which may fail silently. To detect success of a ticket purchase, you
/// should listen for the `TicketBought` event.
///
/// This extrinsic must be called by a signed origin.
#[weight =
T::WeightInfo::buy_ticket()
.saturating_add(call.get_dispatch_info().weight)
]
fn buy_ticket(origin, call: Box<<T as Config>::Call>) {
let caller = ensure_signed(origin.clone())?;
call.clone().dispatch(origin).map_err(|e| e.error)?;
let _ = Self::do_buy_ticket(&caller, &call);
}
/// Set calls in storage which can be used to purchase a lottery ticket.
///
/// This function only matters if you use the `ValidateCall` implementation
/// provided by this pallet, which uses storage to determine the valid calls.
///
/// This extrinsic must be called by the Manager origin.
#[weight = T::WeightInfo::set_calls(calls.len() as u32)]
fn set_calls(origin, calls: Vec<<T as Config>::Call>) {
T::ManagerOrigin::ensure_origin(origin)?;
ensure!(calls.len() <= T::MaxCalls::get(), Error::<T>::TooManyCalls);
if calls.is_empty() {
CallIndices::kill();
} else {
let indices = Self::calls_to_indices(&calls)?;
CallIndices::put(indices);
}
Self::deposit_event(RawEvent::CallsUpdated);
}
/// Start a lottery using the provided configuration.
///
/// This extrinsic must be called by the `ManagerOrigin`.
///
/// Parameters:
///
/// * `price`: The cost of a single ticket.
/// * `length`: How long the lottery should run for starting at the current block.
/// * `delay`: How long after the lottery end we should wait before picking a winner.
/// * `repeat`: If the lottery should repeat when completed.
#[weight = T::WeightInfo::start_lottery()]
fn start_lottery(origin,
price: BalanceOf<T>,
length: T::BlockNumber,
delay: T::BlockNumber,
repeat: bool,
) {
T::ManagerOrigin::ensure_origin(origin)?;
Lottery::<T>::try_mutate(|lottery| -> DispatchResult {
ensure!(lottery.is_none(), Error::<T>::InProgress);
let index = LotteryIndex::get();
let new_index = index.checked_add(1).ok_or(Error::<T>::Overflow)?;
let start = frame_system::Module::<T>::block_number();
// Use new_index to more easily track everything with the current state.
*lottery = Some(LotteryConfig {
price,
start,
length,
delay,
repeat,
});
LotteryIndex::put(new_index);
Ok(())
})?;
// Make sure pot exists.
let lottery_account = Self::account_id();
if T::Currency::total_balance(&lottery_account).is_zero() {
T::Currency::deposit_creating(&lottery_account, T::Currency::minimum_balance());
}
Self::deposit_event(RawEvent::LotteryStarted);
}
/// If a lottery is repeating, you can use this to stop the repeat.
/// The lottery will continue to run to completion.
///
/// This extrinsic must be called by the `ManagerOrigin`.
#[weight = T::WeightInfo::stop_repeat()]
fn stop_repeat(origin) {
T::ManagerOrigin::ensure_origin(origin)?;
Lottery::<T>::mutate(|mut lottery| {
if let Some(config) = &mut lottery {
config.repeat = false
}
});
}
fn on_initialize(n: T::BlockNumber) -> Weight {
Lottery::<T>::mutate(|mut lottery| -> Weight {
if let Some(config) = &mut lottery {
let payout_block = config.start
.saturating_add(config.length)
.saturating_add(config.delay);
if payout_block <= n {
let (lottery_account, lottery_balance) = Self::pot();
let ticket_count = TicketsCount::get();
let winning_number = Self::choose_winner(ticket_count);
let winner = Tickets::<T>::get(winning_number).unwrap_or(lottery_account);
// Not much we can do if this fails...
let _ = T::Currency::transfer(&Self::account_id(), &winner, lottery_balance, KeepAlive);
Self::deposit_event(RawEvent::Winner(winner, lottery_balance));
TicketsCount::kill();
if config.repeat {
// If lottery should repeat, increment index by 1.
LotteryIndex::mutate(|index| *index = index.saturating_add(1));
// Set a new start with the current block.
config.start = n;
return T::WeightInfo::on_initialize_repeat()
} else {
// Else, kill the lottery storage.
*lottery = None;
return T::WeightInfo::on_initialize_end()
}
// We choose not need to kill Participants and Tickets to avoid a large number
// of writes at one time. Instead, data persists between lotteries, but is not used
// if it is not relevant.
}
}
return T::DbWeight::get().reads(1)
})
}
}
}
impl<T: Config> Module<T> {
/// The account ID of the lottery pot.
///
/// This actually does computation. If you need to keep using it, then make sure you cache the
/// value and only call this once.
pub fn account_id() -> T::AccountId {
T::ModuleId::get().into_account()
}
/// Return the pot account and amount of money in the pot.
// The existential deposit is not part of the pot so lottery account never gets deleted.
fn pot() -> (T::AccountId, BalanceOf<T>) {
let account_id = Self::account_id();
let balance = T::Currency::free_balance(&account_id)
.saturating_sub(T::Currency::minimum_balance());
(account_id, balance)
}
// Converts a vector of calls into a vector of call indices.
fn calls_to_indices(calls: &[<T as Config>::Call]) -> Result<Vec<CallIndex>, DispatchError> {
let mut indices = Vec::with_capacity(calls.len());
for c in calls.iter() {
let index = Self::call_to_index(c)?;
indices.push(index)
}
Ok(indices)
}
// Convert a call to it's call index by encoding the call and taking the first two bytes.
fn call_to_index(call: &<T as Config>::Call) -> Result<CallIndex, DispatchError> {
let encoded_call = call.encode();
if encoded_call.len() < 2 { Err(Error::<T>::EncodingFailed)? }
return Ok((encoded_call[0], encoded_call[1]))
}
// Logic for buying a ticket.
fn do_buy_ticket(caller: &T::AccountId, call: &<T as Config>::Call) -> DispatchResult {
// Check the call is valid lottery
let config = Lottery::<T>::get().ok_or(Error::<T>::NotConfigured)?;
let block_number = frame_system::Module::<T>::block_number();
ensure!(block_number < config.start.saturating_add(config.length), Error::<T>::AlreadyEnded);
ensure!(T::ValidateCall::validate_call(call), Error::<T>::InvalidCall);
let call_index = Self::call_to_index(call)?;
let ticket_count = TicketsCount::get();
let new_ticket_count = ticket_count.checked_add(1).ok_or(Error::<T>::Overflow)?;
// Try to update the participant status
Participants::<T>::try_mutate(&caller, |(lottery_index, participating_calls)| -> DispatchResult {
let index = LotteryIndex::get();
// If lottery index doesn't match, then reset participating calls and index.
if *lottery_index != index {
*participating_calls = Vec::new();
*lottery_index = index;
} else {
// Check that user is not already participating under this call.
ensure!(!participating_calls.iter().any(|c| call_index == *c), Error::<T>::AlreadyParticipating);
}
// Check user has enough funds and send it to the Lottery account.
T::Currency::transfer(caller, &Self::account_id(), config.price, KeepAlive)?;
// Create a new ticket.
TicketsCount::put(new_ticket_count);
Tickets::<T>::insert(ticket_count, caller.clone());
participating_calls.push(call_index);
Ok(())
})?;
Self::deposit_event(RawEvent::TicketBought(caller.clone(), call_index));
Ok(())
}
// Randomly choose a winner from among the total number of participants.
fn choose_winner(total: u32) -> u32 {
let mut random_number = Self::generate_random_number(0);
// Best effort attempt to remove bias from modulus operator.
for i in 1 .. T::MaxGenerateRandom::get() {
if random_number < u32::MAX - u32::MAX % total {
break;
}
random_number = Self::generate_random_number(i);
}
random_number % total
}
// Generate a random number from a given seed.
// Note that there is potential bias introduced by using modulus operator.
// You should call this function with different seed values until the random
// number lies within `u32::MAX - u32::MAX % n`.
// TODO: deal with randomness freshness
// https://github.com/paritytech/substrate/issues/8311
fn generate_random_number(seed: u32) -> u32 {
let (random_seed, _) = T::Randomness::random(&(T::ModuleId::get(), seed).encode());
let random_number = <u32>::decode(&mut random_seed.as_ref())
.expect("secure hashes should always be bigger than u32; qed");
random_number
}
}