mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-24 23:01:08 +00:00
ca382f3203
## Xcm changes: - Fix `pallet_xcm::execute`, move the logic into The `ExecuteController` so it can be shared with anything that implement that trait. - Make `ExecuteController::execute` retursn `DispatchErrorWithPostInfo` instead of `DispatchError`, so that we don't charge the full `max_weight` provided if the execution is incomplete (useful for force_batch or contracts calls) - Fix docstring for `pallet_xcm::execute`, to reflect the changes from #2405 - Update the signature for `ExecuteController::execute`, we don't need to return the `Outcome` anymore since we only care about `Outcome::Complete` ## Contracts changes: - Update host fn `xcm_exexute`, we don't need to write the `Outcome` to the sandbox memory anymore. This was also not charged as well before so it if fixes this too. - One of the issue was that the dry_run of a contract that call `xcm_execute` would exhaust the `gas_limit`. This is because `XcmExecuteController::execute` takes a `max_weight` argument, and since we don't want the user to specify it manually we were passing everything left by pre-charghing `ctx.ext.gas_meter().gas_left()` - To fix it I added a `fn influence_lowest_limit` on the `Token` trait and make it return false for `RuntimeCost::XcmExecute`. - Got rid of the `RuntimeToken` indirection, we can just use `RuntimeCost` directly. --------- Co-authored-by: command-bot <>
279 lines
8.0 KiB
Rust
279 lines
8.0 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use crate::{
|
|
parachain::{self, Runtime},
|
|
parachain_account_sovereign_account_id,
|
|
primitives::{AccountId, CENTS},
|
|
relay_chain, MockNet, ParaA, ParachainBalances, Relay, ALICE, BOB, INITIAL_BALANCE,
|
|
};
|
|
use codec::{Decode, Encode};
|
|
use frame_support::{
|
|
assert_err,
|
|
pallet_prelude::Weight,
|
|
traits::{fungibles::Mutate, Currency},
|
|
};
|
|
use pallet_balances::{BalanceLock, Reasons};
|
|
use pallet_contracts::{Code, CollectEvents, DebugInfo, Determinism};
|
|
use pallet_contracts_fixtures::compile_module;
|
|
use pallet_contracts_uapi::ReturnErrorCode;
|
|
use xcm::{v4::prelude::*, VersionedLocation, VersionedXcm};
|
|
use xcm_simulator::TestExt;
|
|
|
|
type ParachainContracts = pallet_contracts::Pallet<parachain::Runtime>;
|
|
|
|
macro_rules! assert_return_code {
|
|
( $x:expr , $y:expr $(,)? ) => {{
|
|
assert_eq!(u32::from_le_bytes($x.data[..].try_into().unwrap()), $y as u32);
|
|
}};
|
|
}
|
|
|
|
/// Instantiate the tests contract, and fund it with some balance and assets.
|
|
fn instantiate_test_contract(name: &str) -> AccountId {
|
|
let (wasm, _) = compile_module::<Runtime>(name).unwrap();
|
|
|
|
// Instantiate contract.
|
|
let contract_addr = ParaA::execute_with(|| {
|
|
ParachainContracts::bare_instantiate(
|
|
ALICE,
|
|
0,
|
|
Weight::MAX,
|
|
None,
|
|
Code::Upload(wasm),
|
|
vec![],
|
|
vec![],
|
|
DebugInfo::UnsafeDebug,
|
|
CollectEvents::Skip,
|
|
)
|
|
.result
|
|
.unwrap()
|
|
.account_id
|
|
});
|
|
|
|
// Funds contract account with some balance and assets.
|
|
ParaA::execute_with(|| {
|
|
parachain::Balances::make_free_balance_be(&contract_addr, INITIAL_BALANCE);
|
|
parachain::Assets::mint_into(0u32.into(), &contract_addr, INITIAL_BALANCE).unwrap();
|
|
});
|
|
Relay::execute_with(|| {
|
|
let sovereign_account = parachain_account_sovereign_account_id(1u32, contract_addr.clone());
|
|
relay_chain::Balances::make_free_balance_be(&sovereign_account, INITIAL_BALANCE);
|
|
});
|
|
|
|
contract_addr
|
|
}
|
|
|
|
#[test]
|
|
fn test_xcm_execute() {
|
|
MockNet::reset();
|
|
|
|
let contract_addr = instantiate_test_contract("xcm_execute");
|
|
|
|
// Execute XCM instructions through the contract.
|
|
ParaA::execute_with(|| {
|
|
let amount: u128 = 10 * CENTS;
|
|
|
|
// The XCM used to transfer funds to Bob.
|
|
let message: Xcm<()> = Xcm(vec![
|
|
WithdrawAsset(vec![(Here, amount).into()].into()),
|
|
DepositAsset {
|
|
assets: All.into(),
|
|
beneficiary: AccountId32 { network: None, id: BOB.clone().into() }.into(),
|
|
},
|
|
]);
|
|
|
|
let result = ParachainContracts::bare_call(
|
|
ALICE,
|
|
contract_addr.clone(),
|
|
0,
|
|
Weight::MAX,
|
|
None,
|
|
VersionedXcm::V4(message).encode(),
|
|
DebugInfo::UnsafeDebug,
|
|
CollectEvents::UnsafeCollect,
|
|
Determinism::Enforced,
|
|
);
|
|
|
|
assert_eq!(result.gas_consumed, result.gas_required);
|
|
assert_return_code!(&result.result.unwrap(), ReturnErrorCode::Success);
|
|
|
|
// Check if the funds are subtracted from the account of Alice and added to the account of
|
|
// Bob.
|
|
let initial = INITIAL_BALANCE;
|
|
assert_eq!(ParachainBalances::free_balance(BOB), initial + amount);
|
|
assert_eq!(ParachainBalances::free_balance(&contract_addr), initial - amount);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn test_xcm_execute_incomplete() {
|
|
MockNet::reset();
|
|
|
|
let contract_addr = instantiate_test_contract("xcm_execute");
|
|
let amount = 10 * CENTS;
|
|
|
|
// Execute XCM instructions through the contract.
|
|
ParaA::execute_with(|| {
|
|
// The XCM used to transfer funds to Bob.
|
|
let message: Xcm<()> = Xcm(vec![
|
|
WithdrawAsset(vec![(Here, amount).into()].into()),
|
|
// This will fail as the contract does not have enough balance to complete both
|
|
// withdrawals.
|
|
WithdrawAsset(vec![(Here, INITIAL_BALANCE).into()].into()),
|
|
DepositAsset {
|
|
assets: All.into(),
|
|
beneficiary: AccountId32 { network: None, id: BOB.clone().into() }.into(),
|
|
},
|
|
]);
|
|
|
|
let result = ParachainContracts::bare_call(
|
|
ALICE,
|
|
contract_addr.clone(),
|
|
0,
|
|
Weight::MAX,
|
|
None,
|
|
VersionedXcm::V4(message).encode(),
|
|
DebugInfo::UnsafeDebug,
|
|
CollectEvents::UnsafeCollect,
|
|
Determinism::Enforced,
|
|
);
|
|
|
|
assert_eq!(result.gas_consumed, result.gas_required);
|
|
assert_return_code!(&result.result.unwrap(), ReturnErrorCode::XcmExecutionFailed);
|
|
|
|
assert_eq!(ParachainBalances::free_balance(BOB), INITIAL_BALANCE);
|
|
assert_eq!(ParachainBalances::free_balance(&contract_addr), INITIAL_BALANCE - amount);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn test_xcm_execute_filtered_call() {
|
|
MockNet::reset();
|
|
|
|
let contract_addr = instantiate_test_contract("xcm_execute");
|
|
|
|
ParaA::execute_with(|| {
|
|
// `remark` should be rejected, as it is not allowed by our CallFilter.
|
|
let call = parachain::RuntimeCall::System(frame_system::Call::remark { remark: vec![] });
|
|
let message: Xcm<parachain::RuntimeCall> = Xcm(vec![Transact {
|
|
origin_kind: OriginKind::Native,
|
|
require_weight_at_most: Weight::MAX,
|
|
call: call.encode().into(),
|
|
}]);
|
|
|
|
let result = ParachainContracts::bare_call(
|
|
ALICE,
|
|
contract_addr.clone(),
|
|
0,
|
|
Weight::MAX,
|
|
None,
|
|
VersionedXcm::V4(message).encode(),
|
|
DebugInfo::UnsafeDebug,
|
|
CollectEvents::UnsafeCollect,
|
|
Determinism::Enforced,
|
|
);
|
|
|
|
assert_err!(result.result, frame_system::Error::<parachain::Runtime>::CallFiltered);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn test_xcm_execute_reentrant_call() {
|
|
MockNet::reset();
|
|
|
|
let contract_addr = instantiate_test_contract("xcm_execute");
|
|
|
|
ParaA::execute_with(|| {
|
|
let transact_call = parachain::RuntimeCall::Contracts(pallet_contracts::Call::call {
|
|
dest: contract_addr.clone(),
|
|
gas_limit: 1_000_000.into(),
|
|
storage_deposit_limit: None,
|
|
data: vec![],
|
|
value: 0u128,
|
|
});
|
|
|
|
// The XCM used to transfer funds to Bob.
|
|
let message: Xcm<parachain::RuntimeCall> = Xcm(vec![
|
|
Transact {
|
|
origin_kind: OriginKind::Native,
|
|
require_weight_at_most: 1_000_000_000.into(),
|
|
call: transact_call.encode().into(),
|
|
},
|
|
ExpectTransactStatus(MaybeErrorCode::Success),
|
|
]);
|
|
|
|
let result = ParachainContracts::bare_call(
|
|
ALICE,
|
|
contract_addr.clone(),
|
|
0,
|
|
Weight::MAX,
|
|
None,
|
|
VersionedXcm::V4(message).encode(),
|
|
DebugInfo::UnsafeDebug,
|
|
CollectEvents::UnsafeCollect,
|
|
Determinism::Enforced,
|
|
);
|
|
|
|
assert_return_code!(&result.result.unwrap(), ReturnErrorCode::XcmExecutionFailed);
|
|
|
|
// Funds should not change hands as the XCM transact failed.
|
|
assert_eq!(ParachainBalances::free_balance(BOB), INITIAL_BALANCE);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn test_xcm_send() {
|
|
MockNet::reset();
|
|
let contract_addr = instantiate_test_contract("xcm_send");
|
|
let fee = parachain::estimate_message_fee(4); // Accounts for the `DescendOrigin` instruction added by `send_xcm`
|
|
|
|
// Send XCM instructions through the contract, to lock some funds on the relay chain.
|
|
ParaA::execute_with(|| {
|
|
let dest = Location::from(Parent);
|
|
let dest = VersionedLocation::V4(dest);
|
|
|
|
let message: Xcm<()> = Xcm(vec![
|
|
WithdrawAsset((Here, fee).into()),
|
|
BuyExecution { fees: (Here, fee).into(), weight_limit: WeightLimit::Unlimited },
|
|
LockAsset { asset: (Here, 5 * CENTS).into(), unlocker: (Parachain(1)).into() },
|
|
]);
|
|
let message = VersionedXcm::V4(message);
|
|
let exec = ParachainContracts::bare_call(
|
|
ALICE,
|
|
contract_addr.clone(),
|
|
0,
|
|
Weight::MAX,
|
|
None,
|
|
(dest, message).encode(),
|
|
DebugInfo::UnsafeDebug,
|
|
CollectEvents::UnsafeCollect,
|
|
Determinism::Enforced,
|
|
);
|
|
|
|
let mut data = &exec.result.unwrap().data[..];
|
|
XcmHash::decode(&mut data).expect("Failed to decode xcm_send message_id");
|
|
});
|
|
|
|
Relay::execute_with(|| {
|
|
// Check if the funds are locked on the relay chain.
|
|
assert_eq!(
|
|
relay_chain::Balances::locks(¶chain_account_sovereign_account_id(1, contract_addr)),
|
|
vec![BalanceLock { id: *b"py/xcmlk", amount: 5 * CENTS, reasons: Reasons::All }]
|
|
);
|
|
});
|
|
}
|