mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-12 13:31:10 +00:00
e6b8a69656
Closes #4467 Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
667 lines
22 KiB
Rust
667 lines
22 KiB
Rust
// Copyright 2017-2019 Parity Technologies (UK) Ltd.
|
|
// This file is part of Substrate.
|
|
|
|
// Substrate is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Substrate is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Substrate. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! # Treasury Module
|
|
//!
|
|
//! The Treasury module provides a "pot" of funds that can be managed by stakeholders in the
|
|
//! system and a structure for making spending proposals from this pot.
|
|
//!
|
|
//! - [`treasury::Trait`](./trait.Trait.html)
|
|
//! - [`Call`](./enum.Call.html)
|
|
//!
|
|
//! ## Overview
|
|
//!
|
|
//! The Treasury Module itself provides the pot to store funds, and a means for stakeholders to
|
|
//! propose, approve, and deny expenditures. The chain will need to provide a method (e.g.
|
|
//! inflation, fees) for collecting funds.
|
|
//!
|
|
//! By way of example, the Council could vote to fund the Treasury with a portion of the block
|
|
//! reward and use the funds to pay developers.
|
|
//!
|
|
//! ### Terminology
|
|
//!
|
|
//! - **Proposal:** A suggestion to allocate funds from the pot to a beneficiary.
|
|
//! - **Beneficiary:** An account who will receive the funds from a proposal iff
|
|
//! the proposal is approved.
|
|
//! - **Deposit:** Funds that a proposer must lock when making a proposal. The
|
|
//! deposit will be returned or slashed if the proposal is approved or rejected
|
|
//! respectively.
|
|
//! - **Pot:** Unspent funds accumulated by the treasury module.
|
|
//!
|
|
//! ## Interface
|
|
//!
|
|
//! ### Dispatchable Functions
|
|
//!
|
|
//! - `propose_spend` - Make a spending proposal and stake the required deposit.
|
|
//! - `set_pot` - Set the spendable balance of funds.
|
|
//! - `configure` - Configure the module's proposal requirements.
|
|
//! - `reject_proposal` - Reject a proposal, slashing the deposit.
|
|
//! - `approve_proposal` - Accept the proposal, returning the deposit.
|
|
//!
|
|
//! ## GenesisConfig
|
|
//!
|
|
//! The Treasury module depends on the [`GenesisConfig`](./struct.GenesisConfig.html).
|
|
|
|
#![cfg_attr(not(feature = "std"), no_std)]
|
|
|
|
#[cfg(feature = "std")]
|
|
use serde::{Serialize, Deserialize};
|
|
use sp_std::prelude::*;
|
|
use frame_support::{decl_module, decl_storage, decl_event, ensure, print, decl_error};
|
|
use frame_support::traits::{
|
|
Currency, ExistenceRequirement, Get, Imbalance, OnUnbalanced,
|
|
ReservableCurrency, WithdrawReason
|
|
};
|
|
use sp_runtime::{Permill, ModuleId};
|
|
use sp_runtime::traits::{Zero, EnsureOrigin, StaticLookup, AccountIdConversion, Saturating};
|
|
use frame_support::weights::SimpleDispatchInfo;
|
|
use codec::{Encode, Decode};
|
|
use frame_system::{self as system, ensure_signed};
|
|
|
|
type BalanceOf<T> = <<T as Trait>::Currency as Currency<<T as frame_system::Trait>::AccountId>>::Balance;
|
|
type PositiveImbalanceOf<T> = <<T as Trait>::Currency as Currency<<T as frame_system::Trait>::AccountId>>::PositiveImbalance;
|
|
type NegativeImbalanceOf<T> = <<T as Trait>::Currency as Currency<<T as frame_system::Trait>::AccountId>>::NegativeImbalance;
|
|
|
|
const MODULE_ID: ModuleId = ModuleId(*b"py/trsry");
|
|
|
|
pub trait Trait: frame_system::Trait {
|
|
/// The staking balance.
|
|
type Currency: Currency<Self::AccountId> + ReservableCurrency<Self::AccountId>;
|
|
|
|
/// Origin from which approvals must come.
|
|
type ApproveOrigin: EnsureOrigin<Self::Origin>;
|
|
|
|
/// Origin from which rejections must come.
|
|
type RejectOrigin: EnsureOrigin<Self::Origin>;
|
|
|
|
/// The overarching event type.
|
|
type Event: From<Event<Self>> + Into<<Self as frame_system::Trait>::Event>;
|
|
|
|
/// Handler for the unbalanced decrease when slashing for a rejected proposal.
|
|
type ProposalRejection: OnUnbalanced<NegativeImbalanceOf<Self>>;
|
|
|
|
/// Fraction of a proposal's value that should be bonded in order to place the proposal.
|
|
/// An accepted proposal gets these back. A rejected proposal does not.
|
|
type ProposalBond: Get<Permill>;
|
|
|
|
/// Minimum amount of funds that should be placed in a deposit for making a proposal.
|
|
type ProposalBondMinimum: Get<BalanceOf<Self>>;
|
|
|
|
/// Period between successive spends.
|
|
type SpendPeriod: Get<Self::BlockNumber>;
|
|
|
|
/// Percentage of spare funds (if any) that are burnt per spend period.
|
|
type Burn: Get<Permill>;
|
|
}
|
|
|
|
type ProposalIndex = u32;
|
|
|
|
decl_module! {
|
|
pub struct Module<T: Trait> for enum Call where origin: T::Origin {
|
|
/// Fraction of a proposal's value that should be bonded in order to place the proposal.
|
|
/// An accepted proposal gets these back. A rejected proposal does not.
|
|
const ProposalBond: Permill = T::ProposalBond::get();
|
|
|
|
/// Minimum amount of funds that should be placed in a deposit for making a proposal.
|
|
const ProposalBondMinimum: BalanceOf<T> = T::ProposalBondMinimum::get();
|
|
|
|
/// Period between successive spends.
|
|
const SpendPeriod: T::BlockNumber = T::SpendPeriod::get();
|
|
|
|
/// Percentage of spare funds (if any) that are burnt per spend period.
|
|
const Burn: Permill = T::Burn::get();
|
|
|
|
type Error = Error<T>;
|
|
|
|
fn deposit_event() = default;
|
|
|
|
/// Put forward a suggestion for spending. A deposit proportional to the value
|
|
/// is reserved and slashed if the proposal is rejected. It is returned once the
|
|
/// proposal is awarded.
|
|
///
|
|
/// # <weight>
|
|
/// - O(1).
|
|
/// - Limited storage reads.
|
|
/// - One DB change, one extra DB entry.
|
|
/// # </weight>
|
|
#[weight = SimpleDispatchInfo::FixedNormal(500_000)]
|
|
fn propose_spend(
|
|
origin,
|
|
#[compact] value: BalanceOf<T>,
|
|
beneficiary: <T::Lookup as StaticLookup>::Source
|
|
) {
|
|
let proposer = ensure_signed(origin)?;
|
|
let beneficiary = T::Lookup::lookup(beneficiary)?;
|
|
|
|
let bond = Self::calculate_bond(value);
|
|
T::Currency::reserve(&proposer, bond)
|
|
.map_err(|_| Error::<T>::InsufficientProposersBalance)?;
|
|
|
|
let c = Self::proposal_count();
|
|
ProposalCount::put(c + 1);
|
|
<Proposals<T>>::insert(c, Proposal { proposer, value, beneficiary, bond });
|
|
|
|
Self::deposit_event(RawEvent::Proposed(c));
|
|
}
|
|
|
|
/// Reject a proposed spend. The original deposit will be slashed.
|
|
///
|
|
/// # <weight>
|
|
/// - O(1).
|
|
/// - Limited storage reads.
|
|
/// - One DB clear.
|
|
/// # </weight>
|
|
#[weight = SimpleDispatchInfo::FixedOperational(100_000)]
|
|
fn reject_proposal(origin, #[compact] proposal_id: ProposalIndex) {
|
|
T::RejectOrigin::ensure_origin(origin)?;
|
|
let proposal = <Proposals<T>>::take(&proposal_id).ok_or(Error::<T>::InvalidProposalIndex)?;
|
|
|
|
let value = proposal.bond;
|
|
let imbalance = T::Currency::slash_reserved(&proposal.proposer, value).0;
|
|
T::ProposalRejection::on_unbalanced(imbalance);
|
|
|
|
Self::deposit_event(Event::<T>::Rejected(proposal_id, value));
|
|
}
|
|
|
|
/// Approve a proposal. At a later time, the proposal will be allocated to the beneficiary
|
|
/// and the original deposit will be returned.
|
|
///
|
|
/// # <weight>
|
|
/// - O(1).
|
|
/// - Limited storage reads.
|
|
/// - One DB change.
|
|
/// # </weight>
|
|
#[weight = SimpleDispatchInfo::FixedOperational(100_000)]
|
|
fn approve_proposal(origin, #[compact] proposal_id: ProposalIndex) {
|
|
T::ApproveOrigin::ensure_origin(origin)?;
|
|
|
|
ensure!(<Proposals<T>>::exists(proposal_id), Error::<T>::InvalidProposalIndex);
|
|
|
|
Approvals::mutate(|v| v.push(proposal_id));
|
|
}
|
|
|
|
fn on_finalize(n: T::BlockNumber) {
|
|
// Check to see if we should spend some funds!
|
|
if (n % T::SpendPeriod::get()).is_zero() {
|
|
Self::spend_funds();
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/// A spending proposal.
|
|
#[cfg_attr(feature = "std", derive(Serialize, Deserialize))]
|
|
#[derive(Encode, Decode, Clone, PartialEq, Eq, sp_runtime::RuntimeDebug)]
|
|
pub struct Proposal<AccountId, Balance> {
|
|
proposer: AccountId,
|
|
value: Balance,
|
|
beneficiary: AccountId,
|
|
bond: Balance,
|
|
}
|
|
|
|
decl_storage! {
|
|
trait Store for Module<T: Trait> as Treasury {
|
|
/// Number of proposals that have been made.
|
|
ProposalCount get(fn proposal_count): ProposalIndex;
|
|
|
|
/// Proposals that have been made.
|
|
Proposals get(fn proposals): map ProposalIndex => Option<Proposal<T::AccountId, BalanceOf<T>>>;
|
|
|
|
/// Proposal indices that have been approved but not yet awarded.
|
|
Approvals get(fn approvals): Vec<ProposalIndex>;
|
|
}
|
|
add_extra_genesis {
|
|
build(|_config| {
|
|
// Create Treasury account
|
|
let _ = T::Currency::make_free_balance_be(
|
|
&<Module<T>>::account_id(),
|
|
T::Currency::minimum_balance(),
|
|
);
|
|
});
|
|
}
|
|
}
|
|
|
|
decl_event!(
|
|
pub enum Event<T>
|
|
where
|
|
Balance = BalanceOf<T>,
|
|
<T as frame_system::Trait>::AccountId
|
|
{
|
|
/// New proposal.
|
|
Proposed(ProposalIndex),
|
|
/// We have ended a spend period and will now allocate funds.
|
|
Spending(Balance),
|
|
/// Some funds have been allocated.
|
|
Awarded(ProposalIndex, Balance, AccountId),
|
|
/// A proposal was rejected; funds were slashed.
|
|
Rejected(ProposalIndex, Balance),
|
|
/// Some of our funds have been burnt.
|
|
Burnt(Balance),
|
|
/// Spending has finished; this is the amount that rolls over until next spend.
|
|
Rollover(Balance),
|
|
/// Some funds have been deposited.
|
|
Deposit(Balance),
|
|
}
|
|
);
|
|
|
|
decl_error! {
|
|
/// Error for the treasury module.
|
|
pub enum Error for Module<T: Trait> {
|
|
/// Proposer's balance is too low.
|
|
InsufficientProposersBalance,
|
|
/// No proposal at that index.
|
|
InvalidProposalIndex,
|
|
}
|
|
}
|
|
|
|
impl<T: Trait> Module<T> {
|
|
// Add public immutables and private mutables.
|
|
|
|
/// The account ID of the treasury pot.
|
|
///
|
|
/// This actually does computation. If you need to keep using it, then make sure you cache the
|
|
/// value and only call this once.
|
|
pub fn account_id() -> T::AccountId {
|
|
MODULE_ID.into_account()
|
|
}
|
|
|
|
/// The needed bond for a proposal whose spend is `value`.
|
|
fn calculate_bond(value: BalanceOf<T>) -> BalanceOf<T> {
|
|
T::ProposalBondMinimum::get().max(T::ProposalBond::get() * value)
|
|
}
|
|
|
|
// Spend some money!
|
|
fn spend_funds() {
|
|
let mut budget_remaining = Self::pot();
|
|
Self::deposit_event(RawEvent::Spending(budget_remaining));
|
|
|
|
let mut missed_any = false;
|
|
let mut imbalance = <PositiveImbalanceOf<T>>::zero();
|
|
Approvals::mutate(|v| {
|
|
v.retain(|&index| {
|
|
// Should always be true, but shouldn't panic if false or we're screwed.
|
|
if let Some(p) = Self::proposals(index) {
|
|
if p.value <= budget_remaining {
|
|
budget_remaining -= p.value;
|
|
<Proposals<T>>::remove(index);
|
|
|
|
// return their deposit.
|
|
let _ = T::Currency::unreserve(&p.proposer, p.bond);
|
|
|
|
// provide the allocation.
|
|
imbalance.subsume(T::Currency::deposit_creating(&p.beneficiary, p.value));
|
|
|
|
Self::deposit_event(RawEvent::Awarded(index, p.value, p.beneficiary));
|
|
false
|
|
} else {
|
|
missed_any = true;
|
|
true
|
|
}
|
|
} else {
|
|
false
|
|
}
|
|
});
|
|
});
|
|
|
|
if !missed_any {
|
|
// burn some proportion of the remaining budget if we run a surplus.
|
|
let burn = (T::Burn::get() * budget_remaining).min(budget_remaining);
|
|
budget_remaining -= burn;
|
|
imbalance.subsume(T::Currency::burn(burn));
|
|
Self::deposit_event(RawEvent::Burnt(burn))
|
|
}
|
|
|
|
// Must never be an error, but better to be safe.
|
|
// proof: budget_remaining is account free balance minus ED;
|
|
// Thus we can't spend more than account free balance minus ED;
|
|
// Thus account is kept alive; qed;
|
|
if let Err(problem) = T::Currency::settle(
|
|
&Self::account_id(),
|
|
imbalance,
|
|
WithdrawReason::Transfer.into(),
|
|
ExistenceRequirement::KeepAlive
|
|
) {
|
|
print("Inconsistent state - couldn't settle imbalance for funds spent by treasury");
|
|
// Nothing else to do here.
|
|
drop(problem);
|
|
}
|
|
|
|
Self::deposit_event(RawEvent::Rollover(budget_remaining));
|
|
}
|
|
|
|
/// Return the amount of money in the pot.
|
|
// The existential deposit is not part of the pot so treasury account never gets deleted.
|
|
fn pot() -> BalanceOf<T> {
|
|
T::Currency::free_balance(&Self::account_id())
|
|
// Must never be less than 0 but better be safe.
|
|
.saturating_sub(T::Currency::minimum_balance())
|
|
}
|
|
}
|
|
|
|
impl<T: Trait> OnUnbalanced<NegativeImbalanceOf<T>> for Module<T> {
|
|
fn on_nonzero_unbalanced(amount: NegativeImbalanceOf<T>) {
|
|
let numeric_amount = amount.peek();
|
|
|
|
// Must resolve into existing but better to be safe.
|
|
let _ = T::Currency::resolve_creating(&Self::account_id(), amount);
|
|
|
|
Self::deposit_event(RawEvent::Deposit(numeric_amount));
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
use frame_support::{assert_noop, assert_ok, impl_outer_origin, parameter_types, weights::Weight};
|
|
use sp_core::H256;
|
|
use sp_runtime::{
|
|
traits::{BlakeTwo256, OnFinalize, IdentityLookup}, testing::Header, Perbill
|
|
};
|
|
|
|
impl_outer_origin! {
|
|
pub enum Origin for Test where system = frame_system {}
|
|
}
|
|
|
|
#[derive(Clone, Eq, PartialEq)]
|
|
pub struct Test;
|
|
parameter_types! {
|
|
pub const BlockHashCount: u64 = 250;
|
|
pub const MaximumBlockWeight: Weight = 1024;
|
|
pub const MaximumBlockLength: u32 = 2 * 1024;
|
|
pub const AvailableBlockRatio: Perbill = Perbill::one();
|
|
}
|
|
impl frame_system::Trait for Test {
|
|
type Origin = Origin;
|
|
type Index = u64;
|
|
type BlockNumber = u64;
|
|
type Call = ();
|
|
type Hash = H256;
|
|
type Hashing = BlakeTwo256;
|
|
type AccountId = u64;
|
|
type Lookup = IdentityLookup<Self::AccountId>;
|
|
type Header = Header;
|
|
type Event = ();
|
|
type BlockHashCount = BlockHashCount;
|
|
type MaximumBlockWeight = MaximumBlockWeight;
|
|
type AvailableBlockRatio = AvailableBlockRatio;
|
|
type MaximumBlockLength = MaximumBlockLength;
|
|
type Version = ();
|
|
type ModuleToIndex = ();
|
|
}
|
|
parameter_types! {
|
|
pub const ExistentialDeposit: u64 = 1;
|
|
pub const TransferFee: u64 = 0;
|
|
pub const CreationFee: u64 = 0;
|
|
}
|
|
impl pallet_balances::Trait for Test {
|
|
type Balance = u64;
|
|
type OnNewAccount = ();
|
|
type OnFreeBalanceZero = ();
|
|
type Event = ();
|
|
type TransferPayment = ();
|
|
type DustRemoval = ();
|
|
type ExistentialDeposit = ExistentialDeposit;
|
|
type TransferFee = TransferFee;
|
|
type CreationFee = CreationFee;
|
|
}
|
|
parameter_types! {
|
|
pub const ProposalBond: Permill = Permill::from_percent(5);
|
|
pub const ProposalBondMinimum: u64 = 1;
|
|
pub const SpendPeriod: u64 = 2;
|
|
pub const Burn: Permill = Permill::from_percent(50);
|
|
}
|
|
impl Trait for Test {
|
|
type Currency = pallet_balances::Module<Test>;
|
|
type ApproveOrigin = frame_system::EnsureRoot<u64>;
|
|
type RejectOrigin = frame_system::EnsureRoot<u64>;
|
|
type Event = ();
|
|
type ProposalRejection = ();
|
|
type ProposalBond = ProposalBond;
|
|
type ProposalBondMinimum = ProposalBondMinimum;
|
|
type SpendPeriod = SpendPeriod;
|
|
type Burn = Burn;
|
|
}
|
|
type Balances = pallet_balances::Module<Test>;
|
|
type Treasury = Module<Test>;
|
|
|
|
fn new_test_ext() -> sp_io::TestExternalities {
|
|
let mut t = frame_system::GenesisConfig::default().build_storage::<Test>().unwrap();
|
|
pallet_balances::GenesisConfig::<Test>{
|
|
// Total issuance will be 200 with treasury account initialized at ED.
|
|
balances: vec![(0, 100), (1, 98), (2, 1)],
|
|
vesting: vec![],
|
|
}.assimilate_storage(&mut t).unwrap();
|
|
GenesisConfig::default().assimilate_storage::<Test>(&mut t).unwrap();
|
|
t.into()
|
|
}
|
|
|
|
#[test]
|
|
fn genesis_config_works() {
|
|
new_test_ext().execute_with(|| {
|
|
assert_eq!(Treasury::pot(), 0);
|
|
assert_eq!(Treasury::proposal_count(), 0);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn minting_works() {
|
|
new_test_ext().execute_with(|| {
|
|
// Check that accumulate works when we have Some value in Dummy already.
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
assert_eq!(Treasury::pot(), 100);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn spend_proposal_takes_min_deposit() {
|
|
new_test_ext().execute_with(|| {
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 1, 3));
|
|
assert_eq!(Balances::free_balance(&0), 99);
|
|
assert_eq!(Balances::reserved_balance(&0), 1);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn spend_proposal_takes_proportional_deposit() {
|
|
new_test_ext().execute_with(|| {
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3));
|
|
assert_eq!(Balances::free_balance(&0), 95);
|
|
assert_eq!(Balances::reserved_balance(&0), 5);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn spend_proposal_fails_when_proposer_poor() {
|
|
new_test_ext().execute_with(|| {
|
|
assert_noop!(
|
|
Treasury::propose_spend(Origin::signed(2), 100, 3),
|
|
Error::<Test>::InsufficientProposersBalance,
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn accepted_spend_proposal_ignored_outside_spend_period() {
|
|
new_test_ext().execute_with(|| {
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3));
|
|
assert_ok!(Treasury::approve_proposal(Origin::ROOT, 0));
|
|
|
|
<Treasury as OnFinalize<u64>>::on_finalize(1);
|
|
assert_eq!(Balances::free_balance(&3), 0);
|
|
assert_eq!(Treasury::pot(), 100);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn unused_pot_should_diminish() {
|
|
new_test_ext().execute_with(|| {
|
|
let init_total_issuance = Balances::total_issuance();
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
assert_eq!(Balances::total_issuance(), init_total_issuance + 100);
|
|
|
|
<Treasury as OnFinalize<u64>>::on_finalize(2);
|
|
assert_eq!(Treasury::pot(), 50);
|
|
assert_eq!(Balances::total_issuance(), init_total_issuance + 50);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn rejected_spend_proposal_ignored_on_spend_period() {
|
|
new_test_ext().execute_with(|| {
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3));
|
|
assert_ok!(Treasury::reject_proposal(Origin::ROOT, 0));
|
|
|
|
<Treasury as OnFinalize<u64>>::on_finalize(2);
|
|
assert_eq!(Balances::free_balance(&3), 0);
|
|
assert_eq!(Treasury::pot(), 50);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn reject_already_rejected_spend_proposal_fails() {
|
|
new_test_ext().execute_with(|| {
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3));
|
|
assert_ok!(Treasury::reject_proposal(Origin::ROOT, 0));
|
|
assert_noop!(Treasury::reject_proposal(Origin::ROOT, 0), Error::<Test>::InvalidProposalIndex);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn reject_non_existant_spend_proposal_fails() {
|
|
new_test_ext().execute_with(|| {
|
|
assert_noop!(Treasury::reject_proposal(Origin::ROOT, 0), Error::<Test>::InvalidProposalIndex);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn accept_non_existant_spend_proposal_fails() {
|
|
new_test_ext().execute_with(|| {
|
|
assert_noop!(Treasury::approve_proposal(Origin::ROOT, 0), Error::<Test>::InvalidProposalIndex);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn accept_already_rejected_spend_proposal_fails() {
|
|
new_test_ext().execute_with(|| {
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3));
|
|
assert_ok!(Treasury::reject_proposal(Origin::ROOT, 0));
|
|
assert_noop!(Treasury::approve_proposal(Origin::ROOT, 0), Error::<Test>::InvalidProposalIndex);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn accepted_spend_proposal_enacted_on_spend_period() {
|
|
new_test_ext().execute_with(|| {
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
assert_eq!(Treasury::pot(), 100);
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 100, 3));
|
|
assert_ok!(Treasury::approve_proposal(Origin::ROOT, 0));
|
|
|
|
<Treasury as OnFinalize<u64>>::on_finalize(2);
|
|
assert_eq!(Balances::free_balance(&3), 100);
|
|
assert_eq!(Treasury::pot(), 0);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn pot_underflow_should_not_diminish() {
|
|
new_test_ext().execute_with(|| {
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
assert_eq!(Treasury::pot(), 100);
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 150, 3));
|
|
assert_ok!(Treasury::approve_proposal(Origin::ROOT, 0));
|
|
|
|
<Treasury as OnFinalize<u64>>::on_finalize(2);
|
|
assert_eq!(Treasury::pot(), 100); // Pot hasn't changed
|
|
|
|
let _ = Balances::deposit_into_existing(&Treasury::account_id(), 100).unwrap();
|
|
<Treasury as OnFinalize<u64>>::on_finalize(4);
|
|
assert_eq!(Balances::free_balance(&3), 150); // Fund has been spent
|
|
assert_eq!(Treasury::pot(), 25); // Pot has finally changed
|
|
});
|
|
}
|
|
|
|
// Treasury account doesn't get deleted if amount approved to spend is all its free balance.
|
|
// i.e. pot should not include existential deposit needed for account survival.
|
|
#[test]
|
|
fn treasury_account_doesnt_get_deleted() {
|
|
new_test_ext().execute_with(|| {
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 101);
|
|
assert_eq!(Treasury::pot(), 100);
|
|
let treasury_balance = Balances::free_balance(&Treasury::account_id());
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), treasury_balance, 3));
|
|
assert_ok!(Treasury::approve_proposal(Origin::ROOT, 0));
|
|
|
|
<Treasury as OnFinalize<u64>>::on_finalize(2);
|
|
assert_eq!(Treasury::pot(), 100); // Pot hasn't changed
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), Treasury::pot(), 3));
|
|
assert_ok!(Treasury::approve_proposal(Origin::ROOT, 1));
|
|
|
|
<Treasury as OnFinalize<u64>>::on_finalize(4);
|
|
assert_eq!(Treasury::pot(), 0); // Pot is emptied
|
|
assert_eq!(Balances::free_balance(&Treasury::account_id()), 1); // but the account is still there
|
|
});
|
|
}
|
|
|
|
// In case treasury account is not existing then it works fine.
|
|
// This is usefull for chain that will just update runtime.
|
|
#[test]
|
|
fn inexisting_account_works() {
|
|
let mut t = frame_system::GenesisConfig::default().build_storage::<Test>().unwrap();
|
|
pallet_balances::GenesisConfig::<Test>{
|
|
balances: vec![(0, 100), (1, 99), (2, 1)],
|
|
vesting: vec![],
|
|
}.assimilate_storage(&mut t).unwrap();
|
|
// Treasury genesis config is not build thus treasury account does not exist
|
|
let mut t: sp_io::TestExternalities = t.into();
|
|
|
|
t.execute_with(|| {
|
|
assert_eq!(Balances::free_balance(&Treasury::account_id()), 0); // Account does not exist
|
|
assert_eq!(Treasury::pot(), 0); // Pot is empty
|
|
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 99, 3));
|
|
assert_ok!(Treasury::approve_proposal(Origin::ROOT, 0));
|
|
assert_ok!(Treasury::propose_spend(Origin::signed(0), 1, 3));
|
|
assert_ok!(Treasury::approve_proposal(Origin::ROOT, 1));
|
|
<Treasury as OnFinalize<u64>>::on_finalize(2);
|
|
assert_eq!(Treasury::pot(), 0); // Pot hasn't changed
|
|
assert_eq!(Balances::free_balance(&3), 0); // Balance of `3` hasn't changed
|
|
|
|
Balances::make_free_balance_be(&Treasury::account_id(), 100);
|
|
assert_eq!(Treasury::pot(), 99); // Pot now contains funds
|
|
assert_eq!(Balances::free_balance(&Treasury::account_id()), 100); // Account does exist
|
|
|
|
<Treasury as OnFinalize<u64>>::on_finalize(4);
|
|
|
|
assert_eq!(Treasury::pot(), 0); // Pot has changed
|
|
assert_eq!(Balances::free_balance(&3), 99); // Balance of `3` has changed
|
|
});
|
|
}
|
|
}
|