mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-18 04:45:40 +00:00
3d9439f646
## Problem During the bumping of the `polkadot-fellows` repository to `polkadot-sdk@1.6.0`, I encountered a situation where the benchmarks `teleport_assets` and `reserve_transfer_assets` in AssetHubKusama started to fail. This issue arose due to a decreased ED balance for AssetHubs introduced [here](https://github.com/polkadot-fellows/runtimes/pull/158/files#diff-80668ff8e793b64f36a9a3ec512df5cbca4ad448c157a5d81abda1b15f35f1daR213), and also because of a [missing CI pipeline](https://github.com/polkadot-fellows/runtimes/issues/197) to check the benchmarks, which went unnoticed. These benchmarks expect the `caller` to have enough: 1. balance to transfer (BTT) 2. balance for paying delivery (BFPD). So the initial balance was calculated as `ED * 100`, which seems reasonable: ``` const ED_MULTIPLIER: u32 = 100; let balance = existential_deposit.saturating_mul(ED_MULTIPLIER.into());` ``` The problem arises when the price for delivery is 100 times higher than the existential deposit. In other words, when `ED * 100` does not cover `BTT` + `BFPD`. I check AHR/AHW/AHK/AHP and this problem has only AssetHubKusama ``` ED: 3333333 calculated price to parent delivery: 1031666634 (from xcm logs from the benchmark) --- 3333333 * 100 - BTT(3333333) - BFPD(1031666634) = −701666667 ``` which results in the error; ``` 2024-02-23 09:19:42 Unable to charge fee with error Module(ModuleError { index: 31, error: [17, 0, 0, 0], message: Some("FeesNotMet") }) Error: Input("Benchmark pallet_xcm::reserve_transfer_assets failed: FeesNotMet") ``` ## Solution The benchmarks `teleport_assets` and `reserve_transfer_assets` were fixed by removing `ED * 100` and replacing it with `DeliveryHelper` logic, which calculates the (almost real) price for delivery and sets it along with the existential deposit as the initial balance for the account used in the benchmark. ## TODO - [ ] patch for 1.6 - https://github.com/paritytech/polkadot-sdk/pull/3466 - [ ] patch for 1.7 - https://github.com/paritytech/polkadot-sdk/pull/3465 - [ ] patch for 1.8 - TODO: PR --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
142 lines
5.0 KiB
Rust
142 lines
5.0 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Various implementations for `SendXcm`.
|
|
|
|
use frame_system::unique;
|
|
use parity_scale_codec::Encode;
|
|
use sp_std::{marker::PhantomData, result::Result};
|
|
use xcm::prelude::*;
|
|
use xcm_executor::{traits::FeeReason, FeesMode};
|
|
|
|
/// Wrapper router which, if the message does not already end with a `SetTopic` instruction,
|
|
/// appends one to the message filled with a universally unique ID. This ID is returned from a
|
|
/// successful `deliver`.
|
|
///
|
|
/// If the message does already end with a `SetTopic` instruction, then it is the responsibility
|
|
/// of the code author to ensure that the ID supplied to `SetTopic` is universally unique. Due to
|
|
/// this property, consumers of the topic ID must be aware that a user-supplied ID may not be
|
|
/// unique.
|
|
///
|
|
/// This is designed to be at the top-level of any routers, since it will always mutate the
|
|
/// passed `message` reference into a `None`. Don't try to combine it within a tuple except as the
|
|
/// last element.
|
|
pub struct WithUniqueTopic<Inner>(PhantomData<Inner>);
|
|
impl<Inner: SendXcm> SendXcm for WithUniqueTopic<Inner> {
|
|
type Ticket = (Inner::Ticket, [u8; 32]);
|
|
|
|
fn validate(
|
|
destination: &mut Option<Location>,
|
|
message: &mut Option<Xcm<()>>,
|
|
) -> SendResult<Self::Ticket> {
|
|
let mut message = message.take().ok_or(SendError::MissingArgument)?;
|
|
let unique_id = if let Some(SetTopic(id)) = message.last() {
|
|
*id
|
|
} else {
|
|
let unique_id = unique(&message);
|
|
message.0.push(SetTopic(unique_id));
|
|
unique_id
|
|
};
|
|
let (ticket, assets) = Inner::validate(destination, &mut Some(message))?;
|
|
Ok(((ticket, unique_id), assets))
|
|
}
|
|
|
|
fn deliver(ticket: Self::Ticket) -> Result<XcmHash, SendError> {
|
|
let (ticket, unique_id) = ticket;
|
|
Inner::deliver(ticket)?;
|
|
Ok(unique_id)
|
|
}
|
|
}
|
|
|
|
pub trait SourceTopic {
|
|
fn source_topic(entropy: impl Encode) -> XcmHash;
|
|
}
|
|
|
|
impl SourceTopic for () {
|
|
fn source_topic(_: impl Encode) -> XcmHash {
|
|
[0u8; 32]
|
|
}
|
|
}
|
|
|
|
/// Wrapper router which, if the message does not already end with a `SetTopic` instruction,
|
|
/// prepends one to the message filled with an ID from `TopicSource`. This ID is returned from a
|
|
/// successful `deliver`.
|
|
///
|
|
/// This is designed to be at the top-level of any routers, since it will always mutate the
|
|
/// passed `message` reference into a `None`. Don't try to combine it within a tuple except as the
|
|
/// last element.
|
|
pub struct WithTopicSource<Inner, TopicSource>(PhantomData<(Inner, TopicSource)>);
|
|
impl<Inner: SendXcm, TopicSource: SourceTopic> SendXcm for WithTopicSource<Inner, TopicSource> {
|
|
type Ticket = (Inner::Ticket, [u8; 32]);
|
|
|
|
fn validate(
|
|
destination: &mut Option<Location>,
|
|
message: &mut Option<Xcm<()>>,
|
|
) -> SendResult<Self::Ticket> {
|
|
let mut message = message.take().ok_or(SendError::MissingArgument)?;
|
|
let unique_id = if let Some(SetTopic(id)) = message.last() {
|
|
*id
|
|
} else {
|
|
let unique_id = TopicSource::source_topic(&message);
|
|
message.0.push(SetTopic(unique_id));
|
|
unique_id
|
|
};
|
|
let (ticket, assets) = Inner::validate(destination, &mut Some(message))
|
|
.map_err(|_| SendError::NotApplicable)?;
|
|
Ok(((ticket, unique_id), assets))
|
|
}
|
|
|
|
fn deliver(ticket: Self::Ticket) -> Result<XcmHash, SendError> {
|
|
let (ticket, unique_id) = ticket;
|
|
Inner::deliver(ticket)?;
|
|
Ok(unique_id)
|
|
}
|
|
}
|
|
|
|
/// Trait for a type which ensures all requirements for successful delivery with XCM transport
|
|
/// layers.
|
|
pub trait EnsureDelivery {
|
|
/// Prepare all requirements for successful `XcmSender: SendXcm` passing (accounts, balances,
|
|
/// channels ...). Returns:
|
|
/// - possible `FeesMode` which is expected to be set to executor
|
|
/// - possible `Assets` which are expected to be subsume to the Holding Register
|
|
fn ensure_successful_delivery(
|
|
origin_ref: &Location,
|
|
dest: &Location,
|
|
fee_reason: FeeReason,
|
|
) -> (Option<FeesMode>, Option<Assets>);
|
|
}
|
|
|
|
/// Tuple implementation for `EnsureDelivery`.
|
|
#[impl_trait_for_tuples::impl_for_tuples(30)]
|
|
impl EnsureDelivery for Tuple {
|
|
fn ensure_successful_delivery(
|
|
origin_ref: &Location,
|
|
dest: &Location,
|
|
fee_reason: FeeReason,
|
|
) -> (Option<FeesMode>, Option<Assets>) {
|
|
for_tuples!( #(
|
|
// If the implementation returns something, we're done; if not, let others try.
|
|
match Tuple::ensure_successful_delivery(origin_ref, dest, fee_reason.clone()) {
|
|
r @ (Some(_), Some(_)) | r @ (Some(_), None) | r @ (None, Some(_)) => return r,
|
|
(None, None) => (),
|
|
}
|
|
)* );
|
|
// doing nothing
|
|
(None, None)
|
|
}
|
|
}
|