mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-26 22:47:56 +00:00
e71c484d5b
This commit introduces a new concept called `NotificationService` which allows Polkadot protocols to communicate with the underlying notification protocol implementation directly, without routing events through `NetworkWorker`. This implies that each protocol has its own service which it uses to communicate with remote peers and that each `NotificationService` is unique with respect to the underlying notification protocol, meaning `NotificationService` for the transaction protocol can only be used to send and receive transaction-related notifications. The `NotificationService` concept introduces two additional benefits: * allow protocols to start using custom handshakes * allow protocols to accept/reject inbound peers Previously the validation of inbound connections was solely the responsibility of `ProtocolController`. This caused issues with light peers and `SyncingEngine` as `ProtocolController` would accept more peers than `SyncingEngine` could accept which caused peers to have differing views of their own states. `SyncingEngine` would reject excess peers but these rejections were not properly communicated to those peers causing them to assume that they were accepted. With `NotificationService`, the local handshake is not sent to remote peer if peer is rejected which allows it to detect that it was rejected. This commit also deprecates the use of `NetworkEventStream` for all notification-related events and going forward only DHT events are provided through `NetworkEventStream`. If protocols wish to follow each other's events, they must introduce additional abtractions, as is done for GRANDPA and transactions protocols by following the syncing protocol through `SyncEventStream`. Fixes https://github.com/paritytech/polkadot-sdk/issues/512 Fixes https://github.com/paritytech/polkadot-sdk/issues/514 Fixes https://github.com/paritytech/polkadot-sdk/issues/515 Fixes https://github.com/paritytech/polkadot-sdk/issues/554 Fixes https://github.com/paritytech/polkadot-sdk/issues/556 --- These changes are transferred from https://github.com/paritytech/substrate/pull/14197 but there are no functional changes compared to that PR --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
138 lines
3.6 KiB
Rust
138 lines
3.6 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
// file-level lint whitelist to avoid problem with bitflags macro below
|
|
// TODO: can be dropped after an update to bitflags 2.4
|
|
#![allow(clippy::bad_bit_mask)]
|
|
|
|
use codec::{self, Encode, EncodeLike, Input, Output};
|
|
|
|
/// Role that the peer sent to us during the handshake, with the addition of what our local node
|
|
/// knows about that peer.
|
|
///
|
|
/// > **Note**: This enum is different from the `Role` enum. The `Role` enum indicates what a
|
|
/// > node says about itself, while `ObservedRole` is a `Role` merged with the
|
|
/// > information known locally about that node.
|
|
#[derive(Debug, Copy, Clone, PartialEq, Eq)]
|
|
pub enum ObservedRole {
|
|
/// Full node.
|
|
Full,
|
|
/// Light node.
|
|
Light,
|
|
/// Third-party authority.
|
|
Authority,
|
|
}
|
|
|
|
impl ObservedRole {
|
|
/// Returns `true` for `ObservedRole::Light`.
|
|
pub fn is_light(&self) -> bool {
|
|
matches!(self, Self::Light)
|
|
}
|
|
}
|
|
|
|
impl From<Roles> for ObservedRole {
|
|
fn from(roles: Roles) -> Self {
|
|
if roles.is_authority() {
|
|
ObservedRole::Authority
|
|
} else if roles.is_full() {
|
|
ObservedRole::Full
|
|
} else {
|
|
ObservedRole::Light
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Role of the local node.
|
|
#[derive(Debug, Clone)]
|
|
pub enum Role {
|
|
/// Regular full node.
|
|
Full,
|
|
/// Actual authority.
|
|
Authority,
|
|
}
|
|
|
|
impl Role {
|
|
/// True for [`Role::Authority`].
|
|
pub fn is_authority(&self) -> bool {
|
|
matches!(self, Self::Authority)
|
|
}
|
|
}
|
|
|
|
impl std::fmt::Display for Role {
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
match self {
|
|
Self::Full => write!(f, "FULL"),
|
|
Self::Authority => write!(f, "AUTHORITY"),
|
|
}
|
|
}
|
|
}
|
|
|
|
bitflags::bitflags! {
|
|
/// Bitmask of the roles that a node fulfills.
|
|
pub struct Roles: u8 {
|
|
/// No network.
|
|
const NONE = 0b00000000;
|
|
/// Full node, does not participate in consensus.
|
|
const FULL = 0b00000001;
|
|
/// Light client node.
|
|
const LIGHT = 0b00000010;
|
|
/// Act as an authority
|
|
const AUTHORITY = 0b00000100;
|
|
}
|
|
}
|
|
|
|
impl Roles {
|
|
/// Does this role represents a client that holds full chain data locally?
|
|
pub fn is_full(&self) -> bool {
|
|
self.intersects(Self::FULL | Self::AUTHORITY)
|
|
}
|
|
|
|
/// Does this role represents a client that does not participates in the consensus?
|
|
pub fn is_authority(&self) -> bool {
|
|
*self == Self::AUTHORITY
|
|
}
|
|
|
|
/// Does this role represents a client that does not hold full chain data locally?
|
|
pub fn is_light(&self) -> bool {
|
|
!self.is_full()
|
|
}
|
|
}
|
|
|
|
impl<'a> From<&'a Role> for Roles {
|
|
fn from(roles: &'a Role) -> Self {
|
|
match roles {
|
|
Role::Full => Self::FULL,
|
|
Role::Authority => Self::AUTHORITY,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Encode for Roles {
|
|
fn encode_to<T: Output + ?Sized>(&self, dest: &mut T) {
|
|
dest.push_byte(self.bits())
|
|
}
|
|
}
|
|
|
|
impl EncodeLike for Roles {}
|
|
|
|
impl codec::Decode for Roles {
|
|
fn decode<I: Input>(input: &mut I) -> Result<Self, codec::Error> {
|
|
Self::from_bits(input.read_byte()?).ok_or_else(|| codec::Error::from("Invalid bytes"))
|
|
}
|
|
}
|