mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-28 07:31:06 +00:00
bb8ddc46c1
I started this investigation/issue based on @liamaharon question [here](https://github.com/paritytech/polkadot-sdk/pull/1801#discussion_r1410452499). ## Problem The `pallet_balances` integrity test should correctly detect that the runtime has correct distinct `HoldReasons` variant count. I assume the same situation exists for RuntimeFreezeReason. It is not a critical problem, if we set `MaxHolds` with a sufficiently large value, everything should be ok. However, in this case, the integrity_test check becomes less useful. **Situation for "any" runtime:** - `HoldReason` enums from different pallets: ```rust /// from pallet_nis #[pallet::composite_enum] pub enum HoldReason { NftReceipt, } /// from pallet_preimage #[pallet::composite_enum] pub enum HoldReason { Preimage, } // from pallet_state-trie-migration #[pallet::composite_enum] pub enum HoldReason { SlashForContinueMigrate, SlashForMigrateCustomTop, SlashForMigrateCustomChild, } ``` - generated `RuntimeHoldReason` enum looks like: ```rust pub enum RuntimeHoldReason { #[codec(index = 32u8)] Preimage(pallet_preimage::HoldReason), #[codec(index = 38u8)] Nis(pallet_nis::HoldReason), #[codec(index = 42u8)] StateTrieMigration(pallet_state_trie_migration::HoldReason), } ``` - composite enum `RuntimeHoldReason` variant count is detected as `3` - we set `type MaxHolds = ConstU32<3>` - `pallet_balances::integrity_test` is ok with `3`(at least 3) However, the real problem can occur in a live runtime where some functionality might stop working. This is due to a total of 5 distinct hold reasons (for pallets with multi-instance support, it is even more), and not all of them can be used because of an incorrect `MaxHolds`, which is deemed acceptable according to the `integrity_test`: ``` // pseudo-code - if we try to call all of these: T::Currency::hold(&pallet_nis::HoldReason::NftReceipt.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_preimage::HoldReason::Preimage.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForContinueMigrate.into(), &nft_owner, deposit)?; // With `type MaxHolds = ConstU32<3>` these two will fail T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomTop.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomChild.into(), &nft_owner, deposit)?; ``` ## Solutions A macro `#[pallet::*]` expansion is extended of `VariantCount` implementation for the `#[pallet::composite_enum]` enum type. This expansion generates the `VariantCount` implementation for pallets' `HoldReason`, `FreezeReason`, `LockId`, and `SlashReason`. Enum variants must be plain enum values without fields to ensure a deterministic count. The composite runtime enum, `RuntimeHoldReason` and `RuntimeFreezeReason`, now sets `VariantCount::VARIANT_COUNT` as the sum of pallets' enum `VariantCount::VARIANT_COUNT`: ```rust #[frame_support::pallet(dev_mode)] mod module_single_instance { #[pallet::composite_enum] pub enum HoldReason { ModuleSingleInstanceReason1, ModuleSingleInstanceReason2, } ... } #[frame_support::pallet(dev_mode)] mod module_multi_instance { #[pallet::composite_enum] pub enum HoldReason<I: 'static = ()> { ModuleMultiInstanceReason1, ModuleMultiInstanceReason2, ModuleMultiInstanceReason3, } ... } impl self::sp_api_hidden_includes_construct_runtime::hidden_include::traits::VariantCount for RuntimeHoldReason { const VARIANT_COUNT: u32 = 0 + module_single_instance::HoldReason::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance1>::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance2>::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance3>::VARIANT_COUNT; } ``` In addition, `MaxHolds` is removed (as suggested [here](https://github.com/paritytech/polkadot-sdk/pull/2657#discussion_r1443324573)) from `pallet_balances`, and its `Holds` are now bounded to `RuntimeHoldReason::VARIANT_COUNT`. Therefore, there is no need to let the runtime specify `MaxHolds`. ## For reviewers Relevant changes can be found here: - `substrate/frame/support/procedural/src/lib.rs` - `substrate/frame/support/procedural/src/pallet/parse/composite.rs` - `substrate/frame/support/procedural/src/pallet/expand/composite.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/composite_helper.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/hold_reason.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/freeze_reason.rs` - `substrate/frame/support/src/traits/misc.rs` And the rest of the files is just about removed `MaxHolds` from `pallet_balances` ## Next steps Do the same for `MaxFreezes` https://github.com/paritytech/polkadot-sdk/issues/2997. --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
342 lines
10 KiB
Rust
342 lines
10 KiB
Rust
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use super::*;
|
|
use crate as xcmp_queue;
|
|
use core::marker::PhantomData;
|
|
use cumulus_pallet_parachain_system::AnyRelayNumber;
|
|
use cumulus_primitives_core::{ChannelInfo, IsSystem, ParaId};
|
|
use frame_support::{
|
|
derive_impl, parameter_types,
|
|
traits::{ConstU32, Everything, Nothing, OriginTrait},
|
|
BoundedSlice,
|
|
};
|
|
use frame_system::EnsureRoot;
|
|
use sp_core::H256;
|
|
use sp_runtime::{
|
|
traits::{BlakeTwo256, IdentityLookup},
|
|
BuildStorage,
|
|
};
|
|
use xcm::prelude::*;
|
|
#[allow(deprecated)]
|
|
use xcm_builder::CurrencyAdapter;
|
|
use xcm_builder::{
|
|
FixedWeightBounds, FrameTransactionalProcessor, IsConcrete, NativeAsset, ParentIsPreset,
|
|
};
|
|
use xcm_executor::traits::ConvertOrigin;
|
|
|
|
type Block = frame_system::mocking::MockBlock<Test>;
|
|
|
|
// Configure a mock runtime to test the pallet.
|
|
frame_support::construct_runtime!(
|
|
pub enum Test
|
|
{
|
|
System: frame_system::{Pallet, Call, Config<T>, Storage, Event<T>},
|
|
Balances: pallet_balances::{Pallet, Call, Storage, Config<T>, Event<T>},
|
|
ParachainSystem: cumulus_pallet_parachain_system::{
|
|
Pallet, Call, Config<T>, Storage, Inherent, Event<T>, ValidateUnsigned,
|
|
},
|
|
XcmpQueue: xcmp_queue::{Pallet, Call, Storage, Event<T>},
|
|
}
|
|
);
|
|
|
|
parameter_types! {
|
|
pub const BlockHashCount: u64 = 250;
|
|
pub const SS58Prefix: u8 = 42;
|
|
}
|
|
|
|
type AccountId = u64;
|
|
|
|
#[derive_impl(frame_system::config_preludes::TestDefaultConfig as frame_system::DefaultConfig)]
|
|
impl frame_system::Config for Test {
|
|
type BaseCallFilter = Everything;
|
|
type BlockWeights = ();
|
|
type BlockLength = ();
|
|
type DbWeight = ();
|
|
type RuntimeOrigin = RuntimeOrigin;
|
|
type RuntimeCall = RuntimeCall;
|
|
type Nonce = u64;
|
|
type Hash = H256;
|
|
type Hashing = BlakeTwo256;
|
|
type AccountId = AccountId;
|
|
type Lookup = IdentityLookup<Self::AccountId>;
|
|
type Block = Block;
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type BlockHashCount = BlockHashCount;
|
|
type Version = ();
|
|
type PalletInfo = PalletInfo;
|
|
type AccountData = pallet_balances::AccountData<u64>;
|
|
type OnNewAccount = ();
|
|
type OnKilledAccount = ();
|
|
type SystemWeightInfo = ();
|
|
type SS58Prefix = SS58Prefix;
|
|
type OnSetCode = cumulus_pallet_parachain_system::ParachainSetCode<Test>;
|
|
type MaxConsumers = frame_support::traits::ConstU32<16>;
|
|
}
|
|
|
|
parameter_types! {
|
|
pub const ExistentialDeposit: u64 = 5;
|
|
pub const MaxReserves: u32 = 50;
|
|
}
|
|
|
|
pub type Balance = u64;
|
|
|
|
impl pallet_balances::Config for Test {
|
|
type Balance = Balance;
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type DustRemoval = ();
|
|
type ExistentialDeposit = ExistentialDeposit;
|
|
type AccountStore = System;
|
|
type WeightInfo = ();
|
|
type MaxLocks = ();
|
|
type MaxReserves = MaxReserves;
|
|
type ReserveIdentifier = [u8; 8];
|
|
type RuntimeHoldReason = RuntimeHoldReason;
|
|
type RuntimeFreezeReason = RuntimeFreezeReason;
|
|
type FreezeIdentifier = ();
|
|
type MaxFreezes = ConstU32<0>;
|
|
}
|
|
|
|
impl cumulus_pallet_parachain_system::Config for Test {
|
|
type WeightInfo = ();
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type OnSystemEvent = ();
|
|
type SelfParaId = ();
|
|
type OutboundXcmpMessageSource = XcmpQueue;
|
|
// Ignore all DMP messages by enqueueing them into `()`:
|
|
type DmpQueue = frame_support::traits::EnqueueWithOrigin<(), sp_core::ConstU8<0>>;
|
|
type ReservedDmpWeight = ();
|
|
type XcmpMessageHandler = XcmpQueue;
|
|
type ReservedXcmpWeight = ();
|
|
type CheckAssociatedRelayNumber = AnyRelayNumber;
|
|
type ConsensusHook = cumulus_pallet_parachain_system::consensus_hook::ExpectParentIncluded;
|
|
}
|
|
|
|
parameter_types! {
|
|
pub const RelayChain: Location = Location::parent();
|
|
pub UniversalLocation: InteriorLocation = [Parachain(1u32)].into();
|
|
pub UnitWeightCost: Weight = Weight::from_parts(1_000_000, 1024);
|
|
pub const MaxInstructions: u32 = 100;
|
|
pub const MaxAssetsIntoHolding: u32 = 64;
|
|
}
|
|
|
|
/// Means for transacting assets on this chain.
|
|
#[allow(deprecated)]
|
|
pub type LocalAssetTransactor = CurrencyAdapter<
|
|
// Use this currency:
|
|
Balances,
|
|
// Use this currency when it is a fungible asset matching the given location or name:
|
|
IsConcrete<RelayChain>,
|
|
// Do a simple punn to convert an AccountId32 Location into a native chain account ID:
|
|
LocationToAccountId,
|
|
// Our chain's account ID type (we can't get away without mentioning it explicitly):
|
|
AccountId,
|
|
// We don't track any teleports.
|
|
(),
|
|
>;
|
|
|
|
pub type LocationToAccountId = (ParentIsPreset<AccountId>,);
|
|
|
|
pub struct XcmConfig;
|
|
impl xcm_executor::Config for XcmConfig {
|
|
type RuntimeCall = RuntimeCall;
|
|
type XcmSender = XcmRouter;
|
|
// How to withdraw and deposit an asset.
|
|
type AssetTransactor = LocalAssetTransactor;
|
|
type OriginConverter = ();
|
|
type IsReserve = NativeAsset;
|
|
type IsTeleporter = NativeAsset;
|
|
type UniversalLocation = UniversalLocation;
|
|
type Barrier = ();
|
|
type Weigher = FixedWeightBounds<UnitWeightCost, RuntimeCall, MaxInstructions>;
|
|
type Trader = ();
|
|
type ResponseHandler = ();
|
|
type AssetTrap = ();
|
|
type AssetClaims = ();
|
|
type SubscriptionService = ();
|
|
type PalletInstancesInfo = AllPalletsWithSystem;
|
|
type MaxAssetsIntoHolding = MaxAssetsIntoHolding;
|
|
type AssetLocker = ();
|
|
type AssetExchanger = ();
|
|
type FeeManager = ();
|
|
type MessageExporter = ();
|
|
type UniversalAliases = Nothing;
|
|
type CallDispatcher = RuntimeCall;
|
|
type SafeCallFilter = Everything;
|
|
type Aliasers = Nothing;
|
|
type TransactionalProcessor = FrameTransactionalProcessor;
|
|
}
|
|
|
|
pub type XcmRouter = (
|
|
// XCMP to communicate with the sibling chains.
|
|
XcmpQueue,
|
|
);
|
|
|
|
pub struct SystemParachainAsSuperuser<RuntimeOrigin>(PhantomData<RuntimeOrigin>);
|
|
impl<RuntimeOrigin: OriginTrait> ConvertOrigin<RuntimeOrigin>
|
|
for SystemParachainAsSuperuser<RuntimeOrigin>
|
|
{
|
|
fn convert_origin(
|
|
origin: impl Into<Location>,
|
|
kind: OriginKind,
|
|
) -> Result<RuntimeOrigin, Location> {
|
|
let origin = origin.into();
|
|
if kind == OriginKind::Superuser &&
|
|
matches!(
|
|
origin.unpack(),
|
|
(1, [Parachain(id)]) if ParaId::from(*id).is_system(),
|
|
) {
|
|
Ok(RuntimeOrigin::root())
|
|
} else {
|
|
Err(origin)
|
|
}
|
|
}
|
|
}
|
|
|
|
parameter_types! {
|
|
pub static EnqueuedMessages: Vec<(ParaId, Vec<u8>)> = Default::default();
|
|
}
|
|
|
|
/// An `EnqueueMessage` implementation that puts all messages in thread-local storage.
|
|
pub struct EnqueueToLocalStorage<T>(PhantomData<T>);
|
|
|
|
impl<T: OnQueueChanged<ParaId>> EnqueueMessage<ParaId> for EnqueueToLocalStorage<T> {
|
|
type MaxMessageLen = sp_core::ConstU32<65_536>;
|
|
|
|
fn enqueue_message(message: BoundedSlice<u8, Self::MaxMessageLen>, origin: ParaId) {
|
|
let mut msgs = EnqueuedMessages::get();
|
|
msgs.push((origin, message.to_vec()));
|
|
EnqueuedMessages::set(msgs);
|
|
T::on_queue_changed(origin, Self::footprint(origin));
|
|
}
|
|
|
|
fn enqueue_messages<'a>(
|
|
iter: impl Iterator<Item = BoundedSlice<'a, u8, Self::MaxMessageLen>>,
|
|
origin: ParaId,
|
|
) {
|
|
let mut msgs = EnqueuedMessages::get();
|
|
msgs.extend(iter.map(|m| (origin, m.to_vec())));
|
|
EnqueuedMessages::set(msgs);
|
|
T::on_queue_changed(origin, Self::footprint(origin));
|
|
}
|
|
|
|
fn sweep_queue(origin: ParaId) {
|
|
let mut msgs = EnqueuedMessages::get();
|
|
msgs.retain(|(o, _)| o != &origin);
|
|
EnqueuedMessages::set(msgs);
|
|
T::on_queue_changed(origin, Self::footprint(origin));
|
|
}
|
|
|
|
fn footprint(origin: ParaId) -> QueueFootprint {
|
|
let msgs = EnqueuedMessages::get();
|
|
let mut footprint = QueueFootprint::default();
|
|
for (o, m) in msgs {
|
|
if o == origin {
|
|
footprint.storage.count += 1;
|
|
footprint.storage.size += m.len() as u64;
|
|
}
|
|
}
|
|
footprint.pages = footprint.storage.size as u32 / 16; // Number does not matter
|
|
footprint
|
|
}
|
|
}
|
|
|
|
parameter_types! {
|
|
/// The asset ID for the asset that we use to pay for message delivery fees.
|
|
pub FeeAssetId: AssetId = AssetId(RelayChain::get());
|
|
/// The base fee for the message delivery fees.
|
|
pub const BaseDeliveryFee: Balance = 300_000_000;
|
|
/// The fee per byte
|
|
pub const ByteFee: Balance = 1_000_000;
|
|
}
|
|
|
|
pub type PriceForSiblingParachainDelivery = polkadot_runtime_common::xcm_sender::ExponentialPrice<
|
|
FeeAssetId,
|
|
BaseDeliveryFee,
|
|
ByteFee,
|
|
XcmpQueue,
|
|
>;
|
|
|
|
impl Config for Test {
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type ChannelInfo = MockedChannelInfo;
|
|
type VersionWrapper = ();
|
|
type XcmpQueue = EnqueueToLocalStorage<Pallet<Test>>;
|
|
type MaxInboundSuspended = sp_core::ConstU32<1_000>;
|
|
type ControllerOrigin = EnsureRoot<AccountId>;
|
|
type ControllerOriginConverter = SystemParachainAsSuperuser<RuntimeOrigin>;
|
|
type WeightInfo = ();
|
|
type PriceForSiblingDelivery = PriceForSiblingParachainDelivery;
|
|
}
|
|
|
|
pub fn new_test_ext() -> sp_io::TestExternalities {
|
|
frame_system::GenesisConfig::<Test>::default().build_storage().unwrap().into()
|
|
}
|
|
|
|
/// A para that we have an HRMP channel with.
|
|
pub const HRMP_PARA_ID: u32 = 7777;
|
|
|
|
pub struct MockedChannelInfo;
|
|
impl GetChannelInfo for MockedChannelInfo {
|
|
fn get_channel_status(id: ParaId) -> ChannelStatus {
|
|
if id == HRMP_PARA_ID.into() {
|
|
return ChannelStatus::Ready(usize::MAX, usize::MAX)
|
|
}
|
|
|
|
ParachainSystem::get_channel_status(id)
|
|
}
|
|
|
|
fn get_channel_info(id: ParaId) -> Option<ChannelInfo> {
|
|
if id == HRMP_PARA_ID.into() {
|
|
return Some(ChannelInfo {
|
|
max_capacity: u32::MAX,
|
|
max_total_size: u32::MAX,
|
|
max_message_size: u32::MAX,
|
|
msg_count: 0,
|
|
total_size: 0,
|
|
})
|
|
}
|
|
|
|
ParachainSystem::get_channel_info(id)
|
|
}
|
|
}
|
|
|
|
pub(crate) fn mk_page() -> Vec<u8> {
|
|
let mut page = Vec::<u8>::new();
|
|
|
|
for i in 0..100 {
|
|
page.extend(match i % 2 {
|
|
0 => v2_xcm().encode(),
|
|
1 => v3_xcm().encode(),
|
|
// We cannot push an undecodable XCM here since it would break the decode stream.
|
|
// This is expected and the whole reason to introduce `MaybeDoubleEncodedVersionedXcm`
|
|
// instead.
|
|
_ => unreachable!(),
|
|
});
|
|
}
|
|
|
|
page
|
|
}
|
|
|
|
pub(crate) fn v2_xcm() -> VersionedXcm<()> {
|
|
let instr = xcm::v2::Instruction::<()>::ClearOrigin;
|
|
VersionedXcm::V2(xcm::v2::Xcm::<()>(vec![instr; 3]))
|
|
}
|
|
|
|
pub(crate) fn v3_xcm() -> VersionedXcm<()> {
|
|
let instr = xcm::v3::Instruction::<()>::Trap(1);
|
|
VersionedXcm::V3(xcm::v3::Xcm::<()>(vec![instr; 3]))
|
|
}
|