mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-26 01:47:55 +00:00
Joshy Orndorff
8683bbeefb
Closes #2326. This PR both fixes a logic bug and replaces an incorrect name. ## Bug Fix: Respecting custom genesis builder Prior to this PR the standard logic for creating a genesis block was repeated inside of cumulus. This PR removes that duplicated logic, and calls into the proper `BuildGenesisBlock` implementation. One consequence is that if the genesis block has already been initialized, it will not be re-created, but rather read from the database like it is for other node invocations. So you need to watch out for old unpurged data during the development process. Offchain tools may need to be updated accordingly. I've already filed https://github.com/paritytech/zombienet/issues/1519 ## Rename: It doesn't export state. It exports head data. The name export-genesis-state was always wrong, nad it's never too late to right a wrong. I've changed the name of the struct to `ExportGenesisHeadCommand`. There is still the question of what to do with individual nodes' public CLIs. I have updated the parachain template to a reasonable default that preserves compatibility with tools that will expect `export-genesis-state` to still work. And I've chosen not to modify the public CLIs of any other nodes in the repo. I'll leave it up to their individual owners/maintains to decide whether that is appropriate. --------- Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>
18 lines
690 B
Plaintext
18 lines
690 B
Plaintext
title: Rename `ExportGenesisStateCommand` to `ExportGenesisHeadCommand`
|
|
|
|
doc:
|
|
- audience: Node Operator
|
|
description: |
|
|
The `export-genesis-state` subcommand is now called `export-gensis-head`, but
|
|
`export-genesis-state` stays as an alias to not break any scripts.
|
|
|
|
- audience: Node Dev
|
|
description: |
|
|
The struct `ExportGenesisStateCommand` is now called `ExportGenesisHeadCommand`.
|
|
So, you only need to rename the import and usage. The `run` function is now
|
|
taking only a `client` as argument to fetch the genesis header. This way
|
|
the exported genesis head is respecting custom genesis block builders.
|
|
|
|
crates:
|
|
- name: "cumulus-client-cli"
|