Files
pezkuwi-subxt/prdoc/pr_4015.prdoc
T
Bastian Köcher c1063a530e sc-beefy-consensus: Remove unneeded stream. (#4015)
The stream was just used to communicate from the validator the peer
reports back to the gossip engine. Internally the gossip engine just
forwards these reports to the networking engine. So, we can just do this
directly.

The reporting stream was also pumped [in the worker behind the
engine](https://github.com/paritytech/polkadot-sdk/blob/9d6261892814fa27c97881c0321c008d7340b54b/substrate/client/consensus/beefy/src/worker.rs#L939).
This means if there was a lot of data incoming over the engine, the
reporting stream was almost never processed and thus, it could have
started to grow and we have seen issues around this.

Partly Closes: https://github.com/paritytech/polkadot-sdk/issues/3945
2024-04-08 08:28:42 +00:00

15 lines
487 B
Plaintext

title: Improve beefy networking code by forwarding data more directly
doc:
- audience: Node Operator
description: |
Improve internal implementation of beefy to forward data directly to the
networking layer instead of first storing them internally. So, the
following error message should not appear again:
```
The number of unprocessed messages in channel `mpsc_beefy_gossip_validator` exceeded 100000.
```
crates:
- name: sc-consensus-beefy