mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-21 08:41:01 +00:00
bb8ddc46c1
I started this investigation/issue based on @liamaharon question [here](https://github.com/paritytech/polkadot-sdk/pull/1801#discussion_r1410452499). ## Problem The `pallet_balances` integrity test should correctly detect that the runtime has correct distinct `HoldReasons` variant count. I assume the same situation exists for RuntimeFreezeReason. It is not a critical problem, if we set `MaxHolds` with a sufficiently large value, everything should be ok. However, in this case, the integrity_test check becomes less useful. **Situation for "any" runtime:** - `HoldReason` enums from different pallets: ```rust /// from pallet_nis #[pallet::composite_enum] pub enum HoldReason { NftReceipt, } /// from pallet_preimage #[pallet::composite_enum] pub enum HoldReason { Preimage, } // from pallet_state-trie-migration #[pallet::composite_enum] pub enum HoldReason { SlashForContinueMigrate, SlashForMigrateCustomTop, SlashForMigrateCustomChild, } ``` - generated `RuntimeHoldReason` enum looks like: ```rust pub enum RuntimeHoldReason { #[codec(index = 32u8)] Preimage(pallet_preimage::HoldReason), #[codec(index = 38u8)] Nis(pallet_nis::HoldReason), #[codec(index = 42u8)] StateTrieMigration(pallet_state_trie_migration::HoldReason), } ``` - composite enum `RuntimeHoldReason` variant count is detected as `3` - we set `type MaxHolds = ConstU32<3>` - `pallet_balances::integrity_test` is ok with `3`(at least 3) However, the real problem can occur in a live runtime where some functionality might stop working. This is due to a total of 5 distinct hold reasons (for pallets with multi-instance support, it is even more), and not all of them can be used because of an incorrect `MaxHolds`, which is deemed acceptable according to the `integrity_test`: ``` // pseudo-code - if we try to call all of these: T::Currency::hold(&pallet_nis::HoldReason::NftReceipt.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_preimage::HoldReason::Preimage.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForContinueMigrate.into(), &nft_owner, deposit)?; // With `type MaxHolds = ConstU32<3>` these two will fail T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomTop.into(), &nft_owner, deposit)?; T::Currency::hold(&pallet_state_trie_migration::HoldReason::SlashForMigrateCustomChild.into(), &nft_owner, deposit)?; ``` ## Solutions A macro `#[pallet::*]` expansion is extended of `VariantCount` implementation for the `#[pallet::composite_enum]` enum type. This expansion generates the `VariantCount` implementation for pallets' `HoldReason`, `FreezeReason`, `LockId`, and `SlashReason`. Enum variants must be plain enum values without fields to ensure a deterministic count. The composite runtime enum, `RuntimeHoldReason` and `RuntimeFreezeReason`, now sets `VariantCount::VARIANT_COUNT` as the sum of pallets' enum `VariantCount::VARIANT_COUNT`: ```rust #[frame_support::pallet(dev_mode)] mod module_single_instance { #[pallet::composite_enum] pub enum HoldReason { ModuleSingleInstanceReason1, ModuleSingleInstanceReason2, } ... } #[frame_support::pallet(dev_mode)] mod module_multi_instance { #[pallet::composite_enum] pub enum HoldReason<I: 'static = ()> { ModuleMultiInstanceReason1, ModuleMultiInstanceReason2, ModuleMultiInstanceReason3, } ... } impl self::sp_api_hidden_includes_construct_runtime::hidden_include::traits::VariantCount for RuntimeHoldReason { const VARIANT_COUNT: u32 = 0 + module_single_instance::HoldReason::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance1>::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance2>::VARIANT_COUNT + module_multi_instance::HoldReason::<module_multi_instance::Instance3>::VARIANT_COUNT; } ``` In addition, `MaxHolds` is removed (as suggested [here](https://github.com/paritytech/polkadot-sdk/pull/2657#discussion_r1443324573)) from `pallet_balances`, and its `Holds` are now bounded to `RuntimeHoldReason::VARIANT_COUNT`. Therefore, there is no need to let the runtime specify `MaxHolds`. ## For reviewers Relevant changes can be found here: - `substrate/frame/support/procedural/src/lib.rs` - `substrate/frame/support/procedural/src/pallet/parse/composite.rs` - `substrate/frame/support/procedural/src/pallet/expand/composite.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/composite_helper.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/hold_reason.rs` - `substrate/frame/support/procedural/src/construct_runtime/expand/freeze_reason.rs` - `substrate/frame/support/src/traits/misc.rs` And the rest of the files is just about removed `MaxHolds` from `pallet_balances` ## Next steps Do the same for `MaxFreezes` https://github.com/paritytech/polkadot-sdk/issues/2997. --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
309 lines
9.7 KiB
Rust
309 lines
9.7 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use std::vec;
|
|
|
|
use frame_election_provider_support::{
|
|
bounds::{ElectionBounds, ElectionBoundsBuilder},
|
|
onchain, SequentialPhragmen,
|
|
};
|
|
use frame_support::{
|
|
construct_runtime, derive_impl, parameter_types,
|
|
traits::{ConstU32, ConstU64, KeyOwnerProofSystem, OnFinalize, OnInitialize},
|
|
};
|
|
use pallet_session::historical as pallet_session_historical;
|
|
use sp_core::{crypto::KeyTypeId, ConstU128};
|
|
use sp_io::TestExternalities;
|
|
use sp_runtime::{
|
|
app_crypto::ecdsa::Public, curve::PiecewiseLinear, impl_opaque_keys, testing::TestXt,
|
|
traits::OpaqueKeys, BuildStorage, Perbill,
|
|
};
|
|
use sp_staking::{EraIndex, SessionIndex};
|
|
use sp_state_machine::BasicExternalities;
|
|
|
|
use crate as pallet_beefy;
|
|
|
|
pub use sp_consensus_beefy::{ecdsa_crypto::AuthorityId as BeefyId, ConsensusLog, BEEFY_ENGINE_ID};
|
|
|
|
impl_opaque_keys! {
|
|
pub struct MockSessionKeys {
|
|
pub dummy: pallet_beefy::Pallet<Test>,
|
|
}
|
|
}
|
|
|
|
type Block = frame_system::mocking::MockBlock<Test>;
|
|
|
|
construct_runtime!(
|
|
pub enum Test
|
|
{
|
|
System: frame_system,
|
|
Authorship: pallet_authorship,
|
|
Timestamp: pallet_timestamp,
|
|
Balances: pallet_balances,
|
|
Beefy: pallet_beefy,
|
|
Staking: pallet_staking,
|
|
Session: pallet_session,
|
|
Offences: pallet_offences,
|
|
Historical: pallet_session_historical,
|
|
}
|
|
);
|
|
|
|
#[derive_impl(frame_system::config_preludes::TestDefaultConfig as frame_system::DefaultConfig)]
|
|
impl frame_system::Config for Test {
|
|
type Block = Block;
|
|
type AccountData = pallet_balances::AccountData<u128>;
|
|
}
|
|
|
|
impl<C> frame_system::offchain::SendTransactionTypes<C> for Test
|
|
where
|
|
RuntimeCall: From<C>,
|
|
{
|
|
type OverarchingCall = RuntimeCall;
|
|
type Extrinsic = TestXt<RuntimeCall, ()>;
|
|
}
|
|
|
|
parameter_types! {
|
|
pub const Period: u64 = 1;
|
|
pub const ReportLongevity: u64 =
|
|
BondingDuration::get() as u64 * SessionsPerEra::get() as u64 * Period::get();
|
|
pub const MaxSetIdSessionEntries: u32 = BondingDuration::get() * SessionsPerEra::get();
|
|
}
|
|
|
|
impl pallet_beefy::Config for Test {
|
|
type BeefyId = BeefyId;
|
|
type MaxAuthorities = ConstU32<100>;
|
|
type MaxNominators = ConstU32<1000>;
|
|
type MaxSetIdSessionEntries = MaxSetIdSessionEntries;
|
|
type OnNewValidatorSet = ();
|
|
type WeightInfo = ();
|
|
type KeyOwnerProof = <Historical as KeyOwnerProofSystem<(KeyTypeId, BeefyId)>>::Proof;
|
|
type EquivocationReportSystem =
|
|
super::EquivocationReportSystem<Self, Offences, Historical, ReportLongevity>;
|
|
}
|
|
|
|
parameter_types! {
|
|
pub const DisabledValidatorsThreshold: Perbill = Perbill::from_percent(33);
|
|
}
|
|
|
|
impl pallet_session::Config for Test {
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type ValidatorId = u64;
|
|
type ValidatorIdOf = pallet_staking::StashOf<Self>;
|
|
type ShouldEndSession = pallet_session::PeriodicSessions<ConstU64<1>, ConstU64<0>>;
|
|
type NextSessionRotation = pallet_session::PeriodicSessions<ConstU64<1>, ConstU64<0>>;
|
|
type SessionManager = pallet_session::historical::NoteHistoricalRoot<Self, Staking>;
|
|
type SessionHandler = <MockSessionKeys as OpaqueKeys>::KeyTypeIdProviders;
|
|
type Keys = MockSessionKeys;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl pallet_session::historical::Config for Test {
|
|
type FullIdentification = pallet_staking::Exposure<u64, u128>;
|
|
type FullIdentificationOf = pallet_staking::ExposureOf<Self>;
|
|
}
|
|
|
|
impl pallet_authorship::Config for Test {
|
|
type FindAuthor = ();
|
|
type EventHandler = ();
|
|
}
|
|
|
|
impl pallet_balances::Config for Test {
|
|
type MaxLocks = ();
|
|
type MaxReserves = ();
|
|
type ReserveIdentifier = [u8; 8];
|
|
type Balance = u128;
|
|
type DustRemoval = ();
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type ExistentialDeposit = ConstU128<1>;
|
|
type AccountStore = System;
|
|
type WeightInfo = ();
|
|
type RuntimeHoldReason = ();
|
|
type RuntimeFreezeReason = ();
|
|
type FreezeIdentifier = ();
|
|
type MaxFreezes = ();
|
|
}
|
|
|
|
impl pallet_timestamp::Config for Test {
|
|
type Moment = u64;
|
|
type OnTimestampSet = ();
|
|
type MinimumPeriod = ConstU64<3>;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
pallet_staking_reward_curve::build! {
|
|
const REWARD_CURVE: PiecewiseLinear<'static> = curve!(
|
|
min_inflation: 0_025_000u64,
|
|
max_inflation: 0_100_000,
|
|
ideal_stake: 0_500_000,
|
|
falloff: 0_050_000,
|
|
max_piece_count: 40,
|
|
test_precision: 0_005_000,
|
|
);
|
|
}
|
|
|
|
parameter_types! {
|
|
pub const SessionsPerEra: SessionIndex = 3;
|
|
pub const BondingDuration: EraIndex = 3;
|
|
pub const RewardCurve: &'static PiecewiseLinear<'static> = &REWARD_CURVE;
|
|
pub const OffendingValidatorsThreshold: Perbill = Perbill::from_percent(17);
|
|
pub static ElectionsBoundsOnChain: ElectionBounds = ElectionBoundsBuilder::default().build();
|
|
}
|
|
|
|
pub struct OnChainSeqPhragmen;
|
|
impl onchain::Config for OnChainSeqPhragmen {
|
|
type System = Test;
|
|
type Solver = SequentialPhragmen<u64, Perbill>;
|
|
type DataProvider = Staking;
|
|
type WeightInfo = ();
|
|
type MaxWinners = ConstU32<100>;
|
|
type Bounds = ElectionsBoundsOnChain;
|
|
}
|
|
|
|
impl pallet_staking::Config for Test {
|
|
type RewardRemainder = ();
|
|
type CurrencyToVote = ();
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type Currency = Balances;
|
|
type CurrencyBalance = <Self as pallet_balances::Config>::Balance;
|
|
type Slash = ();
|
|
type Reward = ();
|
|
type SessionsPerEra = SessionsPerEra;
|
|
type BondingDuration = BondingDuration;
|
|
type SlashDeferDuration = ();
|
|
type AdminOrigin = frame_system::EnsureRoot<Self::AccountId>;
|
|
type SessionInterface = Self;
|
|
type UnixTime = pallet_timestamp::Pallet<Test>;
|
|
type EraPayout = pallet_staking::ConvertCurve<RewardCurve>;
|
|
type MaxExposurePageSize = ConstU32<64>;
|
|
type OffendingValidatorsThreshold = OffendingValidatorsThreshold;
|
|
type NextNewSession = Session;
|
|
type ElectionProvider = onchain::OnChainExecution<OnChainSeqPhragmen>;
|
|
type GenesisElectionProvider = Self::ElectionProvider;
|
|
type VoterList = pallet_staking::UseNominatorsAndValidatorsMap<Self>;
|
|
type TargetList = pallet_staking::UseValidatorsMap<Self>;
|
|
type NominationsQuota = pallet_staking::FixedNominationsQuota<16>;
|
|
type MaxUnlockingChunks = ConstU32<32>;
|
|
type MaxControllersInDeprecationBatch = ConstU32<100>;
|
|
type HistoryDepth = ConstU32<84>;
|
|
type EventListeners = ();
|
|
type BenchmarkingConfig = pallet_staking::TestBenchmarkingConfig;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl pallet_offences::Config for Test {
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type IdentificationTuple = pallet_session::historical::IdentificationTuple<Self>;
|
|
type OnOffenceHandler = Staking;
|
|
}
|
|
|
|
// Note, that we can't use `UintAuthorityId` here. Reason is that the implementation
|
|
// of `to_public_key()` assumes, that a public key is 32 bytes long. This is true for
|
|
// ed25519 and sr25519 but *not* for ecdsa. A compressed ecdsa public key is 33 bytes,
|
|
// with the first one containing information to reconstruct the uncompressed key.
|
|
pub fn mock_beefy_id(id: u8) -> BeefyId {
|
|
let mut buf: [u8; 33] = [id; 33];
|
|
// Set to something valid.
|
|
buf[0] = 0x02;
|
|
let pk = Public::from_raw(buf);
|
|
BeefyId::from(pk)
|
|
}
|
|
|
|
pub fn mock_authorities(vec: Vec<u8>) -> Vec<BeefyId> {
|
|
vec.into_iter().map(|id| mock_beefy_id(id)).collect()
|
|
}
|
|
|
|
pub fn new_test_ext(ids: Vec<u8>) -> TestExternalities {
|
|
new_test_ext_raw_authorities(mock_authorities(ids))
|
|
}
|
|
|
|
pub fn new_test_ext_raw_authorities(authorities: Vec<BeefyId>) -> TestExternalities {
|
|
let mut t = frame_system::GenesisConfig::<Test>::default().build_storage().unwrap();
|
|
|
|
let balances: Vec<_> = (0..authorities.len()).map(|i| (i as u64, 10_000_000)).collect();
|
|
|
|
pallet_balances::GenesisConfig::<Test> { balances }
|
|
.assimilate_storage(&mut t)
|
|
.unwrap();
|
|
|
|
let session_keys: Vec<_> = authorities
|
|
.iter()
|
|
.enumerate()
|
|
.map(|(i, k)| (i as u64, i as u64, MockSessionKeys { dummy: k.clone() }))
|
|
.collect();
|
|
|
|
BasicExternalities::execute_with_storage(&mut t, || {
|
|
for (ref id, ..) in &session_keys {
|
|
frame_system::Pallet::<Test>::inc_providers(id);
|
|
}
|
|
});
|
|
|
|
pallet_session::GenesisConfig::<Test> { keys: session_keys }
|
|
.assimilate_storage(&mut t)
|
|
.unwrap();
|
|
|
|
// controllers are same as stash
|
|
let stakers: Vec<_> = (0..authorities.len())
|
|
.map(|i| (i as u64, i as u64, 10_000, pallet_staking::StakerStatus::<u64>::Validator))
|
|
.collect();
|
|
|
|
let staking_config = pallet_staking::GenesisConfig::<Test> {
|
|
stakers,
|
|
validator_count: 2,
|
|
force_era: pallet_staking::Forcing::ForceNew,
|
|
minimum_validator_count: 0,
|
|
invulnerables: vec![],
|
|
..Default::default()
|
|
};
|
|
|
|
staking_config.assimilate_storage(&mut t).unwrap();
|
|
|
|
t.into()
|
|
}
|
|
|
|
pub fn start_session(session_index: SessionIndex) {
|
|
for i in Session::current_index()..session_index {
|
|
System::on_finalize(System::block_number());
|
|
Session::on_finalize(System::block_number());
|
|
Staking::on_finalize(System::block_number());
|
|
Beefy::on_finalize(System::block_number());
|
|
|
|
let parent_hash = if System::block_number() > 1 {
|
|
let hdr = System::finalize();
|
|
hdr.hash()
|
|
} else {
|
|
System::parent_hash()
|
|
};
|
|
|
|
System::reset_events();
|
|
System::initialize(&(i as u64 + 1), &parent_hash, &Default::default());
|
|
System::set_block_number((i + 1).into());
|
|
Timestamp::set_timestamp(System::block_number() * 6000);
|
|
|
|
System::on_initialize(System::block_number());
|
|
Session::on_initialize(System::block_number());
|
|
Staking::on_initialize(System::block_number());
|
|
Beefy::on_initialize(System::block_number());
|
|
}
|
|
|
|
assert_eq!(Session::current_index(), session_index);
|
|
}
|
|
|
|
pub fn start_era(era_index: EraIndex) {
|
|
start_session((era_index * 3).into());
|
|
assert_eq!(Staking::current_era(), Some(era_index));
|
|
}
|