mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-28 09:51:05 +00:00
Robert Klotzner
55154a8d37
* WIP: Get rid of request multiplexer. * WIP * Receiver for handling of incoming requests. * Get rid of useless `Fault` abstraction. The things the type system let us do are not worth getting abstracted in its own type. Instead error handling is going to be merely a pattern. * Make most things compile again. * Port availability distribution away from request multiplexer. * Formatting. * Port dispute distribution over. * Fixup statement distribution. * Handle request directly in collator protocol. + Only allow fatal errors at top level. * Use direct request channel for availability recovery. * Finally get rid of request multiplexer Fixes #2842 and paves the way for more back pressure possibilities. * Fix overseer and statement distribution tests. * Fix collator protocol and network bridge tests. * Fix tests in availability recovery. * Fix availability distribution tests. * Fix dispute distribution tests. * Add missing dependency * Typos. * Review remarks. * More remarks.
108 lines
3.4 KiB
Rust
108 lines
3.4 KiB
Rust
// Copyright 2021 Parity Technologies (UK) Ltd.
|
|
// This file is part of Polkadot.
|
|
|
|
// Polkadot is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Polkadot is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
|
//
|
|
|
|
//! Error handling related code and Error/Result definitions.
|
|
|
|
use thiserror::Error;
|
|
|
|
use polkadot_node_network_protocol::request_response::incoming;
|
|
use polkadot_node_primitives::UncheckedSignedFullStatement;
|
|
use polkadot_node_subsystem_util::runtime;
|
|
use polkadot_subsystem::errors::SubsystemError;
|
|
|
|
use crate::LOG_TARGET;
|
|
|
|
/// General result.
|
|
pub type Result<T> = std::result::Result<T, Error>;
|
|
/// Result with only fatal errors.
|
|
pub type FatalResult<T> = std::result::Result<T, Fatal>;
|
|
|
|
/// Errors for statement distribution.
|
|
#[derive(Debug, Error, derive_more::From)]
|
|
#[error(transparent)]
|
|
pub enum Error {
|
|
/// All fatal errors.
|
|
Fatal(Fatal),
|
|
/// All nonfatal/potentially recoverable errors.
|
|
NonFatal(NonFatal),
|
|
}
|
|
|
|
impl From<runtime::Error> for Error {
|
|
fn from(o: runtime::Error) -> Self {
|
|
match o {
|
|
runtime::Error::Fatal(f) => Self::Fatal(Fatal::Runtime(f)),
|
|
runtime::Error::NonFatal(f) => Self::NonFatal(NonFatal::Runtime(f)),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl From<incoming::Error> for Error {
|
|
fn from(o: incoming::Error) -> Self {
|
|
match o {
|
|
incoming::Error::Fatal(f) => Self::Fatal(Fatal::IncomingRequest(f)),
|
|
incoming::Error::NonFatal(f) => Self::NonFatal(NonFatal::IncomingRequest(f)),
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Fatal runtime errors.
|
|
#[derive(Debug, Error)]
|
|
pub enum Fatal {
|
|
/// Receiving subsystem message from overseer failed.
|
|
#[error("Receiving message from overseer failed")]
|
|
SubsystemReceive(#[source] SubsystemError),
|
|
|
|
/// Errors coming from runtime::Runtime.
|
|
#[error("Error while accessing runtime information")]
|
|
Runtime(#[from] runtime::Fatal),
|
|
|
|
/// Errors coming from receiving incoming requests.
|
|
#[error("Retrieving next incoming request failed")]
|
|
IncomingRequest(#[from] incoming::Fatal),
|
|
}
|
|
|
|
/// Errors for fetching of runtime information.
|
|
#[derive(Debug, Error)]
|
|
pub enum NonFatal {
|
|
/// Signature was invalid on received statement.
|
|
#[error("CollationSeconded contained statement with invalid signature")]
|
|
InvalidStatementSignature(UncheckedSignedFullStatement),
|
|
|
|
/// Errors coming from runtime::Runtime.
|
|
#[error("Error while accessing runtime information")]
|
|
Runtime(#[from] runtime::NonFatal),
|
|
|
|
/// Errors coming from receiving incoming requests.
|
|
#[error("Retrieving next incoming request failed")]
|
|
IncomingRequest(#[from] incoming::NonFatal),
|
|
}
|
|
|
|
/// Utility for eating top level errors and log them.
|
|
///
|
|
/// We basically always want to try and continue on error. This utility function is meant to
|
|
/// consume top-level errors by simply logging them.
|
|
pub fn log_error(result: Result<()>, ctx: &'static str) -> FatalResult<()> {
|
|
match result {
|
|
Err(Error::Fatal(f)) => Err(f),
|
|
Err(Error::NonFatal(error)) => {
|
|
tracing::warn!(target: LOG_TARGET, error = ?error, ctx);
|
|
Ok(())
|
|
},
|
|
Ok(()) => Ok(()),
|
|
}
|
|
}
|