mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-31 01:41:03 +00:00
e71c484d5b
This commit introduces a new concept called `NotificationService` which allows Polkadot protocols to communicate with the underlying notification protocol implementation directly, without routing events through `NetworkWorker`. This implies that each protocol has its own service which it uses to communicate with remote peers and that each `NotificationService` is unique with respect to the underlying notification protocol, meaning `NotificationService` for the transaction protocol can only be used to send and receive transaction-related notifications. The `NotificationService` concept introduces two additional benefits: * allow protocols to start using custom handshakes * allow protocols to accept/reject inbound peers Previously the validation of inbound connections was solely the responsibility of `ProtocolController`. This caused issues with light peers and `SyncingEngine` as `ProtocolController` would accept more peers than `SyncingEngine` could accept which caused peers to have differing views of their own states. `SyncingEngine` would reject excess peers but these rejections were not properly communicated to those peers causing them to assume that they were accepted. With `NotificationService`, the local handshake is not sent to remote peer if peer is rejected which allows it to detect that it was rejected. This commit also deprecates the use of `NetworkEventStream` for all notification-related events and going forward only DHT events are provided through `NetworkEventStream`. If protocols wish to follow each other's events, they must introduce additional abtractions, as is done for GRANDPA and transactions protocols by following the syncing protocol through `SyncEventStream`. Fixes https://github.com/paritytech/polkadot-sdk/issues/512 Fixes https://github.com/paritytech/polkadot-sdk/issues/514 Fixes https://github.com/paritytech/polkadot-sdk/issues/515 Fixes https://github.com/paritytech/polkadot-sdk/issues/554 Fixes https://github.com/paritytech/polkadot-sdk/issues/556 --- These changes are transferred from https://github.com/paritytech/substrate/pull/14197 but there are no functional changes compared to that PR --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
76 lines
2.4 KiB
WebAssembly Text Format
76 lines
2.4 KiB
WebAssembly Text Format
;; This fixture recursively tests if reentrance_count returns correct reentrant count value when
|
|
;; using seal_call to make caller contract call to itself
|
|
(module
|
|
(import "seal0" "seal_input" (func $seal_input (param i32 i32)))
|
|
(import "seal0" "seal_address" (func $seal_address (param i32 i32)))
|
|
(import "seal1" "seal_call" (func $seal_call (param i32 i32 i64 i32 i32 i32 i32 i32) (result i32)))
|
|
(import "seal0" "reentrance_count" (func $reentrance_count (result i32)))
|
|
(import "env" "memory" (memory 1 1))
|
|
|
|
;; [0, 32) reserved for $seal_address output
|
|
|
|
;; [32, 36) buffer for the call stack height
|
|
|
|
;; [36, 40) size of the input buffer
|
|
(data (i32.const 36) "\04")
|
|
|
|
;; [40, 44) length of the buffer for $seal_address
|
|
(data (i32.const 40) "\20")
|
|
|
|
(func $assert (param i32)
|
|
(block $ok
|
|
(br_if $ok
|
|
(local.get 0)
|
|
)
|
|
(unreachable)
|
|
)
|
|
)
|
|
(func (export "call")
|
|
(local $expected_reentrance_count i32)
|
|
(local $seal_call_exit_code i32)
|
|
|
|
;; reading current contract address
|
|
(call $seal_address (i32.const 0) (i32.const 40))
|
|
|
|
;; reading passed input
|
|
(call $seal_input (i32.const 32) (i32.const 36))
|
|
|
|
;; reading manually passed reentrant count
|
|
(local.set $expected_reentrance_count (i32.load (i32.const 32)))
|
|
|
|
;; reentrance count is calculated correctly
|
|
(call $assert
|
|
(i32.eq (call $reentrance_count) (local.get $expected_reentrance_count))
|
|
)
|
|
|
|
;; re-enter 5 times in a row and assert that the reentrant counter works as expected
|
|
(i32.eq (call $reentrance_count) (i32.const 5))
|
|
(if
|
|
(then) ;; recursion exit case
|
|
(else
|
|
;; incrementing $expected_reentrance_count passed to the contract
|
|
(i32.store (i32.const 32) (i32.add (i32.load (i32.const 32)) (i32.const 1)))
|
|
|
|
;; Call to itself
|
|
(local.set $seal_call_exit_code
|
|
(call $seal_call
|
|
(i32.const 8) ;; Allow reentrancy flag set
|
|
(i32.const 0) ;; Pointer to "callee" address
|
|
(i64.const 0) ;; How much gas to devote for the execution. 0 = all.
|
|
(i32.const 0) ;; Pointer to the buffer with value to transfer
|
|
(i32.const 32) ;; Pointer to input data buffer address
|
|
(i32.const 4) ;; Length of input data buffer
|
|
(i32.const 0xffffffff) ;; u32 max sentinel value: do not copy output
|
|
(i32.const 0) ;; Ptr to output buffer len
|
|
)
|
|
)
|
|
|
|
(call $assert
|
|
(i32.eq (local.get $seal_call_exit_code) (i32.const 0))
|
|
)
|
|
)
|
|
)
|
|
)
|
|
|
|
(func (export "deploy"))
|
|
) |